204242 2019-11-15 13:22:48 -0800 NetworkDataTaskCocoa and NetworkSessionCocoa should use public methods instead of being friends 2019-12-12 15:43:21 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen cdumez commit-queue webkit-bug-importer oldest_to_newest 1590627 0 achristensen 2019-11-15 13:22:48 -0800 NetworkDataTaskCocoa and NetworkSessionCocoa should use public methods instead of being friends 1590628 1 383639 achristensen 2019-11-15 13:23:59 -0800 Created attachment 383639 Patch 1598163 2 383639 commit-queue 2019-12-12 15:42:10 -0800 Comment on attachment 383639 Patch Clearing flags on attachment: 383639 Committed r253449: <https://trac.webkit.org/changeset/253449> 1598164 3 commit-queue 2019-12-12 15:42:12 -0800 All reviewed patches have been landed. Closing bug. 1598165 4 webkit-bug-importer 2019-12-12 15:43:21 -0800 <rdar://problem/57894852> 383639 2019-11-15 13:23:59 -0800 2019-12-12 15:42:10 -0800 Patch bug-204242-20191115132358.patch text/plain 5205 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTI0OTgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE5LTExLTE1ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTmV0d29ya0RhdGFU YXNrQ29jb2EgYW5kIE5ldHdvcmtTZXNzaW9uQ29jb2Egc2hvdWxkIHVzZSBwdWJsaWMgbWV0aG9k cyBpbnN0ZWFkIG9mIGJlaW5nIGZyaWVuZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwNDI0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoaXMgbWFrZXMgdGhlbSBzdGF5IGdvb2QgYWJzdHJhY3Rpb25z LCBhbmQgcHJvYmFibHkgY291bGQgbWFrZSBhIGdvb2QgbWVtZSBhYm91dCBub3QgaGF2aW5nIGFu eSBmcmllbmRzLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFU YXNrQ29jb2EuaDoKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrRGF0YVRh c2tDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0RhdGFUYXNrQ29jb2E6OmFwcGx5 U25pZmZpbmdQb2xpY2llc0FuZEJpbmRSZXF1ZXN0VG9JbmZlcmZhY2VJZk5lZWRlZCk6CisgICAg ICAgICogTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5oOgorCiAyMDE5 LTExLTE1ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmVkdWNlIHN0cnVjdHVyZSBjb3BpZXMgd2hlbiBjcmVhdGluZyBhbiBBUEk6OkZyYW1l SW5mbwpJbmRleDogU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrRGF0 YVRhc2tDb2NvYS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv Y29jb2EvTmV0d29ya0RhdGFUYXNrQ29jb2EuaAkocmV2aXNpb24gMjUyNDk3KQorKysgU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrRGF0YVRhc2tDb2NvYS5oCSh3b3Jr aW5nIGNvcHkpCkBAIC00MSw3ICs0MSw2IEBAIGNsYXNzIE5ldHdvcmtTZXNzaW9uQ29jb2E7CiBz dHJ1Y3QgU2Vzc2lvbldyYXBwZXI7CiAKIGNsYXNzIE5ldHdvcmtEYXRhVGFza0NvY29hIGZpbmFs IDogcHVibGljIE5ldHdvcmtEYXRhVGFzayB7Ci0gICAgZnJpZW5kIGNsYXNzIE5ldHdvcmtTZXNz aW9uQ29jb2E7CiBwdWJsaWM6CiAgICAgc3RhdGljIFJlZjxOZXR3b3JrRGF0YVRhc2s+IGNyZWF0 ZShOZXR3b3JrU2Vzc2lvbiYgc2Vzc2lvbiwgTmV0d29ya0RhdGFUYXNrQ2xpZW50JiBjbGllbnQs IGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwgV2ViQ29yZTo6RnJhbWVJ ZGVudGlmaWVyIGZyYW1lSUQsIFdlYkNvcmU6OlBhZ2VJZGVudGlmaWVyIHBhZ2VJRCwgV2ViQ29y ZTo6U3RvcmVkQ3JlZGVudGlhbHNQb2xpY3kgc3RvcmVkQ3JlZGVudGlhbHNQb2xpY3ksIFdlYkNv cmU6OkNvbnRlbnRTbmlmZmluZ1BvbGljeSBzaG91bGRDb250ZW50U25pZmYsIFdlYkNvcmU6OkNv bnRlbnRFbmNvZGluZ1NuaWZmaW5nUG9saWN5IHNob3VsZENvbnRlbnRFbmNvZGluZ1NuaWZmLCBi b29sIHNob3VsZENsZWFyUmVmZXJyZXJPbkhUVFBTVG9IVFRQUmVkaXJlY3QsIFByZWNvbm5lY3RP bmx5IHNob3VsZFByZWNvbm5lY3RPbmx5LCBib29sIGRhdGFUYXNrSXNGb3JNYWluRnJhbWVOYXZp Z2F0aW9uLCBib29sIGRhdGFUYXNrSXNGb3JNYWluUmVzb3VyY2VOYXZpZ2F0aW9uRm9yQW55RnJh bWUsIE9wdGlvbmFsPE5ldHdvcmtBY3Rpdml0eVRyYWNrZXI+IG5ldHdvcmtBY3Rpdml0eVRyYWNr ZXIpCiAgICAgewpJbmRleDogU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3 b3JrRGF0YVRhc2tDb2NvYS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L05ldHdvcmtQ cm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0NvY29hLm1tCShyZXZpc2lvbiAyNTI0OTcpCisr KyBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0NvY29h Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC04NywxMiArODcsMTQgQEAgdm9pZCBOZXR3b3JrRGF0YVRh c2tDb2NvYTo6YXBwbHlTbmlmZmluZwogI2VuZGlmCiAKICAgICBhdXRvJiBjb2NvYVNlc3Npb24g PSBzdGF0aWNfY2FzdDxOZXR3b3JrU2Vzc2lvbkNvY29hJj4oKm1fc2Vzc2lvbik7CisgICAgYXV0 byYgYm91bmRJbnRlcmZhY2VJZGVudGlmaWVyID0gY29jb2FTZXNzaW9uLmJvdW5kSW50ZXJmYWNl SWRlbnRpZmllcigpOworICAgIGF1dG8qIHByb3h5Q29uZmlndXJhdGlvbiA9IGNvY29hU2Vzc2lv bi5wcm94eUNvbmZpZ3VyYXRpb24oKTsKICAgICBpZiAoc2hvdWxkQ29udGVudFNuaWZmCiAjaWYg VVNFKENGTkVUV09SS19DT05URU5UX0VOQ09ESU5HX1NOSUZGSU5HX09WRVJSSURFKQogICAgICAg ICAmJiBzaG91bGRDb250ZW50RW5jb2RpbmdTbmlmZgogI2VuZGlmCi0gICAgICAgICYmIGNvY29h U2Vzc2lvbi5tX2JvdW5kSW50ZXJmYWNlSWRlbnRpZmllci5pc051bGwoKQotICAgICAgICAmJiAh Y29jb2FTZXNzaW9uLm1fcHJveHlDb25maWd1cmF0aW9uKQorICAgICAgICAmJiBib3VuZEludGVy ZmFjZUlkZW50aWZpZXIuaXNOdWxsKCkKKyAgICAgICAgJiYgIXByb3h5Q29uZmlndXJhdGlvbikK ICAgICAgICAgcmV0dXJuOwogCiAgICAgYXV0byBtdXRhYmxlUmVxdWVzdCA9IGFkb3B0TlMoW25z UmVxdWVzdCBtdXRhYmxlQ29weV0pOwpAQCAtMTA1LDExICsxMDcsMTEgQEAgdm9pZCBOZXR3b3Jr RGF0YVRhc2tDb2NvYTo6YXBwbHlTbmlmZmluZwogICAgIGlmICghc2hvdWxkQ29udGVudFNuaWZm KQogICAgICAgICBbbXV0YWJsZVJlcXVlc3QgX3NldFByb3BlcnR5OkBOTyBmb3JLZXk6KE5TU3Ry aW5nICopX2tDRlVSTENvbm5lY3Rpb25Qcm9wZXJ0eVNob3VsZFNuaWZmXTsKIAotICAgIGlmICgh Y29jb2FTZXNzaW9uLm1fYm91bmRJbnRlcmZhY2VJZGVudGlmaWVyLmlzTnVsbCgpKQotICAgICAg ICBbbXV0YWJsZVJlcXVlc3Qgc2V0Qm91bmRJbnRlcmZhY2VJZGVudGlmaWVyOmNvY29hU2Vzc2lv bi5tX2JvdW5kSW50ZXJmYWNlSWRlbnRpZmllcl07CisgICAgaWYgKCFib3VuZEludGVyZmFjZUlk ZW50aWZpZXIuaXNOdWxsKCkpCisgICAgICAgIFttdXRhYmxlUmVxdWVzdCBzZXRCb3VuZEludGVy ZmFjZUlkZW50aWZpZXI6Ym91bmRJbnRlcmZhY2VJZGVudGlmaWVyXTsKIAotICAgIGlmIChjb2Nv YVNlc3Npb24ubV9wcm94eUNvbmZpZ3VyYXRpb24pCi0gICAgICAgIENGVVJMUmVxdWVzdFNldFBy b3h5U2V0dGluZ3MoW211dGFibGVSZXF1ZXN0IF9DRlVSTFJlcXVlc3RdLCBjb2NvYVNlc3Npb24u bV9wcm94eUNvbmZpZ3VyYXRpb24uZ2V0KCkpOworICAgIGlmIChwcm94eUNvbmZpZ3VyYXRpb24p CisgICAgICAgIENGVVJMUmVxdWVzdFNldFByb3h5U2V0dGluZ3MoW211dGFibGVSZXF1ZXN0IF9D RlVSTFJlcXVlc3RdLCBwcm94eUNvbmZpZ3VyYXRpb24pOwogCiAgICAgbnNSZXF1ZXN0ID0gbXV0 YWJsZVJlcXVlc3QuYXV0b3JlbGVhc2UoKTsKIH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQvTmV0d29y a1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5oCShyZXZp c2lvbiAyNTI0OTcpCisrKyBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdv cmtTZXNzaW9uQ29jb2EuaAkod29ya2luZyBjb3B5KQpAQCAtNjEsNyArNjEsNiBAQCBzdHJ1Y3Qg U2Vzc2lvbldyYXBwZXIgOiBwdWJsaWMgQ2FuTWFrZVdlCiB9OwogCiBjbGFzcyBOZXR3b3JrU2Vz c2lvbkNvY29hIGZpbmFsIDogcHVibGljIE5ldHdvcmtTZXNzaW9uIHsKLSAgICBmcmllbmQgY2xh c3MgTmV0d29ya0RhdGFUYXNrQ29jb2E7CiBwdWJsaWM6CiAgICAgc3RhdGljIHN0ZDo6dW5pcXVl X3B0cjxOZXR3b3JrU2Vzc2lvbj4gY3JlYXRlKE5ldHdvcmtQcm9jZXNzJiwgTmV0d29ya1Nlc3Np b25DcmVhdGlvblBhcmFtZXRlcnMmJik7CiAKQEAgLTk0LDEyICs5MywxMyBAQCBwdWJsaWM6CiAg ICAgYm9vbCBoYXNJc29sYXRlZFNlc3Npb24oY29uc3QgV2ViQ29yZTo6UmVnaXN0cmFibGVEb21h aW4pIGNvbnN0IG92ZXJyaWRlOwogICAgIHZvaWQgY2xlYXJJc29sYXRlZFNlc3Npb25zKCkgb3Zl cnJpZGU7CiAKKyAgICBTZXNzaW9uV3JhcHBlciYgc2Vzc2lvbldyYXBwZXJGb3JUYXNrKGNvbnN0 IFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYsIFdlYkNvcmU6OlN0b3JlZENyZWRlbnRpYWxzUG9s aWN5KTsKKwogcHJpdmF0ZToKICAgICB2b2lkIGludmFsaWRhdGVBbmRDYW5jZWwoKSBvdmVycmlk ZTsKICAgICB2b2lkIGNsZWFyQ3JlZGVudGlhbHMoKSBvdmVycmlkZTsKICAgICBib29sIHNob3Vs ZExvZ0Nvb2tpZUluZm9ybWF0aW9uKCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gbV9zaG91bGRM b2dDb29raWVJbmZvcm1hdGlvbjsgfQogICAgIFNlY29uZHMgbG9hZFRocm90dGxlTGF0ZW5jeSgp IGNvbnN0IG92ZXJyaWRlIHsgcmV0dXJuIG1fbG9hZFRocm90dGxlTGF0ZW5jeTsgfQotICAgIFNl c3Npb25XcmFwcGVyJiBzZXNzaW9uV3JhcHBlckZvclRhc2soY29uc3QgV2ViQ29yZTo6UmVzb3Vy Y2VSZXF1ZXN0JiwgV2ViQ29yZTo6U3RvcmVkQ3JlZGVudGlhbHNQb2xpY3kpOwogICAgIFNlc3Np b25XcmFwcGVyJiBpc29sYXRlZFNlc3Npb24oV2ViQ29yZTo6U3RvcmVkQ3JlZGVudGlhbHNQb2xp Y3ksIGNvbnN0IFdlYkNvcmU6OlJlZ2lzdHJhYmxlRG9tYWluKTsKIAogI2lmIEhBVkUoTlNVUkxT RVNTSU9OX1dFQlNPQ0tFVCkK