204234 2019-11-15 10:43:27 -0800 Add more release logging for network load restarts 2019-11-15 15:55:16 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue ggaren webkit-bug-importer youennf oldest_to_newest 1590549 0 cdumez 2019-11-15 10:43:27 -0800 Add more release logging for network load restarts. 1590550 1 383627 cdumez 2019-11-15 10:44:18 -0800 Created attachment 383627 Patch 1590688 2 383627 youennf 2019-11-15 15:07:27 -0800 Comment on attachment 383627 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383627&action=review > Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:1265 > + RELEASE_LOG_IF_ALLOWED("serviceWorkerDidNotHandle: (pageID = %" PRIu64 ", frameID = %" PRIu64 ", resourceID = %" PRIu64 ") Restarting network load", m_parameters.webPageID.toUInt64(), m_parameters.webFrameID.toUInt64(), m_parameters.identifier); Isn’t it a bit redundant with serviceworkerfetchtask logging? 1590691 3 383627 cdumez 2019-11-15 15:14:07 -0800 Comment on attachment 383627 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383627&action=review >> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:1265 >> + RELEASE_LOG_IF_ALLOWED("serviceWorkerDidNotHandle: (pageID = %" PRIu64 ", frameID = %" PRIu64 ", resourceID = %" PRIu64 ") Restarting network load", m_parameters.webPageID.toUInt64(), m_parameters.webFrameID.toUInt64(), m_parameters.identifier); > > Isn’t it a bit redundant with serviceworkerfetchtask logging? I really want to see the call sites of restartNetworkLoad(). 1590706 4 youennf 2019-11-15 15:23:41 -0800 I believe this specific didNotHandle is logged twice, once in NetworkResouceLoader and once in ServiceWorkerFetchTask. If so, this seems excessive. 1590719 5 383627 commit-queue 2019-11-15 15:54:39 -0800 Comment on attachment 383627 Patch Clearing flags on attachment: 383627 Committed r252510: <https://trac.webkit.org/changeset/252510> 1590720 6 commit-queue 2019-11-15 15:54:40 -0800 All reviewed patches have been landed. Closing bug. 1590721 7 webkit-bug-importer 2019-11-15 15:55:16 -0800 <rdar://problem/57243555> 383627 2019-11-15 10:44:18 -0800 2019-11-15 15:54:39 -0800 Patch bug-204234-20191115104417.patch text/plain 3616 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyNDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMxMzdjMDk2NjYzZTkzZDk5 YTdjYjZhYzRhMDQ5OTE0MDkwYWZhODcuLjJjYmNmOTg0YzZjMjNjM2ZlZGMyMTlkODljZGNhYzY0 ZTA4NDNiZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMTEtMTUgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgbW9yZSByZWxlYXNlIGxvZ2dp bmcgZm9yIG5ldHdvcmsgbG9hZCByZXN0YXJ0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0MjM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2Fk ZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OndpbGxTZW5k UmVkaXJlY3RlZFJlcXVlc3QpOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUmVzb3VyY2VMb2Fk ZXI6OnJlc3RhcnROZXR3b3JrTG9hZCk6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtSZXNvdXJj ZUxvYWRlcjo6Y29udGludWVXaWxsU2VuZFJlcXVlc3QpOgorICAgICAgICAoV2ViS2l0OjpOZXR3 b3JrUmVzb3VyY2VMb2FkZXI6OnNlcnZpY2VXb3JrZXJEaWROb3RIYW5kbGUpOgorCiAyMDE5LTEx LTE1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgUmVncmVzc2lv bihyMjQ0MzYxKSBpT1M6IExheW91dCB0ZXN0IGh0dHAvdGVzdHMvcXVpY2tsb29rL3J0Zi1kb2N1 bWVudC1kb21haW4taXMtZW1wdHktc3RyaW5nLmh0bWwgaXMgY3Jhc2hpbmcKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcCBi L1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcApp bmRleCBlZTE5MjhiN2JjOTc1ODE5MDhiN2QwNGMxNDEwOWIwMGFjZGYxZDNkLi5jNjNjMGEwMjVj Yjg3YzJiMjRhZjE5YTMxZTcxY2YyNjJlYTQ3NTY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dl YktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3BwCkBAIC02ODksNiAr Njg5LDcgQEAgdm9pZCBOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OndpbGxTZW5kUmVkaXJlY3RlZFJl cXVlc3QoUmVzb3VyY2VSZXF1ZXN0JiYgcmVxdWVzdCwKICAgICAgICAgICAgIGlmICh0aGlzLT5p c1N5bmNocm9ub3VzKCkpIHsKICAgICAgICAgICAgICAgICBpZiAoc3RvcmVkQ3JlZGVudGlhbHNQ b2xpY3kgIT0gbV9uZXR3b3JrTG9hZENoZWNrZXItPnN0b3JlZENyZWRlbnRpYWxzUG9saWN5KCkp IHsKICAgICAgICAgICAgICAgICAgICAgLy8gV2UgbmVlZCB0byByZXN0YXJ0IHRoZSBsb2FkIHRv IHVwZGF0ZSB0aGUgc2Vzc2lvbiBhY2NvcmRpbmcgdGhlIG5ldyBjcmVkZW50aWFsIHBvbGljeS4K KyAgICAgICAgICAgICAgICAgICAgUkVMRUFTRV9MT0dfSUZfQUxMT1dFRCgid2lsbFNlbmRSZWRp cmVjdGVkUmVxdWVzdDogKHBhZ2VJRCA9ICUiIFBSSXU2NCAiLCBmcmFtZUlEID0gJSIgUFJJdTY0 ICIsIHJlc291cmNlSUQgPSAlIiBQUkl1NjQgIikgUmVzdGFydGluZyBuZXR3b3JrIGxvYWQgZHVl IHRvIGNyZWRlbnRpYWwgcG9saWN5IGNoYW5nZSBmb3Igc3luY2hyb25vdXMgbG9hZCIsIG1fcGFy YW1ldGVycy53ZWJQYWdlSUQudG9VSW50NjQoKSwgbV9wYXJhbWV0ZXJzLndlYkZyYW1lSUQudG9V SW50NjQoKSwgbV9wYXJhbWV0ZXJzLmlkZW50aWZpZXIpOwogICAgICAgICAgICAgICAgICAgICB0 aGlzLT5yZXN0YXJ0TmV0d29ya0xvYWQoV1RGTW92ZShyZXN1bHQtPnJlZGlyZWN0UmVxdWVzdCkp OwogICAgICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICAgICAgfQpAQCAtNzUy LDYgKzc1Myw4IEBAIFJlc291cmNlUmVzcG9uc2UgTmV0d29ya1Jlc291cmNlTG9hZGVyOjpzYW5p dGl6ZVJlc3BvbnNlSWZQb3NzaWJsZShSZXNvdXJjZVJlc3BvCiAKIHZvaWQgTmV0d29ya1Jlc291 cmNlTG9hZGVyOjpyZXN0YXJ0TmV0d29ya0xvYWQoV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiYg bmV3UmVxdWVzdCkKIHsKKyAgICBSRUxFQVNFX0xPR19JRl9BTExPV0VEKCJyZXN0YXJ0TmV0d29y a0xvYWQ6IChwYWdlSUQgPSAlIiBQUkl1NjQgIiwgZnJhbWVJRCA9ICUiIFBSSXU2NCAiLCByZXNv dXJjZUlEID0gJSIgUFJJdTY0ICIpIiwgbV9wYXJhbWV0ZXJzLndlYlBhZ2VJRC50b1VJbnQ2NCgp LCBtX3BhcmFtZXRlcnMud2ViRnJhbWVJRC50b1VJbnQ2NCgpLCBtX3BhcmFtZXRlcnMuaWRlbnRp Zmllcik7CisKICAgICBpZiAobV9uZXR3b3JrTG9hZCkKICAgICAgICAgbV9uZXR3b3JrTG9hZC0+ Y2FuY2VsKCk7CiAKQEAgLTc4Miw2ICs3ODUsNyBAQCB2b2lkIE5ldHdvcmtSZXNvdXJjZUxvYWRl cjo6Y29udGludWVXaWxsU2VuZFJlcXVlc3QoUmVzb3VyY2VSZXF1ZXN0JiYgbmV3UmVxdWVzdAog ICAgICAgICBpZiAobV9uZXR3b3JrTG9hZCkKICAgICAgICAgICAgIG1fbmV0d29ya0xvYWQtPnVw ZGF0ZVJlcXVlc3RBZnRlclJlZGlyZWN0aW9uKG5ld1JlcXVlc3QpOwogCisgICAgICAgIFJFTEVB U0VfTE9HX0lGX0FMTE9XRUQoImNvbnRpbnVlV2lsbFNlbmRSZXF1ZXN0OiAocGFnZUlEID0gJSIg UFJJdTY0ICIsIGZyYW1lSUQgPSAlIiBQUkl1NjQgIiwgcmVzb3VyY2VJRCA9ICUiIFBSSXU2NCAi KSBSZXN0YXJ0aW5nIG5ldHdvcmsgbG9hZCIsIG1fcGFyYW1ldGVycy53ZWJQYWdlSUQudG9VSW50 NjQoKSwgbV9wYXJhbWV0ZXJzLndlYkZyYW1lSUQudG9VSW50NjQoKSwgbV9wYXJhbWV0ZXJzLmlk ZW50aWZpZXIpOwogICAgICAgICByZXN0YXJ0TmV0d29ya0xvYWQoV1RGTW92ZShuZXdSZXF1ZXN0 KSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CkBAIC0xMjU3LDYgKzEyNjEsOCBAQCB2b2lkIE5l dHdvcmtSZXNvdXJjZUxvYWRlcjo6c2VydmljZVdvcmtlckRpZE5vdEhhbmRsZSgpCiAKICAgICAg ICAgaWYgKG1fbmV0d29ya0xvYWQpCiAgICAgICAgICAgICBtX25ldHdvcmtMb2FkLT51cGRhdGVS ZXF1ZXN0QWZ0ZXJSZWRpcmVjdGlvbihuZXdSZXF1ZXN0KTsKKworICAgICAgICBSRUxFQVNFX0xP R19JRl9BTExPV0VEKCJzZXJ2aWNlV29ya2VyRGlkTm90SGFuZGxlOiAocGFnZUlEID0gJSIgUFJJ dTY0ICIsIGZyYW1lSUQgPSAlIiBQUkl1NjQgIiwgcmVzb3VyY2VJRCA9ICUiIFBSSXU2NCAiKSBS ZXN0YXJ0aW5nIG5ldHdvcmsgbG9hZCIsIG1fcGFyYW1ldGVycy53ZWJQYWdlSUQudG9VSW50NjQo KSwgbV9wYXJhbWV0ZXJzLndlYkZyYW1lSUQudG9VSW50NjQoKSwgbV9wYXJhbWV0ZXJzLmlkZW50 aWZpZXIpOwogICAgICAgICByZXN0YXJ0TmV0d29ya0xvYWQoV1RGTW92ZShuZXdSZXF1ZXN0KSk7 CiAgICAgICAgIHJldHVybjsKICAgICB9Cg==