204222 2019-11-15 04:11:44 -0800 [ews] Perform validation of patch before retrying JSC tests 2019-11-19 08:47:01 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=203756 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue jbedard webkit-bug-importer oldest_to_newest 1590476 0 aakash_jain 2019-11-15 04:11:44 -0800 JSC tests takes a while to run (~45 mins). In case of failure, we retry the tests, and if failures are noticed in retry as well, then we un-apply the patch, build the ToT and run the tests again. All these steps might take a while to complete. Meanwhile the patch might get obsolete or r-. EWS should not continue to process such patches, as it would be wasteful. We should check the patch status before running any time-consuming step (like running tests, or building without patch). We did similar thing for layout and api tests in https://trac.webkit.org/changeset/252037/webkit 1590477 1 383612 aakash_jain 2019-11-15 04:14:05 -0800 Created attachment 383612 Patch 1590508 2 383612 commit-queue 2019-11-15 08:39:32 -0800 Comment on attachment 383612 Patch Clearing flags on attachment: 383612 Committed r252485: <https://trac.webkit.org/changeset/252485> 1590509 3 commit-queue 2019-11-15 08:39:33 -0800 All reviewed patches have been landed. Closing bug. 1590510 4 webkit-bug-importer 2019-11-15 08:40:20 -0800 <rdar://problem/57228467> 1591544 5 aakash_jain 2019-11-19 08:47:01 -0800 Few examples where this change was useful in improving EWS efficiency (saving hours of processing times): https://ews-build.webkit.org/#/builders/1/builds/147 https://ews-build.webkit.org/#/builders/1/builds/246 https://ews-build.webkit.org/#/builders/1/builds/248 https://ews-build.webkit.org/#/builders/1/builds/249 https://ews-build.webkit.org/#/builders/1/builds/250 383612 2019-11-15 04:14:05 -0800 2019-11-15 08:39:32 -0800 Patch bug-204222-20191115071403.patch text/plain 2277 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MjQ4MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTExLTE1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBQZXJmb3JtIHZhbGlkYXRpb24gb2YgcGF0Y2ggYmVmb3JlIHJl dHJ5aW5nIEpTQyB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA0MjIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAg IChSdW5KYXZhU2NyaXB0Q29yZVRlc3RzLmV2YWx1YXRlQ29tbWFuZCk6IEFkZCBhIFZhbGlkYXRl UGF0Y2ggc3RlcCBiZWZvcmUgcmV0cnlpbmcuCisgICAgICAgIChSZVJ1bkphdmFTY3JpcHRDb3Jl VGVzdHMuZXZhbHVhdGVDb21tYW5kKTogRGl0dG8uCisKIDIwMTktMTEtMTQgIEpvbmF0aGFuIEJl ZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIFB5dGhvbiAzOiBBZGQgc3VwcG9y dCBpbiB3ZWJraXRweS5sYXlvdXRfdGVzdHMubGF5b3V0X3BhY2thZ2UKSW5kZXg6IFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9C dWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHJldmlzaW9uIDI1MjQ4MSkKKysr IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5 KQpAQCAtOTc0LDcgKzk3NCw3IEBAIGNsYXNzIFJ1bkphdmFTY3JpcHRDb3JlVGVzdHMoc2hlbGwu VGVzdCkKICAgICAgICAgICAgIHNlbGYuYnVpbGQucmVzdWx0cyA9IFNVQ0NFU1MKICAgICAgICAg ICAgIHNlbGYuYnVpbGQuYnVpbGRGaW5pc2hlZChbbWVzc2FnZV0sIFNVQ0NFU1MpCiAgICAgICAg IGVsc2U6Ci0gICAgICAgICAgICBzZWxmLmJ1aWxkLmFkZFN0ZXBzQWZ0ZXJDdXJyZW50U3RlcChb UmVSdW5KYXZhU2NyaXB0Q29yZVRlc3RzKCldKQorICAgICAgICAgICAgc2VsZi5idWlsZC5hZGRT dGVwc0FmdGVyQ3VycmVudFN0ZXAoW1ZhbGlkYXRlUGF0Y2godmVyaWZ5QnVnQ2xvc2VkPUZhbHNl LCBhZGRVUkxzPUZhbHNlKSwgUmVSdW5KYXZhU2NyaXB0Q29yZVRlc3RzKCldKQogICAgICAgICBy ZXR1cm4gcmMKIAogICAgIGRlZiBjb21tYW5kQ29tcGxldGUoc2VsZiwgY21kKToKQEAgLTEwNDYs NyArMTA0NiwxMiBAQCBjbGFzcyBSZVJ1bkphdmFTY3JpcHRDb3JlVGVzdHMoUnVuSmF2YVNjCiAg ICAgICAgICAgICBzZWxmLmJ1aWxkLmJ1aWxkRmluaXNoZWQoW21lc3NhZ2VdLCBTVUNDRVNTKQog ICAgICAgICBlbHNlOgogICAgICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgncGF0Y2hGYWlsZWRU ZXN0cycsIFRydWUpCi0gICAgICAgICAgICBzZWxmLmJ1aWxkLmFkZFN0ZXBzQWZ0ZXJDdXJyZW50 U3RlcChbVW5BcHBseVBhdGNoSWZSZXF1aXJlZCgpLCBDb21waWxlSlNDVG9UKCksIFJ1bkpTQ1Rl c3RzV2l0aG91dFBhdGNoKCksIEFuYWx5emVKU0NUZXN0c1Jlc3VsdHMoKV0pCisgICAgICAgICAg ICBzZWxmLmJ1aWxkLmFkZFN0ZXBzQWZ0ZXJDdXJyZW50U3RlcChbVW5BcHBseVBhdGNoSWZSZXF1 aXJlZCgpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg VmFsaWRhdGVQYXRjaCh2ZXJpZnlCdWdDbG9zZWQ9RmFsc2UsIGFkZFVSTHM9RmFsc2UpLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgQ29tcGlsZUpTQ1Rv VCgpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgVmFs aWRhdGVQYXRjaCh2ZXJpZnlCdWdDbG9zZWQ9RmFsc2UsIGFkZFVSTHM9RmFsc2UpLAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUnVuSlNDVGVzdHNXaXRo b3V0UGF0Y2goKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIEFuYWx5emVKU0NUZXN0c1Jlc3VsdHMoKV0pCiAgICAgICAgIHJldHVybiByYwogCiAK