204217 2019-11-14 19:19:45 -0800 Make gcSafeMemcpy/gcSafeMemmove/gcSafeZeroMemory work properly on arm64_32 2019-11-14 22:50:19 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov guijemont keith_miller mark.lam msaboff rmorisset ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1590405 0 saam 2019-11-14 19:19:45 -0800 We need to be very specific in wanting 64-bit types. 1590408 1 383596 saam 2019-11-14 19:27:11 -0800 Created attachment 383596 patch 1590410 2 saam 2019-11-14 19:29:31 -0800 <rdar://problem/57209211> 1590426 3 383596 mark.lam 2019-11-14 22:01:03 -0800 Comment on attachment 383596 patch r=me 1590432 4 383596 commit-queue 2019-11-14 22:50:18 -0800 Comment on attachment 383596 patch Clearing flags on attachment: 383596 Committed r252479: <https://trac.webkit.org/changeset/252479> 1590433 5 commit-queue 2019-11-14 22:50:19 -0800 All reviewed patches have been landed. Closing bug. 383596 2019-11-14 19:27:11 -0800 2019-11-14 22:50:18 -0800 patch a-backup.diff text/plain 6186 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUyNDc3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE5LTExLTE0ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IE1ha2UgZ2NTYWZlTWVtY3B5L2djU2FmZU1lbW1vdmUvZ2NTYWZlWmVyb01lbW9yeSB3b3JrIHBy b3Blcmx5IG9uIGFybTY0XzMyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDQyMTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBXZSBuZWVkIHRvIGJlIGV4cGxpY2l0IGluIHRoZSBjb2RlIGFib3V0IHVzaW5n IDY0LWJpdCB0eXBlcyBhbmQgcG9pbnRlciB0eXBlcy4KKworICAgICAgICAqIGhlYXAvR0NNZW1v cnlPcGVyYXRpb25zLmg6CisgICAgICAgIChKU0M6OmdjU2FmZU1lbWNweSk6CisgICAgICAgIChK U0M6OmdjU2FmZU1lbW1vdmUpOgorICAgICAgICAoSlNDOjpnY1NhZmVaZXJvTWVtb3J5KToKKwog MjAxOS0xMS0xNCAgQWxleGV5IFNodmF5a2EgIDxzaHZhaWthbGVzaEBnbWFpbC5jb20+CiAKICAg ICAgICAgVXNlIHRvTGVuZ3RoKCkgYW5kIGdldEluZGV4UXVpY2tseSgpIGluIEpTT04uc3RyaW5n aWZ5CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9HQ01lbW9yeU9wZXJhdGlvbnMu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9HQ01lbW9yeU9wZXJh dGlvbnMuaAkocmV2aXNpb24gMjUyNDYzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAv R0NNZW1vcnlPcGVyYXRpb25zLmgJKHdvcmtpbmcgY29weSkKQEAgLTkyLDI5ICs5MiwzMiBAQCBB TFdBWVNfSU5MSU5FIHZvaWQgZ2NTYWZlTWVtY3B5KFQqIGRzdCwgCiAgICAgICAgICAgICA6ICJ4 bW0wIiwgInhtbTEiLCAieG1tMiIsICJ4bW0zIiwgIm1lbW9yeSIsICJjYyIKICAgICAgICAgKTsK ICNlbGlmIENQVShBUk02NCkKLSAgICAgICAgc2l6ZV90IGFsaWduZWRCeXRlcyA9IChieXRlcyAv IDE2KSAqIDE2OworICAgICAgICB1aW50NjRfdCBhbGlnbmVkQnl0ZXMgPSAoc3RhdGljX2Nhc3Q8 dWludDY0X3Q+KGJ5dGVzKSAvIDE2KSAqIDE2OwogICAgICAgICBzaXplX3Qgb2Zmc2V0ID0gMDsK IAorICAgICAgICB1aW50NjRfdCBkc3RQdHIgPSBzdGF0aWNfY2FzdDx1aW50NjRfdD4oYml0d2lz ZV9jYXN0PHVpbnRwdHJfdD4oZHN0KSk7CisgICAgICAgIHVpbnQ2NF90IHNyY1B0ciA9IHN0YXRp Y19jYXN0PHVpbnQ2NF90PihiaXR3aXNlX2Nhc3Q8dWludHB0cl90PihzcmMpKTsKKwogICAgICAg ICBhc20gdm9sYXRpbGUoCiAgICAgICAgICAgICAiMTpcdFxuIgogICAgICAgICAgICAgImNtcCAl eFtvZmZzZXRdLCAleFthbGlnbmVkQnl0ZXNdXHRcbiIKICAgICAgICAgICAgICJiLmVxIDJmXHRc biIKLSAgICAgICAgICAgICJsZHIgcTAsIFsleFtzcmNdLCAleFtvZmZzZXRdXVx0XG4iCi0gICAg ICAgICAgICAic3RyIHEwLCBbJXhbZHN0XSwgJXhbb2Zmc2V0XV1cdFxuIgorICAgICAgICAgICAg ImxkciBxMCwgWyV4W3NyY1B0cl0sICV4W29mZnNldF1dXHRcbiIKKyAgICAgICAgICAgICJzdHIg cTAsIFsleFtkc3RQdHJdLCAleFtvZmZzZXRdXVx0XG4iCiAgICAgICAgICAgICAiYWRkICV4W29m ZnNldF0sICV4W29mZnNldF0sICMweDEwXHRcbiIKICAgICAgICAgICAgICJiIDFiXHRcbiIKIAog ICAgICAgICAgICAgIjI6XHRcbiIKICAgICAgICAgICAgICJjbXAgJXhbb2Zmc2V0XSwgJXhbYnl0 ZXNdXHRcbiIKICAgICAgICAgICAgICJiLmVxIDNmXHRcbiIKLSAgICAgICAgICAgICJsZHIgZDAs IFsleFtzcmNdLCAleFtvZmZzZXRdXVx0XG4iCi0gICAgICAgICAgICAic3RyIGQwLCBbJXhbZHN0 XSwgJXhbb2Zmc2V0XV1cdFxuIgorICAgICAgICAgICAgImxkciBkMCwgWyV4W3NyY1B0cl0sICV4 W29mZnNldF1dXHRcbiIKKyAgICAgICAgICAgICJzdHIgZDAsIFsleFtkc3RQdHJdLCAleFtvZmZz ZXRdXVx0XG4iCiAgICAgICAgICAgICAiYWRkICV4W29mZnNldF0sICV4W29mZnNldF0sICMweDhc dFxuIgogICAgICAgICAgICAgImIgMmJcdFxuIgogCiAgICAgICAgICAgICAiMzpcdFxuIgogCi0g ICAgICAgICAgICA6IFthbGlnbmVkQnl0ZXNdICIrciIgKGFsaWduZWRCeXRlcyksIFtieXRlc10g IityIiAoYnl0ZXMpLCBbb2Zmc2V0XSAiK3IiIChvZmZzZXQpLCBbZHN0XSAiK3IiIChkc3QpLCBb c3JjXSAiK3IiIChzcmMpCisgICAgICAgICAgICA6IFthbGlnbmVkQnl0ZXNdICIrciIgKGFsaWdu ZWRCeXRlcyksIFtieXRlc10gIityIiAoYnl0ZXMpLCBbb2Zmc2V0XSAiK3IiIChvZmZzZXQpLCBb ZHN0UHRyXSAiK3IiIChkc3RQdHIpLCBbc3JjUHRyXSAiK3IiIChzcmNQdHIpCiAgICAgICAgICAg ICA6CiAgICAgICAgICAgICA6ICJkMCIsICJkMSIsICJtZW1vcnkiCiAgICAgICAgICk7CkBAIC0x NTQsNyArMTU3LDcgQEAgQUxXQVlTX0lOTElORSB2b2lkIGdjU2FmZU1lbW1vdmUoVCogZHN0LAog ICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgaWYgKChiaXR3aXNlX2Nhc3Q8dWludHB0cl90 PihzcmMpICsgYnl0ZXMpIDw9IGJpdHdpc2VfY2FzdDx1aW50cHRyX3Q+KGRzdCkpIHsKKyAgICBp ZiAoKHN0YXRpY19jYXN0PHVpbnQ2NF90PihiaXR3aXNlX2Nhc3Q8dWludHB0cl90PihzcmMpKSAr IHN0YXRpY19jYXN0PHVpbnQ2NF90PihieXRlcykpIDw9IHN0YXRpY19jYXN0PHVpbnQ2NF90Pihi aXR3aXNlX2Nhc3Q8dWludHB0cl90Pihkc3QpKSkgewogICAgICAgICBnY1NhZmVNZW1jcHkoZHN0 LCBzcmMsIGJ5dGVzKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KQEAgLTIwOCwyNyArMjExLDI5 IEBAIEFMV0FZU19JTkxJTkUgdm9pZCBnY1NhZmVNZW1tb3ZlKFQqIGRzdCwKICAgICAgICAgICAg IDogInhtbTAiLCAieG1tMSIsICJ4bW0yIiwgInhtbTMiLCAibWVtb3J5IiwgImNjIgogICAgICAg ICApOwogI2VsaWYgQ1BVKEFSTTY0KQotICAgICAgICBzaXplX3QgYWxpZ25lZEJ5dGVzID0gKGJ5 dGVzIC8gMTYpICogMTY7CisgICAgICAgIHVpbnQ2NF90IGFsaWduZWRCeXRlcyA9IChzdGF0aWNf Y2FzdDx1aW50NjRfdD4oYnl0ZXMpIC8gMTYpICogMTY7CisgICAgICAgIHVpbnQ2NF90IGRzdFB0 ciA9IHN0YXRpY19jYXN0PHVpbnQ2NF90PihiaXR3aXNlX2Nhc3Q8dWludHB0cl90Pihkc3QpKTsK KyAgICAgICAgdWludDY0X3Qgc3JjUHRyID0gc3RhdGljX2Nhc3Q8dWludDY0X3Q+KGJpdHdpc2Vf Y2FzdDx1aW50cHRyX3Q+KHNyYykpOwogCiAgICAgICAgIGFzbSB2b2xhdGlsZSgKICAgICAgICAg ICAgICIxOlx0XG4iCiAgICAgICAgICAgICAiY21wICV4W2FsaWduZWRCeXRlc10sICV4W2J5dGVz XVx0XG4iCiAgICAgICAgICAgICAiYi5lcSAyZlx0XG4iCiAgICAgICAgICAgICAic3ViICV4W2J5 dGVzXSwgJXhbYnl0ZXNdLCAjMHg4XHRcbiIKLSAgICAgICAgICAgICJsZHIgZDAsIFsleFtzcmNd LCAleFtieXRlc11dXHRcbiIKLSAgICAgICAgICAgICJzdHIgZDAsIFsleFtkc3RdLCAleFtieXRl c11dXHRcbiIKKyAgICAgICAgICAgICJsZHIgZDAsIFsleFtzcmNQdHJdLCAleFtieXRlc11dXHRc biIKKyAgICAgICAgICAgICJzdHIgZDAsIFsleFtkc3RQdHJdLCAleFtieXRlc11dXHRcbiIKICAg ICAgICAgICAgICJiIDFiXHRcbiIKIAogICAgICAgICAgICAgIjI6XHRcbiIKICAgICAgICAgICAg ICJjYnogJXhbYWxpZ25lZEJ5dGVzXSwgM2ZcdFxuIgogICAgICAgICAgICAgInN1YiAleFthbGln bmVkQnl0ZXNdLCAleFthbGlnbmVkQnl0ZXNdLCAjMHgxMFx0XG4iCi0gICAgICAgICAgICAibGRy IHEwLCBbJXhbc3JjXSwgJXhbYWxpZ25lZEJ5dGVzXV1cdFxuIgotICAgICAgICAgICAgInN0ciBx MCwgWyV4W2RzdF0sICV4W2FsaWduZWRCeXRlc11dXHRcbiIKKyAgICAgICAgICAgICJsZHIgcTAs IFsleFtzcmNQdHJdLCAleFthbGlnbmVkQnl0ZXNdXVx0XG4iCisgICAgICAgICAgICAic3RyIHEw LCBbJXhbZHN0UHRyXSwgJXhbYWxpZ25lZEJ5dGVzXV1cdFxuIgogICAgICAgICAgICAgImIgMmJc dFxuIgogCiAgICAgICAgICAgICAiMzpcdFxuIgogCi0gICAgICAgICAgICA6IFthbGlnbmVkQnl0 ZXNdICIrciIgKGFsaWduZWRCeXRlcyksIFtieXRlc10gIityIiAoYnl0ZXMpLCBbZHN0XSAiK3Ii IChkc3QpLCBbc3JjXSAiK3IiIChzcmMpCisgICAgICAgICAgICA6IFthbGlnbmVkQnl0ZXNdICIr ciIgKGFsaWduZWRCeXRlcyksIFtieXRlc10gIityIiAoYnl0ZXMpLCBbZHN0UHRyXSAiK3IiIChk c3RQdHIpLCBbc3JjUHRyXSAiK3IiIChzcmNQdHIpCiAgICAgICAgICAgICA6CiAgICAgICAgICAg ICA6ICJkMCIsICJkMSIsICJtZW1vcnkiCiAgICAgICAgICk7CkBAIC0yNjEsMzEgKzI2NiwzMiBA QCBBTFdBWVNfSU5MSU5FIHZvaWQgZ2NTYWZlWmVyb01lbW9yeShUKiBkCiAgICAgICAgIDogIm1l bW9yeSIKICAgICApOwogI2VsaWYgQ1BVKEFSTTY0KQotICAgIHNpemVfdCBhbGlnbmVkQnl0ZXMg PSAoYnl0ZXMgLyA2NCkgKiA2NDsKLSAgICBjaGFyKiBlbmQgPSBiaXR3aXNlX2Nhc3Q8Y2hhcio+ KGRzdCkgKyBieXRlczsKLSAgICBjaGFyKiBhbGlnbmVkRW5kID0gYml0d2lzZV9jYXN0PGNoYXIq Pihkc3QpICsgYWxpZ25lZEJ5dGVzOworICAgIHVpbnQ2NF90IGFsaWduZWRCeXRlcyA9IChzdGF0 aWNfY2FzdDx1aW50NjRfdD4oYnl0ZXMpIC8gNjQpICogNjQ7CisgICAgdWludDY0X3QgZHN0UHRy ID0gc3RhdGljX2Nhc3Q8dWludDY0X3Q+KGJpdHdpc2VfY2FzdDx1aW50cHRyX3Q+KGRzdCkpOwor ICAgIHVpbnQ2NF90IGVuZCA9IGRzdFB0ciArIGJ5dGVzOworICAgIHVpbnQ2NF90IGFsaWduZWRF bmQgPSBkc3RQdHIgKyBhbGlnbmVkQnl0ZXM7CiAgICAgYXNtIHZvbGF0aWxlKAogICAgICAgICAi bW92aSBkMCwgIzBcdFxuIgogICAgICAgICAibW92aSBkMSwgIzBcdFxuIgogCiAgICAgICAgICIu cDJhbGlnbiA0XHRcbiIKICAgICAgICAgIjI6XHRcbiIKLSAgICAgICAgImNtcCAleFtkc3RdLCAl eFthbGlnbmVkRW5kXVx0XG4iCisgICAgICAgICJjbXAgJXhbZHN0UHRyXSwgJXhbYWxpZ25lZEVu ZF1cdFxuIgogICAgICAgICAiYi5lcSA0Zlx0XG4iCi0gICAgICAgICJzdG5wIHEwLCBxMCwgWyV4 W2RzdF1dXHRcbiIKLSAgICAgICAgInN0bnAgcTAsIHEwLCBbJXhbZHN0XSwgIzB4MjBdXHRcbiIK LSAgICAgICAgImFkZCAleFtkc3RdLCAleFtkc3RdLCAjMHg0MFx0XG4iCisgICAgICAgICJzdG5w IHEwLCBxMCwgWyV4W2RzdFB0cl1dXHRcbiIKKyAgICAgICAgInN0bnAgcTAsIHEwLCBbJXhbZHN0 UHRyXSwgIzB4MjBdXHRcbiIKKyAgICAgICAgImFkZCAleFtkc3RQdHJdLCAleFtkc3RQdHJdLCAj MHg0MFx0XG4iCiAgICAgICAgICJiIDJiXHRcbiIKIAogICAgICAgICAiNDpcdFxuIgotICAgICAg ICAiY21wICV4W2RzdF0sICV4W2VuZF1cdFxuIgorICAgICAgICAiY21wICV4W2RzdFB0cl0sICV4 W2VuZF1cdFxuIgogICAgICAgICAiYi5lcSA1Zlx0XG4iCi0gICAgICAgICJzdHIgZDAsIFsleFtk c3RdXSwgIzB4OFx0XG4iCisgICAgICAgICJzdHIgZDAsIFsleFtkc3RQdHJdXSwgIzB4OFx0XG4i CiAgICAgICAgICJiIDRiXHRcbiIKIAogICAgICAgICAiNTpcdFxuIgogCi0gICAgICAgIDogW2Fs aWduZWRCeXRlc10gIityIiAoYWxpZ25lZEJ5dGVzKSwgW2J5dGVzXSAiK3IiIChieXRlcyksIFtk c3RdICIrciIgKGRzdCksIFtlbmRdICIrciIgKGVuZCksIFthbGlnbmVkRW5kXSAiK3IiIChhbGln bmVkRW5kKQorICAgICAgICA6IFthbGlnbmVkQnl0ZXNdICIrciIgKGFsaWduZWRCeXRlcyksIFti eXRlc10gIityIiAoYnl0ZXMpLCBbZHN0UHRyXSAiK3IiIChkc3RQdHIpLCBbZW5kXSAiK3IiIChl bmQpLCBbYWxpZ25lZEVuZF0gIityIiAoYWxpZ25lZEVuZCkKICAgICAgICAgOgogICAgICAgICA6 ICJkMCIsICJkMSIsICJtZW1vcnkiCiAgICAgKTsK