204207 2019-11-14 16:04:37 -0800 Publish JavaScriptCore as Clang module 2019-11-18 10:56:17 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cpolcyn webkit-unassigned commit-queue ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1590355 0 cpolcyn 2019-11-14 16:04:37 -0800 Publish JavaScriptCore as Clang module 1590357 1 383582 cpolcyn 2019-11-14 16:10:47 -0800 Created attachment 383582 Patch 1590370 2 keith_miller 2019-11-14 16:36:19 -0800 Do Clang modules support exporting macros? I'm assuming yes but, IIRC, C++ modules don't. 1590416 3 cpolcyn 2019-11-14 20:23:24 -0800 (In reply to Keith Miller from comment #2) > Do Clang modules support exporting macros? I'm assuming yes but, IIRC, C++ > modules don't. Yes, you can read about it here: https://clang.llvm.org/docs/Modules.html#macros 1590428 4 383582 keith_miller 2019-11-14 22:11:41 -0800 Comment on attachment 383582 Patch I see, that makes sense. r=me. 1590429 5 keith_miller 2019-11-14 22:12:52 -0800 Do you have commit privileges? If not, I can do it for you. 1591095 6 cpolcyn 2019-11-18 09:52:46 -0800 (In reply to Keith Miller from comment #5) > Do you have commit privileges? If not, I can do it for you. I assume I don't have commit privileges as it's my first time contributing here. If you want to do it that would be great. Thanks! 1591114 7 383582 commit-queue 2019-11-18 10:55:26 -0800 Comment on attachment 383582 Patch Clearing flags on attachment: 383582 Committed r252551: <https://trac.webkit.org/changeset/252551> 1591115 8 commit-queue 2019-11-18 10:55:27 -0800 All reviewed patches have been landed. Closing bug. 1591116 9 webkit-bug-importer 2019-11-18 10:56:17 -0800 <rdar://problem/57289332> 383582 2019-11-14 16:10:47 -0800 2019-11-18 10:55:26 -0800 Patch bug-204207-20191114161046.patch text/plain 1115 cpolcyn SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUyNDY3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDE5LTExLTE0ICBDaHJpcyBQb2xjeW4gIDxjcG9sY3luQGFwcGxlLmNvbT4KKworICAgICAg ICBQdWJsaXNoIEphdmFTY3JpcHRDb3JlIGFzIENsYW5nIG1vZHVsZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0MjA3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9KYXZhU2Ny aXB0Q29yZS54Y2NvbmZpZzoKKwogMjAxOS0xMS0xNCAgQWxleGV5IFNodmF5a2EgIDxzaHZhaWth bGVzaEBnbWFpbC5jb20+CiAKICAgICAgICAgVXNlIHRvTGVuZ3RoKCkgYW5kIGdldEluZGV4UXVp Y2tseSgpIGluIEpTT04uc3RyaW5naWZ5CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29u ZmlndXJhdGlvbnMvSmF2YVNjcmlwdENvcmUueGNjb25maWcKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRpb25zL0phdmFTY3JpcHRDb3JlLnhjY29uZmlnCShy ZXZpc2lvbiAyNTI0NjcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMv SmF2YVNjcmlwdENvcmUueGNjb25maWcJKHdvcmtpbmcgY29weSkKQEAgLTI2LDYgKzI2LDcgQEAK IAogREVGSU5FU19NT0RVTEUgPSAkKERFRklORVNfTU9EVUxFXyQoV0tfUExBVEZPUk1fTkFNRSkp CiBERUZJTkVTX01PRFVMRV9tYWNjYXRhbHlzdCA9IFlFUzsKK0RFRklORVNfTU9EVUxFX21hY29z eCA9IFlFUzsKIERFRklORVNfTU9EVUxFXyA9IE5POwogTU9EVUxFTUFQX0ZJTEUgPSAkKFNSQ1JP T1QpL0phdmFTY3JpcHRDb3JlLm1vZHVsZW1hcDsKIAo=