20419 2008-08-17 13:01:41 -0700 Remove op_jless 2008-08-18 07:39:48 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 zwarich zwarich oldest_to_newest 88684 0 zwarich 2008-08-17 13:01:41 -0700 After we added the loop opcodes, I wanted to remove op_jless, as we now have op_loop_if_less. It will only be used when less is inside of a logical operator, which doesn't really justify its continued existence. Removing it was originally a random slowdown on SunSpider, but now it's a 0.1% speedup. 88685 1 22845 zwarich 2008-08-17 13:03:43 -0700 Created attachment 22845 Proposed patch 88687 2 22845 mjs 2008-08-17 14:07:19 -0700 Comment on attachment 22845 Proposed patch r=me 88689 3 zwarich 2008-08-17 14:09:31 -0700 *** Bug 19823 has been marked as a duplicate of this bug. *** 88717 4 zwarich 2008-08-18 07:39:48 -0700 Landed in r35810. 22845 2008-08-17 13:03:43 -0700 2008-08-17 14:07:19 -0700 Proposed patch nojless.diff text/plain 3986 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM1ODA2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDgtMDgt MTcgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDIwNDE5OiBSZW1vdmUg b3Bfamxlc3MKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDQxOT4KKworICAgICAgICBSZW1vdmUgb3Bfamxlc3MsIHdoaWNoIGlzIHJhcmVseSB1c2Vk IG5vdyB0aGF0IGhhdmUgb3BfbG9vcF9pZl9sZXNzLgorCisgICAgICAgICogVk0vQ29kZUJsb2Nr LmNwcDoKKyAgICAgICAgKEtKUzo6Q29kZUJsb2NrOjpkdW1wKToKKyAgICAgICAgKiBWTS9Db2Rl R2VuZXJhdG9yLmNwcDoKKyAgICAgICAgKEtKUzo6Q29kZUdlbmVyYXRvcjo6ZW1pdEp1bXBJZlRy dWUpOgorICAgICAgICAqIFZNL01hY2hpbmUuY3BwOgorICAgICAgICAoS0pTOjpNYWNoaW5lOjpw cml2YXRlRXhlY3V0ZSk6CisgICAgICAgICogVk0vT3Bjb2RlLmg6CisKIDIwMDgtMDgtMTYgIEdl b2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBP bGl2ZXIgSHVudC4KSW5kZXg6IFZNL0NvZGVCbG9jay5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVk0vQ29k ZUJsb2NrLmNwcAkocmV2aXNpb24gMzU4MDYpCisrKyBWTS9Db2RlQmxvY2suY3BwCSh3b3JraW5n IGNvcHkpCkBAIC01MzcsMTMgKzUzNyw2IEBAIHZvaWQgQ29kZUJsb2NrOjpkdW1wKEV4ZWNTdGF0 ZSogZXhlYywgY28KICAgICAgICAgICAgIHByaW50Q29uZGl0aW9uYWxKdW1wKGJlZ2luLCBpdCwg bG9jYXRpb24sICJqZmFsc2UiKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9Ci0gICAg ICAgIGNhc2Ugb3Bfamxlc3M6IHsKLSAgICAgICAgICAgIGludCByMCA9ICgrK2l0KS0+dS5vcGVy YW5kOwotICAgICAgICAgICAgaW50IHIxID0gKCsraXQpLT51Lm9wZXJhbmQ7Ci0gICAgICAgICAg ICBpbnQgb2Zmc2V0ID0gKCsraXQpLT51Lm9wZXJhbmQ7Ci0gICAgICAgICAgICBwcmludGYoIlsl NGRdIGpsZXNzXHRcdCAlcywgJXMsICVkKC0+JWQpXG4iLCBsb2NhdGlvbiwgcmVnaXN0ZXJOYW1l KHIwKS5jX3N0cigpLCByZWdpc3Rlck5hbWUocjEpLmNfc3RyKCksIG9mZnNldCwganVtcFRhcmdl dChiZWdpbiwgaXQsIG9mZnNldCkpOwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIH0KICAg ICAgICAgY2FzZSBvcF9qbmxlc3M6IHsKICAgICAgICAgICAgIGludCByMCA9ICgrK2l0KS0+dS5v cGVyYW5kOwogICAgICAgICAgICAgaW50IHIxID0gKCsraXQpLT51Lm9wZXJhbmQ7CkluZGV4OiBW TS9Db2RlR2VuZXJhdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBWTS9Db2RlR2VuZXJhdG9yLmNwcAko cmV2aXNpb24gMzU4MDYpCisrKyBWTS9Db2RlR2VuZXJhdG9yLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNDYyLDcgKzQ2Miw3IEBAIFBhc3NSZWZQdHI8TGFiZWxJRD4gQ29kZUdlbmVyYXRvcjo6ZW1p dEoKIAogUGFzc1JlZlB0cjxMYWJlbElEPiBDb2RlR2VuZXJhdG9yOjplbWl0SnVtcElmVHJ1ZShS ZWdpc3RlcklEKiBjb25kLCBMYWJlbElEKiB0YXJnZXQpCiB7Ci0gICAgaWYgKG1fbGFzdE9wY29k ZUlEID09IG9wX2xlc3MpIHsKKyAgICBpZiAobV9sYXN0T3Bjb2RlSUQgPT0gb3BfbGVzcyAmJiAh dGFyZ2V0LT5pc0ZvcndhcmRMYWJlbCgpKSB7CiAgICAgICAgIGludCBkc3RJbmRleDsKICAgICAg ICAgaW50IHNyYzFJbmRleDsKICAgICAgICAgaW50IHNyYzJJbmRleDsKQEAgLTQ3MSw3ICs0NzEs NyBAQCBQYXNzUmVmUHRyPExhYmVsSUQ+IENvZGVHZW5lcmF0b3I6OmVtaXRKCiAKICAgICAgICAg aWYgKGNvbmQtPmluZGV4KCkgPT0gZHN0SW5kZXggJiYgY29uZC0+aXNUZW1wb3JhcnkoKSAmJiAh Y29uZC0+cmVmQ291bnQoKSkgewogICAgICAgICAgICAgcmV3aW5kQmluYXJ5T3AoKTsKLSAgICAg ICAgICAgIGVtaXRPcGNvZGUodGFyZ2V0LT5pc0ZvcndhcmRMYWJlbCgpID8gb3Bfamxlc3MgOiBv cF9sb29wX2lmX2xlc3MpOworICAgICAgICAgICAgZW1pdE9wY29kZShvcF9sb29wX2lmX2xlc3Mp OwogICAgICAgICAgICAgaW5zdHJ1Y3Rpb25zKCkuYXBwZW5kKHNyYzFJbmRleCk7CiAgICAgICAg ICAgICBpbnN0cnVjdGlvbnMoKS5hcHBlbmQoc3JjMkluZGV4KTsKICAgICAgICAgICAgIGluc3Ry dWN0aW9ucygpLmFwcGVuZCh0YXJnZXQtPm9mZnNldEZyb20oaW5zdHJ1Y3Rpb25zKCkuc2l6ZSgp KSk7CkluZGV4OiBWTS9NYWNoaW5lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBWTS9NYWNoaW5lLmNwcAko cmV2aXNpb24gMzU4MDYpCisrKyBWTS9NYWNoaW5lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjIx NCwyOSArMjIxNCw2IEBAIEpTVmFsdWUqIE1hY2hpbmU6OnByaXZhdGVFeGVjdXRlKEV4ZWN1dGkK ICAgICAgICAgKyt2UEM7CiAgICAgICAgIE5FWFRfT1BDT0RFOwogICAgIH0KLSAgICBCRUdJTl9P UENPREUob3Bfamxlc3MpIHsKLSAgICAgICAgLyogamxlc3Mgc3JjMShyKSBzcmMyKHIpIHRhcmdl dChvZmZzZXQpCi0KLSAgICAgICAgICAgQ2hlY2tzIHdoZXRoZXIgcmVnaXN0ZXIgc3JjMSBpcyBs ZXNzIHRoYW4gcmVnaXN0ZXIgc3JjMiwgYXMKLSAgICAgICAgICAgd2l0aCB0aGUgRUNNQVNjcmlw dCAnPCcgb3BlcmF0b3IsIGFuZCB0aGVuIGp1bXBzIHRvIG9mZnNldAotICAgICAgICAgICB0YXJn ZXQgZnJvbSB0aGUgY3VycmVudCBpbnN0cnVjdGlvbiwgaWYgYW5kIG9ubHkgaWYgdGhlIAotICAg ICAgICAgICByZXN1bHQgb2YgdGhlIGNvbXBhcmlzb24gaXMgdHJ1ZS4KLSAgICAgICAgKi8KLSAg ICAgICAgSlNWYWx1ZSogc3JjMSA9IHJbKCsrdlBDKS0+dS5vcGVyYW5kXS5qc1ZhbHVlKGV4ZWMp OwotICAgICAgICBKU1ZhbHVlKiBzcmMyID0gclsoKyt2UEMpLT51Lm9wZXJhbmRdLmpzVmFsdWUo ZXhlYyk7Ci0gICAgICAgIGludCB0YXJnZXQgPSAoKyt2UEMpLT51Lm9wZXJhbmQ7Ci0KLSAgICAg ICAgYm9vbCByZXN1bHQgPSBqc0xlc3MoZXhlYywgc3JjMSwgc3JjMik7Ci0gICAgICAgIFZNX0NI RUNLX0VYQ0VQVElPTigpOwotICAgICAgICAKLSAgICAgICAgaWYgKHJlc3VsdCkgewotICAgICAg ICAgICAgdlBDICs9IHRhcmdldDsKLSAgICAgICAgICAgIE5FWFRfT1BDT0RFOwotICAgICAgICB9 Ci0KLSAgICAgICAgKyt2UEM7Ci0gICAgICAgIE5FWFRfT1BDT0RFOwotICAgIH0KICAgICBCRUdJ Tl9PUENPREUob3Bfam5sZXNzKSB7CiAgICAgICAgIC8qIGpubGVzcyBzcmMxKHIpIHNyYzIocikg dGFyZ2V0KG9mZnNldCkKIApJbmRleDogVk0vT3Bjb2RlLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVk0vT3Bj b2RlLmgJKHJldmlzaW9uIDM1ODA2KQorKysgVk0vT3Bjb2RlLmgJKHdvcmtpbmcgY29weSkKQEAg LTk4LDcgKzk4LDYgQEAgbmFtZXNwYWNlIEtKUyB7CiAgICAgICAgIG1hY3JvKG9wX2ptcCkgXAog ICAgICAgICBtYWNybyhvcF9qdHJ1ZSkgXAogICAgICAgICBtYWNybyhvcF9qZmFsc2UpIFwKLSAg ICAgICAgbWFjcm8ob3Bfamxlc3MpIFwKICAgICAgICAgbWFjcm8ob3Bfam5sZXNzKSBcCiAgICAg ICAgIG1hY3JvKG9wX2ptcF9zY29wZXMpIFwKICAgICAgICAgbWFjcm8ob3BfbG9vcCkgXAo=