204176 2019-11-13 16:06:48 -0800 Web Inspector: Uncaught Exception: Invalid type of argument 'eventName' for command 'DOMDebugger.setEventBreakpoint' call. It must be 'string' but it is 'object'. 2019-11-13 19:37:17 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://webkit.org/ InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1590088 0 hi 2019-11-13 16:06:48 -0800 Uncaught Exception in Web Inspector. Steps to Reproduce: 1. inspect any page 2. go to the Sources Tab 3. click the + in the Debugger section and select Event Breakpoint 4. leave the <input> empty and hit enter Uncaught Exceptions: ----------------------- - Invalid type of argument 'eventName' for command 'DOMDebugger.setEventBreakpoint' call. It must be 'string' but it is 'object'. (at InspectorBackend.js:478:48) deliverFailure @ InspectorBackend.js:478:48 invoke @ InspectorBackend.js:494:38 _updateEventBreakpoint @ DOMDebuggerManager.js:701:62 addEventBreakpoint @ DOMDebuggerManager.js:400:44 _willDismissEventBreakpointPopover @ SourcesNavigationSidebarPanel.js:697:49 willDismissPopover @ SourcesNavigationSidebarPanel.js:646:52 dismiss @ Popover.js:166:45 dismiss @ EventBreakpointPopover.js:110:22 handleEvent @ Popover.js:176:29 ----------------------- Notes: Inspected URL: https://webkit.org/ Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/605.1.15 (KHTML, like Gecko) 1590107 1 383516 hi 2019-11-13 16:34:04 -0800 Created attachment 383516 Patch 1590176 2 383516 commit-queue 2019-11-13 19:37:00 -0800 Comment on attachment 383516 Patch Clearing flags on attachment: 383516 Committed r252447: <https://trac.webkit.org/changeset/252447> 1590177 3 commit-queue 2019-11-13 19:37:02 -0800 All reviewed patches have been landed. Closing bug. 1590178 4 webkit-bug-importer 2019-11-13 19:37:17 -0800 <rdar://problem/57178290> 383516 2019-11-13 16:34:04 -0800 2019-11-13 19:37:00 -0800 Patch bug-204176-20191113163404.patch text/plain 6542 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY5NWRmZjEwMmM4Nzc2MmE2YmIxY2Q1ZDk0ZTc0 MmM3YmNjYzRmMzAuLmNiMzc1OGViNDk4ZTMzOGQzZmJjNWE1OTRhOTZjODhhYzI4ZWUzOGMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE5LTExLTEzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBV bmNhdWdodCBFeGNlcHRpb246IEludmFsaWQgdHlwZSBvZiBhcmd1bWVudCAnZXZlbnROYW1lJyBm b3IgY29tbWFuZCAnRE9NRGVidWdnZXIuc2V0RXZlbnRCcmVha3BvaW50JyBjYWxsLiBJdCBtdXN0 IGJlICdzdHJpbmcnIGJ1dCBpdCBpcyAnb2JqZWN0Jy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDE3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9FdmVudEJyZWFr cG9pbnRQb3BvdmVyLmpzOgorICAgICAgICAoV0kuRXZlbnRCcmVha3BvaW50UG9wb3Zlci5wcm90 b3R5cGUuZGlzbWlzcyk6CisgICAgICAgIE9ubHkgY3JlYXRlIHRoZSBgV0kuRXZlbnRCcmVha3Bv aW50YCBpZiB0aGUgPGlucHV0PiBoYXMgYSB2YWx1ZS4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvQ29udHJvbGxlcnMvRE9NRGVidWdnZXJNYW5hZ2VyLmpzOgorICAgICAgICAoV0kuRE9NRGVi dWdnZXJNYW5hZ2VyLnByb3RvdHlwZS5hZGRFdmVudEJyZWFrcG9pbnQpOgorICAgICAgICAoV0ku RE9NRGVidWdnZXJNYW5hZ2VyLnByb3RvdHlwZS5hZGRVUkxCcmVha3BvaW50KToKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZXNOYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzOgor ICAgICAgICAoV0kuU291cmNlc05hdmlnYXRpb25TaWRlYmFyUGFuZWwucHJvdG90eXBlLl93aWxs RGlzbWlzc0V2ZW50QnJlYWtwb2ludFBvcG92ZXIpOgorICAgICAgICAoV0kuU291cmNlc05hdmln YXRpb25TaWRlYmFyUGFuZWwucHJvdG90eXBlLl93aWxsRGlzbWlzc1VSTEJyZWFrcG9pbnRQb3Bv dmVyKToKKyAgICAgICAgRHJpdmUtYnk6IGlmIHRoZSBjb25maWd1cmF0aW9uIGlzbid0IHZhbGlk IChlLmcuIG5vIGJyZWFrcG9pbnQpIG9yIHRoZSBicmVha3BvaW50IGFscmVhZHkKKyAgICAgICAg ICAgICAgICAgIGV4aXN0cywgYmVlcC4KKwogMjAxOS0xMS0xMiAgRGV2aW4gUm91c3NvICA8ZHJv dXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogTG9jYWwgT3ZlcnJpZGVz OiBkcm9wIHpvbmUgb3ZlcmxheSBkb2Vzbid0IHRha2UgdXAgdGhlIGZ1bGwgY29udGVudCBhcmVh CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9s bGVycy9ET01EZWJ1Z2dlck1hbmFnZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9Db250cm9sbGVycy9ET01EZWJ1Z2dlck1hbmFnZXIuanMKaW5kZXggYTRiMTYxM2U1 NTQ3NDMxN2ZlYzIxNjI3ZThjMmZiMjk5ZDcyN2NjZC4uMWE0NTgwYTRmMGY2NzQwMTZhYTlmOGZl NjZmNTE2ZGVjODE4OGIzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvQ29udHJvbGxlcnMvRE9NRGVidWdnZXJNYW5hZ2VyLmpzCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RPTURlYnVnZ2VyTWFuYWdl ci5qcwpAQCAtMzc4LDE4ICszNzgsMTggQEAgV0kuRE9NRGVidWdnZXJNYW5hZ2VyID0gY2xhc3Mg RE9NRGVidWdnZXJNYW5hZ2VyIGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgewogICAgICAgICBjb25z b2xlLmFzc2VydChicmVha3BvaW50IGluc3RhbmNlb2YgV0kuRXZlbnRCcmVha3BvaW50LCBicmVh a3BvaW50KTsKICAgICAgICAgaWYgKCFicmVha3BvaW50KQotICAgICAgICAgICAgcmV0dXJuOwor ICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgICAgIGlmICh0aGlzLmlzQnJlYWtwb2lu dFNwZWNpYWwoYnJlYWtwb2ludCkpIHsKICAgICAgICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRv TGlzdGVuZXJzKFdJLkRPTURlYnVnZ2VyTWFuYWdlci5FdmVudC5FdmVudEJyZWFrcG9pbnRBZGRl ZCwge2JyZWFrcG9pbnR9KTsKLSAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIHJldHVy biB0cnVlOwogICAgICAgICB9CiAKICAgICAgICAgY29uc29sZS5hc3NlcnQoYnJlYWtwb2ludC50 eXBlID09PSBXSS5FdmVudEJyZWFrcG9pbnQuVHlwZS5MaXN0ZW5lciwgYnJlYWtwb2ludCk7CiAg ICAgICAgIGNvbnNvbGUuYXNzZXJ0KGJyZWFrcG9pbnQuZXZlbnROYW1lLCBicmVha3BvaW50KTsK IAogICAgICAgICBpZiAodGhpcy5fbGlzdGVuZXJCcmVha3BvaW50cy5maW5kKChleGlzdGluZykg PT4gZXhpc3RpbmcuZXZlbnROYW1lID09PSBicmVha3BvaW50LmV2ZW50TmFtZSkpCi0gICAgICAg ICAgICByZXR1cm47CisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICAgICAgdGhpcy5f bGlzdGVuZXJCcmVha3BvaW50cy5wdXNoKGJyZWFrcG9pbnQpOwogCkBAIC00MDIsNiArNDAyLDgg QEAgV0kuRE9NRGVidWdnZXJNYW5hZ2VyID0gY2xhc3MgRE9NRGVidWdnZXJNYW5hZ2VyIGV4dGVu ZHMgV0kuT2JqZWN0CiAKICAgICAgICAgaWYgKCF0aGlzLl9yZXN0b3JpbmdCcmVha3BvaW50cykK ICAgICAgICAgICAgIFdJLm9iamVjdFN0b3Jlcy5ldmVudEJyZWFrcG9pbnRzLnB1dE9iamVjdChi cmVha3BvaW50KTsKKworICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKICAgICByZW1vdmVF dmVudEJyZWFrcG9pbnQoYnJlYWtwb2ludCkKQEAgLTQ1MywxOSArNDU1LDE5IEBAIFdJLkRPTURl YnVnZ2VyTWFuYWdlciA9IGNsYXNzIERPTURlYnVnZ2VyTWFuYWdlciBleHRlbmRzIFdJLk9iamVj dAogICAgIHsKICAgICAgICAgY29uc29sZS5hc3NlcnQoYnJlYWtwb2ludCBpbnN0YW5jZW9mIFdJ LlVSTEJyZWFrcG9pbnQpOwogICAgICAgICBpZiAoIWJyZWFrcG9pbnQpCi0gICAgICAgICAgICBy ZXR1cm47CisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICAgICAgaWYgKHRoaXMuaXNC cmVha3BvaW50U3BlY2lhbChicmVha3BvaW50KSkgewogICAgICAgICAgICAgdGhpcy5kaXNwYXRj aEV2ZW50VG9MaXN0ZW5lcnMoV0kuRE9NRGVidWdnZXJNYW5hZ2VyLkV2ZW50LlVSTEJyZWFrcG9p bnRBZGRlZCwge2JyZWFrcG9pbnR9KTsKLSAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAg IHJldHVybiB0cnVlOwogICAgICAgICB9CiAKICAgICAgICAgY29uc29sZS5hc3NlcnQoIXRoaXMu X3VybEJyZWFrcG9pbnRzLmluY2x1ZGVzKGJyZWFrcG9pbnQpLCAiQWxyZWFkeSBhZGRlZCBVUkwg YnJlYWtwb2ludC4iLCBicmVha3BvaW50KTsKICAgICAgICAgaWYgKHRoaXMuX3VybEJyZWFrcG9p bnRzLmluY2x1ZGVzKGJyZWFrcG9pbnQpKQotICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAg ICAgcmV0dXJuIGZhbHNlOwogCiAgICAgICAgIGlmICh0aGlzLl91cmxCcmVha3BvaW50cy5zb21l KChlbnRyeSkgPT4gZW50cnkudHlwZSA9PT0gYnJlYWtwb2ludC50eXBlICYmIGVudHJ5LnVybCA9 PT0gYnJlYWtwb2ludC51cmwpKQotICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOwogCiAgICAgICAgIHRoaXMuX3VybEJyZWFrcG9pbnRzLnB1c2goYnJlYWtwb2lu dCk7CiAKQEAgLTQ3OCw2ICs0ODAsOCBAQCBXSS5ET01EZWJ1Z2dlck1hbmFnZXIgPSBjbGFzcyBE T01EZWJ1Z2dlck1hbmFnZXIgZXh0ZW5kcyBXSS5PYmplY3QKIAogICAgICAgICBpZiAoIXRoaXMu X3Jlc3RvcmluZ0JyZWFrcG9pbnRzKQogICAgICAgICAgICAgV0kub2JqZWN0U3RvcmVzLnVybEJy ZWFrcG9pbnRzLnB1dE9iamVjdChicmVha3BvaW50KTsKKworICAgICAgICByZXR1cm4gdHJ1ZTsK ICAgICB9CiAKICAgICByZW1vdmVVUkxCcmVha3BvaW50KGJyZWFrcG9pbnQpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9FdmVudEJyZWFrcG9p bnRQb3BvdmVyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv RXZlbnRCcmVha3BvaW50UG9wb3Zlci5qcwppbmRleCA4MzIyZjJiZDU0YzIxMDg4ZDhjMWU0MDVk NjY4MWNhMTFjMWNiYmYyLi5mZDQxZjE3NTgyNzc0OWFmMDQyZGVlOGNhYTY0OTc1MDY2NTEzZjZi IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9F dmVudEJyZWFrcG9pbnRQb3BvdmVyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0V2ZW50QnJlYWtwb2ludFBvcG92ZXIuanMKQEAgLTEwNSwxMSArMTA1 LDEzIEBAIFdJLkV2ZW50QnJlYWtwb2ludFBvcG92ZXIgPSBjbGFzcyBFdmVudEJyZWFrcG9pbnRQ b3BvdmVyIGV4dGVuZHMgV0kuUG9wb3ZlcgogCiAgICAgZGlzbWlzcygpCiAgICAgewotICAgICAg ICB0aGlzLl9icmVha3BvaW50ID0gbmV3IFdJLkV2ZW50QnJlYWtwb2ludChXSS5FdmVudEJyZWFr cG9pbnQuVHlwZS5MaXN0ZW5lciwge2V2ZW50TmFtZTogdGhpcy5fZG9tRXZlbnROYW1lSW5wdXRF bGVtZW50LnZhbHVlfSk7Ci0KLSAgICAgICAgc3VwZXIuZGlzbWlzcygpOworICAgICAgICBsZXQg ZXZlbnROYW1lID0gdGhpcy5fZG9tRXZlbnROYW1lSW5wdXRFbGVtZW50LnZhbHVlOworICAgICAg ICBpZiAoZXZlbnROYW1lKQorICAgICAgICAgICAgdGhpcy5fYnJlYWtwb2ludCA9IG5ldyBXSS5F dmVudEJyZWFrcG9pbnQoV0kuRXZlbnRCcmVha3BvaW50LlR5cGUuTGlzdGVuZXIsIHtldmVudE5h bWV9KTsKIAogICAgICAgICB0aGlzLl9zdWdnZXN0aW9uc1ZpZXcuaGlkZSgpOworCisgICAgICAg IHN1cGVyLmRpc21pc3MoKTsKICAgICB9CiAKICAgICAvLyBDb21wbGV0aW9uU3VnZ2VzdGlvbnNW aWV3IGRlbGVnYXRlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9Tb3VyY2VzTmF2aWdhdGlvblNpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZXNOYXZpZ2F0aW9uU2lkZWJhclBh bmVsLmpzCmluZGV4IDYwMDFhMGFiYzJlYzMxMWMzZWUxOWUwOWVjZjgxNTgxNDliMTVkMmQuLmM2 NjM4ZDQ5Y2U2YjY4NDZhMWU0ZGUyZGQ5YmE0NWFlNTdlNGQzNjUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZXNOYXZpZ2F0aW9uU2lk ZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1NvdXJjZXNOYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzCkBAIC02OTEsMTkgKzY5MSwyNSBA QCBXSS5Tb3VyY2VzTmF2aWdhdGlvblNpZGViYXJQYW5lbCA9IGNsYXNzIFNvdXJjZXNOYXZpZ2F0 aW9uU2lkZWJhclBhbmVsIGV4dGVuZHMgVwogICAgIF93aWxsRGlzbWlzc0V2ZW50QnJlYWtwb2lu dFBvcG92ZXIocG9wb3ZlcikKICAgICB7CiAgICAgICAgIGxldCBicmVha3BvaW50ID0gcG9wb3Zl ci5icmVha3BvaW50OwotICAgICAgICBpZiAoIWJyZWFrcG9pbnQpCisgICAgICAgIGlmICghYnJl YWtwb2ludCkgeworICAgICAgICAgICAgSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmJlZXAoKTsKICAg ICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQogCi0gICAgICAgIFdJLmRvbURlYnVnZ2VyTWFu YWdlci5hZGRFdmVudEJyZWFrcG9pbnQoYnJlYWtwb2ludCk7CisgICAgICAgIGlmICghV0kuZG9t RGVidWdnZXJNYW5hZ2VyLmFkZEV2ZW50QnJlYWtwb2ludChicmVha3BvaW50KSkKKyAgICAgICAg ICAgIEluc3BlY3RvckZyb250ZW5kSG9zdC5iZWVwKCk7CiAgICAgfQogCiAgICAgX3dpbGxEaXNt aXNzVVJMQnJlYWtwb2ludFBvcG92ZXIocG9wb3ZlcikKICAgICB7CiAgICAgICAgIGxldCBicmVh a3BvaW50ID0gcG9wb3Zlci5icmVha3BvaW50OwotICAgICAgICBpZiAoIWJyZWFrcG9pbnQpCisg ICAgICAgIGlmICghYnJlYWtwb2ludCkgeworICAgICAgICAgICAgSW5zcGVjdG9yRnJvbnRlbmRI b3N0LmJlZXAoKTsKICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQogCi0gICAgICAgIFdJ LmRvbURlYnVnZ2VyTWFuYWdlci5hZGRVUkxCcmVha3BvaW50KGJyZWFrcG9pbnQpOworICAgICAg ICBpZiAoIVdJLmRvbURlYnVnZ2VyTWFuYWdlci5hZGRVUkxCcmVha3BvaW50KGJyZWFrcG9pbnQp KQorICAgICAgICAgICAgSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmJlZXAoKTsKICAgICB9CiAKICAg ICBfZmlsdGVyQnlSZXNvdXJjZXNXaXRoSXNzdWVzKHRyZWVFbGVtZW50KQo=