<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>204159</bug_id>
          
          <creation_ts>2019-11-13 08:33:32 -0800</creation_ts>
          <short_desc>Use SecTrustEvaluateWithError instead of SecTrustEvaluate where available</short_desc>
          <delta_ts>2019-11-18 14:41:59 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alex Christensen">achristensen</reporter>
          <assigned_to name="Alex Christensen">achristensen</assigned_to>
          <cc>benjamin</cc>
    
    <cc>cdumez</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>dbates</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1589883</commentid>
    <comment_count>0</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-11-13 08:33:32 -0800</bug_when>
    <thetext>Use SecTrustEvaluateWithError instead of SecTrustEvaluate where available</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1589884</commentid>
    <comment_count>1</comment_count>
      <attachid>383459</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-11-13 08:34:24 -0800</bug_when>
    <thetext>Created attachment 383459
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1589885</commentid>
    <comment_count>2</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-11-13 08:34:27 -0800</bug_when>
    <thetext>&lt;rdar://problem/45894288&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1589890</commentid>
    <comment_count>3</comment_count>
      <attachid>383459</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-11-13 09:13:32 -0800</bug_when>
    <thetext>Comment on attachment 383459
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383459&amp;action=review

&gt; Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm:101
&gt; +        bool success = SecTrustEvaluateWithError(trust, &amp;error);

This will leak the CFErrorRef. Note that the error argument is marked CF_RETURNS_RETAINED that indicates it’s the caller’s responsibility to release.

&gt; Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:938
&gt; +        bool success = SecTrustEvaluateWithError(trust, &amp;error);

Ditto.

&gt; Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:947
&gt; +        infoDictionary = [(__bridge NSDictionary *)SecTrustCopyInfo(trust) autorelease];

Not important, but a side note. This line is just re-indented and this is not new code, but I would write this instead:

    infoDictionary = CFBridgingRelease(SecTrustCopyInfo(trust));</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1590419</commentid>
    <comment_count>4</comment_count>
      <attachid>383599</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-11-14 20:54:55 -0800</bug_when>
    <thetext>Created attachment 383599
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1590422</commentid>
    <comment_count>5</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-11-14 21:09:44 -0800</bug_when>
    <thetext>Turns out having an error and returning false are the same, and we do nothing with the error, so I&apos;m just passing nullptr to not receive the error.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1591246</commentid>
    <comment_count>6</comment_count>
      <attachid>383599</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-11-18 14:41:57 -0800</bug_when>
    <thetext>Comment on attachment 383599
Patch

Clearing flags on attachment: 383599

Committed r252595: &lt;https://trac.webkit.org/changeset/252595&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1591247</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-11-18 14:41:59 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>383459</attachid>
            <date>2019-11-13 08:34:24 -0800</date>
            <delta_ts>2019-11-14 20:54:53 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-204159-20191113083423.patch</filename>
            <type>text/plain</type>
            <size>5009</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh
bmdlTG9nCShyZXZpc2lvbiAyNTIyNzQpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu
ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE5LTExLTEzICBBbGV4IENocmlzdGVuc2VuICA8
YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVXNlIFNlY1RydXN0RXZhbHVhdGVX
aXRoRXJyb3IgaW5zdGVhZCBvZiBTZWNUcnVzdEV2YWx1YXRlIHdoZXJlIGF2YWlsYWJsZQorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0MTU5CisgICAg
ICAgIDxyZGFyOi8vcHJvYmxlbS80NTg5NDI4OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDE5LTExLTA3ICBN
YXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYSBzdGFjayBvdmVy
ZmxvdyBjaGVjayBpbiBZYXJyOjpCeXRlQ29tcGlsZXI6OmVtaXREaXNqdW5jdGlvbigpLgpJbmRl
eDogU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0
Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiAyNTIyNzQpCisrKyBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9y
bS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNjIxLDYgKzE2MjEsMTAgQEAKICNkZWZpbmUgSEFWRV9U
TFNfUFJPVE9DT0xfVkVSU0lPTl9UIDEKICNlbmRpZgogCisjaWYgUExBVEZPUk0oSU9TKSB8fCAo
UExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTQw
MCkgfHwgUExBVEZPUk0oV0FUQ0hPUykgfHwgUExBVEZPUk0oQVBQTEVUVikgfHwgUExBVEZPUk0o
TUFDQ0FUQUxZU1QpCisjZGVmaW5lIEhBVkVfU0VDX1RSVVNUX0VWQUxVQVRFX1dJVEhfRVJST1Ig
MQorI2VuZGlmCisKICNpZiBQTEFURk9STShJT1MpIHx8IFBMQVRGT1JNKE1BQ0NBVEFMWVNUKQog
I2RlZmluZSBVU0VfVUlDT05URVhUTUVOVSAxCiAjZW5kaWYKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl
L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlz
aW9uIDI1MjI3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA
QCAtMSwzICsxLDE0IEBACisyMDE5LTExLTEzICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVu
c2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVXNlIFNlY1RydXN0RXZhbHVhdGVXaXRoRXJyb3Ig
aW5zdGVhZCBvZiBTZWNUcnVzdEV2YWx1YXRlIHdoZXJlIGF2YWlsYWJsZQorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0MTU5CisgICAgICAgIDxyZGFy
Oi8vcHJvYmxlbS80NTg5NDI4OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY29jb2EvUmVzb3VyY2VSZXNwb25zZUNv
Y29hLm1tOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VSZXNwb25zZTo6cGxhdGZvcm1DZXJ0
aWZpY2F0ZUluZm8gY29uc3QpOgorCiAyMDE5LTExLTA4ICBDaHJpcyBEdW1leiAgPGNkdW1lekBh
cHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBEZWZlcnJlZFByb21pc2UgYmVoYXZlIG5pY2VseSB3
aXRoIHJlZ2FyZHMgdG8gdGhlIGJhY2svZm9yd2FyZCBjYWNoZQpJbmRleDogU291cmNlL1dlYkNv
cmUvcGxhdGZvcm0vbmV0d29yay9jb2NvYS9SZXNvdXJjZVJlc3BvbnNlQ29jb2EubW0KPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jb2NvYS9SZXNvdXJjZVJl
c3BvbnNlQ29jb2EubW0JKHJldmlzaW9uIDI1MjI3NCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL25ldHdvcmsvY29jb2EvUmVzb3VyY2VSZXNwb25zZUNvY29hLm1tCSh3b3JraW5nIGNvcHkp
CkBAIC05NiwxMiArOTYsMTYgQEAgQ2VydGlmaWNhdGVJbmZvIFJlc291cmNlUmVzcG9uc2U6OnBs
YXRmbwogICAgICAgICByZXR1cm4geyB9OwogCiAgICAgaWYgKHRydXN0UmVzdWx0VHlwZSA9PSBr
U2VjVHJ1c3RSZXN1bHRJbnZhbGlkKSB7Ci0gICAgICAgIC8vIEZJWE1FOiBUaGlzIGlzIGRlcHJl
Y2F0ZWQgPHJkYXI6Ly9wcm9ibGVtLzQ1ODk0Mjg4Pi4KLSAgICAgICAgQUxMT1dfREVQUkVDQVRF
RF9ERUNMQVJBVElPTlNfQkVHSU4KKyNpZiBIQVZFKFNFQ19UUlVTVF9FVkFMVUFURV9XSVRIX0VS
Uk9SKQorICAgICAgICBDRkVycm9yUmVmIGVycm9yID0gbnVsbHB0cjsKKyAgICAgICAgYm9vbCBz
dWNjZXNzID0gU2VjVHJ1c3RFdmFsdWF0ZVdpdGhFcnJvcih0cnVzdCwgJmVycm9yKTsKKyAgICAg
ICAgaWYgKCFzdWNjZXNzIHx8IGVycm9yKQorICAgICAgICAgICAgcmV0dXJuIHsgfTsKKyNlbHNl
CiAgICAgICAgIHJlc3VsdCA9IFNlY1RydXN0RXZhbHVhdGUodHJ1c3QsICZ0cnVzdFJlc3VsdFR5
cGUpOwotICAgICAgICBBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFUSU9OU19FTkQKICAgICAgICAg
aWYgKHJlc3VsdCAhPSBlcnJTZWNTdWNjZXNzKQogICAgICAgICAgICAgcmV0dXJuIHsgfTsKKyNl
bmRpZgogICAgIH0KIAogI2lmIEhBVkUoU0VDX1RSVVNUX1NFUklBTElaQVRJT04pCkluZGV4OiBT
b3VyY2UvV2ViS2l0L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L0NoYW5n
ZUxvZwkocmV2aXNpb24gMjUyNDExKQorKysgU291cmNlL1dlYktpdC9DaGFuZ2VMb2cJKHdvcmtp
bmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxOS0xMS0xMyAgQWxleCBDaHJpc3RlbnNlbiAg
PGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgorCisgICAgICAgIFVzZSBTZWNUcnVzdEV2YWx1YXRl
V2l0aEVycm9yIGluc3RlYWQgb2YgU2VjVHJ1c3RFdmFsdWF0ZSB3aGVyZSBhdmFpbGFibGUKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDE1OQorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNz
L2lvcy9mdWxsc2NyZWVuL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXJJT1MubW06CisgICAg
ICAgICgtW1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIgX0VWT3JnYW5pemF0aW9uTmFtZV0p
OgorCiAyMDE5LTExLTEzICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAg
ICAgUm9sbG91dChyMjUxMzU4KSBDYXVzZXMgbG9hZCBoYW5ncwpJbmRleDogU291cmNlL1dlYktp
dC9VSVByb2Nlc3MvaW9zL2Z1bGxzY3JlZW4vV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlcklP
Uy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZnVsbHNjcmVl
bi9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVySU9TLm1tCShyZXZpc2lvbiAyNTIyNzQpCisr
KyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZnVsbHNjcmVlbi9XS0Z1bGxTY3JlZW5XaW5k
b3dDb250cm9sbGVySU9TLm1tCSh3b3JraW5nIGNvcHkpCkBAIC05MzMsMTUgKzkzMywxOCBAQCAt
IChOU1N0cmluZyAqKV9FVk9yZ2FuaXphdGlvbk5hbWUKICAgICAvLyBJZiBTZWNUcnVzdENvcHlJ
bmZvIHJldHVybmVkIE5VTEwgdGhlbiBpdCdzIGxpa2VseSB0aGF0IHRoZSBTZWNUcnVzdFJlZiBo
YXMgbm90IGJlZW4gZXZhbHVhdGVkCiAgICAgLy8gYW5kIHRoZSBvbmx5IHdheSB0byBnZXQgdGhl
IGluZm9ybWF0aW9uIHdlIG5lZWQgaXMgdG8gY2FsbCBTZWNUcnVzdEV2YWx1YXRlIG91cnNlbHZl
cy4KICAgICBpZiAoIWluZm9EaWN0aW9uYXJ5KSB7CisjaWYgSEFWRShTRUNfVFJVU1RfRVZBTFVB
VEVfV0lUSF9FUlJPUikKKyAgICAgICAgQ0ZFcnJvclJlZiBlcnJvciA9IG51bGxwdHI7CisgICAg
ICAgIGJvb2wgc3VjY2VzcyA9IFNlY1RydXN0RXZhbHVhdGVXaXRoRXJyb3IodHJ1c3QsICZlcnJv
cik7CisgICAgICAgIGlmICghc3VjY2VzcyB8fCBlcnJvcikKKyAgICAgICAgICAgIHJldHVybiBu
aWw7CisjZWxzZQogICAgICAgICBTZWNUcnVzdFJlc3VsdFR5cGUgcmVzdWx0ID0ga1NlY1RydXN0
UmVzdWx0UHJvY2VlZDsKLQotICAgICAgICAvLyBGSVhNRTogVGhpcyBpcyBkZXByZWNhdGVkIDxy
ZGFyOi8vcHJvYmxlbS80NTg5NDI4OD4uCi0gICAgICAgIEFMTE9XX0RFUFJFQ0FURURfREVDTEFS
QVRJT05TX0JFR0lOCiAgICAgICAgIE9TU3RhdHVzIGVyciA9IFNlY1RydXN0RXZhbHVhdGUodHJ1
c3QsICZyZXN1bHQpOwotICAgICAgICBBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFUSU9OU19FTkQK
LQotICAgICAgICBpZiAoZXJyID09IG5vRXJyKQotICAgICAgICAgICAgaW5mb0RpY3Rpb25hcnkg
PSBbKF9fYnJpZGdlIE5TRGljdGlvbmFyeSAqKVNlY1RydXN0Q29weUluZm8odHJ1c3QpIGF1dG9y
ZWxlYXNlXTsKKyAgICAgICAgaWYgKGVyciAhPSBub0VycikKKyAgICAgICAgICAgIHJldHVybiBu
aWw7CisjZW5kaWYKKyAgICAgICAgaW5mb0RpY3Rpb25hcnkgPSBbKF9fYnJpZGdlIE5TRGljdGlv
bmFyeSAqKVNlY1RydXN0Q29weUluZm8odHJ1c3QpIGF1dG9yZWxlYXNlXTsKICAgICAgICAgaWYg
KCFpbmZvRGljdGlvbmFyeSkKICAgICAgICAgICAgIHJldHVybiBuaWw7CiAgICAgfQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>383599</attachid>
            <date>2019-11-14 20:54:55 -0800</date>
            <delta_ts>2019-11-18 14:41:57 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-204159-20191114205454.patch</filename>
            <type>text/plain</type>
            <size>5020</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh
bmdlTG9nCShyZXZpc2lvbiAyNTI0NzIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu
ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE5LTExLTE0ICBBbGV4IENocmlzdGVuc2VuICA8
YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVXNlIFNlY1RydXN0RXZhbHVhdGVX
aXRoRXJyb3IgaW5zdGVhZCBvZiBTZWNUcnVzdEV2YWx1YXRlIHdoZXJlIGF2YWlsYWJsZQorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0MTU5CisgICAg
ICAgIDxyZGFyOi8vcHJvYmxlbS80NTg5NDI4OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDE5LTExLTE0ICBZ
dXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gQmxvY2tE
aXJlY3RvcnkncyBiaXRzIHNob3VsZCBiZSBjb21wYWN0CkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9Q
bGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgJKHJldmlz
aW9uIDI1MjQ3MikKKysrIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkK
QEAgLTE2MjEsNiArMTYyMSwxMCBAQAogI2RlZmluZSBIQVZFX1RMU19QUk9UT0NPTF9WRVJTSU9O
X1QgMQogI2VuZGlmCiAKKyNpZiBQTEFURk9STShJT1MpIHx8IChQTEFURk9STShNQUMpICYmIF9f
TUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxNDAwKSB8fCBQTEFURk9STShXQVRD
SE9TKSB8fCBQTEFURk9STShBUFBMRVRWKSB8fCBQTEFURk9STShNQUNDQVRBTFlTVCkKKyNkZWZp
bmUgSEFWRV9TRUNfVFJVU1RfRVZBTFVBVEVfV0lUSF9FUlJPUiAxCisjZW5kaWYKKwogI2lmIFBM
QVRGT1JNKElPUykgfHwgUExBVEZPUk0oTUFDQ0FUQUxZU1QpCiAjZGVmaW5lIFVTRV9VSUNPTlRF
WFRNRU5VIDEKICNlbmRpZgpJbmRleDogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUyNDcyKQorKysgU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIw
MTktMTEtMTQgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKwor
ICAgICAgICBVc2UgU2VjVHJ1c3RFdmFsdWF0ZVdpdGhFcnJvciBpbnN0ZWFkIG9mIFNlY1RydXN0
RXZhbHVhdGUgd2hlcmUgYXZhaWxhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0yMDQxNTkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ1ODk0Mjg4
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxh
dGZvcm0vbmV0d29yay9jb2NvYS9SZXNvdXJjZVJlc3BvbnNlQ29jb2EubW06CisgICAgICAgIChX
ZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlOjpwbGF0Zm9ybUNlcnRpZmljYXRlSW5mbyBjb25zdCk6
CisKIDIwMTktMTEtMDcgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPiBhbmQgVGhp
YmF1bHQgU2F1bmllciA8dHNhdW5pZXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBVcGRhdGUgbGli
d2VicnRjIHRvIE03OApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jb2Nv
YS9SZXNvdXJjZVJlc3BvbnNlQ29jb2EubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv
cGxhdGZvcm0vbmV0d29yay9jb2NvYS9SZXNvdXJjZVJlc3BvbnNlQ29jb2EubW0JKHJldmlzaW9u
IDI1MjQ3MikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY29jb2EvUmVzb3Vy
Y2VSZXNwb25zZUNvY29hLm1tCSh3b3JraW5nIGNvcHkpCkBAIC05NiwxMiArOTYsMTQgQEAgQ2Vy
dGlmaWNhdGVJbmZvIFJlc291cmNlUmVzcG9uc2U6OnBsYXRmbwogICAgICAgICByZXR1cm4geyB9
OwogCiAgICAgaWYgKHRydXN0UmVzdWx0VHlwZSA9PSBrU2VjVHJ1c3RSZXN1bHRJbnZhbGlkKSB7
Ci0gICAgICAgIC8vIEZJWE1FOiBUaGlzIGlzIGRlcHJlY2F0ZWQgPHJkYXI6Ly9wcm9ibGVtLzQ1
ODk0Mjg4Pi4KLSAgICAgICAgQUxMT1dfREVQUkVDQVRFRF9ERUNMQVJBVElPTlNfQkVHSU4KKyNp
ZiBIQVZFKFNFQ19UUlVTVF9FVkFMVUFURV9XSVRIX0VSUk9SKQorICAgICAgICBpZiAoIVNlY1Ry
dXN0RXZhbHVhdGVXaXRoRXJyb3IodHJ1c3QsIG51bGxwdHIpKQorICAgICAgICAgICAgcmV0dXJu
IHsgfTsKKyNlbHNlCiAgICAgICAgIHJlc3VsdCA9IFNlY1RydXN0RXZhbHVhdGUodHJ1c3QsICZ0
cnVzdFJlc3VsdFR5cGUpOwotICAgICAgICBBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFUSU9OU19F
TkQKICAgICAgICAgaWYgKHJlc3VsdCAhPSBlcnJTZWNTdWNjZXNzKQogICAgICAgICAgICAgcmV0
dXJuIHsgfTsKKyNlbmRpZgogICAgIH0KIAogI2lmIEhBVkUoU0VDX1RSVVNUX1NFUklBTElaQVRJ
T04pCkluZGV4OiBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
V2ViS2l0L0NoYW5nZUxvZwkocmV2aXNpb24gMjUyNDcyKQorKysgU291cmNlL1dlYktpdC9DaGFu
Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxOS0xMS0xNCAgQWxleCBD
aHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgorCisgICAgICAgIFVzZSBTZWNU
cnVzdEV2YWx1YXRlV2l0aEVycm9yIGluc3RlYWQgb2YgU2VjVHJ1c3RFdmFsdWF0ZSB3aGVyZSBh
dmFpbGFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTIwNDE1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
ICogVUlQcm9jZXNzL2lvcy9mdWxsc2NyZWVuL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXJJ
T1MubW06CisgICAgICAgICgtW1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIgX0VWT3JnYW5p
emF0aW9uTmFtZV0pOgorCiAyMDE5LTExLTEyICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxl
LmNvbT4KIAogICAgICAgICBVcGRhdGUgbGlid2VicnRjIHRvIE03OApJbmRleDogU291cmNlL1dl
YktpdC9VSVByb2Nlc3MvaW9zL2Z1bGxzY3JlZW4vV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxl
cklPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZnVsbHNj
cmVlbi9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVySU9TLm1tCShyZXZpc2lvbiAyNTI0NzIp
CisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZnVsbHNjcmVlbi9XS0Z1bGxTY3JlZW5X
aW5kb3dDb250cm9sbGVySU9TLm1tCSh3b3JraW5nIGNvcHkpCkBAIC05MjksMTkgKzkyOSwyMCBA
QCAtIChOU1N0cmluZyAqKV9FVk9yZ2FuaXphdGlvbk5hbWUKICAgICBpZiAoIXRydXN0KQogICAg
ICAgICByZXR1cm4gbmlsOwogCi0gICAgTlNEaWN0aW9uYXJ5ICppbmZvRGljdGlvbmFyeSA9IFso
X19icmlkZ2UgTlNEaWN0aW9uYXJ5ICopU2VjVHJ1c3RDb3B5SW5mbyh0cnVzdCkgYXV0b3JlbGVh
c2VdOworICAgIE5TRGljdGlvbmFyeSAqaW5mb0RpY3Rpb25hcnkgPSBDRkJyaWRnaW5nUmVsZWFz
ZShTZWNUcnVzdENvcHlJbmZvKHRydXN0KSk7CiAgICAgLy8gSWYgU2VjVHJ1c3RDb3B5SW5mbyBy
ZXR1cm5lZCBOVUxMIHRoZW4gaXQncyBsaWtlbHkgdGhhdCB0aGUgU2VjVHJ1c3RSZWYgaGFzIG5v
dCBiZWVuIGV2YWx1YXRlZAogICAgIC8vIGFuZCB0aGUgb25seSB3YXkgdG8gZ2V0IHRoZSBpbmZv
cm1hdGlvbiB3ZSBuZWVkIGlzIHRvIGNhbGwgU2VjVHJ1c3RFdmFsdWF0ZSBvdXJzZWx2ZXMuCiAg
ICAgaWYgKCFpbmZvRGljdGlvbmFyeSkgeworI2lmIEhBVkUoU0VDX1RSVVNUX0VWQUxVQVRFX1dJ
VEhfRVJST1IpCisgICAgICAgIGlmICghU2VjVHJ1c3RFdmFsdWF0ZVdpdGhFcnJvcih0cnVzdCwg
bnVsbHB0cikpCisgICAgICAgICAgICByZXR1cm4gbmlsOworI2Vsc2UKICAgICAgICAgU2VjVHJ1
c3RSZXN1bHRUeXBlIHJlc3VsdCA9IGtTZWNUcnVzdFJlc3VsdFByb2NlZWQ7Ci0KLSAgICAgICAg
Ly8gRklYTUU6IFRoaXMgaXMgZGVwcmVjYXRlZCA8cmRhcjovL3Byb2JsZW0vNDU4OTQyODg+Lgot
ICAgICAgICBBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFUSU9OU19CRUdJTgogICAgICAgICBPU1N0
YXR1cyBlcnIgPSBTZWNUcnVzdEV2YWx1YXRlKHRydXN0LCAmcmVzdWx0KTsKLSAgICAgICAgQUxM
T1dfREVQUkVDQVRFRF9ERUNMQVJBVElPTlNfRU5ECi0KLSAgICAgICAgaWYgKGVyciA9PSBub0Vy
cikKLSAgICAgICAgICAgIGluZm9EaWN0aW9uYXJ5ID0gWyhfX2JyaWRnZSBOU0RpY3Rpb25hcnkg
KilTZWNUcnVzdENvcHlJbmZvKHRydXN0KSBhdXRvcmVsZWFzZV07CisgICAgICAgIGlmIChlcnIg
IT0gbm9FcnIpCisgICAgICAgICAgICByZXR1cm4gbmlsOworI2VuZGlmCisgICAgICAgIGluZm9E
aWN0aW9uYXJ5ID0gQ0ZCcmlkZ2luZ1JlbGVhc2UoU2VjVHJ1c3RDb3B5SW5mbyh0cnVzdCkpOwog
ICAgICAgICBpZiAoIWluZm9EaWN0aW9uYXJ5KQogICAgICAgICAgICAgcmV0dXJuIG5pbDsKICAg
ICB9Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>