204150 2019-11-13 02:54:31 -0800 WebDriver: check the frameID parameter before running switch to frame command 2019-11-13 06:39:25 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg clopez webkit-bug-importer oldest_to_newest 1589810 0 cgarcia 2019-11-13 02:54:31 -0800 We should check it's either null, a number (unsigned sort) or an object referencing a web element. Several tests are failing: imported/w3c/webdriver/tests/switch_to_frame/switch.py::test_frame_id_invalid_types[foo] imported/w3c/webdriver/tests/switch_to_frame/switch.py::test_frame_id_invalid_types[True] imported/w3c/webdriver/tests/switch_to_frame/switch.py::test_frame_id_invalid_types[value2] imported/w3c/webdriver/tests/switch_to_frame/switch.py::test_frame_id_invalid_types[value3] imported/w3c/webdriver/tests/switch_to_frame/switch.py::test_frame_id_out_of_bounds[-1] imported/w3c/webdriver/tests/switch_to_frame/switch.py::test_frame_id_out_of_bounds[65536] 1589812 1 383444 cgarcia 2019-11-13 02:57:36 -0800 Created attachment 383444 Patch 1589839 2 cgarcia 2019-11-13 06:38:13 -0800 Committed r252407: <https://trac.webkit.org/changeset/252407> 1589842 3 webkit-bug-importer 2019-11-13 06:39:25 -0800 <rdar://problem/57152713> 383444 2019-11-13 02:57:36 -0800 2019-11-13 06:16:48 -0800 Patch wd-switch-to-frame-id-checks.diff text/plain 4796 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggYzA0MmVjMzA1YzAuLjNhNjE3MzEyMDg4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDI1IEBACisyMDE5LTExLTEzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJEcml2ZXI6IGNoZWNrIHRoZSBmcmFtZUlE IHBhcmFtZXRlciBiZWZvcmUgcnVubmluZyBzd2l0Y2ggdG8gZnJhbWUgY29tbWFuZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0MTUwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugc2hvdWxkIGNoZWNr IGl0J3MgZWl0aGVyIG51bGwsIGEgbnVtYmVyICh1bnNpZ25lZCBzb3J0KSBvciBhbiBvYmplY3Qg cmVmZXJlbmNpbmcgYSB3ZWIgZWxlbWVudC4KKworICAgICAgICBGaXhlczogaW1wb3J0ZWQvdzNj L3dlYmRyaXZlci90ZXN0cy9zd2l0Y2hfdG9fZnJhbWUvc3dpdGNoLnB5Ojp0ZXN0X2ZyYW1lX2lk X2ludmFsaWRfdHlwZXNbZm9vXQorICAgICAgICAgICAgICAgaW1wb3J0ZWQvdzNjL3dlYmRyaXZl ci90ZXN0cy9zd2l0Y2hfdG9fZnJhbWUvc3dpdGNoLnB5Ojp0ZXN0X2ZyYW1lX2lkX2ludmFsaWRf dHlwZXNbVHJ1ZV0KKyAgICAgICAgICAgICAgIGltcG9ydGVkL3czYy93ZWJkcml2ZXIvdGVzdHMv c3dpdGNoX3RvX2ZyYW1lL3N3aXRjaC5weTo6dGVzdF9mcmFtZV9pZF9pbnZhbGlkX3R5cGVzW3Zh bHVlMl0KKyAgICAgICAgICAgICAgIGltcG9ydGVkL3czYy93ZWJkcml2ZXIvdGVzdHMvc3dpdGNo X3RvX2ZyYW1lL3N3aXRjaC5weTo6dGVzdF9mcmFtZV9pZF9pbnZhbGlkX3R5cGVzW3ZhbHVlM10K KyAgICAgICAgICAgICAgIGltcG9ydGVkL3czYy93ZWJkcml2ZXIvdGVzdHMvc3dpdGNoX3RvX2Zy YW1lL3N3aXRjaC5weTo6dGVzdF9mcmFtZV9pZF9vdXRfb2ZfYm91bmRzWy0xXQorICAgICAgICAg ICAgICAgaW1wb3J0ZWQvdzNjL3dlYmRyaXZlci90ZXN0cy9zd2l0Y2hfdG9fZnJhbWUvc3dpdGNo LnB5Ojp0ZXN0X2ZyYW1lX2lkX291dF9vZl9ib3VuZHNbNjU1MzZdCisKKyAgICAgICAgKiBTZXNz aW9uLmNwcDoKKyAgICAgICAgKFdlYkRyaXZlcjo6U2Vzc2lvbjo6c3dpdGNoVG9GcmFtZSk6IFJl bW92ZSB0aGUgdmFsaWRhdGlvbiBoZXJlLiBBbHNvIHJlbW92ZSB0aGUgY2FzZSBvZiBiZWluZyBh IGZyYW1lIG5hbWUsCisgICAgICAgIHNpbmNlIHRoYXQncyBub3QgaW4gdGhlIHNwZWMuCisgICAg ICAgICogV2ViRHJpdmVyU2VydmljZS5jcHA6CisgICAgICAgIChXZWJEcml2ZXI6OldlYkRyaXZl clNlcnZpY2U6OnN3aXRjaFRvRnJhbWUpOiBDaGVjayBmcmFtZUlEIHR5cGUgYmVmb3JlIGNhbGxp bmcgU2Vzc2lvbjo6c3dpdGNoVG9GcmFtZSgpLgorCiAyMDE5LTExLTEyICBDYXJsb3MgR2FyY2lh IENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBXZWJEcml2ZXI6 IGltcGxlbWVudCBuZXcgd2luZG93IGNvbW1hbmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2 ZXIvU2Vzc2lvbi5jcHAgYi9Tb3VyY2UvV2ViRHJpdmVyL1Nlc3Npb24uY3BwCmluZGV4IDI4MmFl NzQyMjM2Li5mYjEzMjU0YWY3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkRyaXZlci9TZXNzaW9u LmNwcAorKysgYi9Tb3VyY2UvV2ViRHJpdmVyL1Nlc3Npb24uY3BwCkBAIC02NTIsMjMgKzY1Miwx MiBAQCB2b2lkIFNlc3Npb246OnN3aXRjaFRvRnJhbWUoUmVmUHRyPEpTT046OlZhbHVlPiYmIGZy YW1lSUQsIEZ1bmN0aW9uPHZvaWQgKENvbW1hbgogCiAgICAgICAgIGludCBmcmFtZUluZGV4Owog ICAgICAgICBpZiAoZnJhbWVJRC0+YXNJbnRlZ2VyKGZyYW1lSW5kZXgpKSB7Ci0gICAgICAgICAg ICBpZiAoZnJhbWVJbmRleCA8IDAgfHwgZnJhbWVJbmRleCA+IFVTSFJUX01BWCkgewotICAgICAg ICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKENvbW1hbmRSZXN1bHQ6OmZhaWwoQ29tbWFuZFJl c3VsdDo6RXJyb3JDb2RlOjpOb1N1Y2hGcmFtZSkpOwotICAgICAgICAgICAgICAgIHJldHVybjsK LSAgICAgICAgICAgIH0KKyAgICAgICAgICAgIEFTU0VSVChmcmFtZUluZGV4ID49IDAgJiYgZnJh bWVJbmRleCA8IHN0ZDo6bnVtZXJpY19saW1pdHM8dW5zaWduZWQgc2hvcnQ+OjptYXgoKSk7CiAg ICAgICAgICAgICBwYXJhbWV0ZXJzLT5zZXRJbnRlZ2VyKCJvcmRpbmFsIl9zLCBmcmFtZUluZGV4 KTsKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIFN0cmluZyBmcmFtZUVsZW1lbnRJRCA9 IGV4dHJhY3RFbGVtZW50SUQoKmZyYW1lSUQpOwotICAgICAgICAgICAgaWYgKCFmcmFtZUVsZW1l bnRJRC5pc0VtcHR5KCkpCi0gICAgICAgICAgICAgICAgcGFyYW1ldGVycy0+c2V0U3RyaW5nKCJu b2RlSGFuZGxlIl9zLCBmcmFtZUVsZW1lbnRJRCk7Ci0gICAgICAgICAgICBlbHNlIHsKLSAgICAg ICAgICAgICAgICBTdHJpbmcgZnJhbWVOYW1lOwotICAgICAgICAgICAgICAgIGlmICghZnJhbWVJ RC0+YXNTdHJpbmcoZnJhbWVOYW1lKSkgewotICAgICAgICAgICAgICAgICAgICBjb21wbGV0aW9u SGFuZGxlcihDb21tYW5kUmVzdWx0OjpmYWlsKENvbW1hbmRSZXN1bHQ6OkVycm9yQ29kZTo6Tm9T dWNoRnJhbWUpKTsKLSAgICAgICAgICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICAgICAgICAg IH0KLSAgICAgICAgICAgICAgICBwYXJhbWV0ZXJzLT5zZXRTdHJpbmcoIm5hbWUiX3MsIGZyYW1l TmFtZSk7Ci0gICAgICAgICAgICB9CisgICAgICAgICAgICBBU1NFUlQoIWZyYW1lRWxlbWVudElE LmlzRW1wdHkoKSk7CisgICAgICAgICAgICBwYXJhbWV0ZXJzLT5zZXRTdHJpbmcoIm5vZGVIYW5k bGUiX3MsIGZyYW1lRWxlbWVudElEKTsKICAgICAgICAgfQogCiAgICAgICAgIG1faG9zdC0+c2Vu ZENvbW1hbmRUb0JhY2tlbmQoInJlc29sdmVDaGlsZEZyYW1lSGFuZGxlIl9zLCBXVEZNb3ZlKHBh cmFtZXRlcnMpLCBbdGhpcywgcHJvdGVjdGVkVGhpcyA9IHByb3RlY3RlZFRoaXMuY29weVJlZigp LCBjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpXShTZXNzaW9u SG9zdDo6Q29tbWFuZFJlc3BvbnNlJiYgcmVzcG9uc2UpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJEcml2ZXIvV2ViRHJpdmVyU2VydmljZS5jcHAgYi9Tb3VyY2UvV2ViRHJpdmVyL1dlYkRyaXZl clNlcnZpY2UuY3BwCmluZGV4IDBmYjNhMzlmMGM0Li5iYWMzM2M2NDZkNCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkRyaXZlci9XZWJEcml2ZXJTZXJ2aWNlLmNwcAorKysgYi9Tb3VyY2UvV2ViRHJp dmVyL1dlYkRyaXZlclNlcnZpY2UuY3BwCkBAIC0xMTc2LDYgKzExNzYsMzIgQEAgdm9pZCBXZWJE cml2ZXJTZXJ2aWNlOjpzd2l0Y2hUb0ZyYW1lKFJlZlB0cjxKU09OOjpPYmplY3Q+JiYgcGFyYW1l dGVycywgRnVuY3Rpb24KICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIHN3aXRjaCAoZnJh bWVJRC0+dHlwZSgpKSB7CisgICAgY2FzZSBKU09OOjpWYWx1ZTo6VHlwZTo6TnVsbDoKKyAgICAg ICAgYnJlYWs7CisgICAgY2FzZSBKU09OOjpWYWx1ZTo6VHlwZTo6RG91YmxlOgorICAgIGNhc2Ug SlNPTjo6VmFsdWU6OlR5cGU6OkludGVnZXI6CisgICAgICAgIGlmICghdmFsdWVBc051bWJlcklu UmFuZ2UoKmZyYW1lSUQsIDAsIHN0ZDo6bnVtZXJpY19saW1pdHM8dW5zaWduZWQgc2hvcnQ+Ojpt YXgoKSkpIHsKKyAgICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKENvbW1hbmRSZXN1bHQ6OmZh aWwoQ29tbWFuZFJlc3VsdDo6RXJyb3JDb2RlOjpJbnZhbGlkQXJndW1lbnQpKTsKKyAgICAgICAg ICAgIHJldHVybjsKKyAgICAgICAgfQorICAgICAgICBicmVhazsKKyAgICBjYXNlIEpTT046OlZh bHVlOjpUeXBlOjpPYmplY3Q6IHsKKyAgICAgICAgUmVmUHRyPEpTT046Ok9iamVjdD4gZnJhbWVJ RE9iamVjdDsKKyAgICAgICAgZnJhbWVJRC0+YXNPYmplY3QoZnJhbWVJRE9iamVjdCk7CisgICAg ICAgIGlmIChmcmFtZUlET2JqZWN0LT5maW5kKFNlc3Npb246OndlYkVsZW1lbnRJZGVudGlmaWVy KCkpID09IGZyYW1lSURPYmplY3QtPmVuZCgpKSB7CisgICAgICAgICAgICBjb21wbGV0aW9uSGFu ZGxlcihDb21tYW5kUmVzdWx0OjpmYWlsKENvbW1hbmRSZXN1bHQ6OkVycm9yQ29kZTo6SW52YWxp ZEFyZ3VtZW50KSk7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKyAgICAgICAgYnJl YWs7CisgICAgfQorICAgIGNhc2UgSlNPTjo6VmFsdWU6OlR5cGU6OkJvb2xlYW46CisgICAgY2Fz ZSBKU09OOjpWYWx1ZTo6VHlwZTo6U3RyaW5nOgorICAgIGNhc2UgSlNPTjo6VmFsdWU6OlR5cGU6 OkFycmF5OgorICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihDb21tYW5kUmVzdWx0OjpmYWlsKENv bW1hbmRSZXN1bHQ6OkVycm9yQ29kZTo6SW52YWxpZEFyZ3VtZW50KSk7CisgICAgICAgIHJldHVy bjsKKyAgICB9CisKICAgICBtX3Nlc3Npb24tPndhaXRGb3JOYXZpZ2F0aW9uVG9Db21wbGV0ZShb dGhpcywgZnJhbWVJRCwgY29tcGxldGlvbkhhbmRsZXIgPSBXVEZNb3ZlKGNvbXBsZXRpb25IYW5k bGVyKV0oQ29tbWFuZFJlc3VsdCYmIHJlc3VsdCkgbXV0YWJsZSB7CiAgICAgICAgIGlmIChyZXN1 bHQuaXNFcnJvcigpKSB7CiAgICAgICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihXVEZNb3ZlKHJl c3VsdCkpOwo=