204142 2019-11-12 21:59:44 -0800 check-webkit-style: fix false errors for obj-c method calls in range-based for statements using colon syntax 2019-11-13 14:58:20 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner achristensen commit-queue ews-watchlist glenn jbedard simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1589766 0 megan_gardner 2019-11-12 21:59:44 -0800 check-webkit-style: fix false errors for obj-c method calls in range-based for statements using colon syntax 1589768 1 383429 megan_gardner 2019-11-12 22:02:54 -0800 Created attachment 383429 Patch 1589864 2 383429 jbedard 2019-11-13 07:31:34 -0800 Comment on attachment 383429 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383429&action=review Small nit about combining the regex check into the existing if statement, but other than that, it looks good! > Tools/Scripts/webkitpy/style/checkers/cpp.py:1988 > + if not search(r'\[[^\]]+:[^\]]*\]', condition): Seems like this should be on line 1987 with the rest of the if statement, so it looks like: if statement == 'for' and search(r'(?:[^ :]:[^:]|[^:]:[^ :])', condition) and not search(r'\[[^\]]+:[^\]]*\]', condition): error(...) 1590039 3 383494 megan_gardner 2019-11-13 14:11:02 -0800 Created attachment 383494 Patch for landing 1590054 4 383494 commit-queue 2019-11-13 14:57:02 -0800 Comment on attachment 383494 Patch for landing Clearing flags on attachment: 383494 Committed r252433: <https://trac.webkit.org/changeset/252433> 1590055 5 commit-queue 2019-11-13 14:57:03 -0800 All reviewed patches have been landed. Closing bug. 1590056 6 webkit-bug-importer 2019-11-13 14:58:20 -0800 <rdar://problem/57169493> 383429 2019-11-12 22:02:54 -0800 2019-11-13 14:11:01 -0800 Patch bug-204142-20191112220253.patch text/plain 3415 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyMzU0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzlhZGFjOWVkOTJhMTJlMDNjN2YyY2MwNmMwODQzZmQx ZWVmNGMwMS4uMTVhZDcxNWJiM2VhYzMyMWQ0YzRhYWVlOTRlNTBkMDRhMzQ1NGY0NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE5LTExLTEyICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+ CisKKyAgICAgICAgY2hlY2std2Via2l0LXN0eWxlOiBmaXggZmFsc2UgZXJyb3JzIGZvciBvYmot YyBtZXRob2QgY2FsbHMgaW4gcmFuZ2UtYmFzZWQgZm9yIHN0YXRlbWVudHMgdXNpbmcgY29sb24g c3ludGF4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDQxNDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB bGxvdyBmb3IgdGhlIGV4aXN0YW5jZSBvZiBhbiBvYmotYyBtZXRob2QgY2FsbCBpbiBhIHJhbmdl LWJhc2VkIGZvciBzdGF0ZW1lbnQgdGhhdCBhbHNvIHVzZXMgY29sb25zLgorICAgICAgICBEbyBu b3QgYWxsb3cgY29sb25zIGJldHdlZW4gc3F1YXJlIGJyYWNrZXRzIHRvIHRyaWdnZXIgdGhlIGVy cm9yLgorICAgICAgICBBbHNvIGFkZCBhIHRlc3QgZm9yIHRoaXMgc3BlY2lmaWMgY2FzZS4KKwor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5OgorICAgICAg ICAoY2hlY2tfc3BhY2luZyk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2Vycy9jcHBfdW5pdHRlc3QucHk6CisgICAgICAgIChXZWJLaXRTdHlsZVRlc3QudGVzdF9zcGFj aW5nKToKKwogMjAxOS0xMS0xMSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJr aXQub3JnPgogCiAgICAgICAgIEFkZCBTUEkgdG8gYWNjZXNzIGEgV2Vic2l0ZURhdGFTdG9yZSB3 aXRob3V0IGluc3RhbnRpYXRpbmcgaXQsIGFuZCBpdHMgY29uZmlndXJhdGlvbgpkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCA1OTE4NjBmZDI4NzQ4 NWE2NDI1ZmFjMjU1MGE4NDAwYWY2NjZiZDFiLi45YmFhMzliNjhkZGE2NDNmZmQxNjRiMjFiNGMy NjVlMmM2NTdkYTUyIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2No ZWNrZXJzL2NwcC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NwcC5weQpAQCAtMTk3OCwxMyArMTk3OCwxNSBAQCBkZWYgY2hlY2tfc3BhY2luZyhmaWxlX2V4 dGVuc2lvbiwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX3N0YXRlLCBlcnJvcik6CiAg ICAgIyB0aGVyZSBzaG91bGQgZWl0aGVyIGJlIHplcm8gb3Igb25lIHNwYWNlcyBpbnNpZGUgdGhl IHBhcmVucy4KICAgICAjIFdlIGRvbid0IHdhbnQ6ICJpZiAoIGZvbykiIG9yICJpZiAoIGZvbyAg ICkiLgogICAgICMgRXhjZXB0aW9uOiAiZm9yICggOyBmb287IGJhcikiIGFuZCAiZm9yIChmb287 IGJhcjsgKSIgYXJlIGFsbG93ZWQuCisgICAgIyBFeGNlcHRpb246ICJmb3IgKGZvbyBuIGluIFtm b28gYmFyOmJhel0pIiBpcyBhbGxvd2VkIGJlY2F1c2Ugb2Ygb2JqLWMgbWV0aG9kIGNhbGxzCiAg ICAgbWF0Y2hlZCA9IHNlYXJjaChyJ1xiKD9QPHN0YXRlbWVudD5pZnxmb3J8d2hpbGV8c3dpdGNo KVxzKlwoKD9QPHJlbWFpbmRlcj4uKikkJywgbGluZSkKICAgICBpZiBtYXRjaGVkOgogICAgICAg ICBzdGF0ZW1lbnQgPSBtYXRjaGVkLmdyb3VwKCdzdGF0ZW1lbnQnKQogICAgICAgICBjb25kaXRp b24sIHJlc3QgPSB1cF90b191bm1hdGNoZWRfY2xvc2luZ19wYXJlbihtYXRjaGVkLmdyb3VwKCdy ZW1haW5kZXInKSkKICAgICAgICAgaWYgY29uZGl0aW9uIGlzIG5vdCBOb25lOgogICAgICAgICAg ICAgaWYgc3RhdGVtZW50ID09ICdmb3InIGFuZCBzZWFyY2gocicoPzpbXiA6XTpbXjpdfFteOl06 W14gOl0pJywgY29uZGl0aW9uKToKLSAgICAgICAgICAgICAgICBlcnJvcihsaW5lX251bWJlciwg J3doaXRlc3BhY2UvY29sb24nLCA0LCAnTWlzc2luZyBzcGFjZSBhcm91bmQgOiBpbiByYW5nZS1i YXNlZCBmb3Igc3RhdGVtZW50JykKKyAgICAgICAgICAgICAgICBpZiBub3Qgc2VhcmNoKHInXFtb XlxdXSs6W15cXV0qXF0nLCBjb25kaXRpb24pOgorICAgICAgICAgICAgICAgICAgICBlcnJvcihs aW5lX251bWJlciwgJ3doaXRlc3BhY2UvY29sb24nLCA0LCAnTWlzc2luZyBzcGFjZSBhcm91bmQg OiBpbiByYW5nZS1iYXNlZCBmb3Igc3RhdGVtZW50JykKICAgICAgICAgICAgIGNvbmRpdGlvbl9t YXRjaCA9IHNlYXJjaChyJyg/UDxsZWFkaW5nPlsgXSopKD9QPHNlcGFyYXRvcj4uKS4qW14gXSso P1A8dHJhaWxpbmc+WyBdKiknLCBjb25kaXRpb24pCiAgICAgICAgICAgICBpZiBjb25kaXRpb25f bWF0Y2g6CiAgICAgICAgICAgICAgICAgbl9sZWFkaW5nID0gbGVuKGNvbmRpdGlvbl9tYXRjaC5n cm91cCgnbGVhZGluZycpKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHls ZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQppbmRleCBlOTcwZDY1MGQ0M2I4YjdkYTFlMWU1ZDFi OTNiODdmN2YxNzFjNjhjLi4wYWVkZGI2ZjFhMDgyYjNjOGM3NzI3MDU3NmI5NTViMGZkZjdkODY0 IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91 bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2Nw cF91bml0dGVzdC5weQpAQCAtNDM1OSw2ICs0MzU5LDEyIEBAIGNsYXNzIFdlYktpdFN0eWxlVGVz dChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgICAgICcgICAgICAgIHByb2Nlc3ModmVjdG9y KTtcbicsCiAgICAgICAgICAgICAnJykKIAorICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5l X2xpbnQoCisgICAgICAgICAgICAnICAgIGZvciAoZm9vICpiYXIgaW4gW2ZvbyBiYXI6YmF6XSlc bicKKyAgICAgICAgICAgICcgICAgICAgIHByb2Nlc3MoYmFyKTtcbicsCisgICAgICAgICAgICAn JywKKyAgICAgICAgICAgICdmb28ubW0nKQorCiAgICAgICAgIHNlbGYuYXNzZXJ0X211bHRpX2xp bmVfbGludCgKICAgICAgICAgICAgICcgICAgZm9yIChjb25zdCBWZWN0b3ImIHZlY3RvcjogdmVj dG9ycylcbicKICAgICAgICAgICAgICcgICAgICAgIHByb2Nlc3ModmVjdG9yKTtcbicsCg== 383494 2019-11-13 14:11:02 -0800 2019-11-13 14:57:02 -0800 Patch for landing bug-204142-20191113141102.patch text/plain 3487 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyMzU0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzlhZGFjOWVkOTJhMTJlMDNjN2YyY2MwNmMwODQzZmQx ZWVmNGMwMS4uZjNhZjA1ZTAyMDQ2N2Y0MjYxYjVkZDIzMzkwNzM4MDk4Yjc3MzdhYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE5LTExLTEyICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+ CisKKyAgICAgICAgY2hlY2std2Via2l0LXN0eWxlOiBmaXggZmFsc2UgZXJyb3JzIGZvciBvYmot YyBtZXRob2QgY2FsbHMgaW4gcmFuZ2UtYmFzZWQgZm9yIHN0YXRlbWVudHMgdXNpbmcgY29sb24g c3ludGF4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDQxNDIKKworICAgICAgICBSZXZpZXdlZCBieSBKb25hdGhhbiBCZWRhcmQuCisKKyAgICAgICAg QWxsb3cgZm9yIHRoZSBleGlzdGFuY2Ugb2YgYW4gb2JqLWMgbWV0aG9kIGNhbGwgaW4gYSByYW5n ZS1iYXNlZCBmb3Igc3RhdGVtZW50IHRoYXQgYWxzbyB1c2VzIGNvbG9ucy4KKyAgICAgICAgRG8g bm90IGFsbG93IGNvbG9ucyBiZXR3ZWVuIHNxdWFyZSBicmFja2V0cyB0byB0cmlnZ2VyIHRoZSBl cnJvci4KKyAgICAgICAgQWxzbyBhZGQgYSB0ZXN0IGZvciB0aGlzIHNwZWNpZmljIGNhc2UuCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weToKKyAgICAg ICAgKGNoZWNrX3NwYWNpbmcpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlcnMvY3BwX3VuaXR0ZXN0LnB5OgorICAgICAgICAoV2ViS2l0U3R5bGVUZXN0LnRlc3Rfc3Bh Y2luZyk6CisKIDIwMTktMTEtMTEgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Vi a2l0Lm9yZz4KIAogICAgICAgICBBZGQgU1BJIHRvIGFjY2VzcyBhIFdlYnNpdGVEYXRhU3RvcmUg d2l0aG91dCBpbnN0YW50aWF0aW5nIGl0LCBhbmQgaXRzIGNvbmZpZ3VyYXRpb24KZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggNTkxODYwZmQyODc0 ODVhNjQyNWZhYzI1NTBhODQwMGFmNjY2YmQxYi4uYTI5ZGM2MDgwNWQ0Y2RhZmE0ZDk4M2Q3ZjRh ODUwNjQ1ZDg2OGQ0ZiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jcHAucHkKQEAgLTE5NzgsMTMgKzE5NzgsMTQgQEAgZGVmIGNoZWNrX3NwYWNpbmcoZmlsZV9l eHRlbnNpb24sIGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZmlsZV9zdGF0ZSwgZXJyb3IpOgog ICAgICMgdGhlcmUgc2hvdWxkIGVpdGhlciBiZSB6ZXJvIG9yIG9uZSBzcGFjZXMgaW5zaWRlIHRo ZSBwYXJlbnMuCiAgICAgIyBXZSBkb24ndCB3YW50OiAiaWYgKCBmb28pIiBvciAiaWYgKCBmb28g ICApIi4KICAgICAjIEV4Y2VwdGlvbjogImZvciAoIDsgZm9vOyBiYXIpIiBhbmQgImZvciAoZm9v OyBiYXI7ICkiIGFyZSBhbGxvd2VkLgorICAgICMgRXhjZXB0aW9uOiAiZm9yIChmb28gbiBpbiBb Zm9vIGJhcjpiYXpdKSIgaXMgYWxsb3dlZCBiZWNhdXNlIG9mIG9iai1jIG1ldGhvZCBjYWxscwog ICAgIG1hdGNoZWQgPSBzZWFyY2gocidcYig/UDxzdGF0ZW1lbnQ+aWZ8Zm9yfHdoaWxlfHN3aXRj aClccypcKCg/UDxyZW1haW5kZXI+LiopJCcsIGxpbmUpCiAgICAgaWYgbWF0Y2hlZDoKICAgICAg ICAgc3RhdGVtZW50ID0gbWF0Y2hlZC5ncm91cCgnc3RhdGVtZW50JykKICAgICAgICAgY29uZGl0 aW9uLCByZXN0ID0gdXBfdG9fdW5tYXRjaGVkX2Nsb3NpbmdfcGFyZW4obWF0Y2hlZC5ncm91cCgn cmVtYWluZGVyJykpCiAgICAgICAgIGlmIGNvbmRpdGlvbiBpcyBub3QgTm9uZToKLSAgICAgICAg ICAgIGlmIHN0YXRlbWVudCA9PSAnZm9yJyBhbmQgc2VhcmNoKHInKD86W14gOl06W146XXxbXjpd OlteIDpdKScsIGNvbmRpdGlvbik6Ci0gICAgICAgICAgICAgICAgZXJyb3IobGluZV9udW1iZXIs ICd3aGl0ZXNwYWNlL2NvbG9uJywgNCwgJ01pc3Npbmcgc3BhY2UgYXJvdW5kIDogaW4gcmFuZ2Ut YmFzZWQgZm9yIHN0YXRlbWVudCcpCisgICAgICAgICAgICBpZiBzdGF0ZW1lbnQgPT0gJ2Zvcicg YW5kIHNlYXJjaChyJyg/OlteIDpdOlteOl18W146XTpbXiA6XSknLCBjb25kaXRpb24pIGFuZCBu b3Qgc2VhcmNoKHInXFtbXlxdXSs6W15cXV0qXF0nLCBjb25kaXRpb24pOgorICAgICAgICAgICAg ICAgICAgICBlcnJvcihsaW5lX251bWJlciwgJ3doaXRlc3BhY2UvY29sb24nLCA0LCAnTWlzc2lu ZyBzcGFjZSBhcm91bmQgOiBpbiByYW5nZS1iYXNlZCBmb3Igc3RhdGVtZW50JykKICAgICAgICAg ICAgIGNvbmRpdGlvbl9tYXRjaCA9IHNlYXJjaChyJyg/UDxsZWFkaW5nPlsgXSopKD9QPHNlcGFy YXRvcj4uKS4qW14gXSsoP1A8dHJhaWxpbmc+WyBdKiknLCBjb25kaXRpb24pCiAgICAgICAgICAg ICBpZiBjb25kaXRpb25fbWF0Y2g6CiAgICAgICAgICAgICAgICAgbl9sZWFkaW5nID0gbGVuKGNv bmRpdGlvbl9tYXRjaC5ncm91cCgnbGVhZGluZycpKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQppbmRleCBlOTcwZDY1MGQ0 M2I4YjdkYTFlMWU1ZDFiOTNiODdmN2YxNzFjNjhjLi4wYWVkZGI2ZjFhMDgyYjNjOGM3NzI3MDU3 NmI5NTViMGZkZjdkODY0IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQpAQCAtNDM1OSw2ICs0MzU5LDEyIEBAIGNsYXNz IFdlYktpdFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgICAgICcgICAgICAg IHByb2Nlc3ModmVjdG9yKTtcbicsCiAgICAgICAgICAgICAnJykKIAorICAgICAgICBzZWxmLmFz c2VydF9tdWx0aV9saW5lX2xpbnQoCisgICAgICAgICAgICAnICAgIGZvciAoZm9vICpiYXIgaW4g W2ZvbyBiYXI6YmF6XSlcbicKKyAgICAgICAgICAgICcgICAgICAgIHByb2Nlc3MoYmFyKTtcbics CisgICAgICAgICAgICAnJywKKyAgICAgICAgICAgICdmb28ubW0nKQorCiAgICAgICAgIHNlbGYu YXNzZXJ0X211bHRpX2xpbmVfbGludCgKICAgICAgICAgICAgICcgICAgZm9yIChjb25zdCBWZWN0 b3ImIHZlY3RvcjogdmVjdG9ycylcbicKICAgICAgICAgICAgICcgICAgICAgIHByb2Nlc3ModmVj dG9yKTtcbicsCg==