204135 2019-11-12 17:11:18 -0800 [bmalloc] The tracking of freeableMemory of Heap doesn't count Chunk's metadata size. 2019-11-15 18:35:16 -0800 1 1 1 Unclassified WebKit bmalloc WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 basuke basuke basuke commit-queue ggaren msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1589713 0 basuke 2019-11-12 17:11:18 -0800 We were observing that freeableMemory keeped growing. Then we found that the chunk metadataSize was not counted. 1589715 1 383411 basuke 2019-11-12 17:20:18 -0800 Created attachment 383411 PATCH This is first part of the fix of the bug. I couldn't figure out that yet, but at least this must be right fix. 1589718 2 basuke 2019-11-12 17:22:10 -0800 We did an internal research to log out freeable memory and footprint on each scavenge. This issue was found on that process. 1590597 3 383411 ysuzuki 2019-11-15 12:06:43 -0800 Comment on attachment 383411 PATCH I think freeable memory is tracking the size of memory usable for allocation. So I don't think we need to add/sub Chunk's metadata size. Is my understanding correct? 1590666 4 basuke 2019-11-15 14:29:12 -0800 https://github.com/WebKit/webkit/blob/5f3db1e7192810f53c4668f01ecb4e4fdbb3dc18/Source/bmalloc/bmalloc/Heap.cpp#L141-L157 This is the former implementation of feeableMemory. So you are right. Then here is the issue: https://github.com/WebKit/webkit/blob/master/Source/bmalloc/bmalloc/Heap.cpp#L286 When allocating a chunk in allocateSmallChunk(), chunkSize is added to freeableMemory. It should add only sizes of free pages. 1590668 5 ysuzuki 2019-11-15 14:30:01 -0800 (In reply to Basuke Suzuki from comment #4) > https://github.com/WebKit/webkit/blob/ > 5f3db1e7192810f53c4668f01ecb4e4fdbb3dc18/Source/bmalloc/bmalloc/Heap. > cpp#L141-L157 > > This is the former implementation of feeableMemory. So you are right. Then > here is the issue: > > https://github.com/WebKit/webkit/blob/master/Source/bmalloc/bmalloc/Heap. > cpp#L286 > > When allocating a chunk in allocateSmallChunk(), chunkSize is added to > freeableMemory. It should add only sizes of free pages. Right. This looks wrong, nice. 1590779 6 383677 basuke 2019-11-15 17:28:56 -0800 Created attachment 383677 PATCH 1590781 7 383677 ysuzuki 2019-11-15 17:38:20 -0800 Comment on attachment 383677 PATCH r=me 1590794 8 383677 commit-queue 2019-11-15 18:34:39 -0800 Comment on attachment 383677 PATCH Clearing flags on attachment: 383677 Committed r252519: <https://trac.webkit.org/changeset/252519> 1590795 9 commit-queue 2019-11-15 18:34:40 -0800 All reviewed patches have been landed. Closing bug. 1590796 10 webkit-bug-importer 2019-11-15 18:35:16 -0800 <rdar://problem/57247662> 383411 2019-11-12 17:20:18 -0800 2019-11-15 17:28:56 -0800 PATCH bug-204135.diff text/plain 4861 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZyBiL1NvdXJjZS9ibWFsbG9jL0No YW5nZUxvZwppbmRleCBiNjI5MjNlYmM5Ny4uOTlhYThkMGVmNzYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9ibWFsbG9jL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxOS0xMS0xMiAgQmFzdWtlIFN1enVraSAgPGJhc3VrZS5zdXp1a2lAc29u eS5jb20+CisKKyAgICAgICAgW2JtYWxsb2NdIFRoZSB0cmFja2luZyBvZiBmcmVlYWJsZU1lbW9y eSBvZiBIZWFwIGRvZXNuJ3QgY291bnQgQ2h1bmsncyBtZXRhZGF0YSBzaXplLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0MTM1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBwYXJ0IG9uZSBv ZiBmaXhpbmcgdGhlIGNhbGN1cmF0aW9uIG9mIGZyZWVhYmxlTWVtb3J5IGluIEhlYXAuIFRoZSBh bW91bnQgb2YgbWV0YWRhdGEKKyAgICAgICAgc2l6ZSBpcyBub3QgY291bnRlZCB3aGVuIGZpcnN0 IHRpbWUgdGhlIENodW5rIGlzIHVzZWQuIEFsc28gdGhhdCBzaXplIGhhcyB0byBiZSByZXR1cm5l ZCB0bworICAgICAgICBmcmVlYWJsZU1lbW9yeSB3aGVuIGl0IGlzIHJldHVybmVkIHRvIGNodW5r Q2FjaGUuCisKKyAgICAgICAgKiBibWFsbG9jL0NodW5rLmg6CisgICAgICAgIChibWFsbG9jOjpm b3JFYWNoUGFnZSk6CisgICAgICAgIChibWFsbG9jOjpDaHVuazo6bWV0YWRhdGFTaXplKToKKyAg ICAgICAgKiBibWFsbG9jL0hlYXAuY3BwOgorICAgICAgICAoYm1hbGxvYzo6SGVhcDo6YWxsb2Nh dGVTbWFsbFBhZ2UpOgorICAgICAgICAoYm1hbGxvYzo6SGVhcDo6ZGVhbGxvY2F0ZVNtYWxsTGlu ZSk6CisKIDIwMTktMTEtMDcgIEJhc3VrZSBTdXp1a2kgIDxCYXN1a2UuU3V6dWtpQHNvbnkuY29t PiBhbmQgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtibWFs bG9jXSBCdWcgZml4IGZvciB3YWl0IHRpbWUgd2hlbiBpdCdzIGluIG1pbmkgbW9kZS4KZGlmZiAt LWdpdCBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQ2h1bmsuaCBiL1NvdXJjZS9ibWFsbG9jL2Jt YWxsb2MvQ2h1bmsuaAppbmRleCAzMWRiNmYyZDdiZi4uNTQ5YWY3ZWYyNDYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQ2h1bmsuaAorKysgYi9Tb3VyY2UvYm1hbGxvYy9ibWFs bG9jL0NodW5rLmgKQEAgLTM4LDYgKzM4LDcgQEAgbmFtZXNwYWNlIGJtYWxsb2MgewogY2xhc3Mg Q2h1bmsgOiBwdWJsaWMgTGlzdE5vZGU8Q2h1bms+IHsKIHB1YmxpYzoKICAgICBzdGF0aWMgQ2h1 bmsqIGdldCh2b2lkKik7CisgICAgc3RhdGljIHNpemVfdCBtZXRhZGF0YVNpemUoc2l6ZV90IHBh Z2VTaXplKTsKIAogICAgIENodW5rKHNpemVfdCBwYWdlU2l6ZSk7CiAgICAgCkBAIC03NSwxMSAr NzYsNyBAQCBzdHJ1Y3QgQ2h1bmtIYXNoIHsKIAogdGVtcGxhdGU8dHlwZW5hbWUgRnVuY3Rpb24+ IHZvaWQgZm9yRWFjaFBhZ2UoQ2h1bmsqIGNodW5rLCBzaXplX3QgcGFnZVNpemUsIEZ1bmN0aW9u IGZ1bmN0aW9uKQogewotICAgIC8vIFdlIGFsaWduIHRvIGF0IGxlYXN0IHRoZSBwYWdlIHNpemUg c28gd2UgY2FuIHNlcnZpY2UgYWxpZ25lZCBhbGxvY2F0aW9ucwotICAgIC8vIGF0IGVxdWFsIGFu ZCBzbWFsbGVyIHBvd2VycyBvZiB0d28sIGFuZCBhbHNvIHNvIHdlIGNhbiB2bURlYWxsb2NhdGVQ aHlzaWNhbFBhZ2VzKCkuCi0gICAgc2l6ZV90IG1ldGFkYXRhU2l6ZSA9IHJvdW5kVXBUb011bHRp cGxlT2ZOb25Qb3dlck9mVHdvKHBhZ2VTaXplLCBzaXplb2YoQ2h1bmspKTsKLQotICAgIE9iamVj dCBiZWdpbihjaHVuaywgbWV0YWRhdGFTaXplKTsKKyAgICBPYmplY3QgYmVnaW4oY2h1bmssIENo dW5rOjptZXRhZGF0YVNpemUocGFnZVNpemUpKTsKICAgICBPYmplY3QgZW5kKGNodW5rLCBjaHVu a1NpemUpOwogCiAgICAgZm9yIChhdXRvIGl0ID0gYmVnaW47IGl0ICsgcGFnZVNpemUgPD0gZW5k OyBpdCA9IGl0ICsgcGFnZVNpemUpCkBAIC0xMDAsNiArOTcsMTMgQEAgaW5saW5lIENodW5rKiBD aHVuazo6Z2V0KHZvaWQqIGFkZHJlc3MpCiAgICAgcmV0dXJuIHN0YXRpY19jYXN0PENodW5rKj4o bWFzayhhZGRyZXNzLCBjaHVua01hc2spKTsKIH0KIAoraW5saW5lIHNpemVfdCBDaHVuazo6bWV0 YWRhdGFTaXplKHNpemVfdCBwYWdlU2l6ZSkKK3sKKyAgICAvLyBXZSBhbGlnbiB0byBhdCBsZWFz dCB0aGUgcGFnZSBzaXplIHNvIHdlIGNhbiBzZXJ2aWNlIGFsaWduZWQgYWxsb2NhdGlvbnMKKyAg ICAvLyBhdCBlcXVhbCBhbmQgc21hbGxlciBwb3dlcnMgb2YgdHdvLCBhbmQgYWxzbyBzbyB3ZSBj YW4gdm1EZWFsbG9jYXRlUGh5c2ljYWxQYWdlcygpLgorICAgIHJldHVybiByb3VuZFVwVG9NdWx0 aXBsZU9mTm9uUG93ZXJPZlR3byhwYWdlU2l6ZSwgc2l6ZW9mKENodW5rKSk7Cit9CisKIGlubGlu ZSBzaXplX3QgQ2h1bms6Om9mZnNldCh2b2lkKiBhZGRyZXNzKQogewogICAgIEJBU1NFUlQoYWRk cmVzcyA+PSB0aGlzKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvSGVhcC5j cHAgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0hlYXAuY3BwCmluZGV4IDdiODJiMjdhMjRhLi40 MWViNmJjYWU4OSAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9IZWFwLmNwcAor KysgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0hlYXAuY3BwCkBAIC0zMzQsNiArMzM0LDcgQEAg U21hbGxQYWdlKiBIZWFwOjphbGxvY2F0ZVNtYWxsUGFnZShzdGQ6OnVuaXF1ZV9sb2NrPE11dGV4 PiYgbG9jaywgc2l6ZV90IHNpemVDbGEKICAgICAKICAgICBTbWFsbFBhZ2UqIHBhZ2UgPSBbJl0o KSAtPiBTbWFsbFBhZ2UqIHsKICAgICAgICAgc2l6ZV90IHBhZ2VDbGFzcyA9IG1fcGFnZUNsYXNz ZXNbc2l6ZUNsYXNzXTsKKyAgICAgICAgc2l6ZV90IHBhZ2VTaXplID0gYm1hbGxvYzo6cGFnZVNp emUocGFnZUNsYXNzKTsKICAgICAgICAgCiAgICAgICAgIGlmIChtX2ZyZWVQYWdlc1twYWdlQ2xh c3NdLmlzRW1wdHkoKSkKICAgICAgICAgICAgIGFsbG9jYXRlU21hbGxDaHVuayhsb2NrLCBwYWdl Q2xhc3MsIGFjdGlvbik7CkBAIC0zNDIsMTMgKzM0MywxNCBAQCBTbWFsbFBhZ2UqIEhlYXA6OmFs bG9jYXRlU21hbGxQYWdlKHN0ZDo6dW5pcXVlX2xvY2s8TXV0ZXg+JiBsb2NrLCBzaXplX3Qgc2l6 ZUNsYQogCiAgICAgICAgIENodW5rKiBjaHVuayA9IG1fZnJlZVBhZ2VzW3BhZ2VDbGFzc10udGFp bCgpOwogCisgICAgICAgIGlmICghY2h1bmstPnJlZkNvdW50KCkpCisgICAgICAgICAgICBtX2Zy ZWVhYmxlTWVtb3J5IC09IENodW5rOjptZXRhZGF0YVNpemUocGFnZVNpemUpOwogICAgICAgICBj aHVuay0+cmVmKCk7CiAKICAgICAgICAgU21hbGxQYWdlKiBwYWdlID0gY2h1bmstPmZyZWVQYWdl cygpLnBvcCgpOwogICAgICAgICBpZiAoY2h1bmstPmZyZWVQYWdlcygpLmlzRW1wdHkoKSkKICAg ICAgICAgICAgIG1fZnJlZVBhZ2VzW3BhZ2VDbGFzc10ucmVtb3ZlKGNodW5rKTsKIAotICAgICAg ICBzaXplX3QgcGFnZVNpemUgPSBibWFsbG9jOjpwYWdlU2l6ZShwYWdlQ2xhc3MpOwogICAgICAg ICBzaXplX3QgcGh5c2ljYWxTaXplID0gcGh5c2ljYWxQYWdlU2l6ZVNsb3BweShwYWdlLT5iZWdp bigpLT5iZWdpbigpLCBwYWdlU2l6ZSk7CiAgICAgICAgIGlmIChwYWdlLT5oYXNQaHlzaWNhbFBh Z2VzKCkpCiAgICAgICAgICAgICBtX2ZyZWVhYmxlTWVtb3J5IC09IHBoeXNpY2FsU2l6ZTsKQEAg LTM5Miw4ICszOTQsMTAgQEAgdm9pZCBIZWFwOjpkZWFsbG9jYXRlU21hbGxMaW5lKHN0ZDo6dW5p cXVlX2xvY2s8TXV0ZXg+JiBsb2NrLCBPYmplY3Qgb2JqZWN0LCBMaW4KIAogICAgIHNpemVfdCBz aXplQ2xhc3MgPSBwYWdlLT5zaXplQ2xhc3MoKTsKICAgICBzaXplX3QgcGFnZUNsYXNzID0gbV9w YWdlQ2xhc3Nlc1tzaXplQ2xhc3NdOworICAgIHNpemVfdCBwYWdlU2l6ZSA9IGJtYWxsb2M6OnBh Z2VTaXplKHBhZ2VDbGFzcyk7CisgICAgc2l6ZV90IG9yaWdpbmFsRnJlZWFibGVtZW1vcnkgPSBt X2ZyZWVhYmxlTWVtb3J5OwogCi0gICAgbV9mcmVlYWJsZU1lbW9yeSArPSBwaHlzaWNhbFBhZ2VT aXplU2xvcHB5KHBhZ2UtPmJlZ2luKCktPmJlZ2luKCksIHBhZ2VTaXplKHBhZ2VDbGFzcykpOwor ICAgIG1fZnJlZWFibGVNZW1vcnkgKz0gcGh5c2ljYWxQYWdlU2l6ZVNsb3BweShwYWdlLT5iZWdp bigpLT5iZWdpbigpLCBwYWdlU2l6ZSk7CiAKICAgICBMaXN0PFNtYWxsUGFnZT46OnJlbW92ZShw YWdlKTsgLy8gJ3BhZ2UnIG1heSBiZSBpbiBhbnkgdGhyZWFkJ3MgbGluZSBjYWNoZS4KICAgICAK QEAgLTQxMSw5ICs0MTUsMTAgQEAgdm9pZCBIZWFwOjpkZWFsbG9jYXRlU21hbGxMaW5lKHN0ZDo6 dW5pcXVlX2xvY2s8TXV0ZXg+JiBsb2NrLCBPYmplY3Qgb2JqZWN0LCBMaW4KICAgICAgICAgICAg IGRlYWxsb2NhdGVTbWFsbENodW5rKG1fY2h1bmtDYWNoZVtwYWdlQ2xhc3NdLnBvcCgpLCBwYWdl Q2xhc3MpOwogCiAgICAgICAgIG1fY2h1bmtDYWNoZVtwYWdlQ2xhc3NdLnB1c2goY2h1bmspOwor ICAgICAgICBtX2ZyZWVhYmxlTWVtb3J5ICs9IENodW5rOjptZXRhZGF0YVNpemUocGFnZVNpemUp OwogICAgIH0KICAgICAKLSAgICBtX3NjYXZlbmdlci0+c2NoZWR1bGUocGFnZVNpemUocGFnZUNs YXNzKSk7CisgICAgbV9zY2F2ZW5nZXItPnNjaGVkdWxlKG1fZnJlZWFibGVNZW1vcnkgLSBvcmln aW5hbEZyZWVhYmxlbWVtb3J5KTsKIH0KIAogdm9pZCBIZWFwOjphbGxvY2F0ZVNtYWxsQnVtcFJh bmdlc0J5TWV0YWRhdGEoCg== 383677 2019-11-15 17:28:56 -0800 2019-11-15 18:34:39 -0800 PATCH bug-204135.diff text/plain 1752 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZyBiL1NvdXJjZS9ibWFsbG9jL0No YW5nZUxvZwppbmRleCBiNjI5MjNlYmM5Ny4uY2MxNDhlZTRiZTEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9ibWFsbG9jL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0xMS0xNSAgQmFzdWtlIFN1enVraSAgPGJhc3VrZS5zdXp1a2lAc29u eS5jb20+CisKKyAgICAgICAgW2JtYWxsb2NdIFRoZSB0cmFja2luZyBvZiBmcmVlYWJsZU1lbW9y eSBvZiBIZWFwIGRvZXNuJ3QgY291bnQgQ2h1bmsncyBtZXRhZGF0YSBzaXplLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0MTM1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBjaHVuayBpcyBhbGxv Y2F0ZWQgaW4gYWxsb2NhdGVTbWFsbENodW5rKCksIGFsbCBjaHVuayBzaXplIGlzIGFkZGVkIHRv IGZyZWVhYmxlTWVtb3J5LgorICAgICAgICBUaGlzIGlzIHdyb25nLiBPbmx5IGZyZWUgcGFnZXMg c2hvdWxkIGJlIGFkZGVkIHRvIGl0LgorCisgICAgICAgICogYm1hbGxvYy9IZWFwLmNwcDoKKyAg ICAgICAgKGJtYWxsb2M6OkhlYXA6OmFsbG9jYXRlU21hbGxDaHVuayk6CisKIDIwMTktMTEtMDcg IEJhc3VrZSBTdXp1a2kgIDxCYXN1a2UuU3V6dWtpQHNvbnkuY29tPiBhbmQgWXVzdWtlIFN1enVr aSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtibWFsbG9jXSBCdWcgZml4IGZvciB3 YWl0IHRpbWUgd2hlbiBpdCdzIGluIG1pbmkgbW9kZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9ibWFs bG9jL2JtYWxsb2MvSGVhcC5jcHAgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0hlYXAuY3BwCmlu ZGV4IDdiODJiMjdhMjRhLi4zMTkyMzliZDYwZCAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2Mv Ym1hbGxvYy9IZWFwLmNwcAorKysgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0hlYXAuY3BwCkBA IC0yNzQsNiArMjc0LDcgQEAgdm9pZCBIZWFwOjphbGxvY2F0ZVNtYWxsQ2h1bmsoc3RkOjp1bmlx dWVfbG9jazxNdXRleD4mIGxvY2ssIHNpemVfdCBwYWdlQ2xhc3MsIEYKIAogICAgICAgICBtX29i amVjdFR5cGVzLnNldChjaHVuaywgT2JqZWN0VHlwZTo6U21hbGwpOwogCisgICAgICAgIHNpemVf dCBhY2NvdW50ZWRJbkZyZWVhYmxlID0gMDsKICAgICAgICAgZm9yRWFjaFBhZ2UoY2h1bmssIHBh Z2VTaXplLCBbJl0oU21hbGxQYWdlKiBwYWdlKSB7CiAgICAgICAgICAgICBwYWdlLT5zZXRIYXNQ aHlzaWNhbFBhZ2VzKHRydWUpOwogI2lmICFCUExBVEZPUk0oTUFDKQpAQCAtMjgxLDkgKzI4Miwx MCBAQCB2b2lkIEhlYXA6OmFsbG9jYXRlU21hbGxDaHVuayhzdGQ6OnVuaXF1ZV9sb2NrPE11dGV4 PiYgbG9jaywgc2l6ZV90IHBhZ2VDbGFzcywgRgogI2VuZGlmCiAgICAgICAgICAgICBwYWdlLT5z ZXRIYXNGcmVlTGluZXMobG9jaywgdHJ1ZSk7CiAgICAgICAgICAgICBjaHVuay0+ZnJlZVBhZ2Vz KCkucHVzaChwYWdlKTsKKyAgICAgICAgICAgIGFjY291bnRlZEluRnJlZWFibGUgKz0gcGFnZVNp emU7CiAgICAgICAgIH0pOwogCi0gICAgICAgIG1fZnJlZWFibGVNZW1vcnkgKz0gY2h1bmtTaXpl OworICAgICAgICBtX2ZyZWVhYmxlTWVtb3J5ICs9IGFjY291bnRlZEluRnJlZWFibGU7CiAgICAg ICAgIAogICAgICAgICBtX3NjYXZlbmdlci0+c2NoZWR1bGUoMCk7CiAK