204123 2019-11-12 12:36:48 -0800 Update unit-tests for JSC EWS 2019-11-12 15:05:59 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=201997 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain jbedard webkit-bug-importer oldest_to_newest 1589598 0 aakash_jain 2019-11-12 12:36:48 -0800 After we updated platform from 'jsc-only' to 'mac-highsierra' for jsc queues in https://trac.webkit.org/changeset/250102/webkit, we need to update the unit-tests to correctly cover both 'mac-highsierra' and 'jsc-only' platforms. 1589600 1 383371 aakash_jain 2019-11-12 12:51:53 -0800 Created attachment 383371 Patch 1589608 2 383371 jbedard 2019-11-12 13:26:40 -0800 Comment on attachment 383371 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383371&action=review > Tools/BuildSlaveSupport/ews-build/steps_unittest.py:-1075 > - self.expectRemoteCommands( Why are we removing this? 1589613 3 383371 aakash_jain 2019-11-12 13:34:13 -0800 Comment on attachment 383371 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383371&action=review >> Tools/BuildSlaveSupport/ews-build/steps_unittest.py:-1075 >> - self.expectRemoteCommands( > > Why are we removing this? We are removing this class and newer version of this class now sub-classes from TestRunJavaScriptCoreTests. So it automatically runs all the unit-tests run by TestRunJavaScriptCoreTests. That way we won't have to duplicate all the unit-test from TestRunJavaScriptCoreTests into TestReRunJavaScriptCoreTests. Similar to TestRunWebKitTestsWithoutPatch at https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py#L1307 1589650 4 aakash_jain 2019-11-12 15:04:39 -0800 Committed r252375: <https://trac.webkit.org/changeset/252375> 1589651 5 webkit-bug-importer 2019-11-12 15:05:59 -0800 <rdar://problem/57132571> 383371 2019-11-12 12:51:53 -0800 2019-11-12 14:53:46 -0800 Patch bug-204123-20191112155151.patch text/plain 6140 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MjM3MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE5LTExLTEyICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBVcGRhdGUgdW5pdC10ZXN0cyBmb3IgSlNDIEVXUworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0MTIzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9l d3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHk6CisgICAgICAgIChUZXN0UnVuSmF2YVNjcmlwdENv cmVUZXN0cy5jb25maWd1cmVTdGVwKToKKyAgICAgICAgKFRlc3RSdW5KYXZhU2NyaXB0Q29yZVRl c3RzLnRlc3Rfc3VjY2Vzcyk6IFVwZGF0ZWQgcGxhdGZvcm0gdG8gbWFjLWhpZ2hzaWVycmEuCisg ICAgICAgIChUZXN0UnVuSmF2YVNjcmlwdENvcmVUZXN0cy50ZXN0X2ZhaWx1cmUpOiBEaXR0by4K KyAgICAgICAgKFRlc3RSdW5KYXZhU2NyaXB0Q29yZVRlc3RzLnRlc3RfcmVtb3RlX3N1Y2Nlc3Mp OiBVbml0LXRlc3QgZm9yIGpzYy1vbmx5IHBsYXRmb3JtLgorICAgICAgICAoVGVzdFJlUnVuSmF2 YVNjcmlwdENvcmVUZXN0cyk6IEF1dG9tYXRpY2FsbHkgcnVuIGFsbCB1bml0LXRlc3RzIGZyb20g VGVzdFJ1bkphdmFTY3JpcHRDb3JlVGVzdHMgY2xhc3MuCisKIDIwMTktMTEtMTIgIERpZWdvIFBp bm8gR2FyY2lhICA8ZHBpbm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBBZGQgJ3Rlc3Qy NjItdGVzdCcgc3RlcCB0byBHVEsgYW5kIFdQRSBidWlsZCBib3RzCkluZGV4OiBUb29scy9CdWls ZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CShyZXZp c2lvbiAyNTIzNzMpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNf dW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTk5NiwxMCArOTk2LDE3IEBAIGNsYXNzIFRl c3RSdW5KYXZhU2NyaXB0Q29yZVRlc3RzKEJ1aWxkU3QKICAgICBkZWYgdGVhckRvd24oc2VsZik6 CiAgICAgICAgIHJldHVybiBzZWxmLnRlYXJEb3duQnVpbGRTdGVwKCkKIAotICAgIGRlZiB0ZXN0 X3N1Y2Nlc3Moc2VsZik6CisgICAgZGVmIGNvbmZpZ3VyZVN0ZXAoc2VsZiwgcGxhdGZvcm09Tm9u ZSwgZnVsbFBsYXRmb3JtPU5vbmUsIGNvbmZpZ3VyYXRpb249Tm9uZSk6CiAgICAgICAgIHNlbGYu c2V0dXBTdGVwKFJ1bkphdmFTY3JpcHRDb3JlVGVzdHMoKSkKLSAgICAgICAgc2VsZi5zZXRQcm9w ZXJ0eSgnZnVsbFBsYXRmb3JtJywgJ2pzYy1vbmx5JykKLSAgICAgICAgc2VsZi5zZXRQcm9wZXJ0 eSgnY29uZmlndXJhdGlvbicsICdyZWxlYXNlJykKKyAgICAgICAgaWYgcGxhdGZvcm06CisgICAg ICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdwbGF0Zm9ybScsIHBsYXRmb3JtKQorICAgICAgICBp ZiBmdWxsUGxhdGZvcm06CisgICAgICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdmdWxsUGxhdGZv cm0nLCBmdWxsUGxhdGZvcm0pCisgICAgICAgIGlmIGNvbmZpZ3VyYXRpb246CisgICAgICAgICAg ICBzZWxmLnNldFByb3BlcnR5KCdjb25maWd1cmF0aW9uJywgY29uZmlndXJhdGlvbikKKworICAg IGRlZiB0ZXN0X3N1Y2Nlc3Moc2VsZik6CisgICAgICAgIHNlbGYuY29uZmlndXJlU3RlcChwbGF0 Zm9ybT0nbWFjJywgZnVsbFBsYXRmb3JtPSdtYWMtaGlnaHNpZXJyYScsIGNvbmZpZ3VyYXRpb249 J3JlbGVhc2UnKQogICAgICAgICBzZWxmLmV4cGVjdFJlbW90ZUNvbW1hbmRzKAogICAgICAgICAg ICAgRXhwZWN0U2hlbGwod29ya2Rpcj0nd2tkaXInLAogICAgICAgICAgICAgICAgICAgICAgICAg bG9nRW52aXJvbj1GYWxzZSwKQEAgLTEwMTIsMTQgKzEwMTksMTIgQEAgY2xhc3MgVGVzdFJ1bkph dmFTY3JpcHRDb3JlVGVzdHMoQnVpbGRTdAogICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkK IAogICAgIGRlZiB0ZXN0X3JlbW90ZV9zdWNjZXNzKHNlbGYpOgotICAgICAgICBzZWxmLnNldHVw U3RlcChSdW5KYXZhU2NyaXB0Q29yZVRlc3RzKCkpCi0gICAgICAgIHNlbGYuc2V0UHJvcGVydHko J2Z1bGxQbGF0Zm9ybScsICdqc2Mtb25seScpCi0gICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2Nv bmZpZ3VyYXRpb24nLCAncmVsZWFzZScpCisgICAgICAgIHNlbGYuY29uZmlndXJlU3RlcChwbGF0 Zm9ybT0nanNjLW9ubHknLCBmdWxsUGxhdGZvcm09J2pzYy1vbmx5JywgY29uZmlndXJhdGlvbj0n cmVsZWFzZScpCiAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ3JlbW90ZXMnLCAncmVtb3RlLW1h Y2hpbmVzLmpzb24nKQogICAgICAgICBzZWxmLmV4cGVjdFJlbW90ZUNvbW1hbmRzKAogICAgICAg ICAgICAgRXhwZWN0U2hlbGwod29ya2Rpcj0nd2tkaXInLAogICAgICAgICAgICAgICAgICAgICAg ICAgbG9nRW52aXJvbj1GYWxzZSwKLSAgICAgICAgICAgICAgICAgICAgICAgIGNvbW1hbmQ9Wydw ZXJsJywgJ1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzJywgJy0tbm8tYnVp bGQnLCAnLS1uby1mYWlsLWZhc3QnLCAnLS1qc29uLW91dHB1dD17MH0nLmZvcm1hdChzZWxmLmpz b25GaWxlTmFtZSksICctLXJlbGVhc2UnLCAnLS1yZW1vdGUtY29uZmlnLWZpbGU9cmVtb3RlLW1h Y2hpbmVzLmpzb24nXSwKKyAgICAgICAgICAgICAgICAgICAgICAgIGNvbW1hbmQ9WydwZXJsJywg J1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzJywgJy0tbm8tYnVpbGQnLCAn LS1uby1mYWlsLWZhc3QnLCAnLS1qc29uLW91dHB1dD17MH0nLmZvcm1hdChzZWxmLmpzb25GaWxl TmFtZSksICctLXJlbGVhc2UnLCAnLS1yZW1vdGUtY29uZmlnLWZpbGU9cmVtb3RlLW1hY2hpbmVz Lmpzb24nLCAnLS1qc2Mtb25seSddLAogICAgICAgICAgICAgICAgICAgICAgICAgbG9nZmlsZXM9 eydqc29uJzogc2VsZi5qc29uRmlsZU5hbWV9LAogICAgICAgICAgICAgICAgICAgICAgICAgKQog ICAgICAgICAgICAgKyAwLApAQCAtMTAyOCw5ICsxMDMzLDcgQEAgY2xhc3MgVGVzdFJ1bkphdmFT Y3JpcHRDb3JlVGVzdHMoQnVpbGRTdAogICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKIAog ICAgIGRlZiB0ZXN0X2ZhaWx1cmUoc2VsZik6Ci0gICAgICAgIHNlbGYuc2V0dXBTdGVwKFJ1bkph dmFTY3JpcHRDb3JlVGVzdHMoKSkKLSAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnZnVsbFBsYXRm b3JtJywgJ2pzYy1vbmx5JykKLSAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnY29uZmlndXJhdGlv bicsICdkZWJ1ZycpCisgICAgICAgIHNlbGYuY29uZmlndXJlU3RlcChwbGF0Zm9ybT0nbWFjJywg ZnVsbFBsYXRmb3JtPSdtYWMtaGlnaHNpZXJyYScsIGNvbmZpZ3VyYXRpb249J2RlYnVnJykKICAg ICAgICAgc2VsZi5leHBlY3RSZW1vdGVDb21tYW5kcygKICAgICAgICAgICAgIEV4cGVjdFNoZWxs KHdvcmtkaXI9J3drZGlyJywKICAgICAgICAgICAgICAgICAgICAgICAgIGxvZ0Vudmlyb249RmFs c2UsCkBAIC0xMDQ0LDQ1ICsxMDQ3LDE1IEBAIGNsYXNzIFRlc3RSdW5KYXZhU2NyaXB0Q29yZVRl c3RzKEJ1aWxkU3QKICAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCiAKIAotY2xhc3MgVGVz dFJlUnVuSmF2YVNjcmlwdENvcmVUZXN0cyhCdWlsZFN0ZXBNaXhpbkFkZGl0aW9ucywgdW5pdHRl c3QuVGVzdENhc2UpOgotICAgIGRlZiBzZXRVcChzZWxmKToKLSAgICAgICAgc2VsZi5sb25nTWVz c2FnZSA9IFRydWUKLSAgICAgICAgc2VsZi5qc29uRmlsZU5hbWUgPSAnanNjX3Jlc3VsdHMuanNv bicKLSAgICAgICAgcmV0dXJuIHNlbGYuc2V0VXBCdWlsZFN0ZXAoKQotCi0gICAgZGVmIHRlYXJE b3duKHNlbGYpOgotICAgICAgICByZXR1cm4gc2VsZi50ZWFyRG93bkJ1aWxkU3RlcCgpCi0KLSAg ICBkZWYgdGVzdF9zdWNjZXNzKHNlbGYpOgotICAgICAgICBzZWxmLnNldHVwU3RlcChSZVJ1bkph dmFTY3JpcHRDb3JlVGVzdHMoKSkKLSAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnZnVsbFBsYXRm b3JtJywgJ2pzYy1vbmx5JykKLSAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnY29uZmlndXJhdGlv bicsICdyZWxlYXNlJykKLSAgICAgICAgc2VsZi5leHBlY3RSZW1vdGVDb21tYW5kcygKLSAgICAg ICAgICAgIEV4cGVjdFNoZWxsKHdvcmtkaXI9J3drZGlyJywKLSAgICAgICAgICAgICAgICAgICAg ICAgIGxvZ0Vudmlyb249RmFsc2UsCi0gICAgICAgICAgICAgICAgICAgICAgICBjb21tYW5kPVsn cGVybCcsICdUb29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cycsICctLW5vLWJ1 aWxkJywgJy0tbm8tZmFpbC1mYXN0JywgJy0tanNvbi1vdXRwdXQ9ezB9Jy5mb3JtYXQoc2VsZi5q c29uRmlsZU5hbWUpLCAnLS1yZWxlYXNlJ10sCi0gICAgICAgICAgICAgICAgICAgICAgICBsb2dm aWxlcz17J2pzb24nOiBzZWxmLmpzb25GaWxlTmFtZX0sCi0gICAgICAgICAgICAgICAgICAgICAg ICApCi0gICAgICAgICAgICArIDAsCi0gICAgICAgICkKLSAgICAgICAgc2VsZi5leHBlY3RPdXRj b21lKHJlc3VsdD1TVUNDRVNTLCBzdGF0ZV9zdHJpbmc9J1Bhc3NlZCBKU0MgdGVzdHMnKQotICAg ICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKLQotICAgIGRlZiB0ZXN0X2ZhaWx1cmUoc2VsZik6 CitjbGFzcyBUZXN0UmVSdW5KYXZhU2NyaXB0Q29yZVRlc3RzKFRlc3RSdW5KYXZhU2NyaXB0Q29y ZVRlc3RzKToKKyAgICBkZWYgY29uZmlndXJlU3RlcChzZWxmLCBwbGF0Zm9ybT1Ob25lLCBmdWxs UGxhdGZvcm09Tm9uZSwgY29uZmlndXJhdGlvbj1Ob25lKToKICAgICAgICAgc2VsZi5zZXR1cFN0 ZXAoUmVSdW5KYXZhU2NyaXB0Q29yZVRlc3RzKCkpCi0gICAgICAgIHNlbGYuc2V0UHJvcGVydHko J2Z1bGxQbGF0Zm9ybScsICdqc2Mtb25seScpCi0gICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2Nv bmZpZ3VyYXRpb24nLCAnZGVidWcnKQotICAgICAgICBzZWxmLmV4cGVjdFJlbW90ZUNvbW1hbmRz KAotICAgICAgICAgICAgRXhwZWN0U2hlbGwod29ya2Rpcj0nd2tkaXInLAotICAgICAgICAgICAg ICAgICAgICAgICAgbG9nRW52aXJvbj1GYWxzZSwKLSAgICAgICAgICAgICAgICAgICAgICAgIGNv bW1hbmQ9WydwZXJsJywgJ1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzJywg Jy0tbm8tYnVpbGQnLCAnLS1uby1mYWlsLWZhc3QnLCAnLS1qc29uLW91dHB1dD17MH0nLmZvcm1h dChzZWxmLmpzb25GaWxlTmFtZSksICctLWRlYnVnJ10sCi0gICAgICAgICAgICAgICAgICAgICAg ICBsb2dmaWxlcz17J2pzb24nOiBzZWxmLmpzb25GaWxlTmFtZX0sCi0gICAgICAgICAgICAgICAg ICAgICAgICApCi0gICAgICAgICAgICArIEV4cGVjdFNoZWxsLmxvZygnc3RkaW8nLCBzdGRvdXQ9 JzkgZmFpbHVyZXMgZm91bmQuJykKLSAgICAgICAgICAgICsgMiwKLSAgICAgICAgKQotICAgICAg ICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PUZBSUxVUkUsIHN0YXRlX3N0cmluZz0nanNjb3Jl LXRlc3RzIChmYWlsdXJlKScpCi0gICAgICAgIHJldHVybiBzZWxmLnJ1blN0ZXAoKQorICAgICAg ICBpZiBwbGF0Zm9ybToKKyAgICAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ3BsYXRmb3JtJywg cGxhdGZvcm0pCisgICAgICAgIGlmIGZ1bGxQbGF0Zm9ybToKKyAgICAgICAgICAgIHNlbGYuc2V0 UHJvcGVydHkoJ2Z1bGxQbGF0Zm9ybScsIGZ1bGxQbGF0Zm9ybSkKKyAgICAgICAgaWYgY29uZmln dXJhdGlvbjoKKyAgICAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2NvbmZpZ3VyYXRpb24nLCBj b25maWd1cmF0aW9uKQogCiAKIGNsYXNzIFRlc3RSdW5KU0NUZXN0c1dpdGhvdXRQYXRjaChCdWls ZFN0ZXBNaXhpbkFkZGl0aW9ucywgdW5pdHRlc3QuVGVzdENhc2UpOgo=