204122 2019-11-12 12:02:12 -0800 Use toLength() and getIndexQuickly() in JSON.stringify 2019-11-14 14:01:25 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=203227 InRadar P2 Enhancement --- 1 ashvayka webkit-unassigned commit-queue ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1589591 0 ashvayka 2019-11-12 12:02:12 -0800 Use toLength() and getIndexQuickly() in JSON.stringify 1589595 1 383370 ashvayka 2019-11-12 12:23:56 -0800 Created attachment 383370 Patch 1589599 2 ashvayka 2019-11-12 12:51:11 -0800 Style EWS fails because of RETURN_IF_EXCEPTION(scope, ); // <= that space, which is a common pattern. Cold runs, only results with low measurement error, --outer 8: rev. 252354 patch json-stringify-array-replacer 350.7169+-0.9911 263.3854+-2.2296 json-stringify-empty-array 188.0573+-1.2934 189.5053+-1.4060 1590315 3 383370 ysuzuki 2019-11-14 13:15:39 -0800 Comment on attachment 383370 Patch Nice, r=me 1590323 4 383370 commit-queue 2019-11-14 14:00:06 -0800 Comment on attachment 383370 Patch Clearing flags on attachment: 383370 Committed r252464: <https://trac.webkit.org/changeset/252464> 1590324 5 commit-queue 2019-11-14 14:00:08 -0800 All reviewed patches have been landed. Closing bug. 1590327 6 webkit-bug-importer 2019-11-14 14:01:25 -0800 <rdar://problem/57203266> 383370 2019-11-12 12:23:56 -0800 2019-11-14 14:00:06 -0800 Patch bug-204122-20191112222355.patch text/plain 5255 ashvayka SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTIzNzMpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE5LTExLTEyICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNo QGdtYWlsLmNvbT4KKworICAgICAgICBVc2UgdG9MZW5ndGgoKSBhbmQgZ2V0SW5kZXhRdWlja2x5 KCkgaW4gSlNPTi5zdHJpbmdpZnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIwNDEyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogbWljcm9iZW5jaG1hcmtzL2pzb24tc3RyaW5naWZ5LWFycmF5LXJlcGxh Y2VyLmpzOiBBZGRlZC4KKyAgICAgICAgKiBtaWNyb2JlbmNobWFya3MvanNvbi1zdHJpbmdpZnkt ZW1wdHktYXJyYXkuanM6IEFkZGVkLgorCiAyMDE5LTExLTExICBSb3NzIEtpcnNsaW5nICA8cm9z cy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBVVEMgb2Zmc2V0IGZvciBTYW1vYSBpcyBt aXNjYWxjdWxhdGVkIHdoZW4gIUhBVkUoVElNRUdNKQpJbmRleDogSlNUZXN0cy9taWNyb2JlbmNo bWFya3MvanNvbi1zdHJpbmdpZnktYXJyYXktcmVwbGFjZXIuanMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNU ZXN0cy9taWNyb2JlbmNobWFya3MvanNvbi1zdHJpbmdpZnktYXJyYXktcmVwbGFjZXIuanMJKG5v bmV4aXN0ZW50KQorKysgSlNUZXN0cy9taWNyb2JlbmNobWFya3MvanNvbi1zdHJpbmdpZnktYXJy YXktcmVwbGFjZXIuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwzIEBACitjb25zdCByZXBs YWNlciA9IG5ldyBBcnJheSgxNSkuZmlsbCgna2V5Jyk7Citmb3IgKGxldCBpID0gMDsgaSA8IDFl NjsgKytpKQorICAgIEpTT04uc3RyaW5naWZ5KG51bGwsIHJlcGxhY2VyKTsKSW5kZXg6IEpTVGVz dHMvbWljcm9iZW5jaG1hcmtzL2pzb24tc3RyaW5naWZ5LWVtcHR5LWFycmF5LmpzCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIEpTVGVzdHMvbWljcm9iZW5jaG1hcmtzL2pzb24tc3RyaW5naWZ5LWVtcHR5LWFycmF5 LmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvbWljcm9iZW5jaG1hcmtzL2pzb24tc3RyaW5n aWZ5LWVtcHR5LWFycmF5LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMyBAQAorY29uc3Qg YXJyID0gW107Citmb3IgKGxldCBpID0gMDsgaSA8IDFlNjsgKytpKQorICAgIEpTT04uc3RyaW5n aWZ5KGFycik7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1MjM3MykK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEs MyArMSwxOCBAQAorMjAxOS0xMS0xMiAgQWxleGV5IFNodmF5a2EgIDxzaHZhaWthbGVzaEBnbWFp bC5jb20+CisKKyAgICAgICAgVXNlIHRvTGVuZ3RoKCkgYW5kIGdldEluZGV4UXVpY2tseSgpIGlu IEpTT04uc3RyaW5naWZ5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDQxMjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBVc2luZyB0b0xlbmd0aCgpIGlzIHNlbWFudGljYWxseSBlcXVpdmFsZW50IGFuZCBw ZXJmb3JtYW5jZS1uZXV0cmFsLCB3aGlsZSBhZGRpbmcKKyAgICAgICAgSlNPYmplY3Q6OmdldElu ZGV4UXVpY2tseSgpIGFkdmFuY2VzIG1pY3JvYmVuY2htYXJrcy9qc29uLXN0cmluZ2lmeS1hcnJh eS1yZXBsYWNlci5qcworICAgICAgICBieSAzNCUuCisKKyAgICAgICAgKiBydW50aW1lL0pTT05P YmplY3QuY3BwOgorICAgICAgICAoSlNDOjpTdHJpbmdpZmllcjo6U3RyaW5naWZpZXIpOgorICAg ICAgICAoSlNDOjpTdHJpbmdpZmllcjo6SG9sZGVyOjphcHBlbmROZXh0UHJvcGVydHkpOgorCiAy MDE5LTExLTExICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgZml4IGluY29ycmVjdCBhc3NlcnRpb24KSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0pTT05PYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0pTT05PYmplY3QuY3BwCShyZXZpc2lvbiAyNTIzNTQpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09OT2JqZWN0LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMjM3LDEzICsyMzcsMTYgQEAgU3RyaW5naWZpZXI6OlN0cmluZ2lmaWVyKEpTR2xvYmFs T2JqZWN0KgogICAgICAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgKTsKICAgICAg ICAgICAgIGlmIChpc0FycmF5UmVwbGFjZXIpIHsKICAgICAgICAgICAgICAgICBtX3VzaW5nQXJy YXlSZXBsYWNlciA9IHRydWU7Ci0gICAgICAgICAgICAgICAgSlNWYWx1ZSBsZW5ndGhWYWx1ZSA9 IHJlcGxhY2VyT2JqZWN0LT5nZXQoZ2xvYmFsT2JqZWN0LCB2bS5wcm9wZXJ0eU5hbWVzLT5sZW5n dGgpOworICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxlbmd0aCA9IHRvTGVuZ3RoKGdsb2JhbE9i amVjdCwgcmVwbGFjZXJPYmplY3QpOwogICAgICAgICAgICAgICAgIFJFVFVSTl9JRl9FWENFUFRJ T04oc2NvcGUsICk7Ci0gICAgICAgICAgICAgICAgdW5zaWduZWQgbGVuZ3RoID0gbGVuZ3RoVmFs dWUudG9VSW50MzIoZ2xvYmFsT2JqZWN0KTsKLSAgICAgICAgICAgICAgICBSRVRVUk5fSUZfRVhD RVBUSU9OKHNjb3BlLCApOwotICAgICAgICAgICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkg PCBsZW5ndGg7ICsraSkgewotICAgICAgICAgICAgICAgICAgICBKU1ZhbHVlIG5hbWUgPSByZXBs YWNlck9iamVjdC0+Z2V0KGdsb2JhbE9iamVjdCwgaSk7Ci0gICAgICAgICAgICAgICAgICAgIFJF VFVSTl9JRl9FWENFUFRJT04oc2NvcGUsICk7CisgICAgICAgICAgICAgICAgZm9yICh1bnNpZ25l ZCBpbmRleCA9IDA7IGluZGV4IDwgbGVuZ3RoOyArK2luZGV4KSB7CisgICAgICAgICAgICAgICAg ICAgIEpTVmFsdWUgbmFtZTsKKyAgICAgICAgICAgICAgICAgICAgaWYgKGlzSlNBcnJheShyZXBs YWNlck9iamVjdCkgJiYgcmVwbGFjZXJPYmplY3QtPmNhbkdldEluZGV4UXVpY2tseShpbmRleCkp CisgICAgICAgICAgICAgICAgICAgICAgICBuYW1lID0gcmVwbGFjZXJPYmplY3QtPmdldEluZGV4 UXVpY2tseShpbmRleCk7CisgICAgICAgICAgICAgICAgICAgIGVsc2UgeworICAgICAgICAgICAg ICAgICAgICAgICAgbmFtZSA9IHJlcGxhY2VyT2JqZWN0LT5nZXQoZ2xvYmFsT2JqZWN0LCBpbmRl eCk7CisgICAgICAgICAgICAgICAgICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCAp OworICAgICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgICAgIGlmIChuYW1lLmlz T2JqZWN0KCkpIHsKICAgICAgICAgICAgICAgICAgICAgICAgIGF1dG8qIG5hbWVPYmplY3QgPSBq c0Nhc3Q8SlNPYmplY3QqPihuYW1lKTsKICAgICAgICAgICAgICAgICAgICAgICAgIGlmICghbmFt ZU9iamVjdC0+aW5oZXJpdHM8TnVtYmVyT2JqZWN0Pih2bSkgJiYgIW5hbWVPYmplY3QtPmluaGVy aXRzPFN0cmluZ09iamVjdD4odm0pKQpAQCAtNDg2LDE0ICs0ODksOCBAQCBib29sIFN0cmluZ2lm aWVyOjpIb2xkZXI6OmFwcGVuZE5leHRQcm9wCiAgICAgLy8gRmlyc3QgdGltZSB0aHJvdWdoLCBp bml0aWFsaXplLgogICAgIGlmICghbV9pbmRleCkgewogICAgICAgICBpZiAobV9pc0FycmF5KSB7 Ci0gICAgICAgICAgICBpZiAobV9pc0pTQXJyYXkpCi0gICAgICAgICAgICAgICAgbV9zaXplID0g YXNBcnJheShtX29iamVjdCktPmxlbmd0aCgpOwotICAgICAgICAgICAgZWxzZSB7Ci0gICAgICAg ICAgICAgICAgSlNWYWx1ZSB2YWx1ZSA9IG1fb2JqZWN0LT5nZXQoZ2xvYmFsT2JqZWN0LCB2bS5w cm9wZXJ0eU5hbWVzLT5sZW5ndGgpOwotICAgICAgICAgICAgICAgIFJFVFVSTl9JRl9FWENFUFRJ T04oc2NvcGUsIGZhbHNlKTsKLSAgICAgICAgICAgICAgICBtX3NpemUgPSB2YWx1ZS50b1VJbnQz MihnbG9iYWxPYmplY3QpOwotICAgICAgICAgICAgICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2Nv cGUsIGZhbHNlKTsKLSAgICAgICAgICAgIH0KKyAgICAgICAgICAgIG1fc2l6ZSA9IHRvTGVuZ3Ro KGdsb2JhbE9iamVjdCwgbV9vYmplY3QpOworICAgICAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElP TihzY29wZSwgZmFsc2UpOwogICAgICAgICAgICAgYnVpbGRlci5hcHBlbmQoJ1snKTsKICAgICAg ICAgfSBlbHNlIHsKICAgICAgICAgICAgIGlmIChzdHJpbmdpZmllci5tX3VzaW5nQXJyYXlSZXBs YWNlcikKQEAgLTUyOCw4ICs1MjUsOCBAQCBib29sIFN0cmluZ2lmaWVyOjpIb2xkZXI6OmFwcGVu ZE5leHRQcm9wCiAgICAgaWYgKG1faXNBcnJheSkgewogICAgICAgICAvLyBHZXQgdGhlIHZhbHVl LgogICAgICAgICBKU1ZhbHVlIHZhbHVlOwotICAgICAgICBpZiAobV9pc0pTQXJyYXkgJiYgYXNB cnJheShtX29iamVjdCktPmNhbkdldEluZGV4UXVpY2tseShpbmRleCkpCi0gICAgICAgICAgICB2 YWx1ZSA9IGFzQXJyYXkobV9vYmplY3QpLT5nZXRJbmRleFF1aWNrbHkoaW5kZXgpOworICAgICAg ICBpZiAobV9pc0pTQXJyYXkgJiYgbV9vYmplY3QtPmNhbkdldEluZGV4UXVpY2tseShpbmRleCkp CisgICAgICAgICAgICB2YWx1ZSA9IG1fb2JqZWN0LT5nZXRJbmRleFF1aWNrbHkoaW5kZXgpOwog ICAgICAgICBlbHNlIHsKICAgICAgICAgICAgIFByb3BlcnR5U2xvdCBzbG90KG1fb2JqZWN0LCBQ cm9wZXJ0eVNsb3Q6OkludGVybmFsTWV0aG9kVHlwZTo6R2V0KTsKICAgICAgICAgICAgIGJvb2wg aGFzUHJvcGVydHkgPSBtX29iamVjdC0+Z2V0UHJvcGVydHlTbG90KGdsb2JhbE9iamVjdCwgaW5k ZXgsIHNsb3QpOwo=