20412 2008-08-16 15:07:06 -0700 webkitview.cpp passes negative-value constants as guint 2009-02-06 16:11:36 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 dmacks webkit-unassigned oldest_to_newest 88641 0 dmacks 2008-08-16 15:07:06 -0700 Compiling webkit source (nightly r35788) on OS X 10.4, using all gtk and other non-apple-supplied support libs using latest available from fink unstable tree... 1. ./autogen.sh --prefix=/sw --with-target=x11 --with-http-backend=curl --with-font-backend-pango --disable-video no configure problems 2. make WebKit/gtk/webkit/webkitwebview.cpp: In function 'void webkit_web_view_init(WebKitWebView*)': WebKit/gtk/webkit/webkitwebview.cpp:1431: warning: passing negative value 'WEBKIT_WEB_VIEW_TARGET_INFO_HTML' for argument 4 to 'void gtk_target_list_add(GtkTargetList*, _GdkAtom*, guint, guint)' WebKit/gtk/webkit/webkitwebview.cpp:1432: warning: passing negative value 'WEBKIT_WEB_VIEW_TARGET_INFO_TEXT' for argument 2 to 'void gtk_target_list_add_text_targets(GtkTargetList*, guint)' WebKit/gtk/webkit/webkitwebview.cpp:1436: warning: passing negative value 'WEBKIT_WEB_VIEW_TARGET_INFO_HTML' for argument 4 to 'void gtk_target_list_add(GtkTargetList*, _GdkAtom*, guint, guint)' WebKit/gtk/webkit/webkitwebview.cpp:1437: warning: passing negative value 'WEBKIT_WEB_VIEW_TARGET_INFO_TEXT' for argument 2 to 'void gtk_target_list_add_text_targets(GtkTargetList*, guint)' Sure enough, webkitwebview.h defines those constants as negative-values: typedef enum { WEBKIT_WEB_VIEW_TARGET_INFO_HTML = - 1, WEBKIT_WEB_VIEW_TARGET_INFO_TEXT = - 2 } WebKitWebViewTargetInfo; I don't know how the gtk_lists themselves are used in gtk but the functions are prototyped as guint in gtkselection.h (from gtk-2.12.11). The only other place this value (appears to my casual reading) to be used is in WebCore/platform/gtk/PasteboardGtk.cpp, where the stored token is casted to a gint. To a first guess, could just flip those enums to positive values? 105484 1 xan.lopez 2009-01-13 07:27:14 -0800 I think you are right, having them as negative numbers does not make sense IMHO. 105485 2 christian 2009-01-13 07:34:58 -0800 Doesn't make much sense to me either to have negatives here. Applications shouldn't even use the actual values, the enumeration should just be fixed. 105486 3 26667 xan.lopez 2009-01-13 07:38:25 -0800 Created attachment 26667 0001-2009-01-13-Xan-Lopez-xan-gnome.org.patch commit aeda6d41172041771a67768130db8d38f6ed28f8 Author: Xan Lopez <xan@gnome.org> Date: Tue Jan 13 17:36:57 2009 +0200 2009-01-13 Xan Lopez <xan@gnome.org> Reviewed by NOBODY (OOPS!). Reported by Daniel Macks. https://bugs.webkit.org/show_bug.cgi?id=20412 Use positive numbers for the target info IDs, gtk_target_list_add casts them to 'guint'. Also just start them from 0, since the values are not relevant or magic in any way, they are just used as tokens for the user of the API. * webkit/webkitwebview.h: WebKit/gtk/ChangeLog | 15 +++++++++++++++ WebKit/gtk/webkit/webkitwebview.h | 4 ++-- 2 files changed, 17 insertions(+), 2 deletions(-) 106040 4 zecke 2009-01-16 02:06:35 -0800 This will create a weird compability problem?! Changing the enum values means old code will pass -1 and -2 and new code 0 and 1. Should we consider that? Do we care? 107961 5 26667 zecke 2009-02-02 06:49:24 -0800 Comment on attachment 26667 0001-2009-01-13-Xan-Lopez-xan-gnome.org.patch Okay, ABI compat but this was discussed. 108760 6 zecke 2009-02-06 16:11:36 -0800 M WebKit/gtk/webkit/webkitwebview.h M WebKit/gtk/ChangeLog r40739 = d2a2bab5d8673ca82cdd570cdb58d24220ae61e8 (git-svn) 26667 2009-01-13 07:38:25 -0800 2009-02-02 06:49:24 -0800 0001-2009-01-13-Xan-Lopez-xan-gnome.org.patch 0001-2009-01-13-Xan-Lopez-xan-gnome.org.patch text/plain 1987 xan.lopez RnJvbSBhZWRhNmQ0MTE3MjA0MTc3MWE2Nzc2ODEzMGRiOGQzOGY2ZWQyOGY4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhhbkBnbm9tZS5vcmc+CkRhdGU6IFR1ZSwg MTMgSmFuIDIwMDkgMTc6MzY6NTcgKzAyMDAKU3ViamVjdDogW1BBVENIXSAyMDA5LTAxLTEzICBY YW4gTG9wZXogIDx4YW5AZ25vbWUub3JnPgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KCiAgICAgICAgUmVwb3J0ZWQgYnkgRGFuaWVsIE1hY2tzLgoKICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0MTIKCiAgICAgICAgVXNlIHBvc2l0 aXZlIG51bWJlcnMgZm9yIHRoZSB0YXJnZXQgaW5mbyBJRHMsIGd0a190YXJnZXRfbGlzdF9hZGQK ICAgICAgICBjYXN0cyB0aGVtIHRvICdndWludCcuIEFsc28ganVzdCBzdGFydCB0aGVtIGZyb20g MCwgc2luY2UgdGhlCiAgICAgICAgdmFsdWVzIGFyZSBub3QgcmVsZXZhbnQgb3IgbWFnaWMgaW4g YW55IHdheSwgdGhleSBhcmUganVzdCB1c2VkIGFzCiAgICAgICAgdG9rZW5zIGZvciB0aGUgdXNl ciBvZiB0aGUgQVBJLgoKICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3Lmg6Ci0tLQogV2Vi S2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAgICAgIHwgICAxNSArKysrKysrKysrKysrKysKIFdl YktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuaCB8ICAgIDQgKystLQogMiBmaWxlcyBjaGFu Z2VkLCAxNyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktp dC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggN2I5NTRmNi4uN2Q4 ODA1OSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0wMS0xMyAgWGFuIExvcGV6ICA8eGFuQGdu b21lLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZXBvcnRlZCBieSBEYW5pZWwgTWFja3MuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDEyCisKKyAgICAgICAgVXNlIHBvc2l0aXZlIG51bWJl cnMgZm9yIHRoZSB0YXJnZXQgaW5mbyBJRHMsIGd0a190YXJnZXRfbGlzdF9hZGQKKyAgICAgICAg Y2FzdHMgdGhlbSB0byAnZ3VpbnQnLiBBbHNvIGp1c3Qgc3RhcnQgdGhlbSBmcm9tIDAsIHNpbmNl IHRoZQorICAgICAgICB2YWx1ZXMgYXJlIG5vdCByZWxldmFudCBvciBtYWdpYyBpbiBhbnkgd2F5 LCB0aGV5IGFyZSBqdXN0IHVzZWQgYXMKKyAgICAgICAgdG9rZW5zIGZvciB0aGUgdXNlciBvZiB0 aGUgQVBJLgorCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcuaDoKKwogMjAwOS0wMS0x MyAgQWxleGFuZGVyIFYuIEJ1dGVua28gIDxhbGV4QGRpZ2lxdWJlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBIb2xnZXIgRnJleXRoZXIuCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXR3ZWJ2aWV3LmggYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmgKaW5k ZXggMmJiOGM2MS4uMjJiNWY0ZiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0 d2Vidmlldy5oCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuaApAQCAtNDks OCArNDksOCBAQCB0eXBlZGVmIGVudW0gewogCiB0eXBlZGVmIGVudW0KIHsKLSAgICBXRUJLSVRf V0VCX1ZJRVdfVEFSR0VUX0lORk9fSFRNTCA9IC0gMSwKLSAgICBXRUJLSVRfV0VCX1ZJRVdfVEFS R0VUX0lORk9fVEVYVCA9IC0gMgorICAgIFdFQktJVF9XRUJfVklFV19UQVJHRVRfSU5GT19IVE1M LAorICAgIFdFQktJVF9XRUJfVklFV19UQVJHRVRfSU5GT19URVhUCiB9IFdlYktpdFdlYlZpZXdU YXJnZXRJbmZvOwogCiBzdHJ1Y3QgX1dlYktpdFdlYlZpZXcgewotLSAKMS42LjEKCg==