204098 2019-11-11 17:22:16 -0800 Skip matched declarations cache only for length resolution affecting font properties 2019-11-13 10:54:07 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned allan.jensen commit-queue esprehn+autocc ews-watchlist glenn gyuyoung.kim macpherson menard simon.fraser webkit-bug-importer zalan oldest_to_newest 1589407 0 koivisto 2019-11-11 17:22:16 -0800 Instead of skipping on any sort of font change. 1589411 1 383325 koivisto 2019-11-11 17:26:31 -0800 Created attachment 383325 patch 1589584 2 383325 commit-queue 2019-11-12 11:32:34 -0800 Comment on attachment 383325 patch Clearing flags on attachment: 383325 Committed r252370: <https://trac.webkit.org/changeset/252370> 1589585 3 commit-queue 2019-11-12 11:32:36 -0800 All reviewed patches have been landed. Closing bug. 1589587 4 webkit-bug-importer 2019-11-12 11:34:21 -0800 <rdar://problem/57124173> 1589784 5 383325 simon.fraser 2019-11-12 23:10:51 -0800 Comment on attachment 383325 patch View in context: https://bugs.webkit.org/attachment.cgi?id=383325&action=review > Source/WebCore/css/CSSPrimitiveValue.cpp:708 > +bool CSSPrimitiveValue::equalForLengthResolution(const RenderStyle& styleA, const RenderStyle& styleB) Why is this a function on CSSPrimitiveValue? Seems like it could be on RenderStyle. 1589942 6 koivisto 2019-11-13 10:54:07 -0800 > Why is this a function on CSSPrimitiveValue? Seems like it could be on > RenderStyle. I put it next to the length resolution function (CSSPrimitiveValue::computeNonCalcLengthDouble) since these two must stay in sync. They should be moved somewhere else together. 383325 2019-11-11 17:26:31 -0800 2019-11-12 11:32:34 -0800 patch matched-declarations-length-affecting.patch text/plain 5960 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzZTc4MjI1ZmNlZS4uZTQ1M2QxMGY3YmMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyOCBAQAorMjAxOS0xMS0xMSAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CisKKyAgICAgICAgU2tpcCBtYXRjaGVkIGRlY2xhcmF0aW9ucyBjYWNoZSBvbmx5IGZvciBsZW5n dGggcmVzb2x1dGlvbiBhZmZlY3RpbmcgZm9udCBwcm9wZXJ0aWVzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQwOTgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNzcy9DU1NQcmltaXRpdmVWYWx1ZS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQcmltaXRpdmVWYWx1ZTo6ZXF1YWxGb3JMZW5ndGhS ZXNvbHV0aW9uKToKKworICAgICAgICBQdXQgdGhpcyBuZXh0IHRvIHRoZSBsZW5ndGggcmVzb2x1 dGlvbiBmdW5jdGlvbiwgaG9wZWZ1bGx5IGhlbHBpbmcgdG8ga2VlcCB0aGVtIGluIHN5bmMuCisK KyAgICAgICAgKiBjc3MvQ1NTUHJpbWl0aXZlVmFsdWUuaDoKKyAgICAgICAgKiBjc3MvU3R5bGVS ZXNvbHZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZVJlc29sdmVyOjphcHBseU1hdGNo ZWRQcm9wZXJ0aWVzKToKKworICAgICAgICBSZXBsYWNlIHRlc3QgZm9yIGZvbnQgZGVjbGFyYXRp b24gY2hhbmdlIHdpdGggYSBuYXJyb3dlciB0ZXN0IHRoYXQgb25seSBsb29rcyBmb3IgdGhvc2Ug cHJvcGVydGllcyB0aGF0IGFmZmVjdCBsZW5ndGggcmVzb2x1dGlvbi4KKworICAgICAgICAqIHN0 eWxlL01hdGNoZWREZWNsYXJhdGlvbnNDYWNoZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHls ZTo6TWF0Y2hlZERlY2xhcmF0aW9uc0NhY2hlOjpFbnRyeTo6aXNVc2FibGVBZnRlckhpZ2hQcmlv cml0eVByb3BlcnRpZXMgY29uc3QpOgorCisgICAgICAgIEZhY3RvciBpbnRvIGZ1bmN0aW9uLgor CisgICAgICAgICogc3R5bGUvTWF0Y2hlZERlY2xhcmF0aW9uc0NhY2hlLmg6CisKIDIwMTktMTEt MTEgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIEFsd2F5cyB1 c2UgbWF0Y2hlZCBkZWNsYXJhdGlvbnMgY2FjaGUgZnVsbHkgd2hlbiBwYXJlbnQgaW5oZXJpdGVk IHN0eWxlIG1hdGNoZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRp dmVWYWx1ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3BwCmlu ZGV4IDM4ZmQ2ZGEwOGY4Li45ZGE1YmU2OGEzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Y3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJp bWl0aXZlVmFsdWUuY3BwCkBAIC03MDUsNiArNzA1LDI1IEBAIGRvdWJsZSBDU1NQcmltaXRpdmVW YWx1ZTo6Y29tcHV0ZU5vbkNhbGNMZW5ndGhEb3VibGUoY29uc3QgQ1NTVG9MZW5ndGhDb252ZXJz aW9uCiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KIAorYm9vbCBDU1NQcmltaXRpdmVWYWx1ZTo6ZXF1 YWxGb3JMZW5ndGhSZXNvbHV0aW9uKGNvbnN0IFJlbmRlclN0eWxlJiBzdHlsZUEsIGNvbnN0IFJl bmRlclN0eWxlJiBzdHlsZUIpCit7CisgICAgLy8gVGhlc2UgcHJvcGVydGllcyBhZmZlY3QgcmVz dWx0cyBvZiBjb21wdXRlTm9uQ2FsY0xlbmd0aERvdWJsZSBhYm92ZS4KKyAgICBpZiAoc3R5bGVB LmZvbnREZXNjcmlwdGlvbigpLmNvbXB1dGVkU2l6ZSgpICE9IHN0eWxlQi5mb250RGVzY3JpcHRp b24oKS5jb21wdXRlZFNpemUoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIGlmIChzdHls ZUEuZm9udERlc2NyaXB0aW9uKCkuc3BlY2lmaWVkU2l6ZSgpICE9IHN0eWxlQi5mb250RGVzY3Jp cHRpb24oKS5zcGVjaWZpZWRTaXplKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGlm IChzdHlsZUEuZm9udE1ldHJpY3MoKS54SGVpZ2h0KCkgIT0gc3R5bGVCLmZvbnRNZXRyaWNzKCku eEhlaWdodCgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgaWYgKHN0eWxlQS5mb250TWV0 cmljcygpLnplcm9XaWR0aCgpICE9IHN0eWxlQi5mb250TWV0cmljcygpLnplcm9XaWR0aCgpKQor ICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBpZiAoc3R5bGVBLnpvb20oKSAhPSBzdHlsZUIu em9vbSgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICByZXR1cm4gdHJ1ZTsKK30KKwog RXhjZXB0aW9uT3I8dm9pZD4gQ1NTUHJpbWl0aXZlVmFsdWU6OnNldEZsb2F0VmFsdWUodW5zaWdu ZWQgc2hvcnQsIGRvdWJsZSkKIHsKICAgICAvLyBLZWVwaW5nIHZhbHVlcyBpbW11dGFibGUgbWFr ZXMgb3B0aW1pemF0aW9ucyBlYXNpZXIgYW5kIGFsbG93cyBzaGFyaW5nIG9mIHRoZSBwcmltaXRp dmUgdmFsdWUgb2JqZWN0cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmlt aXRpdmVWYWx1ZS5oIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmgKaW5k ZXggOWY5NTQzMTJkYTAuLmFkNGEwNTEzYzNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTUHJpbWl0aXZlVmFsdWUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0 aXZlVmFsdWUuaApAQCAtMjc4LDYgKzI3OCw4IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgZG91Ymxl IGNvbnZlcnNpb25Ub0Nhbm9uaWNhbFVuaXRzU2NhbGVGYWN0b3IoVW5pdFR5cGUpOwogCiAgICAg c3RhdGljIGRvdWJsZSBjb21wdXRlTm9uQ2FsY0xlbmd0aERvdWJsZShjb25zdCBDU1NUb0xlbmd0 aENvbnZlcnNpb25EYXRhJiwgVW5pdFR5cGUsIGRvdWJsZSB2YWx1ZSk7CisgICAgLy8gVHJ1ZSBp ZiBjb21wdXRlTm9uQ2FsY0xlbmd0aERvdWJsZSB3b3VsZCBwcm9kdWNlIGlkZW50aWNhbCByZXN1 bHRzIHdoZW4gcmVzb2x2ZWQgYWdhaW5zdCBib3RoIHRoZXNlIHN0eWxlcy4KKyAgICBzdGF0aWMg Ym9vbCBlcXVhbEZvckxlbmd0aFJlc29sdXRpb24oY29uc3QgUmVuZGVyU3R5bGUmLCBjb25zdCBS ZW5kZXJTdHlsZSYpOwogCiAgICAgUmVmPERlcHJlY2F0ZWRDU1NPTVByaW1pdGl2ZVZhbHVlPiBj cmVhdGVEZXByZWNhdGVkQ1NTT01QcmltaXRpdmVXcmFwcGVyKENTU1N0eWxlRGVjbGFyYXRpb24m KSBjb25zdDsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCmluZGV4IDc1MDdiYjZl NWRlLi42NDQzZWMzMmJkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVz b2x2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcApAQCAt NTg0LDEzICs1ODQsMTEgQEAgdm9pZCBTdHlsZVJlc29sdmVyOjphcHBseU1hdGNoZWRQcm9wZXJ0 aWVzKFN0YXRlJiBzdGF0ZSwgY29uc3QgTWF0Y2hSZXN1bHQmIG1hdGMKICAgICAvLyBIaWdoIHBy aW9yaXR5IHByb3BlcnRpZXMgbWF5IGFmZmVjdCByZXNvbHV0aW9uIG9mIG90aGVyIHByb3BlcnRp ZXMgKHRoZXkgYXJlIG1vc3RseSBmb250IHJlbGF0ZWQpLgogICAgIGJ1aWxkZXIuYXBwbHlIaWdo UHJpb3JpdHlQcm9wZXJ0aWVzKCk7CiAKLSAgICAvLyBJZiB0aGUgZWZmZWN0aXZlIHpvb20gdmFs dWUgY2hhbmdlcywgd2UgY2FuJ3QgdXNlIHRoZSBtYXRjaGVkIHByb3BlcnRpZXMgY2FjaGUuIFN0 YXJ0IG92ZXIuCi0gICAgaWYgKGNhY2hlRW50cnkgJiYgY2FjaGVFbnRyeS0+cmVuZGVyU3R5bGUt PmVmZmVjdGl2ZVpvb20oKSAhPSBzdHlsZS5lZmZlY3RpdmVab29tKCkpCi0gICAgICAgIHJldHVy biBhcHBseU1hdGNoZWRQcm9wZXJ0aWVzKHN0YXRlLCBtYXRjaFJlc3VsdCwgVXNlTWF0Y2hlZERl Y2xhcmF0aW9uc0NhY2hlOjpObyk7Ci0KLSAgICAvLyBJZiB0aGUgZm9udCBjaGFuZ2VkLCB3ZSBj YW4ndCB1c2UgdGhlIG1hdGNoZWQgcHJvcGVydGllcyBjYWNoZS4gU3RhcnQgb3Zlci4KLSAgICBp ZiAoY2FjaGVFbnRyeSAmJiBjYWNoZUVudHJ5LT5yZW5kZXJTdHlsZS0+Zm9udERlc2NyaXB0aW9u KCkgIT0gc3R5bGUuZm9udERlc2NyaXB0aW9uKCkpCi0gICAgICAgIHJldHVybiBhcHBseU1hdGNo ZWRQcm9wZXJ0aWVzKHN0YXRlLCBtYXRjaFJlc3VsdCwgVXNlTWF0Y2hlZERlY2xhcmF0aW9uc0Nh Y2hlOjpObyk7CisgICAgaWYgKGNhY2hlRW50cnkgJiYgIWNhY2hlRW50cnktPmlzVXNhYmxlQWZ0 ZXJIaWdoUHJpb3JpdHlQcm9wZXJ0aWVzKHN0eWxlKSkgeworICAgICAgICAvLyBXZSBuZWVkIHRv IHJlc29sdmUgYWxsIHByb3BlcnRpZXMgd2l0aG91dCBjYWNoaW5nLgorICAgICAgICBhcHBseU1h dGNoZWRQcm9wZXJ0aWVzKHN0YXRlLCBtYXRjaFJlc3VsdCwgVXNlTWF0Y2hlZERlY2xhcmF0aW9u c0NhY2hlOjpObyk7CisgICAgICAgIHJldHVybjsKKyAgICB9CiAKICAgICBidWlsZGVyLmFwcGx5 TG93UHJpb3JpdHlQcm9wZXJ0aWVzKCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N0 eWxlL01hdGNoZWREZWNsYXJhdGlvbnNDYWNoZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9N YXRjaGVkRGVjbGFyYXRpb25zQ2FjaGUuY3BwCmluZGV4IDYzOWQwNGNlNjliLi43M2U5ZTZmY2Ez ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3R5bGUvTWF0Y2hlZERlY2xhcmF0aW9uc0Nh Y2hlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9NYXRjaGVkRGVjbGFyYXRpb25zQ2Fj aGUuY3BwCkBAIC02NCw2ICs2NCwxNCBAQCBib29sIE1hdGNoZWREZWNsYXJhdGlvbnNDYWNoZTo6 aXNDYWNoZWFibGUoY29uc3QgRWxlbWVudCYgZWxlbWVudCwgY29uc3QgUmVuZGVyUwogICAgIHJl dHVybiB0cnVlOwogfQogCitib29sIE1hdGNoZWREZWNsYXJhdGlvbnNDYWNoZTo6RW50cnk6Omlz VXNhYmxlQWZ0ZXJIaWdoUHJpb3JpdHlQcm9wZXJ0aWVzKGNvbnN0IFJlbmRlclN0eWxlJiBzdHls ZSkgY29uc3QKK3sKKyAgICBpZiAoc3R5bGUuZWZmZWN0aXZlWm9vbSgpICE9IHJlbmRlclN0eWxl LT5lZmZlY3RpdmVab29tKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIHJldHVybiBD U1NQcmltaXRpdmVWYWx1ZTo6ZXF1YWxGb3JMZW5ndGhSZXNvbHV0aW9uKHN0eWxlLCAqcmVuZGVy U3R5bGUpOworfQorCiB1bnNpZ25lZCBNYXRjaGVkRGVjbGFyYXRpb25zQ2FjaGU6OmNvbXB1dGVI YXNoKGNvbnN0IE1hdGNoUmVzdWx0JiBtYXRjaFJlc3VsdCkKIHsKICAgICBpZiAoIW1hdGNoUmVz dWx0LmlzQ2FjaGVhYmxlKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3R5bGUvTWF0Y2hl ZERlY2xhcmF0aW9uc0NhY2hlLmggYi9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9NYXRjaGVkRGVjbGFy YXRpb25zQ2FjaGUuaAppbmRleCAzNjVmYTAxZjYyYy4uYmRkNDU3YTg1MmIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3N0eWxlL01hdGNoZWREZWNsYXJhdGlvbnNDYWNoZS5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3N0eWxlL01hdGNoZWREZWNsYXJhdGlvbnNDYWNoZS5oCkBAIC00Niw2ICs0 Niw4IEBAIHB1YmxpYzoKICAgICAgICAgTWF0Y2hSZXN1bHQgbWF0Y2hSZXN1bHQ7CiAgICAgICAg IHN0ZDo6dW5pcXVlX3B0cjxjb25zdCBSZW5kZXJTdHlsZT4gcmVuZGVyU3R5bGU7CiAgICAgICAg IHN0ZDo6dW5pcXVlX3B0cjxjb25zdCBSZW5kZXJTdHlsZT4gcGFyZW50UmVuZGVyU3R5bGU7CisK KyAgICAgICAgYm9vbCBpc1VzYWJsZUFmdGVySGlnaFByaW9yaXR5UHJvcGVydGllcyhjb25zdCBS ZW5kZXJTdHlsZSYpIGNvbnN0OwogICAgIH07CiAKICAgICBjb25zdCBFbnRyeSogZmluZCh1bnNp Z25lZCBoYXNoLCBjb25zdCBNYXRjaFJlc3VsdCYpOwo=