204094 2019-11-11 16:55:35 -0800 results.webkit.org: Support branches in run-javascriptcore-tests 2020-02-04 14:18:19 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=204091 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue dbates ews-watchlist ryanhaddad webkit-bug-importer zhifei_fang oldest_to_newest 1589374 0 jbedard 2019-11-11 16:55:35 -0800 We should automatically determine the correct branch when uploading jsc results to the results database. 1614265 1 389596 jbedard 2020-02-03 16:23:15 -0800 Created attachment 389596 Patch 1614678 2 389596 aakash_jain 2020-02-04 12:35:14 -0800 Comment on attachment 389596 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389596&action=review rs=me > Tools/Scripts/webkitdirs.pm:778 > +sub commitForDirectory($$) Maybe more appropriate place for this method would be in VCSUtils.pm next to svnRevisionForDirectory() 1614694 3 389696 jbedard 2020-02-04 13:27:36 -0800 Created attachment 389696 Patch for landing 1614735 4 389696 commit-queue 2020-02-04 14:17:47 -0800 Comment on attachment 389696 Patch for landing Clearing flags on attachment: 389696 Committed r255698: <https://trac.webkit.org/changeset/255698> 1614736 5 commit-queue 2020-02-04 14:17:48 -0800 All reviewed patches have been landed. Closing bug. 1614737 6 webkit-bug-importer 2020-02-04 14:18:19 -0800 <rdar://problem/59164749> 389596 2020-02-03 16:23:15 -0800 2020-02-04 13:27:34 -0800 Patch bug-204094-20200203162314.patch text/plain 2461 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NTYxMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIwLTAyLTAzICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IFN1cHBvcnQgYnJhbmNoZXMgaW4gcnVu LWphdmFzY3JpcHRjb3JlLXRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDQwOTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzOgorICAgICAg ICAodXBsb2FkUmVzdWx0cyk6IFVzZSB3ZWJraXRkaXJzIGZ1bmN0aW9uIHRvIGdlbmVyYXRlIGNv bW1pdCBpbmZvcm1hdGlvbi4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAg ICAgIChjb21taXRGb3JEaXJlY3RvcnkpOiBHZW5lcmF0ZSBjb21taXQgaW5mb3JtYXRpb24gZm9y IFNWTiByZXBvc2l0b3J5LCBpbmNsdWRpbmcKKyAgICAgICAgYnJhbmNoIG5hbWUuCisKIDIwMjAt MDItMDMgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAg ICAgICBSZWR1Y2Ugc2l6ZSBvZiBIYXNoTWFwIGFuZCBIYXNoU2V0CkluZGV4OiBUb29scy9TY3Jp cHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRz L3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwkocmV2aXNpb24gMjU1NTc0KQorKysgVG9vbHMvU2Ny aXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMJKHdvcmtpbmcgY29weSkKQEAgLTk0MywxMiAr OTQzLDggQEAgc3ViIHVwbG9hZFJlc3VsdHMKICAgICBteSAldXBsb2FkID0gKAogICAgICAgICB2 ZXJzaW9uID0+IDAsCiAgICAgICAgIHN1aXRlID0+ICdqYXZhc2NyaXB0Y29yZS10ZXN0cycsCi0g ICAgICAgICMgRklYTUU6IEludGVncmF0ZSBicmFuY2hlcywgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwNDA5NAogICAgICAgICAjIEZJWE1FOiBJbnRlZ3JhdGUgdGhl IFNhZmFyaSByZXBvc2l0b3J5LCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjA0MDk1Ci0gICAgICAgIGNvbW1pdHMgPT4gW3sKLSAgICAgICAgICAgIHJlcG9zaXRvcnlf aWQgPT4gJ3dlYmtpdCcsCi0gICAgICAgICAgICBpZCA9PiBkZXRlcm1pbmVDdXJyZW50U1ZOUmV2 aXNpb24oKSwKLSAgICAgICAgfV0sCisgICAgICAgIGNvbW1pdHMgPT4gW2NvbW1pdEZvckRpcmVj dG9yeShzb3VyY2VEaXIoKSwgJ3dlYmtpdCcpXSwKICAgICAgICAgY29uZmlndXJhdGlvbiA9PiBj b25maWd1cmF0aW9uRm9yVXBsb2FkKCksCiAgICAgICAgIHRlc3RfcmVzdWx0cyA9PiB7CiAgICAg ICAgICAgICBydW5fc3RhdHMgPT4gewpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBt Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkocmV2aXNpb24gMjU1 NTc0KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCSh3b3JraW5nIGNvcHkpCkBAIC03 NzUsNiArNzc1LDI1IEBAIHN1YiBkZXRlcm1pbmVDdXJyZW50U1ZOUmV2aXNpb24KICAgICByZXR1 cm4gJGN1cnJlbnRTVk5SZXZpc2lvbjsKIH0KIAorc3ViIGNvbW1pdEZvckRpcmVjdG9yeSgkJCkK K3sKKyAgICBteSAoJGRpcmVjdG9yeSwgJHJlcG9zaXRvcnkpID0gQF87CisKKyAgICBteSAkcmVz dWx0ID0geworICAgICAgICByZXBvc2l0b3J5X2lkID0+ICRyZXBvc2l0b3J5LAorICAgIH07Cisg ICAgaWYgKGlzU1ZORGlyZWN0b3J5KCRkaXJlY3RvcnkpKSB7CisgICAgICAgICRyZXN1bHQtPntp ZH0gPSBzdm5SZXZpc2lvbkZvckRpcmVjdG9yeSgkZGlyZWN0b3J5KTsKKyAgICAgICAgbXkgJGlu Zm8gPSBzdm5JbmZvRm9yUGF0aCgkZGlyZWN0b3J5KTsKKyAgICAgICAgJGluZm8gPX4gLy4qUmVs YXRpdmUgVVJMOiBcXlwvKFthLXpdKylcbi4qLzsKKyAgICAgICAgbXkgJGJyYW5jaCA9ICQxOwor ICAgICAgICAkcmVzdWx0LT57YnJhbmNofSA9ICRicmFuY2ggaWYgKCRicmFuY2ggbmUgJ3RydW5r Jyk7CisgICAgfSBlbHNlIHsKKyAgICAgICAgZGllICIkZGlyZWN0b3J5IGlzIG5vdCBhIHJlY29n bml6ZWQgU0NNIjsKKyAgICB9CisgICAgcmV0dXJuICRyZXN1bHQ7Cit9CisKIAogc3ViIGNoZGly V2ViS2l0CiB7Cg== 389696 2020-02-04 13:27:36 -0800 2020-02-04 14:17:47 -0800 Patch for landing bug-204094-20200204132735.patch text/plain 2777 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NTY5MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIwLTAyLTA0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IFN1cHBvcnQgYnJhbmNoZXMgaW4gcnVu LWphdmFzY3JpcHRjb3JlLXRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDQwOTQKKworICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBBYWthc2gg SmFpbi4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzOgorICAg ICAgICAodXBsb2FkUmVzdWx0cyk6IFVzZSB3ZWJraXRkaXJzIGZ1bmN0aW9uIHRvIGdlbmVyYXRl IGNvbW1pdCBpbmZvcm1hdGlvbi4KKyAgICAgICAgKiBTY3JpcHRzL1ZDU1V0aWxzLnBtOgorICAg ICAgICAoY29tbWl0Rm9yRGlyZWN0b3J5KTogR2VuZXJhdGUgY29tbWl0IGluZm9ybWF0aW9uIGZv ciBTVk4gcmVwb3NpdG9yeSwgaW5jbHVkaW5nCisgICAgICAgIGJyYW5jaCBuYW1lLgorCiAyMDIw LTAyLTA0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBb RVdTXSBEbyBub3QgcmVtb3ZlIFRlc3RXZWJLaXRBUEkgcHJlZml4IGZyb20gYXBpIHRlc3QgZmFp bHVyZXMKSW5kZXg6IFRvb2xzL1NjcmlwdHMvVkNTVXRpbHMucG0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvU2NyaXB0cy9WQ1NVdGlscy5wbQkocmV2aXNpb24gMjU1NjkwKQorKysgVG9vbHMvU2NyaXB0 cy9WQ1NVdGlscy5wbQkod29ya2luZyBjb3B5KQpAQCAtNTIsNiArNTIsNyBAQCBCRUdJTiB7CiAg ICAgICAgICZjaGFuZ2VMb2dFbWFpbEFkZHJlc3MKICAgICAgICAgJmNoYW5nZUxvZ05hbWUKICAg ICAgICAgJmNoZGlyUmV0dXJuaW5nUmVsYXRpdmVQYXRoCisgICAgICAgICZjb21taXRGb3JEaXJl Y3RvcnkKICAgICAgICAgJmRlY29kZUdpdEJpbmFyeUNodW5rCiAgICAgICAgICZkZWNvZGVHaXRC aW5hcnlQYXRjaAogICAgICAgICAmZGV0ZXJtaW5lU1ZOUm9vdApAQCAtMzcxLDYgKzM3MiwyNSBA QCBzdWIgY2hkaXJSZXR1cm5pbmdSZWxhdGl2ZVBhdGgoJCkKICAgICByZXR1cm4gRmlsZTo6U3Bl Yy0+YWJzMnJlbCgkcHJldmlvdXNEaXJlY3RvcnksICRuZXdEaXJlY3RvcnkpOwogfQogCitzdWIg Y29tbWl0Rm9yRGlyZWN0b3J5KCQkKQoreworICAgIG15ICgkZGlyZWN0b3J5LCAkcmVwb3NpdG9y eSkgPSBAXzsKKworICAgIG15ICRyZXN1bHQgPSB7CisgICAgICAgIHJlcG9zaXRvcnlfaWQgPT4g JHJlcG9zaXRvcnksCisgICAgfTsKKyAgICBpZiAoaXNTVk5EaXJlY3RvcnkoJGRpcmVjdG9yeSkp IHsKKyAgICAgICAgJHJlc3VsdC0+e2lkfSA9IHN2blJldmlzaW9uRm9yRGlyZWN0b3J5KCRkaXJl Y3RvcnkpOworICAgICAgICBteSAkaW5mbyA9IHN2bkluZm9Gb3JQYXRoKCRkaXJlY3RvcnkpOwor ICAgICAgICAkaW5mbyA9fiAvLipSZWxhdGl2ZSBVUkw6IFxeXC8oW2Etel0rKVxuLiovOworICAg ICAgICBteSAkYnJhbmNoID0gJDE7CisgICAgICAgICRyZXN1bHQtPnticmFuY2h9ID0gJGJyYW5j aCBpZiAoJGJyYW5jaCBuZSAndHJ1bmsnKTsKKyAgICB9IGVsc2UgeworICAgICAgICBkaWUgIiRk aXJlY3RvcnkgaXMgbm90IGEgcmVjb2duaXplZCBTQ00iOworICAgIH0KKyAgICByZXR1cm4gJHJl c3VsdDsKK30KKwogc3ViIGRldGVybWluZVNWTlJvb3QoKQogewogICAgIG15ICRsYXN0ID0gJyc7 CkluZGV4OiBUb29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwkocmV2aXNpb24gMjU1 NjkwKQorKysgVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMJKHdvcmtpbmcg Y29weSkKQEAgLTg4MSwxMiArODgxLDggQEAgc3ViIHVwbG9hZFJlc3VsdHMKICAgICBteSAldXBs b2FkID0gKAogICAgICAgICB2ZXJzaW9uID0+IDAsCiAgICAgICAgIHN1aXRlID0+ICdqYXZhc2Ny aXB0Y29yZS10ZXN0cycsCi0gICAgICAgICMgRklYTUU6IEludGVncmF0ZSBicmFuY2hlcywgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDA5NAogICAgICAgICAjIEZJ WE1FOiBJbnRlZ3JhdGUgdGhlIFNhZmFyaSByZXBvc2l0b3J5LCBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0MDk1Ci0gICAgICAgIGNvbW1pdHMgPT4gW3sKLSAgICAg ICAgICAgIHJlcG9zaXRvcnlfaWQgPT4gJ3dlYmtpdCcsCi0gICAgICAgICAgICBpZCA9PiBkZXRl cm1pbmVDdXJyZW50U1ZOUmV2aXNpb24oKSwKLSAgICAgICAgfV0sCisgICAgICAgIGNvbW1pdHMg PT4gW2NvbW1pdEZvckRpcmVjdG9yeShzb3VyY2VEaXIoKSwgJ3dlYmtpdCcpXSwKICAgICAgICAg Y29uZmlndXJhdGlvbiA9PiBjb25maWd1cmF0aW9uRm9yVXBsb2FkKCksCiAgICAgICAgIHRlc3Rf cmVzdWx0cyA9PiB7CiAgICAgICAgICAgICBydW5fc3RhdHMgPT4gewo=