204085 2019-11-11 14:50:30 -0800 Web Inspector: "aqua" and "fuchsia" aren't detected as colors 2019-11-13 20:05:22 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue hi inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1589338 0 nvasilyev 2019-11-11 14:50:30 -0800 That's the only color keyword that is defined in https://www.w3.org/TR/css-color-4/#named-colors but missing in the Web Inpector color dictionary. 1589339 1 383303 nvasilyev 2019-11-11 14:51:19 -0800 Created attachment 383303 Patch 1589926 2 383303 hi 2019-11-13 10:29:48 -0800 Comment on attachment 383303 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383303&action=review r=me > Source/WebInspectorUI/UserInterface/Models/Color.js:745 > + "aqua": [0, 255, 255, 1], We're also missing `fuchsia`, which is one of the original HTML colors 🤦‍♂️: ``` "fuchsia": [255, 0, 255, 1], ``` Interestingly, both `aqua` and `fuchsia` have alternate names in CSS, respectively being `cyan` and `magenta`. This doesn't look to be an issue, other than that we'll instead always prefer `aqua` over `cyan` (same with `fuchsia` over `magenta`) when generating CSS color keyword strings simply because they're sorted alphabetically. 1590021 3 383489 nvasilyev 2019-11-13 13:41:48 -0800 Created attachment 383489 Patch 1590187 4 383489 commit-queue 2019-11-13 20:04:23 -0800 Comment on attachment 383489 Patch Clearing flags on attachment: 383489 Committed r252448: <https://trac.webkit.org/changeset/252448> 1590188 5 commit-queue 2019-11-13 20:04:25 -0800 All reviewed patches have been landed. Closing bug. 1590189 6 webkit-bug-importer 2019-11-13 20:05:22 -0800 <rdar://problem/57178710> 383303 2019-11-11 14:51:19 -0800 2019-11-13 13:41:48 -0800 Patch patch.txt text/plain 1184 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDE3NzNmNDljNGQxLi5kODgzNjA4ZDYyOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTktMTEtMTEgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogImFxdWEiIGlzbid0IGRldGVjdGVkIGFzIGNvbG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQwODUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL0NvbG9yLmpz OgorCiAyMDE5LTExLTA3ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBSRUdSRVNTSU9OKHIyNTE5NTgpOiBjb25zb2xlIHByb21wdCBp cyBhdXRvbWF0aWNhbGx5IGZvY3VzZWQgd2hlbiBwYWdlIGlzIHJlbG9hZGVkCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ29sb3IuanMgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ29sb3IuanMKaW5kZXgg NmFjOWI3ZjhiM2QuLjNjODQ3YWNhODcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ29sb3IuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NvbG9yLmpzCkBAIC03NDIsNiArNzQyLDcgQEAgV0ku Q29sb3IuRnVuY3Rpb25OYW1lcyA9IG5ldyBTZXQoWwogV0kuQ29sb3IuS2V5d29yZHMgPSB7CiAg ICAgImFsaWNlYmx1ZSI6IFsyNDAsIDI0OCwgMjU1LCAxXSwKICAgICAiYW50aXF1ZXdoaXRlIjog WzI1MCwgMjM1LCAyMTUsIDFdLAorICAgICJhcXVhIjogWzAsIDI1NSwgMjU1LCAxXSwKICAgICAi YXF1YW1hcmluZSI6IFsxMjcsIDI1NSwgMjEyLCAxXSwKICAgICAiYXp1cmUiOiBbMjQwLCAyNTUs IDI1NSwgMV0sCiAgICAgImJlaWdlIjogWzI0NSwgMjQ1LCAyMjAsIDFdLAo= 383489 2019-11-13 13:41:48 -0800 2019-11-13 20:04:23 -0800 Patch patch.txt text/plain 1496 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDE3NzNmNDljNGQxLi43ZWM0Y2M1MGU4MSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTktMTEtMTMgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogImFxdWEiIGFuZCAiZnVjaHNpYSIgYXJlbid0IGRldGVjdGVkIGFzIGNvbG9ycworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0MDg1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgRGV2aW4gUm91c3NvLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9N b2RlbHMvQ29sb3IuanM6CisKIDIwMTktMTEtMDcgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBw bGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJFR1JFU1NJT04ocjI1MTk1OCk6IGNv bnNvbGUgcHJvbXB0IGlzIGF1dG9tYXRpY2FsbHkgZm9jdXNlZCB3aGVuIHBhZ2UgaXMgcmVsb2Fk ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVs cy9Db2xvci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9D b2xvci5qcwppbmRleCA2YWM5YjdmOGIzZC4uYTdkMTBhM2QzZTQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9Db2xvci5qcworKysgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ29sb3IuanMKQEAgLTc0Miw2 ICs3NDIsNyBAQCBXSS5Db2xvci5GdW5jdGlvbk5hbWVzID0gbmV3IFNldChbCiBXSS5Db2xvci5L ZXl3b3JkcyA9IHsKICAgICAiYWxpY2VibHVlIjogWzI0MCwgMjQ4LCAyNTUsIDFdLAogICAgICJh bnRpcXVld2hpdGUiOiBbMjUwLCAyMzUsIDIxNSwgMV0sCisgICAgImFxdWEiOiBbMCwgMjU1LCAy NTUsIDFdLAogICAgICJhcXVhbWFyaW5lIjogWzEyNywgMjU1LCAyMTIsIDFdLAogICAgICJhenVy ZSI6IFsyNDAsIDI1NSwgMjU1LCAxXSwKICAgICAiYmVpZ2UiOiBbMjQ1LCAyNDUsIDIyMCwgMV0s CkBAIC03ODcsNiArNzg4LDcgQEAgV0kuQ29sb3IuS2V5d29yZHMgPSB7CiAgICAgImZpcmVicmlj ayI6IFsxNzgsIDM0LCAzNCwgMV0sCiAgICAgImZsb3JhbHdoaXRlIjogWzI1NSwgMjUwLCAyNDAs IDFdLAogICAgICJmb3Jlc3RncmVlbiI6IFszNCwgMTM5LCAzNCwgMV0sCisgICAgImZ1Y2hzaWEi OiBbMjU1LCAwLCAyNTUsIDFdLAogICAgICJnYWluc2Jvcm8iOiBbMjIwLCAyMjAsIDIyMCwgMV0s CiAgICAgImdob3N0d2hpdGUiOiBbMjQ4LCAyNDgsIDI1NSwgMV0sCiAgICAgImdvbGQiOiBbMjU1 LCAyMTUsIDAsIDFdLAo=