204045 2019-11-09 03:55:52 -0800 iOS: fast/events/scroll-subframe-in-rendering-update.html always fails 2019-11-10 21:39:31 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=203839 InRadar P2 Normal --- 1 aakash_jain rniwa ap commit-queue rniwa simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1588994 0 aakash_jain 2019-11-09 03:55:52 -0800 The following layout test is failing consistently on iOS Simulator Debug/Release: fast/events/scroll-subframe-in-rendering-update.html Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fevents%2Fscroll-subframe-in-rendering-update.html https://results.webkit.org/?suite=layout-tests&test=fast%2Fevents%2Fscroll-subframe-in-rendering-update.html e.g.: https://build.webkit.org/results/Apple%20iOS%2013%20Simulator%20Release%20WK2%20(Tests)/r252205%20(939)/results.html https://build.webkit.org/results/Apple%20iOS%2013%20Simulator%20Release%20WK2%20(Tests)/r252231%20(947)/results.html https://build.webkit.org/results/Apple%20iOS%2013%20Simulator%20Release%20WK2%20(Tests)/r252240%20(954)/results.html https://build.webkit.org/results/Apple%20iOS%2013%20Simulator%20Release%20WK2%20(Tests)/r252262%20(960)/results.html https://build.webkit.org/results/Apple%20iOS%2013%20Simulator%20Debug%20WK2%20(Tests)/r252299%20(810)/results.html https://build.webkit.org/results/Apple%20iOS%2013%20Simulator%20Debug%20WK2%20(Tests)/r252205%20(788)/results.html https://ews-build.webkit.org/results/iOS-13-Simulator-WK2-Tests-EWS/r383072-4464/results.html 1588995 1 aakash_jain 2019-11-09 03:56:14 -0800 Diff: --- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/fast/events/scroll-subframe-in-rendering-update-expected.txt +++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/fast/events/scroll-subframe-in-rendering-update-actual.txt @@ -8,9 +8,10 @@ iframeAA.contentWindow.scrollTo(0, 1000); updateLayout(iframeAA) PASS logs.length is 0 After requestAnimationFrame -PASS logs.length is 3 -PASS logs.join(", ") is "A, AA, B" +FAIL logs.length should be 3. Was 0. +FAIL logs.join(", ") should be A, AA, B. Was . PASS successfullyParsed is true +Some tests failed. TEST COMPLETE 1588996 2 webkit-bug-importer 2019-11-09 03:56:20 -0800 <rdar://problem/57047296> 1588997 3 webkit-bug-importer 2019-11-09 03:59:46 -0800 <rdar://problem/57047315> 1588998 4 aakash_jain 2019-11-09 04:02:01 -0800 This test was added 2 days back in http://trac.webkit.org/changeset/252205/webkit and has been failing on iOS since then. 1589048 5 rniwa 2019-11-09 15:20:01 -0800 Ugh... frame flattening is in effect here. 1589050 6 383229 rniwa 2019-11-09 15:29:41 -0800 Created attachment 383229 Disable frame flattening 1589058 7 rniwa 2019-11-09 15:55:01 -0800 Ugh... I need to download & install a new iOS SDK to test this out. Doing that now. 1589065 8 rniwa 2019-11-09 19:30:10 -0800 Committed r252311: <https://trac.webkit.org/changeset/252311> 1589066 9 rniwa 2019-11-09 19:33:26 -0800 Ugh... I can't either SSH into my machine or download the iOS SDK. Landing the fix speculatively for now. If this doesn't work, we probably need to skip the test on iOS for now until I regain access to a machine with functional iOS SDK. 1589072 10 aakash_jain 2019-11-09 22:14:42 -0800 (In reply to Ryosuke Niwa from comment #8) > Committed r252311: <https://trac.webkit.org/changeset/252311> Seems to be still failing. https://build.webkit.org/builders/Apple%20iOS%2013%20Simulator%20Release%20WK2%20%28Tests%29/builds/975 1589073 11 rniwa 2019-11-09 23:08:09 -0800 Oh, I think we probably also need <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->. 1589074 12 rniwa 2019-11-09 23:12:35 -0800 Added the failing expectation in https://trac.webkit.org/r252312 for now. 1589076 13 383237 rniwa 2019-11-09 23:18:11 -0800 Created attachment 383237 Fix attempt no.2 1589077 14 rniwa 2019-11-09 23:20:25 -0800 It's really annoying that we need to enable random ass flags in the tests to make scrolling tests to work in iOS. We should probably flip the default so that async scrolling is enabled by default so that many of existing layout tests for scrolling behavior can be enabled on iOS, and create a separate set of tests for frame flattening. 1589111 15 aakash_jain 2019-11-10 13:54:27 -0800 (In reply to Ryosuke Niwa from comment #13) > Created attachment 383237 [details] > Fix attempt no.2 Did you want to update the TestExpectations as well? I guess EWS results for this patch wouldn't have covered this test because we pass --skip-failing-tests to run-webkit-tests in EWS. 1589129 16 rniwa 2019-11-10 17:26:26 -0800 (In reply to Aakash Jain from comment #15) > (In reply to Ryosuke Niwa from comment #13) > > Created attachment 383237 [details] > > Fix attempt no.2 > Did you want to update the TestExpectations as well? > > I guess EWS results for this patch wouldn't have covered this test because > we pass --skip-failing-tests to run-webkit-tests in EWS. WTF!? When did we start doing that? 1589130 17 383251 rniwa 2019-11-10 17:27:22 -0800 Created attachment 383251 Patch for landing 1589131 18 383251 rniwa 2019-11-10 17:27:33 -0800 Comment on attachment 383251 Patch for landing Wait for EWS. 1589132 19 aakash_jain 2019-11-10 18:52:11 -0800 (In reply to Ryosuke Niwa from comment #16) > (In reply to Aakash Jain from comment #15) > > (In reply to Ryosuke Niwa from comment #13) > > > Created attachment 383237 [details] > > > Fix attempt no.2 > > Did you want to update the TestExpectations as well? > > > > I guess EWS results for this patch wouldn't have covered this test because > > we pass --skip-failing-tests to run-webkit-tests in EWS. > > WTF!? When did we start doing that? Seems like we started it in https://trac.webkit.org/changeset/106518/webkit 1589142 20 383251 commit-queue 2019-11-10 21:39:29 -0800 Comment on attachment 383251 Patch for landing Clearing flags on attachment: 383251 Committed r252317: <https://trac.webkit.org/changeset/252317> 1589143 21 commit-queue 2019-11-10 21:39:31 -0800 All reviewed patches have been landed. Closing bug. 383229 2019-11-09 15:29:41 -0800 2019-11-09 23:18:10 -0800 Disable frame flattening bug-204045-20191109152939.patch text/plain 1376 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI1MjMwOSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE5LTExLTA5ICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIGlPUzogZmFzdC9ldmVudHMvc2Nyb2xsLXN1YmZy YW1lLWluLXJlbmRlcmluZy11cGRhdGUuaHRtbCBhbHdheXMgZmFpbHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDA0NQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERpc2FibGUgdGhlIGZyYW1lIGZsYXR0 ZW5pbmcgdG8gbWFrZSB0aGUgdGVzdCB3b3JrIG9uIGlPUy4KKworICAgICAgICAqIGZhc3QvZXZl bnRzL3Njcm9sbC1zdWJmcmFtZS1pbi1yZW5kZXJpbmctdXBkYXRlLmh0bWw6CisKIDIwMTktMTEt MDggIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTmV3 IHRlc3QgaW5zcGVjdG9yLXByb3RvY29sL3BhZ2UvYXJjaGl2ZS5odG1sIGFkZGVkIGluIHIxNTQ4 MjggZmFpbHMgb24gRUZMLCBRdCwgR1RLCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9z Y3JvbGwtc3ViZnJhbWUtaW4tcmVuZGVyaW5nLXVwZGF0ZS5odG1sCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvZXZlbnRzL3Njcm9sbC1zdWJmcmFtZS1pbi1yZW5kZXJpbmctdXBkYXRl Lmh0bWwJKHJldmlzaW9uIDI1MjMwOSkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3Njcm9s bC1zdWJmcmFtZS1pbi1yZW5kZXJpbmctdXBkYXRlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTcs NiArNyw5IEBACiBkZXNjcmlwdGlvbignVGhpcyB0ZXN0cyB0aGF0IHNjcm9sbCBldmVudCBpcyBk aXNwYXRjaGVkIGluIHRoZSB1cGRhdGUtdGhlLXJlbmRlcmluZyBzdGVwIGluIHRoZSBldmVudCBs b29wIGFjcm9zcyBhbGwgcmVsZXZhbnQgZnJhbWVzJyk7CiBqc1Rlc3RJc0FzeW5jID0gdHJ1ZTsK IAoraWYgKHdpbmRvdy5pbnRlcm5hbHMpCisgICAgaW50ZXJuYWxzLnNldHRpbmdzLnNldEZyYW1l RmxhdHRlbmluZygiRGlzYWJsZWQiKTsKKwogZnVuY3Rpb24gY3JlYXRlSWZyYW1lKHBhcmVudERv Y3VtZW50KQogewogICAgIGNvbnN0IGlmcmFtZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2lm cmFtZScpOwo= 383237 2019-11-09 23:18:11 -0800 2019-11-10 17:27:19 -0800 Fix attempt no.2 bug-204045-20191109231810.patch text/plain 1592 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI1MjMxMikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE5LTExLTA5ICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIGlPUzogZmFzdC9ldmVudHMvc2Nyb2xsLXN1YmZy YW1lLWluLXJlbmRlcmluZy11cGRhdGUuaHRtbCBhbHdheXMgZmFpbHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDA0NQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuYWJsZSBhc3luYyAmIGZyYW1lIHNj cm9sbGluZyB0byBtYWtlIHRoZSB0ZXN0IHdvcmsgaW4gaU9TLgorCisgICAgICAgICogZmFzdC9l dmVudHMvc2Nyb2xsLXN1YmZyYW1lLWluLXJlbmRlcmluZy11cGRhdGUuaHRtbDoKKwogMjAxOS0x MS0wOSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBpT1M6IGZh c3QvZXZlbnRzL3Njcm9sbC1zdWJmcmFtZS1pbi1yZW5kZXJpbmctdXBkYXRlLmh0bWwgYWx3YXlz IGZhaWxzCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zY3JvbGwtc3ViZnJhbWUtaW4t cmVuZGVyaW5nLXVwZGF0ZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZXZl bnRzL3Njcm9sbC1zdWJmcmFtZS1pbi1yZW5kZXJpbmctdXBkYXRlLmh0bWwJKHJldmlzaW9uIDI1 MjMxMSkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3Njcm9sbC1zdWJmcmFtZS1pbi1yZW5k ZXJpbmctdXBkYXRlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTEsNCArMSw0IEBACi08IURPQ1RZ UEUgaHRtbD4KKzwhRE9DVFlQRSBodG1sPjwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgaW50ZXJu YWw6QXN5bmNPdmVyZmxvd1Njcm9sbGluZ0VuYWJsZWQ9dHJ1ZSBpbnRlcm5hbDpBc3luY0ZyYW1l U2Nyb2xsaW5nRW5hYmxlZD10cnVlIF0gLS0+CiA8aHRtbD4KIDxib2R5PgogPHNjcmlwdCBzcmM9 Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LmpzIj48L3NjcmlwdD4KQEAgLTcsOSArNyw2IEBACiBk ZXNjcmlwdGlvbignVGhpcyB0ZXN0cyB0aGF0IHNjcm9sbCBldmVudCBpcyBkaXNwYXRjaGVkIGlu IHRoZSB1cGRhdGUtdGhlLXJlbmRlcmluZyBzdGVwIGluIHRoZSBldmVudCBsb29wIGFjcm9zcyBh bGwgcmVsZXZhbnQgZnJhbWVzJyk7CiBqc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKIAotaWYgKHdpbmRv dy5pbnRlcm5hbHMpCi0gICAgaW50ZXJuYWxzLnNldHRpbmdzLnNldEZyYW1lRmxhdHRlbmluZygi RGlzYWJsZWQiKTsKLQogZnVuY3Rpb24gY3JlYXRlSWZyYW1lKHBhcmVudERvY3VtZW50KQogewog ICAgIGNvbnN0IGlmcmFtZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2lmcmFtZScpOwo= 383251 2019-11-10 17:27:22 -0800 2019-11-10 21:39:29 -0800 Patch for landing bug-204045-20191110172720.patch text/plain 2163 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI1MjMxMikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE5LTExLTA5ICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIGlPUzogZmFzdC9ldmVudHMvc2Nyb2xsLXN1YmZy YW1lLWluLXJlbmRlcmluZy11cGRhdGUuaHRtbCBhbHdheXMgZmFpbHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDA0NQorCisgICAgICAgIFJldmll d2VkIGJ5IFdlbnNvbiBIc2llaC4KKworICAgICAgICBFbmFibGUgYXN5bmMgJiBmcmFtZSBzY3Jv bGxpbmcgdG8gbWFrZSB0aGUgdGVzdCB3b3JrIGluIGlPUy4KKworICAgICAgICAqIGZhc3QvZXZl bnRzL3Njcm9sbC1zdWJmcmFtZS1pbi1yZW5kZXJpbmctdXBkYXRlLmh0bWw6CisKIDIwMTktMTEt MDkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgaU9TOiBmYXN0 L2V2ZW50cy9zY3JvbGwtc3ViZnJhbWUtaW4tcmVuZGVyaW5nLXVwZGF0ZS5odG1sIGFsd2F5cyBm YWlscwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvc2Nyb2xsLXN1YmZyYW1lLWluLXJl bmRlcmluZy11cGRhdGUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50 cy9zY3JvbGwtc3ViZnJhbWUtaW4tcmVuZGVyaW5nLXVwZGF0ZS5odG1sCShyZXZpc2lvbiAyNTIz MTEpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zY3JvbGwtc3ViZnJhbWUtaW4tcmVuZGVy aW5nLXVwZGF0ZS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNCBAQAotPCFET0NUWVBF IGh0bWw+Cis8IURPQ1RZUEUgaHRtbD48IS0tIHdlYmtpdC10ZXN0LXJ1bm5lciBbIGludGVybmFs OkFzeW5jT3ZlcmZsb3dTY3JvbGxpbmdFbmFibGVkPXRydWUgaW50ZXJuYWw6QXN5bmNGcmFtZVNj cm9sbGluZ0VuYWJsZWQ9dHJ1ZSBdIC0tPgogPGh0bWw+CiA8Ym9keT4KIDxzY3JpcHQgc3JjPSIu Li8uLi9yZXNvdXJjZXMvanMtdGVzdC5qcyI+PC9zY3JpcHQ+CkBAIC03LDkgKzcsNiBAQAogZGVz Y3JpcHRpb24oJ1RoaXMgdGVzdHMgdGhhdCBzY3JvbGwgZXZlbnQgaXMgZGlzcGF0Y2hlZCBpbiB0 aGUgdXBkYXRlLXRoZS1yZW5kZXJpbmcgc3RlcCBpbiB0aGUgZXZlbnQgbG9vcCBhY3Jvc3MgYWxs IHJlbGV2YW50IGZyYW1lcycpOwoganNUZXN0SXNBc3luYyA9IHRydWU7CiAKLWlmICh3aW5kb3cu aW50ZXJuYWxzKQotICAgIGludGVybmFscy5zZXR0aW5ncy5zZXRGcmFtZUZsYXR0ZW5pbmcoIkRp c2FibGVkIik7Ci0KIGZ1bmN0aW9uIGNyZWF0ZUlmcmFtZShwYXJlbnREb2N1bWVudCkKIHsKICAg ICBjb25zdCBpZnJhbWUgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdpZnJhbWUnKTsKSW5kZXg6 IExheW91dFRlc3RzL3BsYXRmb3JtL2lvcy9UZXN0RXhwZWN0YXRpb25zCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL3BsYXRmb3JtL2lvcy9UZXN0RXhwZWN0YXRpb25zCShyZXZpc2lvbiAyNTIz MTUpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3MvVGVzdEV4cGVjdGF0aW9ucwkod29ya2lu ZyBjb3B5KQpAQCAtMzQ2NCw1ICszNDY0LDMgQEAgd2Via2l0Lm9yZy9iLzIwMzQxNiBpbXBvcnRl ZC93M2Mvd2ViLXBsYQogCiAjIFRoaXMgdGVzdCBmYWlscyBpbiBpT1MgZHVlIHRvIHN1YnBpeGVs IGRpZmZlcmVuY2VzIGZvciB0aGUgbWFya2VyIHBvc2l0aW9uCiBpbXBvcnRlZC93M2Mvd2ViLXBs YXRmb3JtLXRlc3RzL2Nzcy9jc3MtbGlzdHMvbGlzdC1zdHlsZS10eXBlLXN0cmluZy0wMDIuaHRt bCBbIEltYWdlT25seUZhaWx1cmUgXQotCi13ZWJraXQub3JnL2IvMjA0MDQ1IGZhc3QvZXZlbnRz L3Njcm9sbC1zdWJmcmFtZS1pbi1yZW5kZXJpbmctdXBkYXRlLmh0bWwgWyBGYWlsdXJlIF0K