204021 2019-11-08 13:56:02 -0800 Add punctuation rules for C++ lambdas 2019-11-13 01:26:18 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa ross.kirsling webkit-bug-importer zalan oldest_to_newest 1588822 0 rniwa 2019-11-08 13:56:02 -0800 Add punctuation rules for C++ lambdas 1588823 1 383160 rniwa 2019-11-08 13:58:57 -0800 Created attachment 383160 Add punctuation rules for C++ lambdas 1588835 2 383160 ross.kirsling 2019-11-08 14:17:29 -0800 Comment on attachment 383160 Add punctuation rules for C++ lambdas View in context: https://bugs.webkit.org/attachment.cgi?id=383160&action=review > Websites/webkit.org/code-style.md:900 > +[](#punctuation-omit-lambda-paren) Omit parantheses for a C++ lambda whenever possible nit: parantheses -> parentheses 1588836 3 ross.kirsling 2019-11-08 14:18:17 -0800 (In reply to Ross Kirsling from comment #2) > Comment on attachment 383160 [details] > Add punctuation rules for C++ lambdas > > View in context: > https://bugs.webkit.org/attachment.cgi?id=383160&action=review > > > Websites/webkit.org/code-style.md:900 > > +[](#punctuation-omit-lambda-paren) Omit parantheses for a C++ lambda whenever possible > > nit: parantheses -> parentheses (Also a missing period.) 1589783 4 rniwa 2019-11-12 23:05:01 -0800 (In reply to Ross Kirsling from comment #3) > (In reply to Ross Kirsling from comment #2) > > Comment on attachment 383160 [details] > > Add punctuation rules for C++ lambdas > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=383160&action=review > > > > > Websites/webkit.org/code-style.md:900 > > > +[](#punctuation-omit-lambda-paren) Omit parantheses for a C++ lambda whenever possible > > > > nit: parantheses -> parentheses > > (Also a missing period.) Fixed. 1589795 5 rniwa 2019-11-13 01:25:19 -0800 Committed r252395: <https://trac.webkit.org/changeset/252395> 1589796 6 webkit-bug-importer 2019-11-13 01:26:18 -0800 <rdar://problem/57146959> 383160 2019-11-08 13:58:57 -0800 2019-11-09 19:58:14 -0800 Add punctuation rules for C++ lambdas bug-204021-20191108135856.patch text/plain 1923 rniwa SW5kZXg6IFdlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNp dGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTIyNTQpCisrKyBXZWJzaXRlcy93 ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE5 LTExLTA4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBw dW5jdHVhdGlvbiBydWxlcyBmb3IgQysrIGxhbWJkYXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDAyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIHJ1bGVzIGZvciBub3QgcHV0dGluZyBzcGFj ZXMgYmV0d2VlbiBbXSBhbmQgKCkgYW5kIG9taXR0aW5nICgpIHdoZW5ldmVyIHBvc3NpYmxlIGZv ciBDKysgbGFtYmRhcy4KKworICAgICAgICAqIGNvZGUtc3R5bGUubWQ6CisKIDIwMTktMTAtMjYg IENocmlzIExvcmQgIDxjbG9yZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFB1dCBPZmZzY3JlZW5D YW52YXMgYmVoaW5kIGEgYnVpbGQgZmxhZwpJbmRleDogV2Vic2l0ZXMvd2Via2l0Lm9yZy9jb2Rl LXN0eWxlLm1kCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNpdGVzL3dlYmtpdC5vcmcvY29kZS1zdHlsZS5t ZAkocmV2aXNpb24gMjUyMjU0KQorKysgV2Vic2l0ZXMvd2Via2l0Lm9yZy9jb2RlLXN0eWxlLm1k CSh3b3JraW5nIGNvcHkpCkBAIC0yMzQsNiArMjM0LDIyIEBAIGYgKGEsIGIpOwogZiggYSwgYiAp OwogYGBgCiAKK1tdKCNzcGFjaW5nLWxhbWJkYS1wYXJlbikgRG8gbm90IHBsYWNlIHNwYWNlcyBi ZXR3ZWVuIHNxdWFyZSBicmFja2V0cyBhbmQgcGFyZW50aGVzZXMgb2YgYSBsYW1iZGEgZnVuY3Rp b24gYnV0IGRvIHBsYWNlIGEgc3BhY2UgYmVmb3JlIGJyYWNlcy4KKworIyMjIyMjIFJpZ2h0Ogor CitgYGBjcHAKK1tdKGludCB4KSB7IHJldHVybiB4OyB9CitbdGhpc10geyByZXR1cm4gbV9tZW1i ZXI7IH0KK2BgYAorCisjIyMjIyMgV3Jvbmc6CisKK2BgYGNwcAorW10gKGludCB4KSB7IHJldHVy biB4OyB9CitbdGhpc117IHJldHVybiBtX21lbWJlcjsgfQorYGBgCisKIFtdKCNzcGFjaW5nLWJy YWNlZC1pbml0KSBXaGVuIGluaXRpYWxpemluZyBhbiBvYmplY3QsIHBsYWNlIGEgc3BhY2UgYmVm b3JlIHRoZSBsZWFkaW5nIGJyYWNlIGFzIHdlbGwgYXMgYmV0d2VlbiB0aGUgYnJhY2VzIGFuZCB0 aGVpciBjb250ZW50LgogCiAjIyMjIyMgUmlnaHQ6CkBAIC04ODEsNiArODk3LDIyIEBAIGZvciAo VmVjdG9yPFJlZlB0cjxGcmFtZVZpZXc+ID46Oml0ZXJhdG8KICAgICAoKml0KS0+dXBkYXRlTGF5 b3V0QW5kU3R5bGVJZk5lZWRlZFJlY3Vyc2l2ZSgpOwogYGBgCiAKK1tdKCNwdW5jdHVhdGlvbi1v bWl0LWxhbWJkYS1wYXJlbikgT21pdCBwYXJhbnRoZXNlcyBmb3IgYSBDKysgbGFtYmRhIHdoZW5l dmVyIHBvc3NpYmxlCisKKyMjIyMjIyBSaWdodDoKKworYGBgY3BwCitbdGhpc10geyByZXR1cm4g bV9tZW1iZXI7IH0KK1t0aGlzXSgpIG11dGFibGUgeyByZXR1cm4gZG9Xb3JrKFdURk1vdmUobV9v YmplY3QpKTsgfQorYGBgCisKKyMjIyMjIyBXcm9uZzoKKworYGBgY3BwCitbdGhpc10oKSB7IHJl dHVybiBtX21lbWJlcjsgfQorW10oKSB7IHJldHVybiBzdGF0aWNfY2FzdDx1bnNpZ25lZD4oLTEp OyB9CitgYGAKKwogIyMjIFBvaW50ZXJzIGFuZCBSZWZlcmVuY2VzCiAKIFtdKCNwb2ludGVycy1u b24tY3BwKSAqKlBvaW50ZXIgdHlwZXMgaW4gbm9uLUMrKyBjb2RlKioK