204009 2019-11-08 09:58:20 -0800 [Web Animations] Optimize animation resolution to not re-compute whether effects only contain accelerated animation properties 2019-11-11 16:59:04 -0800 1 1 1 Unclassified WebKit Animations Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=204010 InRadar P2 Normal --- 1 graouts graouts cdumez cmarcelo dbates dino esprehn+autocc ews-watchlist kangil.han webkit-bug-importer oldest_to_newest 1588692 0 graouts 2019-11-08 09:58:20 -0800 When resolving animations we re-compute whether all animated properties are accelerated to return the `shouldRecompositeLayer` flag in TreeResolver::createAnimatedElementUpdate. We should be able to expose such a property when keyframes on a KeyframeEffect change and then also store it on KeyframeEffectStack and compute that value when the stack is changed. 1588709 1 graouts 2019-11-08 10:22:24 -0800 Retitling because it will likely be enough to do it on just KeyframeEffect since we have to iterate through all the effects of a stack when resolving anyway. 1588772 2 graouts 2019-11-08 13:02:10 -0800 As it turns out KeyframeEffect already caches this information, we just need to use it! 1588773 3 383154 graouts 2019-11-08 13:04:08 -0800 Created attachment 383154 Patch 1588793 4 383154 dino 2019-11-08 13:18:29 -0800 Comment on attachment 383154 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383154&action=review > Source/WebCore/ChangeLog:9 > + of iterating over an effec'ts animated properties during resolution to get at the same information. typo 1588993 5 graouts 2019-11-09 03:05:30 -0800 Committed r252307: <https://trac.webkit.org/changeset/252307> 1589384 6 webkit-bug-importer 2019-11-11 16:59:04 -0800 <rdar://problem/57099367> 383154 2019-11-08 13:04:08 -0800 2019-11-08 13:18:29 -0800 Patch bug-204009-20191108220406.patch text/plain 2279 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyMjUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGYyY2E5YTM4NmZhZDYz ZjM2NjdiYjYwZWUzMTQ4ZTJiYzNiYjM5Yy4uYTJiNDg3ODc5YjMyNWYwZGI5YTU2NjdhOTc2Mjdm MDAxODRjNjgxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTExLTA4ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYiBBbmltYXRpb25z XSBPcHRpbWl6ZSBhbmltYXRpb24gcmVzb2x1dGlvbiB0byBub3QgcmUtY29tcHV0ZSB3aGV0aGVy IGVmZmVjdHMgb25seSBjb250YWluIGFjY2VsZXJhdGVkIGFuaW1hdGlvbiBwcm9wZXJ0aWVzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQwMDkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBIEtleWZyYW1l RWZmZWN0IGFscmVhZHkgZXhwb3NlcyB3aGV0aGVyIGl0IG9ubHkgYWZmZWN0cyBDU1MgcHJvcGVy dGllcyB0aGF0IGNhbiBiZSBhY2NlbGVyYXRlZCwgc28gdXNlIHRoaXMgaW5mb3JtYXRpb24gaW5z dGVhZAorICAgICAgICBvZiBpdGVyYXRpbmcgb3ZlciBhbiBlZmZlYyd0cyBhbmltYXRlZCBwcm9w ZXJ0aWVzIGR1cmluZyByZXNvbHV0aW9uIHRvIGdldCBhdCB0aGUgc2FtZSBpbmZvcm1hdGlvbi4g CisKKyAgICAgICAgTm8gdGVzdHMgb3IgY2hhbmdlcyB0byBleGlzdGVkIHRlc3QgZXhwZWN0YXRp b25zIGFzIHRoaXMgc2hvdWxkIG5vdCB5aWVsZCBhbnkgY2hhbmdlIGluIGJlaGF2aW9yLgorCisg ICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6YXBw bHlLZXlmcmFtZUVmZmVjdHMpOgorCiAyMDE5LTExLTA4ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0 c0BhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYiBBbmltYXRpb25zXSBVc2UgYSBrZXlmcmFtZSBl ZmZlY3Qgc3RhY2sgdG8gcmVzb2x2ZSBhbmltYXRpb25zIG9uIGFuIGVsZW1lbnQKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9F bGVtZW50LmNwcAppbmRleCBhODI2NjgxN2QyMzk0YjkzZWY0ZTI2M2ViNzE4ODc5YWRlMmVlYzcw Li45YjdkYmM3OTRjNjAyZDJlNmI2ZTcwMjZjYjAyYTYyNmZjMTljMjM0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0Vs ZW1lbnQuY3BwCkBAIC0zNzAzLDE3ICszNzAzLDggQEAgYm9vbCBFbGVtZW50OjphcHBseUtleWZy YW1lRWZmZWN0cyhSZW5kZXJTdHlsZSYgdGFyZ2V0U3R5bGUpCiAgICAgICAgIEFTU0VSVChlZmZl Y3QtPmFuaW1hdGlvbigpKTsKICAgICAgICAgZWZmZWN0LT5hbmltYXRpb24oKS0+cmVzb2x2ZSh0 YXJnZXRTdHlsZSk7CiAKLSAgICAgICAgaWYgKGhhc05vbkFjY2VsZXJhdGVkQW5pbWF0aW9uUHJv cGVydHkpCi0gICAgICAgICAgICBjb250aW51ZTsKLQotICAgICAgICAvLyBGSVhNRTogaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDAwOQotICAgICAgICAvLyBLZXlm cmFtZUVmZmVjdFN0YWNrIGFuZCBLZXlmcmFtZUVmZmVjdCBzaG91bGQgaW5kaWNhdGUgd2hldGhl ciBpdCBvbmx5IGNvbnRhaW5zIGFjY2VsZXJhdGVkIGFuaW1hdGlvbiBwcm9wZXJ0aWVzCi0gICAg ICAgIGZvciAoYXV0byBjc3NQcm9wZXJ0eUlkIDogZWZmZWN0LT5hbmltYXRlZFByb3BlcnRpZXMo KSkgewotICAgICAgICAgICAgaWYgKCFDU1NQcm9wZXJ0eUFuaW1hdGlvbjo6YW5pbWF0aW9uT2ZQ cm9wZXJ0eUlzQWNjZWxlcmF0ZWQoY3NzUHJvcGVydHlJZCkpIHsKLSAgICAgICAgICAgICAgICBo YXNOb25BY2NlbGVyYXRlZEFuaW1hdGlvblByb3BlcnR5ID0gdHJ1ZTsKLSAgICAgICAgICAgICAg ICBicmVhazsKLSAgICAgICAgICAgIH0KLSAgICAgICAgfQorICAgICAgICBpZiAoIWhhc05vbkFj Y2VsZXJhdGVkQW5pbWF0aW9uUHJvcGVydHkgJiYgIWVmZmVjdC0+aXNBY2NlbGVyYXRlZCgpKQor ICAgICAgICAgICAgaGFzTm9uQWNjZWxlcmF0ZWRBbmltYXRpb25Qcm9wZXJ0eSA9IHRydWU7CiAg ICAgfQogCiAgICAgcmV0dXJuICFoYXNOb25BY2NlbGVyYXRlZEFuaW1hdGlvblByb3BlcnR5Owo=