204002 2019-11-08 09:17:51 -0800 Remove invalid assertion in DFG's compileNewArray(). 2019-11-08 11:39:20 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer oldest_to_newest 1588659 0 mark.lam 2019-11-08 09:17:51 -0800 <rdar://problem/56973531> 1588730 1 383146 mark.lam 2019-11-08 11:15:43 -0800 Created attachment 383146 proposed patch. 1588731 2 383146 rmorisset 2019-11-08 11:17:49 -0800 Comment on attachment 383146 proposed patch. r=me 1588743 3 mark.lam 2019-11-08 11:38:40 -0800 Thanks for the review. Landed in r252247: <http://trac.webkit.org/r252247>. 383146 2019-11-08 11:15:43 -0800 2019-11-08 11:17:49 -0800 proposed patch. bug-204002.patch text/plain 2570 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUyMjM5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBA CisyMDE5LTExLTA4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW1vdmUgaW52YWxpZCBhc3NlcnRpb24gaW4gREZHJ3MgY29tcGlsZU5ld0FycmF5KCkuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDQwMDIKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzU2OTczNTMxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoZSBhc3NlcnRpb24gaXMgaW4gYW4gaWYgY2xhdXNlIGNv bmRpdGlvbmFsIG9uICFnbG9iYWxPYmplY3QtPmlzSGF2aW5nQUJhZFRpbWUoKS4KKyAgICAgICAg VGhlIGFzc2VydGlvbiB0ZXN0cyB0aGUgSW5kZXhpbmdUeXBlIG9mIGEgc3RydWN0dXJlIHJldHVy bmVkIGJ5CisgICAgICAgIGFycmF5U3RydWN0dXJlRm9ySW5kZXhpbmdUeXBlRHVyaW5nQWxsb2Nh dGlvbigpLiAgCisKKyAgICAgICAgSG93ZXZlciwgdGhlIHN0cnVjdHVyZXMgcmV0dXJuZWQgYnkg YXJyYXlTdHJ1Y3R1cmVGb3JJbmRleGluZ1R5cGVEdXJpbmdBbGxvY2F0aW9uKCkKKyAgICAgICAg bWF5IGhhdmUgc3RhcnRlZCB0cmFuc2l0aW9uaW5nIHRvIHRoZWlyIFNsb3dQdXQgdmFyaWFudCBi ZWNhdXNlIHRoZSBtdXRhdG9yIHdpbGwKKyAgICAgICAgYmUgaW1taW5lbnRseSBmaXJpbmcgdGhl IEhhdmluZ0FCYWRUaW1lIHdhdGNocG9pbnQsIGJ1dCBoYXZlbid0IGRvbmUgc28geWV0LgorICAg ICAgICBJbiBhIHJhY2UsIHRoZSBERkcgbWF5IHNlZSB0aGUgU2xvd1B1dCB2YXJpYW50cyBvZiB0 aGUgc3RydWN0dXJlcyBiZWZvcmUKKyAgICAgICAgaXNIYXZpbmdBQmFkVGltZSgpIHJldHVybnMg dHJ1ZS4gIEhlbmNlLCB0aGUgYXNzZXJ0aW9uIGlzIGludmFsaWQuCisKKyAgICAgICAgTm90ZSB0 aGF0IHRoZSBGVEwgZG9lcyBub3QgaGF2ZSB0aGlzIGFzc2VydGlvbi4KKworICAgICAgICBUaGlz IGlzc3VlIGlzIGFscmVhZHkgdGVzdGVkIGJ5IHN0cmVzcy9yYWN5LXNsb3ctcHV0LWNsb25lZC1h cmd1bWVudHMtd2hlbi1oYXZpbmctYS1iYWQtdGltZS5qcy4KKworICAgICAgICAqIGRmZy9ERkdT cGVjdWxhdGl2ZUpJVC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNv bXBpbGVOZXdBcnJheSk6CisKIDIwMTktMTEtMDcgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUu Y29tPgogCiAgICAgICAgIEFkZCBhIHN0YWNrIG92ZXJmbG93IGNoZWNrIGluIFlhcnI6OkJ5dGVD b21waWxlcjo6ZW1pdERpc2p1bmN0aW9uKCkuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAkocmV2aXNpb24gMjUyMjM4KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTc5NzgsMTIgKzc5NzgsNiBAQCB2b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxlTmV3 QXJyYXkoTm9kCiAgICAgSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCA9IG1faml0LmdyYXBo KCkuZ2xvYmFsT2JqZWN0Rm9yKG5vZGUtPm9yaWdpbi5zZW1hbnRpYyk7CiAgICAgUmVnaXN0ZXJl ZFN0cnVjdHVyZSBzdHJ1Y3R1cmUgPSBtX2ppdC5ncmFwaCgpLnJlZ2lzdGVyU3RydWN0dXJlKGds b2JhbE9iamVjdC0+YXJyYXlTdHJ1Y3R1cmVGb3JJbmRleGluZ1R5cGVEdXJpbmdBbGxvY2F0aW9u KG5vZGUtPmluZGV4aW5nVHlwZSgpKSk7CiAgICAgaWYgKCFnbG9iYWxPYmplY3QtPmlzSGF2aW5n QUJhZFRpbWUoKSAmJiAhaGFzQW55QXJyYXlTdG9yYWdlKG5vZGUtPmluZGV4aW5nVHlwZSgpKSkg ewotICAgICAgICBBU1NFUlQoCi0gICAgICAgICAgICBoYXNVbmRlY2lkZWQoc3RydWN0dXJlLT5p bmRleGluZ1R5cGUoKSkKLSAgICAgICAgICAgIHx8IGhhc0ludDMyKHN0cnVjdHVyZS0+aW5kZXhp bmdUeXBlKCkpCi0gICAgICAgICAgICB8fCBoYXNEb3VibGUoc3RydWN0dXJlLT5pbmRleGluZ1R5 cGUoKSkKLSAgICAgICAgICAgIHx8IGhhc0NvbnRpZ3VvdXMoc3RydWN0dXJlLT5pbmRleGluZ1R5 cGUoKSkpOwotCiAgICAgICAgIHVuc2lnbmVkIG51bUVsZW1lbnRzID0gbm9kZS0+bnVtQ2hpbGRy ZW4oKTsKICAgICAgICAgdW5zaWduZWQgdmVjdG9yTGVuZ3RoSGludCA9IG5vZGUtPnZlY3Rvckxl bmd0aEhpbnQoKTsKICAgICAgICAgQVNTRVJUKHZlY3Rvckxlbmd0aEhpbnQgPj0gbnVtRWxlbWVu dHMpOwo=