204000 2019-11-08 08:07:54 -0800 Many legacy animation tests are timing out with VS2019 2019-11-14 17:45:43 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 197288 1 pvollan pvollan aakash_jain ap bfulgham commit-queue dino dstockwell ews-watchlist fujii simon.fraser tsavell webkit-bug-importer oldest_to_newest 1588647 0 pvollan 2019-11-08 08:07:54 -0800 When building WebKit with VS2019, many legacy animation tests are timing out. 1589021 1 383222 pvollan 2019-11-09 10:21:37 -0800 Created attachment 383222 Patch 1589323 2 383222 bfulgham 2019-11-11 14:24:26 -0800 Comment on attachment 383222 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383222&action=review > Source/WebCore/page/animation/KeyframeAnimation.cpp:522 > +#endif Do we need this for ImplicitAnimation::timeToNextService, too? 1589325 3 383222 bfulgham 2019-11-11 14:32:02 -0800 Comment on attachment 383222 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383222&action=review >> Source/WebCore/page/animation/KeyframeAnimation.cpp:522 >> +#endif > > Do we need this for ImplicitAnimation::timeToNextService, too? That method has the same logic for early return. 1589328 4 pvollan 2019-11-11 14:34:59 -0800 (In reply to Brent Fulgham from comment #3) > Comment on attachment 383222 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=383222&action=review > > >> Source/WebCore/page/animation/KeyframeAnimation.cpp:522 > >> +#endif > > > > Do we need this for ImplicitAnimation::timeToNextService, too? > > That method has the same logic for early return. Good catch! I will check if that is needed. 1589403 5 383322 pvollan 2019-11-11 17:13:38 -0800 Created attachment 383322 Patch 1589404 6 pvollan 2019-11-11 17:14:35 -0800 (In reply to Brent Fulgham from comment #2) > Comment on attachment 383222 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=383222&action=review > > > Source/WebCore/page/animation/KeyframeAnimation.cpp:522 > > +#endif > > Do we need this for ImplicitAnimation::timeToNextService, too? Fixed. Thanks for reviewing! 1589431 7 383322 commit-queue 2019-11-11 17:58:59 -0800 Comment on attachment 383322 Patch Clearing flags on attachment: 383322 Committed r252352: <https://trac.webkit.org/changeset/252352> 1589498 8 aakash_jain 2019-11-12 06:33:15 -0800 > Committed r252352: <https://trac.webkit.org/changeset/252352> Did you meant to close the bug as well? 1589576 9 pvollan 2019-11-12 10:53:33 -0800 (In reply to Aakash Jain from comment #8) > > Committed r252352: <https://trac.webkit.org/changeset/252352> > Did you meant to close the bug as well? Yes, thanks! 1589577 10 webkit-bug-importer 2019-11-12 10:54:16 -0800 <rdar://problem/57122380> 383222 2019-11-09 10:21:37 -0800 2019-11-11 14:31:35 -0800 Patch bug-204000-20191109102136.patch text/plain 1666 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1MjMwOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE5LTExLTA5ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBNYW55IGxlZ2FjeSBhbmlt YXRpb24gdGVzdHMgYXJlIHRpbWluZyBvdXQgd2l0aCBWUzIwMTkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDAwMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gY29tcGlsaW5nIHdpdGggVlMyMDE5 LCB0aGVyZSBpcyBhIGNvbXBpbGVyIGlzc3VlLCB3aGVyZSBhbiBPcHRpb25hbCB3aXRob3V0IGEg dmFsdWUgaXMgcmV0dXJuZWQKKyAgICAgICAgd2hlbiBpdCBzaG91bGQgZGVmaW5pdGVseSBoYXZl IGEgdmFsdWUuIFdvcmsgYXJvdW5kIHRoaXMgaXNzdWUgYnkgbW92aW5nIHRoZSBsb2NhbCBPcHRp b25hbCB2YWx1ZQorICAgICAgICB3aGVuIHJldHVybmluZy4KKworICAgICAgICBObyBuZXcgdGVz dHMsIGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBwYWdlL2FuaW1hdGlv bi9LZXlmcmFtZUFuaW1hdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpLZXlmcmFtZUFuaW1h dGlvbjo6dGltZVRvTmV4dFNlcnZpY2UpOgorCiAyMDE5LTExLTA5ICBBbnR0aSBLb2l2aXN0byAg PGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlIHN0eWxlIGFkanVzdG1lbnQgY29kZSBv dXQgb2YgU3R5bGVSZXNvbHZlciBhbmQgaW50byBhIGNsYXNzIG9mIGl0cyBvd24KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0tleWZyYW1lQW5pbWF0aW9uLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9LZXlmcmFtZUFuaW1hdGlvbi5j cHAJKHJldmlzaW9uIDI1MjI0NCkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0tl eWZyYW1lQW5pbWF0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTE1LDcgKzUxNSwxMSBAQCBP cHRpb25hbDxTZWNvbmRzPiBLZXlmcmFtZUFuaW1hdGlvbjo6dGltCiB7CiAgICAgT3B0aW9uYWw8 U2Vjb25kcz4gdCA9IEFuaW1hdGlvbkJhc2U6OnRpbWVUb05leHRTZXJ2aWNlKCk7CiAgICAgaWYg KCF0IHx8IHQudmFsdWUoKSAhPSAwX3MgfHwgcHJlQWN0aXZlKCkpCisjaWYgQ09NUElMRVIoTVNW QykgJiYgX01TQ19WRVIgPj0gMTkyMAorICAgICAgICByZXR1cm4gV1RGTW92ZSh0KTsKKyNlbHNl CiAgICAgICAgIHJldHVybiB0OworI2VuZGlmCiAKICAgICAvLyBBIHJldHVybiB2YWx1ZSBvZiAw IG1lYW5zIHdlIG5lZWQgc2VydmljZS4gQnV0IGlmIHdlIG9ubHkgaGF2ZSBhY2NlbGVyYXRlZCBh bmltYXRpb25zIHdlIAogICAgIC8vIG9ubHkgbmVlZCBzZXJ2aWNlIGF0IHRoZSBlbmQgb2YgdGhl IHRyYW5zaXRpb24uCg== 383322 2019-11-11 17:13:38 -0800 2019-11-11 17:58:59 -0800 Patch bug-204000-20191111171338.patch text/plain 2486 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1MjM0NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE5LTExLTExICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBNYW55IGxlZ2FjeSBhbmlt YXRpb24gdGVzdHMgYXJlIHRpbWluZyBvdXQgd2l0aCBWUzIwMTkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNDAwMAorCisgICAgICAgIFJldmlld2Vk IGJ5IEJyZW50IEZ1bGdoYW0uCisKKyAgICAgICAgV2hlbiBjb21waWxpbmcgd2l0aCBWUzIwMTks IHRoZXJlIGlzIGEgY29tcGlsZXIgaXNzdWUsIHdoZXJlIGFuIE9wdGlvbmFsIHdpdGhvdXQgYSB2 YWx1ZSBpcyByZXR1cm5lZAorICAgICAgICB3aGVuIGl0IHNob3VsZCBkZWZpbml0ZWx5IGhhdmUg YSB2YWx1ZS4gV29yayBhcm91bmQgdGhpcyBpc3N1ZSBieSBtb3ZpbmcgdGhlIGxvY2FsIE9wdGlv bmFsIHZhbHVlCisgICAgICAgIHdoZW4gcmV0dXJuaW5nLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cywgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHBhZ2UvYW5pbWF0aW9u L0ltcGxpY2l0QW5pbWF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltcGxpY2l0QW5pbWF0 aW9uOjp0aW1lVG9OZXh0U2VydmljZSk6CisgICAgICAgICogcGFnZS9hbmltYXRpb24vS2V5ZnJh bWVBbmltYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6S2V5ZnJhbWVBbmltYXRpb246OnRp bWVUb05leHRTZXJ2aWNlKToKKwogMjAxOS0xMS0xMSAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFw cGxlLmNvbT4KIAogICAgICAgICBBU1NFUlQgYXQgUGxhdGZvcm1DQUxheWVyQ29jb2E6OmF2UGxh eWVyTGF5ZXIoKTogW3BsYXRmb3JtTGF5ZXIoKSBzdWJsYXllcnNdLmNvdW50ID09IDEKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0ltcGxpY2l0QW5pbWF0aW9uLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9JbXBsaWNpdEFuaW1hdGlv bi5jcHAJKHJldmlzaW9uIDI1MjM0NikKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9u L0ltcGxpY2l0QW5pbWF0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzYwLDcgKzM2MCwxMSBA QCBPcHRpb25hbDxTZWNvbmRzPiBJbXBsaWNpdEFuaW1hdGlvbjo6dGltCiB7CiAgICAgT3B0aW9u YWw8U2Vjb25kcz4gdCA9IEFuaW1hdGlvbkJhc2U6OnRpbWVUb05leHRTZXJ2aWNlKCk7CiAgICAg aWYgKCF0IHx8IHQudmFsdWUoKSAhPSAwX3MgfHwgcHJlQWN0aXZlKCkpCisjaWYgQ09NUElMRVIo TVNWQykgJiYgX01TQ19WRVIgPj0gMTkyMAorICAgICAgICByZXR1cm4gV1RGTW92ZSh0KTsKKyNl bHNlCiAgICAgICAgIHJldHVybiB0OworI2VuZGlmCiAKICAgICAvLyBBIHJldHVybiB2YWx1ZSBv ZiAwIG1lYW5zIHdlIG5lZWQgc2VydmljZS4gQnV0IGlmIHRoaXMgaXMgYW4gYWNjZWxlcmF0ZWQg YW5pbWF0aW9uIHdlIAogICAgIC8vIG9ubHkgbmVlZCBzZXJ2aWNlIGF0IHRoZSBlbmQgb2YgdGhl IHRyYW5zaXRpb24uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9LZXlmcmFt ZUFuaW1hdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9hbmltYXRp b24vS2V5ZnJhbWVBbmltYXRpb24uY3BwCShyZXZpc2lvbiAyNTIzNDYpCisrKyBTb3VyY2UvV2Vi Q29yZS9wYWdlL2FuaW1hdGlvbi9LZXlmcmFtZUFuaW1hdGlvbi5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTUxNSw3ICs1MTUsMTEgQEAgT3B0aW9uYWw8U2Vjb25kcz4gS2V5ZnJhbWVBbmltYXRpb246 OnRpbQogewogICAgIE9wdGlvbmFsPFNlY29uZHM+IHQgPSBBbmltYXRpb25CYXNlOjp0aW1lVG9O ZXh0U2VydmljZSgpOwogICAgIGlmICghdCB8fCB0LnZhbHVlKCkgIT0gMF9zIHx8IHByZUFjdGl2 ZSgpKQorI2lmIENPTVBJTEVSKE1TVkMpICYmIF9NU0NfVkVSID49IDE5MjAKKyAgICAgICAgcmV0 dXJuIFdURk1vdmUodCk7CisjZWxzZQogICAgICAgICByZXR1cm4gdDsKKyNlbmRpZgogCiAgICAg Ly8gQSByZXR1cm4gdmFsdWUgb2YgMCBtZWFucyB3ZSBuZWVkIHNlcnZpY2UuIEJ1dCBpZiB3ZSBv bmx5IGhhdmUgYWNjZWxlcmF0ZWQgYW5pbWF0aW9ucyB3ZSAKICAgICAvLyBvbmx5IG5lZWQgc2Vy dmljZSBhdCB0aGUgZW5kIG9mIHRoZSB0cmFuc2l0aW9uLgo=