203999 2019-11-08 08:06:39 -0800 [macOS] Add logging and telemetry to mach lookup rules 2022-02-28 04:10:51 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue webkit-bug-importer oldest_to_newest 1588645 0 pvollan 2019-11-08 08:06:39 -0800 Add logging and telemetry to help determine if mach lookup can be denied in the WebContent process. 1588646 1 webkit-bug-importer 2019-11-08 08:07:16 -0800 <rdar://problem/57021686> 1588651 2 383127 pvollan 2019-11-08 08:15:57 -0800 Created attachment 383127 Patch 1588725 3 383127 bfulgham 2019-11-08 11:02:37 -0800 Comment on attachment 383127 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383127&action=review r=me > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:601 > +) These look fine, but we seem to be hitting test failures (which seems crazy to me). Can you double-check we don't have a syntax error in the sandbox? 1588732 4 pvollan 2019-11-08 11:18:04 -0800 (In reply to Brent Fulgham from comment #3) > Comment on attachment 383127 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=383127&action=review > > r=me > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:601 > > +) > > These look fine, but we seem to be hitting test failures (which seems crazy > to me). Can you double-check we don't have a syntax error in the sandbox? Yes, investigating now :) Thanks for reviewing! 1588742 5 383148 pvollan 2019-11-08 11:38:11 -0800 Created attachment 383148 Patch 1588806 6 383148 commit-queue 2019-11-08 13:35:18 -0800 Comment on attachment 383148 Patch Clearing flags on attachment: 383148 Committed r252261: <https://trac.webkit.org/changeset/252261> 383127 2019-11-08 08:15:57 -0800 2022-02-28 04:10:51 -0800 Patch bug-203999-20191108081556.patch text/plain 3306 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTIyMzgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTExLTA4ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIFtpT1NdIEFkZCBs b2dnaW5nIGFuZCB0ZWxlbWV0cnkgdG8gbWFjaCBsb29rdXAgcnVsZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzk5OQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBsb2dnaW5nIGFuZCB0ZWxlbWV0 cnkgdG8gaGVscCBkZXRlcm1pbmUgaWYgbWFjaCBsb29rdXBzIHRvIGEgc2V0IG9mIHNlcnZpY2Vz IGNhbiBiZSBkZW5pZWQgaW4gdGhlIFdlYkNvbnRlbnQgcHJvY2Vzcy4KKworICAgICAgICBObyBu ZXcgdGVzdHMsIHNpbmNlIHRoaXMgb25seSBhZGRzIGxvZ2dpbmcgYW5kIHRlbGVtZXRyeS4KKwor ICAgICAgICAqIFdlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW46CisKIDIwMTkt MTEtMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtHVEtdIEFkZCBwb2ludGVyIGxvY2sgcGVybWlzc2lvbiByZXF1ZXN0IEFQSQpJbmRleDog U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5z Yi5pbgkocmV2aXNpb24gMjUyMjM4KQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5h cHBsZS5XZWJQcm9jZXNzLnNiLmluCSh3b3JraW5nIGNvcHkpCkBAIC01ODcsNiArNTg3LDE5IEBA CiAoYWxsb3cgbWFjaC1sb29rdXAKICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS53ZWJp bnNwZWN0b3IiKSkKIAorKGFsbG93IG1hY2gtbG9va3VwICh3aXRoIHJlcG9ydCkgKHdpdGggdGVs ZW1ldHJ5KQorICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmF1ZGlvLkF1ZGlvQ29tcG9uZW50 UmVnaXN0cmFyIikKKyAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5hd2RkIikKKyAgICAoZ2xv YmFsLW5hbWUgImNvbS5hcHBsZS5jZnByZWZzZC5hZ2VudCIpCisgICAgKGdsb2JhbC1uYW1lICJj b20uYXBwbGUuY29va2llZCIpCisgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuZGlhZ25vc3Rp Y2QiKQorICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmljb25zZXJ2aWNlcyIpCisgICAgKGds b2JhbC1uYW1lICJjb20uYXBwbGUuaWNvbnNlcnZpY2VzLnN0b3JlIikKKyAgICAoZ2xvYmFsLW5h bWUgImNvbS5hcHBsZS5tb2JpbGVhc3NldGQiKQorICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxl LnBvd2VybG9nLnBseHBjbG9nZ2VyLnhwYyIpCisgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUu c3lzdGVtLmxvZ2dlciIpCispCisKIDs7IFZhcmlvdXMgc2VydmljZXMgcmVxdWlyZWQgYnkgQXBw S2l0IGFuZCBvdGhlciBmcmFtZXdvcmtzCiAoYWxsb3cgbWFjaC1sb29rdXAKICNpZiBfX01BQ19P U19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEIDwgMTAxNDAwCkBAIC01OTUsMjggKzYwOCwxOCBAQAog ICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLlBvd2VyTWFuYWdlbWVudC5jb250cm9sIikK ICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5TeXN0ZW1Db25maWd1cmF0aW9uLmNvbmZp Z2QiKQogICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmFuYWx5dGljc2QiKQotICAgICAg IChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmF1ZGlvLkF1ZGlvQ29tcG9uZW50UmVnaXN0cmFyIikK ICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5hc3NlcnRpb25kLnByb2Nlc3Nhc3NlcnRp b25jb25uZWN0aW9uIikKICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5hdWRpby5TeXN0 ZW1Tb3VuZFNlcnZlci1PU1giKQogICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmF1ZGlv LmF1ZGlvaGFsZCIpCi0gICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuYXdkZCIpCi0gICAg ICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuY2ZwcmVmc2QuYWdlbnQiKQogICAgICAgIChnbG9i YWwtbmFtZSAiY29tLmFwcGxlLmNmcHJlZnNkLmRhZW1vbiIpCiAgICAgICAgKGdsb2JhbC1uYW1l ICJjb20uYXBwbGUuY21pby5yZWdpc3RlcmFzc2lzdGFudHNlcnZpY2UiKSA7OyBOZWVkZWQgYnkg Q29yZU1lZGlhIGZvciBwbHVnaW4gZHJpdmVycwotICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFw cGxlLmNvb2tpZWQiKQogICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmNvcmVzZXJ2aWNl cy5sYXVuY2hzZXJ2aWNlc2QiKQotICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmRpYWdu b3N0aWNkIikKICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5mb250cyIpCi0gICAgICAg KGdsb2JhbC1uYW1lICJjb20uYXBwbGUuaWNvbnNlcnZpY2VzIikKLSAgICAgICAoZ2xvYmFsLW5h bWUgImNvbS5hcHBsZS5pY29uc2VydmljZXMuc3RvcmUiKQogICAgICAgIChnbG9iYWwtbmFtZSAi Y29tLmFwcGxlLm1lZGlhcmVtb3RlZC54cGMiKQogICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFw cGxlLmxvZ2QiKQogICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmxvZ2QuZXZlbnRzIikK ICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5sc2QubWFwZGIiKQogICAgICAgIChnbG9i YWwtbmFtZSAiY29tLmFwcGxlLmxza2RkIikgOzsgPHJkYXI6Ly9wcm9ibGVtLzQ5MTIzODU1Pgot ICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLm1vYmlsZWFzc2V0ZCIpCi0gICAgICAgKGds b2JhbC1uYW1lICJjb20uYXBwbGUucG93ZXJsb2cucGx4cGNsb2dnZXIueHBjIikKLSAgICAgICAo Z2xvYmFsLW5hbWUgImNvbS5hcHBsZS5zeXN0ZW0ubG9nZ2VyIikKICAgICAgICAoZ2xvYmFsLW5h bWUgImNvbS5hcHBsZS50Y2NkIikKICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS50Y2Nk LnN5c3RlbSIpCiAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUudHJ1c3RkLmFnZW50IikK 383148 2019-11-08 11:38:11 -0800 2019-11-08 13:35:18 -0800 Patch bug-203999-20191108113810.patch text/plain 3365 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTIyNDYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTExLTA4ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIFtpT1NdIEFkZCBs b2dnaW5nIGFuZCB0ZWxlbWV0cnkgdG8gbWFjaCBsb29rdXAgcnVsZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzk5OQorCisgICAgICAgIFJldmll d2VkIGJ5IEJyZW50IEZ1bGdoYW0uCisKKyAgICAgICAgQWRkIGxvZ2dpbmcgYW5kIHRlbGVtZXRy eSB0byBoZWxwIGRldGVybWluZSBpZiBtYWNoIGxvb2t1cHMgdG8gYSBzZXQgb2Ygc2VydmljZXMg Y2FuIGJlIGRlbmllZCBpbiB0aGUgV2ViQ29udGVudCBwcm9jZXNzLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cywgc2luY2UgdGhpcyBvbmx5IGFkZHMgbG9nZ2luZyBhbmQgdGVsZW1ldHJ5LgorCisg ICAgICAgICogV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbjoKKwogMjAxOS0x MS0wOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAg ICAgW0dUS10gQWRkIHBvaW50ZXIgbG9jayBwZXJtaXNzaW9uIHJlcXVlc3QgQVBJCkluZGV4OiBT b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNi LmluCShyZXZpc2lvbiAyNTIyNDYpCisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFw cGxlLldlYlByb2Nlc3Muc2IuaW4JKHdvcmtpbmcgY29weSkKQEAgLTU4Nyw2ICs1ODcsMjIgQEAK IChhbGxvdyBtYWNoLWxvb2t1cAogICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLndlYmlu c3BlY3RvciIpKQogCisoYWxsb3cgbWFjaC1sb29rdXAKKyNpZiBfX01BQ19PU19YX1ZFUlNJT05f TUlOX1JFUVVJUkVEID49IDEwMTUwMAorICAgICh3aXRoIHJlcG9ydCkgKHdpdGggdGVsZW1ldHJ5 KQorI2VuZGlmCisgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuYXVkaW8uQXVkaW9Db21wb25l bnRSZWdpc3RyYXIiKQorICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmF3ZGQiKQorICAgIChn bG9iYWwtbmFtZSAiY29tLmFwcGxlLmNmcHJlZnNkLmFnZW50IikKKyAgICAoZ2xvYmFsLW5hbWUg ImNvbS5hcHBsZS5jb29raWVkIikKKyAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5kaWFnbm9z dGljZCIpCisgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuaWNvbnNlcnZpY2VzIikKKyAgICAo Z2xvYmFsLW5hbWUgImNvbS5hcHBsZS5pY29uc2VydmljZXMuc3RvcmUiKQorICAgIChnbG9iYWwt bmFtZSAiY29tLmFwcGxlLm1vYmlsZWFzc2V0ZCIpCisgICAgKGdsb2JhbC1uYW1lICJjb20uYXBw bGUucG93ZXJsb2cucGx4cGNsb2dnZXIueHBjIikKKyAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBs ZS5zeXN0ZW0ubG9nZ2VyIikKKykKKwogOzsgVmFyaW91cyBzZXJ2aWNlcyByZXF1aXJlZCBieSBB cHBLaXQgYW5kIG90aGVyIGZyYW1ld29ya3MKIChhbGxvdyBtYWNoLWxvb2t1cAogI2lmIF9fTUFD X09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAxMDE0MDAKQEAgLTU5NSwyOCArNjExLDE4IEBA CiAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuUG93ZXJNYW5hZ2VtZW50LmNvbnRyb2wi KQogICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLlN5c3RlbUNvbmZpZ3VyYXRpb24uY29u ZmlnZCIpCiAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuYW5hbHl0aWNzZCIpCi0gICAg ICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuYXVkaW8uQXVkaW9Db21wb25lbnRSZWdpc3RyYXIi KQogICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmFzc2VydGlvbmQucHJvY2Vzc2Fzc2Vy dGlvbmNvbm5lY3Rpb24iKQogICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmF1ZGlvLlN5 c3RlbVNvdW5kU2VydmVyLU9TWCIpCiAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuYXVk aW8uYXVkaW9oYWxkIikKLSAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5hd2RkIikKLSAg ICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5jZnByZWZzZC5hZ2VudCIpCiAgICAgICAgKGds b2JhbC1uYW1lICJjb20uYXBwbGUuY2ZwcmVmc2QuZGFlbW9uIikKICAgICAgICAoZ2xvYmFsLW5h bWUgImNvbS5hcHBsZS5jbWlvLnJlZ2lzdGVyYXNzaXN0YW50c2VydmljZSIpIDs7IE5lZWRlZCBi eSBDb3JlTWVkaWEgZm9yIHBsdWdpbiBkcml2ZXJzCi0gICAgICAgKGdsb2JhbC1uYW1lICJjb20u YXBwbGUuY29va2llZCIpCiAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuY29yZXNlcnZp Y2VzLmxhdW5jaHNlcnZpY2VzZCIpCi0gICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuZGlh Z25vc3RpY2QiKQogICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmZvbnRzIikKLSAgICAg ICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5pY29uc2VydmljZXMiKQotICAgICAgIChnbG9iYWwt bmFtZSAiY29tLmFwcGxlLmljb25zZXJ2aWNlcy5zdG9yZSIpCiAgICAgICAgKGdsb2JhbC1uYW1l ICJjb20uYXBwbGUubWVkaWFyZW1vdGVkLnhwYyIpCiAgICAgICAgKGdsb2JhbC1uYW1lICJjb20u YXBwbGUubG9nZCIpCiAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUubG9nZC5ldmVudHMi KQogICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmxzZC5tYXBkYiIpCiAgICAgICAgKGds b2JhbC1uYW1lICJjb20uYXBwbGUubHNrZGQiKSA7OyA8cmRhcjovL3Byb2JsZW0vNDkxMjM4NTU+ Ci0gICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUubW9iaWxlYXNzZXRkIikKLSAgICAgICAo Z2xvYmFsLW5hbWUgImNvbS5hcHBsZS5wb3dlcmxvZy5wbHhwY2xvZ2dlci54cGMiKQotICAgICAg IChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLnN5c3RlbS5sb2dnZXIiKQogICAgICAgIChnbG9iYWwt bmFtZSAiY29tLmFwcGxlLnRjY2QiKQogICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLnRj Y2Quc3lzdGVtIikKICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS50cnVzdGQuYWdlbnQi KQo=