203995 2019-11-08 07:05:13 -0800 Regression r252209: Layout Test fast/workers/worker-close-more.html is failing 2019-11-08 10:24:32 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=203960 InRadar P2 Normal --- 1 aakash_jain cdumez aakash_jain achristensen cdumez commit-queue ggaren rniwa tsavell webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1588626 0 aakash_jain 2019-11-08 07:05:13 -0800 The following layout test is failing on all the platforms: fast/workers/worker-close-more.html Flakiness Dashboard: https://results.webkit.org/?suite=layout-tests&test=fast%2Fworkers%2Fworker-close-more.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fworkers%2Fworker-close-more.html Probable cause: It passed in r252208 and failed in r252210. Most likely a regression from r252209 https://trac.webkit.org/changeset/252209/webkit https://bugs.webkit.org/show_bug.cgi?id=203960 'Port MessagePort to the HTML5 event loop' 1588627 1 aakash_jain 2019-11-08 07:05:39 -0800 Sample failure: https://ews-build.webkit.org/results/macOS-High-Sierra-Debug-WK1-Tests-EWS/r383034-6067-clean-tree/results.html Diff: PASS: workerThreadCount = 0 PASS: MessagePort multiple message test, received message: echo_ping1 +FAIL: The MessagePort message was dispatched after a JS fragment that called 'close()' exited. +PASS: MessagePort messages were not delivered asfter close(). +DONE PASS: MessagePort messages were not delivered asfter close(). DONE 1588629 2 webkit-bug-importer 2019-11-08 07:08:04 -0800 <rdar://problem/57020558> 1588644 3 cdumez 2019-11-08 08:05:21 -0800 Looking. 1588650 4 cdumez 2019-11-08 08:15:44 -0800 I think WorkerMessagingProxy::workerGlobalScopeClosed() needs to be ported to the Event Loop too, or the ordering between posting a message and closing the worker global scope is no longer correct. I will confirm. 1588657 5 383130 cdumez 2019-11-08 09:15:12 -0800 Created attachment 383130 Patch 1588711 6 383130 commit-queue 2019-11-08 10:24:30 -0800 Comment on attachment 383130 Patch Clearing flags on attachment: 383130 Committed r252242: <https://trac.webkit.org/changeset/252242> 1588712 7 commit-queue 2019-11-08 10:24:32 -0800 All reviewed patches have been landed. Closing bug. 383130 2019-11-08 09:15:12 -0800 2019-11-08 10:24:30 -0800 Patch bug-203995-20191108091511.patch text/plain 1544 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyMjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODEyNjdmODU3ZjFkMzEw NmE4ZjM4NzNmMzE4ZmIyNjA5MzFiZWE0Ny4uZjkxZWFmMGI0NTFlZDA0NWQyYjBlMGRlODY1ZDJl ODhmYjkzMDhhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTExLTA4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbiByMjUyMjA5 OiBMYXlvdXQgVGVzdCBmYXN0L3dvcmtlcnMvd29ya2VyLWNsb3NlLW1vcmUuaHRtbCBpcyBmYWls aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDM5 OTUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU3MDIwNTU4PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHNob3VsZCBub3QgZGlzcGF0Y2ggZXZl bnRzIG9uIGEgTWVzc2FnZVBvcnQgb2JqZWN0cyBpbiBhIFdvcmtlckdsb2JhbFNjb3BlIHdoaWNo IGlzCisgICAgICAgIGNsb3NpbmcgKGkuZS4gV29ya2VyR2xvYmFsU2NvcGUuY2xvc2UoKSBoYXMg YmVlbiBjYWxsZWQpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgY292ZXJlZCBieSBmYXN0L3dv cmtlcnMvd29ya2VyLWNsb3NlLW1vcmUuaHRtbC4KKworICAgICAgICAqIGRvbS9NZXNzYWdlUG9y dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZXNzYWdlUG9ydDo6ZGlzcGF0Y2hFdmVudCk6CisK IDIwMTktMTEtMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CiAgICAgICAgICdTdHJpa2V0aHJvdWdoJyBlZGl0aW5nIGNvbW1hbmQgcmVwb3J0ZWQgYXMgJ2Zv cm1hdFVuZGVybGluZScKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9NZXNzYWdlUG9y dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTWVzc2FnZVBvcnQuY3BwCmluZGV4IDI0NDQ5NDk3 ZDNjYzE1NTY1ZTViYmRmYTczOWVjYTA1ZGNkODA5YmUuLmQ0M2IyNjJiNzIyNjc1OGViNjE1OWIy OGI2YmNlNjE4NmI5NjJkM2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9NZXNzYWdl UG9ydC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL01lc3NhZ2VQb3J0LmNwcApAQCAtMjg4 LDYgKzI4OCw5IEBAIHZvaWQgTWVzc2FnZVBvcnQ6OmRpc3BhdGNoRXZlbnQoRXZlbnQmIGV2ZW50 KQogICAgIGlmIChtX2Nsb3NlZCkKICAgICAgICAgcmV0dXJuOwogCisgICAgaWYgKGlzPFdvcmtl ckdsb2JhbFNjb3BlPigqbV9zY3JpcHRFeGVjdXRpb25Db250ZXh0KSAmJiBkb3duY2FzdDxXb3Jr ZXJHbG9iYWxTY29wZT4oKm1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dCkuaXNDbG9zaW5nKCkpCisg ICAgICAgIHJldHVybjsKKwogICAgIEV2ZW50VGFyZ2V0OjpkaXNwYXRjaEV2ZW50KGV2ZW50KTsK IH0KIAo=