203991 2019-11-07 22:43:49 -0800 Safari leaks memory of Cache/Response objects of CacheStorage API 2020-03-24 02:07:52 -0700 1 1 1 Unclassified WebKit New Bugs Safari Technology Preview Unspecified Unspecified RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 1 mail webkit-unassigned cdumez ddkilzer joepeck koivisto rniwa webkit-bug-importer youennf oldest_to_newest 1588579 0 383113 mail 2019-11-07 22:43:49 -0800 Created attachment 383113 Memory leak with CacheStorage/Cache/Response When using the CacheStorage API and calling `cache.keys()` to retrieve all items stored in a cache, Safari won't free the memory of those objects. The attached sample page opens the Cache repeatedly, and requests keys. Memory grows to several gigabytes in the span of a few seconds. 1604229 1 webkit-bug-importer 2020-01-08 12:16:38 -0800 <rdar://problem/58417259> 1604592 2 youennf 2020-01-09 06:46:44 -0800 Doing a quick test, the script creates lots of objects that at some point gets collected. I do not see a leak per se although we should probably try to improve memory management, in particular not send response body until actually requested by the page. Konstantin, can you validate that memory consumption does not increase forever on your setup as well? 1604594 3 mail 2020-01-09 06:51:41 -0800 Thanks for looking into this issue. It looks like it's growing linearly until ~3GB on my machine, then some objects are garbage collected. It seems like the garbage collector isn't aware of the true size of these objects, so it doesn't collect them even though they take up a lot of memory. 1633255 4 youennf 2020-03-24 02:07:52 -0700 I removed buffering of request/response in https://bugs.webkit.org/show_bug.cgi?id=209425. That should help this. 383113 2019-11-07 22:43:49 -0800 2019-11-07 22:43:49 -0800 Memory leak with CacheStorage/Cache/Response cache.html text/html 712 mail PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KICAgIDxtZXRhIGNoYXJzZXQ9J3V0Zi04JyAv PgogICAgPHRpdGxlPkNhY2hlU3RvcmFnZSBtZW1vcnkgbGVhazwvdGl0bGU+CjwvaGVhZD4KPGJv ZHk+CjxzY3JpcHQ+CgovLyBJbnNlcnQgYSBmZXcgZWxlbWVudHMgaW50byB0aGUgY2FjaGUsIHRo ZW4gc3RhcnQgcmVxdWVzdGluZyBpdGVtcy4Kd2luZG93LmNhY2hlcy5vcGVuKCd0ZXN0JykKICAg IC50aGVuKGNhY2hlID0+IHsKICAgICAgICBQcm9taXNlLmFsbChbLi4uQXJyYXkoMjUpLmtleXMo KV0ubWFwKG5hbWUgPT4gewogICAgICAgICAgICBjb25zdCBidWZmZXIgPSBuZXcgQXJyYXlCdWZm ZXIoMTAyNCAqIDEwMjQpOwogICAgICAgICAgICBjYWNoZS5wdXQoYGh0dHA6Ly9leGFtcGxlLmNv bS8ke25hbWV9YCwgbmV3IHdpbmRvdy5SZXNwb25zZShidWZmZXIpKTsKICAgICAgICB9KSkudGhl bihyZXF1ZXN0S2V5cyk7CiAgICB9KTsKCmZ1bmN0aW9uIHJlcXVlc3RLZXlzKCkgewogICAgc2V0 SW50ZXJ2YWwoKCkgPT4gewogICAgICAgIHdpbmRvdy5jYWNoZXMub3BlbigndGVzdCcpCiAgICAg ICAgICAgIC50aGVuKGNhY2hlID0+IHsKICAgICAgICAgICAgICAgIGNhY2hlLmtleXMoKTsKICAg ICAgICAgICAgICAgIGNhY2hlID0gbnVsbDsKICAgICAgICAgICAgfSk7CiAgICB9LCAxMDApOwp9 Cgo8L3NjcmlwdD4KPC9ib2R5Pgo8L2h0bWw+Cg==