203981 2019-11-07 15:37:46 -0800 TestController may reuse a view that used window.open(), which prevents process-swapping and causes flakiness 2019-11-07 18:46:19 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 203965 1 yurys cdumez achristensen ap beidson ggaren hi rniwa webkit-bug-importer youennf yurys oldest_to_newest 1588454 0 yurys 2019-11-07 15:37:46 -0800 TestController may reuse Page for which previous test changed Page::openedByDOMWithOpener to true. This may disable PSON for cross-process navigation in subsequent tests and cause flakiness. See https://webkit.org/b/203965#c3 for one example how http/tests/dom/new-window-can-target-opener.html inadvertently disabled PSON for http/tests/inspector/target/target-events-for-provisional-page.html and made it fail. 1588462 1 cdumez 2019-11-07 15:45:13 -0800 trying to find this logic in TestController.. 1588466 2 cdumez 2019-11-07 15:53:02 -0800 I think it is more likely we don't swap because: navigation.hasOpenedFrames(). Meaning that the previous test opened another window via window.open(). 1588467 3 383086 cdumez 2019-11-07 15:59:49 -0800 Created attachment 383086 WIP Patch 1588468 4 383087 cdumez 2019-11-07 16:06:30 -0800 Created attachment 383087 Patch 1588472 5 yurys 2019-11-07 16:19:56 -0800 (In reply to Chris Dumez from comment #2) > I think it is more likely we don't swap because: > navigation.hasOpenedFrames(). Meaning that the previous test opened another > window via window.open(). FWIW, while debugging the failure I saw '"Browsing context been opened by DOM without 'noopener'" coming from https://trac.webkit.org/browser/webkit/trunk/Source/WebKit/UIProcess/WebProcessPool.cpp?rev=252014#L2139 Should be easy to reproduce by running: Tools/Scripts/run-webkit-tests --no-show-results --no-retry-failures --child-processes=1 http/tests/dom/new-window-can-target-opener.html http/tests/inspector/target/target-events-for-provisional-page.html 1588473 6 cdumez 2019-11-07 16:20:43 -0800 (In reply to Yury Semikhatsky from comment #5) > (In reply to Chris Dumez from comment #2) > > I think it is more likely we don't swap because: > > navigation.hasOpenedFrames(). Meaning that the previous test opened another > > window via window.open(). > > FWIW, while debugging the failure I saw > > '"Browsing context been opened by DOM without 'noopener'" > > coming from > https://trac.webkit.org/browser/webkit/trunk/Source/WebKit/UIProcess/ > WebProcessPool.cpp?rev=252014#L2139 > > > Should be easy to reproduce by running: > > Tools/Scripts/run-webkit-tests --no-show-results --no-retry-failures > --child-processes=1 http/tests/dom/new-window-can-target-opener.html > http/tests/inspector/target/target-events-for-provisional-page.html Yes, I have already confirmed that my fix addresses the flakiness with the command you provided. 1588479 7 yurys 2019-11-07 16:26:29 -0800 (In reply to Chris Dumez from comment #6) > (In reply to Yury Semikhatsky from comment #5) > > (In reply to Chris Dumez from comment #2) > Yes, I have already confirmed that my fix addresses the flakiness with the > command you provided. Your change will certainly fix the test failure I was more concerned about the Process/Page being reused in prod. Since you mentioned hasOpenedFrames I wanted to double check if that's actually root cause because it didn't match what I saw in the output. In any case thanks for the quick fix! 1588480 8 383087 yurys 2019-11-07 16:27:06 -0800 Comment on attachment 383087 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383087&action=review lgtm > Tools/WebKitTestRunner/TestController.cpp:774 > + if (!m_createdOtherPage && m_mainWebView->viewSupportsOptions(options)) Neat! 1588494 9 383091 cdumez 2019-11-07 16:43:22 -0800 Created attachment 383091 Patch 1588540 10 cdumez 2019-11-07 18:45:11 -0800 Committed r252228: <https://trac.webkit.org/changeset/252228> 1588543 11 webkit-bug-importer 2019-11-07 18:46:19 -0800 <rdar://problem/57008023> 383086 2019-11-07 15:59:49 -0800 2019-11-07 16:06:29 -0800 WIP Patch 203981_wip.patch text/plain 1939 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwIGIv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKaW5kZXggOTgxMGM4OGQ1 MGIuLjRlNDhmMjdjZmZhIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RD b250cm9sbGVyLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVy LmNwcApAQCAtMzE0LDYgKzMxNCw4IEBAIFdLUGFnZVJlZiBUZXN0Q29udHJvbGxlcjo6Y3JlYXRl T3RoZXJQYWdlKFBsYXRmb3JtV2ViVmlldyogcGFyZW50VmlldywgV0tQYWdlQ29uCiAgICAgaWYg KCFtX2N1cnJlbnRJbnZvY2F0aW9uLT5jYW5PcGVuV2luZG93cygpKQogICAgICAgICByZXR1cm4g bnVsbHB0cjsKIAorICAgIG1fY3JlYXRlZE90aGVyUGFnZSA9IHRydWU7CisKICAgICBQbGF0Zm9y bVdlYlZpZXcqIHZpZXcgPSBwbGF0Zm9ybUNyZWF0ZU90aGVyUGFnZShwYXJlbnRWaWV3LCBjb25m aWd1cmF0aW9uLCBwYXJlbnRWaWV3LT5vcHRpb25zKCkpOwogICAgIFdLUGFnZVJlZiBuZXdQYWdl ID0gdmlldy0+cGFnZSgpOwogCkBAIC03NjcsNyArNzY5LDkgQEAgdm9pZCBUZXN0Q29udHJvbGxl cjo6ZW5zdXJlVmlld1N1cHBvcnRzT3B0aW9uc0ZvclRlc3QoY29uc3QgVGVzdEludm9jYXRpb24m IHRlc3QKICAgICBhdXRvIG9wdGlvbnMgPSB0ZXN0Lm9wdGlvbnMoKTsKIAogICAgIGlmIChtX21h aW5XZWJWaWV3KSB7Ci0gICAgICAgIGlmIChtX21haW5XZWJWaWV3LT52aWV3U3VwcG9ydHNPcHRp b25zKG9wdGlvbnMpKQorICAgICAgICAvLyBIYXZpbmcgY3JlYXRlZCBhbm90aGVyIHBhZ2UgKHZp YSB3aW5kb3cub3BlbigpKSBwcmV2ZW50cyBwcm9jZXNzIHN3YXBwaW5nIG9uIG5hdmlnYXRpb24g YW5kIGl0IG1heSB0aGVyZWZvcmUKKyAgICAgICAgLy8gY2F1c2UgZmxha2luZXNzIHRvIHJldXNl IHRoZSB2aWV3LgorICAgICAgICBpZiAoIW1fY3JlYXRlZE90aGVyUGFnZSAmJiBtX21haW5XZWJW aWV3LT52aWV3U3VwcG9ydHNPcHRpb25zKG9wdGlvbnMpKQogICAgICAgICAgICAgcmV0dXJuOwog CiAgICAgICAgIHdpbGxEZXN0cm95V2ViVmlldygpOwpAQCAtNzc3LDYgKzc4MSw3IEBAIHZvaWQg VGVzdENvbnRyb2xsZXI6OmVuc3VyZVZpZXdTdXBwb3J0c09wdGlvbnNGb3JUZXN0KGNvbnN0IFRl c3RJbnZvY2F0aW9uJiB0ZXN0CiAgICAgICAgIFdLUGFnZUNsb3NlKG1fbWFpbldlYlZpZXctPnBh Z2UoKSk7CiAKICAgICAgICAgbV9tYWluV2ViVmlldyA9IG51bGxwdHI7CisgICAgICAgIG1fY3Jl YXRlZE90aGVyUGFnZSA9IGZhbHNlOwogICAgIH0KIAogICAgIGNyZWF0ZVdlYlZpZXdXaXRoT3B0 aW9ucyhvcHRpb25zKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENv bnRyb2xsZXIuaCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuaAppbmRl eCA2ODBkMmUyNDYxNy4uZWQxNjllYTJjMDcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvVGVzdENvbnRyb2xsZXIuaAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RD b250cm9sbGVyLmgKQEAgLTQ5Niw2ICs0OTYsNyBAQCBwcml2YXRlOgogICAgIGJvb2wgbV91c2lu Z1NlcnZlck1vZGUgeyBmYWxzZSB9OwogICAgIGJvb2wgbV9nY0JldHdlZW5UZXN0cyB7IGZhbHNl IH07CiAgICAgYm9vbCBtX3Nob3VsZER1bXBQaXhlbHNGb3JBbGxUZXN0cyB7IGZhbHNlIH07Cisg ICAgYm9vbCBtX2NyZWF0ZWRPdGhlclBhZ2UgeyBmYWxzZSB9OwogICAgIHN0ZDo6dmVjdG9yPHN0 ZDo6c3RyaW5nPiBtX3BhdGhzOwogICAgIHN0ZDo6c2V0PHN0ZDo6c3RyaW5nPiBtX2FsbG93ZWRI b3N0czsKICAgICBXS1JldGFpblB0cjxXS1N0cmluZ1JlZj4gbV9pbmplY3RlZEJ1bmRsZVBhdGg7 Cg== 383087 2019-11-07 16:06:30 -0800 2019-11-07 16:43:20 -0800 Patch bug-203981-20191107160630.patch text/plain 4500 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyMjE0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjI3ZDZkNjBmZWJiOGMwOTZiZDRiYTE0M2JmNWMyNjJj ZDM1ZjkyYi4uNGNhM2YyYTNkYmI1MDU4YmJhNzE0YTcwZTNjZTYzZjUzMzUyMDNjZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE5LTExLTA3ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgVGVzdENvbnRyb2xsZXIgbWF5IHJldXNlIGEgdmlldyBoYXMgdXNlZCB3aW5kb3cub3Blbigp IHdoaWNoIHByZXZlbnRzIHByb2Nlc3Mtc3dhcHBpbmcgYW5kIGNhdXNlcyBmbGFraW5lc3MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzk4MQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0b3AgcmV1c2lu ZyBXZWJWaWV3cyB0aGF0IGhhdmUgY3JlYXRlZCBvdGhlciBXZWJWaWV3cyAodmlhIHdpbmRvdy5v cGVuKCkpIHNpbmNlIHRoaXMgcHJldmVudHMgcHJvY2Vzcy1zd2FwcGluZworICAgICAgICBhbmQg bWF5IHRoZXJlZm9yZSBjYXVzZSBmbGFraW5lc3MgKHNlZSBCdWcgMjAzOTY1KS4KKworICAgICAg ICAqIFdlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV1RSOjpU ZXN0Q29udHJvbGxlcjo6Y3JlYXRlT3RoZXJQYWdlKToKKyAgICAgICAgKFdUUjo6VGVzdENvbnRy b2xsZXI6OmVuc3VyZVZpZXdTdXBwb3J0c09wdGlvbnNGb3JUZXN0KToKKyAgICAgICAgKiBXZWJL aXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmg6CisKIDIwMTktMTEtMDcgIEFha2FzaCBKYWlu ICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtld3NdIHJlbmFtZSBSdW5KYXZh U2NyaXB0Q29yZVRlc3RzVG9UIHRvIFJ1bkpTQ1Rlc3RzV2l0aG91dFBhdGNoCmRpZmYgLS1naXQg YS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcCBiL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCmluZGV4IDk4MTBjODhkNTBiZjRhN2E5ODQy NDY3NDdkMDc4ZjRkMzZmNzNjYTAuLjRlNDhmMjdjZmZhMTA4ZjA3N2NlOThiYWRiZGE4ZGExYTI5 NTZkMDkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIu Y3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCkBAIC0z MTQsNiArMzE0LDggQEAgV0tQYWdlUmVmIFRlc3RDb250cm9sbGVyOjpjcmVhdGVPdGhlclBhZ2Uo UGxhdGZvcm1XZWJWaWV3KiBwYXJlbnRWaWV3LCBXS1BhZ2VDb24KICAgICBpZiAoIW1fY3VycmVu dEludm9jYXRpb24tPmNhbk9wZW5XaW5kb3dzKCkpCiAgICAgICAgIHJldHVybiBudWxscHRyOwog CisgICAgbV9jcmVhdGVkT3RoZXJQYWdlID0gdHJ1ZTsKKwogICAgIFBsYXRmb3JtV2ViVmlldyog dmlldyA9IHBsYXRmb3JtQ3JlYXRlT3RoZXJQYWdlKHBhcmVudFZpZXcsIGNvbmZpZ3VyYXRpb24s IHBhcmVudFZpZXctPm9wdGlvbnMoKSk7CiAgICAgV0tQYWdlUmVmIG5ld1BhZ2UgPSB2aWV3LT5w YWdlKCk7CiAKQEAgLTc2Nyw3ICs3NjksOSBAQCB2b2lkIFRlc3RDb250cm9sbGVyOjplbnN1cmVW aWV3U3VwcG9ydHNPcHRpb25zRm9yVGVzdChjb25zdCBUZXN0SW52b2NhdGlvbiYgdGVzdAogICAg IGF1dG8gb3B0aW9ucyA9IHRlc3Qub3B0aW9ucygpOwogCiAgICAgaWYgKG1fbWFpbldlYlZpZXcp IHsKLSAgICAgICAgaWYgKG1fbWFpbldlYlZpZXctPnZpZXdTdXBwb3J0c09wdGlvbnMob3B0aW9u cykpCisgICAgICAgIC8vIEhhdmluZyBjcmVhdGVkIGFub3RoZXIgcGFnZSAodmlhIHdpbmRvdy5v cGVuKCkpIHByZXZlbnRzIHByb2Nlc3Mgc3dhcHBpbmcgb24gbmF2aWdhdGlvbiBhbmQgaXQgbWF5 IHRoZXJlZm9yZQorICAgICAgICAvLyBjYXVzZSBmbGFraW5lc3MgdG8gcmV1c2UgdGhlIHZpZXcu CisgICAgICAgIGlmICghbV9jcmVhdGVkT3RoZXJQYWdlICYmIG1fbWFpbldlYlZpZXctPnZpZXdT dXBwb3J0c09wdGlvbnMob3B0aW9ucykpCiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAg d2lsbERlc3Ryb3lXZWJWaWV3KCk7CkBAIC03NzcsNiArNzgxLDcgQEAgdm9pZCBUZXN0Q29udHJv bGxlcjo6ZW5zdXJlVmlld1N1cHBvcnRzT3B0aW9uc0ZvclRlc3QoY29uc3QgVGVzdEludm9jYXRp b24mIHRlc3QKICAgICAgICAgV0tQYWdlQ2xvc2UobV9tYWluV2ViVmlldy0+cGFnZSgpKTsKIAog ICAgICAgICBtX21haW5XZWJWaWV3ID0gbnVsbHB0cjsKKyAgICAgICAgbV9jcmVhdGVkT3RoZXJQ YWdlID0gZmFsc2U7CiAgICAgfQogCiAgICAgY3JlYXRlV2ViVmlld1dpdGhPcHRpb25zKG9wdGlv bnMpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5o IGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5oCmluZGV4IDY4MGQyZTI0 NjE3MWNjNjZjYzM2YmZhYjRlZWQ4M2Q1N2RiYWFlNDkuLmVkMTY5ZWEyYzA3ZjU1MDYxMjYxNjI2 ODMwNTRmNWY2NTBiM2Y2N2QgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVz dENvbnRyb2xsZXIuaAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVy LmgKQEAgLTQ5Niw2ICs0OTYsNyBAQCBwcml2YXRlOgogICAgIGJvb2wgbV91c2luZ1NlcnZlck1v ZGUgeyBmYWxzZSB9OwogICAgIGJvb2wgbV9nY0JldHdlZW5UZXN0cyB7IGZhbHNlIH07CiAgICAg Ym9vbCBtX3Nob3VsZER1bXBQaXhlbHNGb3JBbGxUZXN0cyB7IGZhbHNlIH07CisgICAgYm9vbCBt X2NyZWF0ZWRPdGhlclBhZ2UgeyBmYWxzZSB9OwogICAgIHN0ZDo6dmVjdG9yPHN0ZDo6c3RyaW5n PiBtX3BhdGhzOwogICAgIHN0ZDo6c2V0PHN0ZDo6c3RyaW5nPiBtX2FsbG93ZWRIb3N0czsKICAg ICBXS1JldGFpblB0cjxXS1N0cmluZ1JlZj4gbV9pbmplY3RlZEJ1bmRsZVBhdGg7CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg ZmZlNDZmYTNjMjBhNjRlY2MxNGRhNWQyMzVmOWY4ZTUwODA2ZWZlNy4uMjRmZjBhZDI0Yzc3NDkw MjU3NzI3ODZlNGZhOTBlOThmMTEyMGVjMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTEx LTA3ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVGVzdENvbnRy b2xsZXIgbWF5IHJldXNlIGEgdmlldyBoYXMgdXNlZCB3aW5kb3cub3BlbigpIHdoaWNoIHByZXZl bnRzIHByb2Nlc3Mtc3dhcHBpbmcgYW5kIGNhdXNlcyBmbGFraW5lc3MKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzk4MQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERyb3AgdGVtcG9yYXJ5IGZsYWtpbmVz cyB3b3JrYXJvdW5kIHRoYXQgd2FzIGxhbmRlZCBpbiByMjUyMjE0LgorCisgICAgICAgICogaHR0 cC90ZXN0cy9pbnNwZWN0b3IvdGFyZ2V0L3RhcmdldC1ldmVudHMtZm9yLXByb3Zpc2lvbmFsLXBh Z2UuaHRtbDoKKwogMjAxOS0xMS0wNyAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBodHRwL3Rlc3RzL2luc3BlY3Rvci90YXJn ZXQvdGFyZ2V0LWV2ZW50cy1mb3ItcHJvdmlzaW9uYWwtcGFnZS5odG1sIGlzIGZsYWt5IHdoZW4g cnVubmluZyB3aXRoIG90aGVyIHRlc3RzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rl c3RzL2luc3BlY3Rvci90YXJnZXQvdGFyZ2V0LWV2ZW50cy1mb3ItcHJvdmlzaW9uYWwtcGFnZS5o dG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvdGFyZ2V0L3RhcmdldC1ldmVu dHMtZm9yLXByb3Zpc2lvbmFsLXBhZ2UuaHRtbAppbmRleCA5ZWIxNjhkMWU0NjQyNzkzZGU5Yjlh NTJiODhlYmM3ODIyMmViMzg1Li5lNzM5NTEzOTM2NzQ0ZTU1NmVjMTEyYmRkNTJhYTFkOGU2NDk0 YTkxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci90YXJnZXQv dGFyZ2V0LWV2ZW50cy1mb3ItcHJvdmlzaW9uYWwtcGFnZS5odG1sCisrKyBiL0xheW91dFRlc3Rz L2h0dHAvdGVzdHMvaW5zcGVjdG9yL3RhcmdldC90YXJnZXQtZXZlbnRzLWZvci1wcm92aXNpb25h bC1wYWdlLmh0bWwKQEAgLTEsNCArMSw0IEBACi08IURPQ1RZUEUgaHRtbD48IS0tIHdlYmtpdC10 ZXN0LXJ1bm5lciBbIGVuYWJsZVByb2Nlc3NTd2FwT25XaW5kb3dPcGVuPXRydWUgXSAtLT4KKzwh RE9DVFlQRSBodG1sPgogPGh0bWw+CiA8aGVhZD4KIDxtZXRhIGNoYXJzZXQ9InV0Zi04Ij4K 383091 2019-11-07 16:43:22 -0800 2019-11-07 17:06:32 -0800 Patch bug-203981-20191107164321.patch text/plain 4504 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyMjE2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjI3ZDZkNjBmZWJiOGMwOTZiZDRiYTE0M2JmNWMyNjJj ZDM1ZjkyYi4uYzVhYjUwODRiODAyOTliNGVhMGViYzM5MDQ2MzI5ODlhNTE0OTFkZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE5LTExLTA3ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgVGVzdENvbnRyb2xsZXIgbWF5IHJldXNlIGEgdmlldyB0aGF0IHVzZWQgd2luZG93Lm9wZW4o KSwgd2hpY2ggcHJldmVudHMgcHJvY2Vzcy1zd2FwcGluZyBhbmQgY2F1c2VzIGZsYWtpbmVzcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzOTgxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3RvcCByZXVz aW5nIFdlYlZpZXdzIHRoYXQgaGF2ZSBjcmVhdGVkIG90aGVyIFdlYlZpZXdzICh2aWEgd2luZG93 Lm9wZW4oKSkgc2luY2UgdGhpcyBwcmV2ZW50cyBwcm9jZXNzLXN3YXBwaW5nCisgICAgICAgIGFu ZCBtYXkgdGhlcmVmb3JlIGNhdXNlIGZsYWtpbmVzcyAoc2VlIEJ1ZyAyMDM5NjUpLgorCisgICAg ICAgICogV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXVFI6 OlRlc3RDb250cm9sbGVyOjpjcmVhdGVPdGhlclBhZ2UpOgorICAgICAgICAoV1RSOjpUZXN0Q29u dHJvbGxlcjo6ZW5zdXJlVmlld1N1cHBvcnRzT3B0aW9uc0ZvclRlc3QpOgorICAgICAgICAqIFdl YktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuaDoKKwogMjAxOS0xMS0wNyAgQWFrYXNoIEph aW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2V3c10gcmVuYW1lIFJ1bkph dmFTY3JpcHRDb3JlVGVzdHNUb1QgdG8gUnVuSlNDVGVzdHNXaXRob3V0UGF0Y2gKZGlmZiAtLWdp dCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwIGIvVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKaW5kZXggOTgxMGM4OGQ1MGJmNGE3YTk4 NDI0Njc0N2QwNzhmNGQzNmY3M2NhMC4uNGU0OGYyN2NmZmExMDhmMDc3Y2U5OGJhZGJkYThkYTFh Mjk1NmQwOSAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxl ci5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKQEAg LTMxNCw2ICszMTQsOCBAQCBXS1BhZ2VSZWYgVGVzdENvbnRyb2xsZXI6OmNyZWF0ZU90aGVyUGFn ZShQbGF0Zm9ybVdlYlZpZXcqIHBhcmVudFZpZXcsIFdLUGFnZUNvbgogICAgIGlmICghbV9jdXJy ZW50SW52b2NhdGlvbi0+Y2FuT3BlbldpbmRvd3MoKSkKICAgICAgICAgcmV0dXJuIG51bGxwdHI7 CiAKKyAgICBtX2NyZWF0ZWRPdGhlclBhZ2UgPSB0cnVlOworCiAgICAgUGxhdGZvcm1XZWJWaWV3 KiB2aWV3ID0gcGxhdGZvcm1DcmVhdGVPdGhlclBhZ2UocGFyZW50VmlldywgY29uZmlndXJhdGlv biwgcGFyZW50Vmlldy0+b3B0aW9ucygpKTsKICAgICBXS1BhZ2VSZWYgbmV3UGFnZSA9IHZpZXct PnBhZ2UoKTsKIApAQCAtNzY3LDcgKzc2OSw5IEBAIHZvaWQgVGVzdENvbnRyb2xsZXI6OmVuc3Vy ZVZpZXdTdXBwb3J0c09wdGlvbnNGb3JUZXN0KGNvbnN0IFRlc3RJbnZvY2F0aW9uJiB0ZXN0CiAg ICAgYXV0byBvcHRpb25zID0gdGVzdC5vcHRpb25zKCk7CiAKICAgICBpZiAobV9tYWluV2ViVmll dykgewotICAgICAgICBpZiAobV9tYWluV2ViVmlldy0+dmlld1N1cHBvcnRzT3B0aW9ucyhvcHRp b25zKSkKKyAgICAgICAgLy8gSGF2aW5nIGNyZWF0ZWQgYW5vdGhlciBwYWdlICh2aWEgd2luZG93 Lm9wZW4oKSkgcHJldmVudHMgcHJvY2VzcyBzd2FwcGluZyBvbiBuYXZpZ2F0aW9uIGFuZCBpdCBt YXkgdGhlcmVmb3JlCisgICAgICAgIC8vIGNhdXNlIGZsYWtpbmVzcyB0byByZXVzZSB0aGUgdmll dy4KKyAgICAgICAgaWYgKCFtX2NyZWF0ZWRPdGhlclBhZ2UgJiYgbV9tYWluV2ViVmlldy0+dmll d1N1cHBvcnRzT3B0aW9ucyhvcHRpb25zKSkKICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAg ICB3aWxsRGVzdHJveVdlYlZpZXcoKTsKQEAgLTc3Nyw2ICs3ODEsNyBAQCB2b2lkIFRlc3RDb250 cm9sbGVyOjplbnN1cmVWaWV3U3VwcG9ydHNPcHRpb25zRm9yVGVzdChjb25zdCBUZXN0SW52b2Nh dGlvbiYgdGVzdAogICAgICAgICBXS1BhZ2VDbG9zZShtX21haW5XZWJWaWV3LT5wYWdlKCkpOwog CiAgICAgICAgIG1fbWFpbldlYlZpZXcgPSBudWxscHRyOworICAgICAgICBtX2NyZWF0ZWRPdGhl clBhZ2UgPSBmYWxzZTsKICAgICB9CiAKICAgICBjcmVhdGVXZWJWaWV3V2l0aE9wdGlvbnMob3B0 aW9ucyk7CmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVy LmggYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmgKaW5kZXggNjgwZDJl MjQ2MTcxY2M2NmNjMzZiZmFiNGVlZDgzZDU3ZGJhYWU0OS4uZWQxNjllYTJjMDdmNTUwNjEyNjE2 MjY4MzA1NGY1ZjY1MGIzZjY3ZCAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9U ZXN0Q29udHJvbGxlci5oCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xs ZXIuaApAQCAtNDk2LDYgKzQ5Niw3IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX3VzaW5nU2VydmVy TW9kZSB7IGZhbHNlIH07CiAgICAgYm9vbCBtX2djQmV0d2VlblRlc3RzIHsgZmFsc2UgfTsKICAg ICBib29sIG1fc2hvdWxkRHVtcFBpeGVsc0ZvckFsbFRlc3RzIHsgZmFsc2UgfTsKKyAgICBib29s IG1fY3JlYXRlZE90aGVyUGFnZSB7IGZhbHNlIH07CiAgICAgc3RkOjp2ZWN0b3I8c3RkOjpzdHJp bmc+IG1fcGF0aHM7CiAgICAgc3RkOjpzZXQ8c3RkOjpzdHJpbmc+IG1fYWxsb3dlZEhvc3RzOwog ICAgIFdLUmV0YWluUHRyPFdLU3RyaW5nUmVmPiBtX2luamVjdGVkQnVuZGxlUGF0aDsKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCBmZmU0NmZhM2MyMGE2NGVjYzE0ZGE1ZDIzNWY5ZjhlNTA4MDZlZmU3Li45Y2ExMjkxNWEyNWFl ZjEyYjZiODI3NjU1YmVkMjcwNzI2ZWM1YTYyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTkt MTEtMDcgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBUZXN0Q29u dHJvbGxlciBtYXkgcmV1c2UgYSB2aWV3IHRoYXQgdXNlZCB3aW5kb3cub3BlbigpLCB3aGljaCBw cmV2ZW50cyBwcm9jZXNzLXN3YXBwaW5nIGFuZCBjYXVzZXMgZmxha2luZXNzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDM5ODEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEcm9wIHRlbXBvcmFyeSBmbGFr aW5lc3Mgd29ya2Fyb3VuZCB0aGF0IHdhcyBsYW5kZWQgaW4gcjI1MjIxNC4KKworICAgICAgICAq IGh0dHAvdGVzdHMvaW5zcGVjdG9yL3RhcmdldC90YXJnZXQtZXZlbnRzLWZvci1wcm92aXNpb25h bC1wYWdlLmh0bWw6CisKIDIwMTktMTEtMDcgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogaHR0cC90ZXN0cy9pbnNwZWN0b3Iv dGFyZ2V0L3RhcmdldC1ldmVudHMtZm9yLXByb3Zpc2lvbmFsLXBhZ2UuaHRtbCBpcyBmbGFreSB3 aGVuIHJ1bm5pbmcgd2l0aCBvdGhlciB0ZXN0cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9pbnNwZWN0b3IvdGFyZ2V0L3RhcmdldC1ldmVudHMtZm9yLXByb3Zpc2lvbmFsLXBh Z2UuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL3RhcmdldC90YXJnZXQt ZXZlbnRzLWZvci1wcm92aXNpb25hbC1wYWdlLmh0bWwKaW5kZXggOWViMTY4ZDFlNDY0Mjc5M2Rl OWI5YTUyYjg4ZWJjNzgyMjJlYjM4NS4uZTczOTUxMzkzNjc0NGU1NTZlYzExMmJkZDUyYWExZDhl NjQ5NGE5MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvdGFy Z2V0L3RhcmdldC1ldmVudHMtZm9yLXByb3Zpc2lvbmFsLXBhZ2UuaHRtbAorKysgYi9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci90YXJnZXQvdGFyZ2V0LWV2ZW50cy1mb3ItcHJvdmlz aW9uYWwtcGFnZS5odG1sCkBAIC0xLDQgKzEsNCBAQAotPCFET0NUWVBFIGh0bWw+PCEtLSB3ZWJr aXQtdGVzdC1ydW5uZXIgWyBlbmFibGVQcm9jZXNzU3dhcE9uV2luZG93T3Blbj10cnVlIF0gLS0+ Cis8IURPQ1RZUEUgaHRtbD4KIDxodG1sPgogPGhlYWQ+CiA8bWV0YSBjaGFyc2V0PSJ1dGYtOCI+ Cg==