203965 2019-11-07 09:53:12 -0800 Web Inspector: http/tests/inspector/target/target-events-for-provisional-page.html is flaky when running with other tests 2019-11-07 16:02:32 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 203981 1 yurys yurys ap cdumez commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1588261 0 yurys 2019-11-07 09:53:12 -0800 http/tests/inspector/target/target-events-for-provisional-page.html added in https://trac.webkit.org/changeset/251494/webkit is a flakey failure when running with other tests. Probable cause: Some side effect of previous tests that disable PSON. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Finspector%2Ftarget%2Ftarget-events-for-provisional-page.html 1588267 1 yurys 2019-11-07 09:58:45 -0800 The test reliably fails when running after http/tests/dom/new-window-can-target-opener.html. Tools/Scripts/run-webkit-tests --no-show-results --no-retry-failures --child-processes=1 http/tests/dom/new-window-can-target-opener.html http/tests/inspector/target/target-events-for-provisional-page.html 1588294 2 webkit-bug-importer 2019-11-07 10:50:18 -0800 <rdar://problem/56988642> 1588414 3 yurys 2019-11-07 14:36:46 -0800 The problem is that new-window-can-target-opener-win.html opened in a child window calls open() on its opener window, i.e. the test page itself (new-window-can-target-opener.html). It in turn triggers Page::setOpenedByDOMWithOpener() on the parent page. The next test will reuse the same instance of PlatformWebView and consequently the same Page in the WebProcess. Since instance of the page is the same it still has Page::openedByDOMWithOpener() == true. Because of that[1] cross-origin navigation in the next test page will reuse same process. I don't know if this is intentional behavior. I'm going to add <!-- webkit-test-runner [ enableProcessSwapOnWindowOpen=true ] --> as a temporary workaround for the flaky inspector test but we should probably never reuse a page which was openedByDOM. [1] https://trac.webkit.org/browser/webkit/trunk/Source/WebKit/UIProcess/WebProcessPool.cpp?rev=252014#L2139 [2] https://trac.webkit.org/browser/webkit/trunk/LayoutTests/http/tests/dom/resources/new-window-can-target-opener-win.html#L19 1588421 4 383075 yurys 2019-11-07 14:48:29 -0800 Created attachment 383075 Patch 1588428 5 383075 hi 2019-11-07 15:04:47 -0800 Comment on attachment 383075 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383075&action=review rs=me > LayoutTests/ChangeLog:11 > + that may run before (the test may reuse Page instance from the previous test on which > + Page::openedByDOMWithOpener==true). This seems like a bug. Can you file a separate bug to fix this please? 1588455 6 yurys 2019-11-07 15:39:40 -0800 Filed https://bugs.webkit.org/show_bug.cgi?id=203981 1588460 7 383075 commit-queue 2019-11-07 15:45:02 -0800 Comment on attachment 383075 Patch Clearing flags on attachment: 383075 Committed r252214: <https://trac.webkit.org/changeset/252214> 1588461 8 commit-queue 2019-11-07 15:45:04 -0800 All reviewed patches have been landed. Closing bug. 383075 2019-11-07 14:48:29 -0800 2019-11-07 15:45:02 -0800 Patch bug-203965-20191107144829.patch text/plain 1668 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyMTQwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDk0ZTdkYjgxMmIzZGU0ZTFlMjk1 ZTQzOGUxMWY5NmE5ZDlkNjJmYS4uNjRjYWI4ZmRhMWJlMjAyYmU1ODk0YTY5YWVhMjZiZTZlNDM5 ZjBlNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTExLTA3ICBZdXJ5IFNlbWlraGF0c2t5 ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGh0dHAvdGVz dHMvaW5zcGVjdG9yL3RhcmdldC90YXJnZXQtZXZlbnRzLWZvci1wcm92aXNpb25hbC1wYWdlLmh0 bWwgaXMgZmxha3kgd2hlbiBydW5uaW5nIHdpdGggb3RoZXIgdGVzdHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzk2NQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNTY5ODg2NDI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRW5mb3JjZSBlbmFibGVQcm9jZXNzU3dhcE9uV2luZG93T3Blbj10cnVlIGZv ciB0aGUgdGVzdCBzbyB0aGF0IGl0IFBTT04gaXMgZW5hYmxlZCByZWdhcmRsZXNzIG9mIG90aGVy IHRlc3RzCisgICAgICAgIHRoYXQgbWF5IHJ1biBiZWZvcmUgKHRoZSB0ZXN0IG1heSByZXVzZSBQ YWdlIGluc3RhbmNlIGZyb20gdGhlIHByZXZpb3VzIHRlc3Qgb24gd2hpY2gKKyAgICAgICAgUGFn ZTo6b3BlbmVkQnlET01XaXRoT3BlbmVyPT10cnVlKS4KKworICAgICAgICAqIGh0dHAvdGVzdHMv aW5zcGVjdG9yL3RhcmdldC90YXJnZXQtZXZlbnRzLWZvci1wcm92aXNpb25hbC1wYWdlLmh0bWw6 CisKIDIwMTktMTEtMDYgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAg ICAgIFJFR1JFU1NJT04gWyBQSFAgXVsgaU9TIF06IFR3byBodHRwL3Rlc3RzL2Nvb2tpZXMvc2Ft ZS1zaXRlL3NldC1maXJzdC1wYXJ0eS0qIFRlc3RzIGFyZSBGYWlsaW5nCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci90YXJnZXQvdGFyZ2V0LWV2ZW50cy1mb3It cHJvdmlzaW9uYWwtcGFnZS5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3Iv dGFyZ2V0L3RhcmdldC1ldmVudHMtZm9yLXByb3Zpc2lvbmFsLXBhZ2UuaHRtbAppbmRleCBlNzM5 NTEzOTM2NzQ0ZTU1NmVjMTEyYmRkNTJhYTFkOGU2NDk0YTkxLi45ZWIxNjhkMWU0NjQyNzkzZGU5 YjlhNTJiODhlYmM3ODIyMmViMzg1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3Rz L2luc3BlY3Rvci90YXJnZXQvdGFyZ2V0LWV2ZW50cy1mb3ItcHJvdmlzaW9uYWwtcGFnZS5odG1s CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL3RhcmdldC90YXJnZXQtZXZl bnRzLWZvci1wcm92aXNpb25hbC1wYWdlLmh0bWwKQEAgLTEsNCArMSw0IEBACi08IURPQ1RZUEUg aHRtbD4KKzwhRE9DVFlQRSBodG1sPjwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgZW5hYmxlUHJv Y2Vzc1N3YXBPbldpbmRvd09wZW49dHJ1ZSBdIC0tPgogPGh0bWw+CiA8aGVhZD4KIDxtZXRhIGNo YXJzZXQ9InV0Zi04Ij4K