203959 2019-11-07 09:09:17 -0800 [ews] rename RunJavaScriptCoreTestsToT to RunJSCTestsWithoutPatch 2020-04-08 09:03:46 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210190 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue jbedard pmatos webkit-bug-importer oldest_to_newest 1588247 0 aakash_jain 2019-11-07 09:09:17 -0800 Rename RunJavaScriptCoreTestsToT to RunJSCTestsWithoutPatch since that's more accurate name. In EWS, when the jsc tests fails, we un-apply the patch and run tests on clean tree, not on ToT. We re-run the tests without patch on same revision on which tests were run with the patch. This naming would also make it consistent with other similar steps like: RunWebKitTestsWithout and RunAPITestsWithoutPatch. 1588250 1 383056 aakash_jain 2019-11-07 09:12:41 -0800 Created attachment 383056 Patch 1588253 2 383056 ap 2019-11-07 09:24:08 -0800 Comment on attachment 383056 Patch Why is webkitperl EWS red? 1588264 3 aakash_jain 2019-11-07 09:54:45 -0800 (In reply to Alexey Proskuryakov from comment #2) > Why is webkitperl EWS red? Not sure. It passed on retry. Filed: https://bugs.webkit.org/show_bug.cgi?id=203964 1588279 4 383056 commit-queue 2019-11-07 10:31:02 -0800 Comment on attachment 383056 Patch Clearing flags on attachment: 383056 Committed r252190: <https://trac.webkit.org/changeset/252190> 1588280 5 commit-queue 2019-11-07 10:31:03 -0800 All reviewed patches have been landed. Closing bug. 1588284 6 webkit-bug-importer 2019-11-07 10:32:15 -0800 <rdar://problem/56987785> 383056 2019-11-07 09:12:41 -0800 2019-11-07 10:31:02 -0800 Patch bug-203959-20191107121239.patch text/plain 4147 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MjE4NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTExLTA3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSByZW5hbWUgUnVuSmF2YVNjcmlwdENvcmVUZXN0c1RvVCB0byBS dW5KU0NUZXN0c1dpdGhvdXRQYXRjaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjAzOTU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6Cisg ICAgICAgIChSdW5KU0NUZXN0c1dpdGhvdXRQYXRjaCk6IFJlbmFtZWQuCisgICAgICAgICogQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5OiBVcGRhdGVkIHVuaXQt dGVzdHMuCisKIDIwMTktMTEtMDcgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZS1lbmFibGUgTlNVUkxTZXNzaW9uIGlzb2xhdGlvbiBhZnRl ciByMjUyMTE2CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMu cHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBz LnB5CShyZXZpc2lvbiAyNTIxODUpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVp bGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTk2NywxMiArOTY3LDEyIEBAIGNsYXNzIFJl UnVuSmF2YVNjcmlwdENvcmVUZXN0cyhSdW5KYXZhU2MKICAgICAgICAgICAgIHNlbGYuYnVpbGQu YnVpbGRGaW5pc2hlZChbbWVzc2FnZV0sIFNVQ0NFU1MpCiAgICAgICAgIGVsc2U6CiAgICAgICAg ICAgICBzZWxmLnNldFByb3BlcnR5KCdwYXRjaEZhaWxlZFRlc3RzJywgVHJ1ZSkKLSAgICAgICAg ICAgIHNlbGYuYnVpbGQuYWRkU3RlcHNBZnRlckN1cnJlbnRTdGVwKFtVbkFwcGx5UGF0Y2hJZlJl cXVpcmVkKCksIENvbXBpbGVKU0NUb1QoKSwgUnVuSmF2YVNjcmlwdENvcmVUZXN0c1RvVCgpXSkK KyAgICAgICAgICAgIHNlbGYuYnVpbGQuYWRkU3RlcHNBZnRlckN1cnJlbnRTdGVwKFtVbkFwcGx5 UGF0Y2hJZlJlcXVpcmVkKCksIENvbXBpbGVKU0NUb1QoKSwgUnVuSlNDVGVzdHNXaXRob3V0UGF0 Y2goKV0pCiAgICAgICAgIHJldHVybiByYwogCiAKLWNsYXNzIFJ1bkphdmFTY3JpcHRDb3JlVGVz dHNUb1QoUnVuSmF2YVNjcmlwdENvcmVUZXN0cyk6Ci0gICAgbmFtZSA9ICdqc2NvcmUtdGVzdC10 b3QnCitjbGFzcyBSdW5KU0NUZXN0c1dpdGhvdXRQYXRjaChSdW5KYXZhU2NyaXB0Q29yZVRlc3Rz KToKKyAgICBuYW1lID0gJ2pzY29yZS10ZXN0LXdpdGhvdXQtcGF0Y2gnCiAgICAganNvbkZpbGVO YW1lID0gJ2pzY19yZXN1bHRzLmpzb24nCiAKICAgICBkZWYgZXZhbHVhdGVDb21tYW5kKHNlbGYs IGNtZCk6CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5p dHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxk L3N0ZXBzX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyNTIxODUpCisrKyBUb29scy9CdWlsZFNsYXZl U3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTM5 LDcgKzM5LDcgQEAgZnJvbSBzdGVwcyBpbXBvcnQgKEFuYWx5emVBUElUZXN0c1Jlc3VsdAogICAg ICAgICAgICAgICAgICAgIENvbXBpbGVKU0MsIENvbXBpbGVKU0NUb1QsIENvbXBpbGVXZWJLaXQs IENvbXBpbGVXZWJLaXRUb1QsIENvbmZpZ3VyZUJ1aWxkLAogICAgICAgICAgICAgICAgICAgIERv d25sb2FkQnVpbHRQcm9kdWN0LCBEb3dubG9hZEJ1aWx0UHJvZHVjdEZyb21NYXN0ZXIsIEV4dHJh Y3RCdWlsdFByb2R1Y3QsIEV4dHJhY3RUZXN0UmVzdWx0cywgSW5zdGFsbEd0a0RlcGVuZGVuY2ll cywgSW5zdGFsbFdwZURlcGVuZGVuY2llcywgS2lsbE9sZFByb2Nlc3NlcywKICAgICAgICAgICAg ICAgICAgICBQcmludENvbmZpZ3VyYXRpb24sIFJlUnVuQVBJVGVzdHMsIFJlUnVuSmF2YVNjcmlw dENvcmVUZXN0cywgUmVSdW5XZWJLaXRUZXN0cywgUnVuQVBJVGVzdHMsIFJ1bkFQSVRlc3RzV2l0 aG91dFBhdGNoLAotICAgICAgICAgICAgICAgICAgIFJ1bkJpbmRpbmdzVGVzdHMsIFJ1bkJ1aWxk V2ViS2l0T3JnVW5pdFRlc3RzLCBSdW5FV1NCdWlsZGJvdENoZWNrQ29uZmlnLCBSdW5FV1NVbml0 VGVzdHMsIFJ1bkphdmFTY3JpcHRDb3JlVGVzdHMsIFJ1bkphdmFTY3JpcHRDb3JlVGVzdHNUb1Qs IFJ1bldlYktpdDFUZXN0cywKKyAgICAgICAgICAgICAgICAgICBSdW5CaW5kaW5nc1Rlc3RzLCBS dW5CdWlsZFdlYktpdE9yZ1VuaXRUZXN0cywgUnVuRVdTQnVpbGRib3RDaGVja0NvbmZpZywgUnVu RVdTVW5pdFRlc3RzLCBSdW5KYXZhU2NyaXB0Q29yZVRlc3RzLCBSdW5KU0NUZXN0c1dpdGhvdXRQ YXRjaCwgUnVuV2ViS2l0MVRlc3RzLAogICAgICAgICAgICAgICAgICAgIFJ1bldlYktpdFBlcmxU ZXN0cywgUnVuV2ViS2l0UHlUZXN0cywgUnVuV2ViS2l0VGVzdHMsIFJ1bldlYktpdFRlc3RzV2l0 aG91dFBhdGNoLCBUZXN0V2l0aEZhaWx1cmVDb3VudCwgVHJpZ2dlciwgVHJhbnNmZXJUb1MzLCBV bkFwcGx5UGF0Y2hJZlJlcXVpcmVkLAogICAgICAgICAgICAgICAgICAgIFVwZGF0ZVdvcmtpbmdE aXJlY3RvcnksIFVwbG9hZEJ1aWx0UHJvZHVjdCwgVXBsb2FkVGVzdFJlc3VsdHMsIFZhbGlkYXRl UGF0Y2gpCiAKQEAgLTEwODUsNyArMTA4NSw3IEBAIGNsYXNzIFRlc3RSZVJ1bkphdmFTY3JpcHRD b3JlVGVzdHMoQnVpbGQKICAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCiAKIAotY2xhc3Mg VGVzdFJ1bkphdmFTY3JpcHRDb3JlVGVzdHNUb1QoQnVpbGRTdGVwTWl4aW5BZGRpdGlvbnMsIHVu aXR0ZXN0LlRlc3RDYXNlKToKK2NsYXNzIFRlc3RSdW5KU0NUZXN0c1dpdGhvdXRQYXRjaChCdWls ZFN0ZXBNaXhpbkFkZGl0aW9ucywgdW5pdHRlc3QuVGVzdENhc2UpOgogICAgIGRlZiBzZXRVcChz ZWxmKToKICAgICAgICAgc2VsZi5sb25nTWVzc2FnZSA9IFRydWUKICAgICAgICAgc2VsZi5qc29u RmlsZU5hbWUgPSAnanNjX3Jlc3VsdHMuanNvbicKQEAgLTEwOTUsNyArMTA5NSw3IEBAIGNsYXNz IFRlc3RSdW5KYXZhU2NyaXB0Q29yZVRlc3RzVG9UKEJ1aWwKICAgICAgICAgcmV0dXJuIHNlbGYu dGVhckRvd25CdWlsZFN0ZXAoKQogCiAgICAgZGVmIHRlc3Rfc3VjY2VzcyhzZWxmKToKLSAgICAg ICAgc2VsZi5zZXR1cFN0ZXAoUnVuSmF2YVNjcmlwdENvcmVUZXN0c1RvVCgpKQorICAgICAgICBz ZWxmLnNldHVwU3RlcChSdW5KU0NUZXN0c1dpdGhvdXRQYXRjaCgpKQogICAgICAgICBzZWxmLnNl dFByb3BlcnR5KCdmdWxsUGxhdGZvcm0nLCAnanNjLW9ubHknKQogICAgICAgICBzZWxmLnNldFBy b3BlcnR5KCdjb25maWd1cmF0aW9uJywgJ3JlbGVhc2UnKQogICAgICAgICBzZWxmLmV4cGVjdFJl bW90ZUNvbW1hbmRzKApAQCAtMTExMCw3ICsxMTEwLDcgQEAgY2xhc3MgVGVzdFJ1bkphdmFTY3Jp cHRDb3JlVGVzdHNUb1QoQnVpbAogICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKIAogICAg IGRlZiB0ZXN0X2ZhaWx1cmUoc2VsZik6Ci0gICAgICAgIHNlbGYuc2V0dXBTdGVwKFJ1bkphdmFT Y3JpcHRDb3JlVGVzdHNUb1QoKSkKKyAgICAgICAgc2VsZi5zZXR1cFN0ZXAoUnVuSlNDVGVzdHNX aXRob3V0UGF0Y2goKSkKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnZnVsbFBsYXRmb3JtJywg J2pzYy1vbmx5JykKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnY29uZmlndXJhdGlvbicsICdk ZWJ1ZycpCiAgICAgICAgIHNlbGYuZXhwZWN0UmVtb3RlQ29tbWFuZHMoCg==