203944 2019-11-07 00:46:36 -0800 'Strikethrough' editing command reported as 'formatUnderline' 2019-11-08 01:12:29 -0800 1 1 1 Unclassified WebKit HTML Editing Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 203992 1 mcrha webkit-unassigned aperez bugs-noreply cgarcia ews-watchlist mifenton webkit-bug-importer wenson_hsieh oldest_to_newest 1588138 0 mcrha 2019-11-07 00:46:36 -0800 Calling: webkit_web_view_execute_editing_command (web_view, "Strikethrough"); is reported as "formatUnderline" in document.oninput() callback. Semi-steps: a) open web inspector and switch to the Console b) run there this: document.oninput = function(op) { console.log("oninput:'" + op.inputType + "'"); } c) run: webkit_web_view_execute_editing_command (web_view, "Strikethrough"); from the C code. Actual result: The console prints: oninput:'formatUnderline' even the HTML does strikethrough. Expected: The inputType should be "formatStrikethrough" or similar, definitely not "formatUnderline". There are several other editing commands, which identify itself with empty string. Maybe most of them are custom WebKit commands, but it does so also for standard commands, like when I execute this on Console: document.execCommand("strikethrough", false, "") the printed output on it is: oninput:'' Having properly identified events helps for correct undo/redo implementation, among other things. 1588152 1 cgarcia 2019-11-07 01:56:39 -0800 This is not GTK specific. static bool executeStrikethrough(Frame& frame, Event*, EditorCommandSource source, const String&) { Ref<EditingStyle> style = EditingStyle::create(); style->setStrikeThroughChange(textDecorationChangeForToggling(frame.editor(), CSSPropertyWebkitTextDecorationsInEffect, "line-through"_s)); // FIXME: Needs a new EditAction! return applyCommandToFrame(frame, source, EditAction::Underline, WTFMove(style)); } Regarding others identified as empty string is probably because they are not listed in: https://w3c.github.io/input-events/#interface-InputEvent-Attributes 1588153 2 mcrha 2019-11-07 02:05:11 -0800 (In reply to Carlos Garcia Campos from comment #1) > Regarding others identified as empty string is probably because they are not > listed in: > > https://w3c.github.io/input-events/#interface-InputEvent-Attributes Aha, nice. Should I try to identify those which are listed in the above URL and WebKitGTK+ reports empty string in the oninput() event? By the way, I tried the above JavaScipt commands in Firefox (67.0) and calling document.execCommand() did not trigger the oninput event handler. For me, WebKit(GTK+) works better than Firefox in this regard (because I rely on these events heavily). 1588158 3 383032 cgarcia 2019-11-07 02:57:20 -0800 Created attachment 383032 Patch 1588183 4 383032 aperez 2019-11-07 05:50:37 -0800 Comment on attachment 383032 Patch Patch looks good to me. While I don't expect any issue with the changes because they build and complete upon existing code without essentially changing how things work, let's anyway wait a day or two before landing it in case somebody else may have feedback :-) 1588585 5 mcrha 2019-11-08 00:28:03 -0800 (In reply to Milan Crha from comment #2) > Should I try to identify those which are listed in the above URL > and WebKitGTK+ reports empty string in the oninput() event? I went ahead and opened bug #203992 for the other events. 1588592 6 cgarcia 2019-11-08 01:09:42 -0800 Committed r252233: <https://trac.webkit.org/changeset/252233> 1588593 7 webkit-bug-importer 2019-11-08 01:12:29 -0800 <rdar://problem/57014779> 383032 2019-11-07 02:57:20 -0800 2019-11-07 05:50:37 -0800 Patch wcore-strikethrough.diff text/plain 5962 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlZTJhOGIxZDZiMi4uOTdlMTQ4NDMxOWIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAxOS0xMS0wNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisK KyAgICAgICAgJ1N0cmlrZXRocm91Z2gnIGVkaXRpbmcgY29tbWFuZCByZXBvcnRlZCBhcyAnZm9y bWF0VW5kZXJsaW5lJworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjAzOTQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBmYXN0L2V2ZW50cy9pbnB1dC1ldmVudHMtc3RyaWtldGhyb3VnaC10eXBlLWV4cGVj dGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9ldmVudHMvaW5wdXQtZXZlbnRzLXN0cmlr ZXRocm91Z2gtdHlwZS5odG1sOiBBZGRlZC4KKwogMjAxOS0xMS0wNiAgQ2FybG9zIEdhcmNpYSBD YW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gSW1wbGVtZW50IHN1 cHBvcnQgZm9yIFBvaW50ZXIgTG9jayBBUEkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL2lucHV0LWV2ZW50cy1zdHJpa2V0aHJvdWdoLXR5cGUtZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvZmFzdC9ldmVudHMvaW5wdXQtZXZlbnRzLXN0cmlrZXRocm91Z2gtdHlwZS1leHBl Y3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLjQzNzNjNTM0 MjhkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvaW5wdXQtZXZl bnRzLXN0cmlrZXRocm91Z2gtdHlwZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMSBAQAorQ2hl Y2sgdGhhdCBzdHJpa2VUaHJvdWdoIGNvbW1hbmQgcHJvZHVjZXMgYW4gaW5wdXQgZXZlbnQgb2Yg dHlwZSBmb3JtYXRTdHJpa2VUaHJvdWdoCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNl cmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKwor CitQQVNTIGV2ZW50LnR5cGUgaXMgImlucHV0IgorUEFTUyBldmVudC5pbnB1dFR5cGUgaXMgImZv cm1hdFN0cmlrZVRocm91Z2giCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RF U1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvaW5wdXQt ZXZlbnRzLXN0cmlrZXRocm91Z2gtdHlwZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMv aW5wdXQtZXZlbnRzLXN0cmlrZXRocm91Z2gtdHlwZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwLi5hNzhmODY2MWZlZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvZXZlbnRzL2lucHV0LWV2ZW50cy1zdHJpa2V0aHJvdWdoLXR5cGUuaHRtbApA QCAtMCwwICsxLDIyIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+CisgICAgPHNj cmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hl YWQ+Cis8Ym9keT4KKyAgICA8ZGl2IGlkPSJlZGl0YWJsZSIgY29udGVudGVkaXRhYmxlPjwvZGl2 PgorICAgIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KKyAgICAgICAgZGVzY3JpcHRp b24oIkNoZWNrIHRoYXQgc3RyaWtlVGhyb3VnaCBjb21tYW5kIHByb2R1Y2VzIGFuIGlucHV0IGV2 ZW50IG9mIHR5cGUgZm9ybWF0U3RyaWtlVGhyb3VnaCIpOworCisgICAgICAgIGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJlZGl0YWJsZSIpLmZvY3VzKCk7CisgICAgICAgIGlmICh3aW5kb3cudGVz dFJ1bm5lcikgeworICAgICAgICAgICAgZG9jdW1lbnQub25pbnB1dCA9IGZ1bmN0aW9uKGV2ZW50 KSB7CisgICAgICAgICAgICAgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJldmVudC50eXBlIiwg ImlucHV0Iik7CisgICAgICAgICAgICAgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJldmVudC5p bnB1dFR5cGUiLCAiZm9ybWF0U3RyaWtlVGhyb3VnaCIpOworICAgICAgICAgICAgfQorICAgICAg ICAgICAgdGVzdFJ1bm5lci5leGVjQ29tbWFuZCgnc3RyaWtlVGhyb3VnaCcpOworICAgICAgICB9 CisgICAgPC9zY3JpcHQ+CisgICAgPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0 LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDYyZWIx YTE2YmYwLi4wNmY5ZGNjOWU4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTEx LTA3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAg ICAnU3RyaWtldGhyb3VnaCcgZWRpdGluZyBjb21tYW5kIHJlcG9ydGVkIGFzICdmb3JtYXRVbmRl cmxpbmUnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDM5NDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGQgYW4gRWRpdEFjdGlvbiBmb3Igc3RyaWtlVGhyb3VnaCBjb21tYW5kLgorCisgICAgICAgIFRl c3Q6IGZhc3QvZXZlbnRzL2lucHV0LWV2ZW50cy1zdHJpa2V0aHJvdWdoLXR5cGUuaHRtbAorCisg ICAgICAgICogZWRpdGluZy9FZGl0QWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnVuZG9S ZWRvTGFiZWwpOiBIYW5kbGUgU3RyaWtlVGhyb3VnaCBhY3Rpb24uCisgICAgICAgICogZWRpdGlu Zy9FZGl0QWN0aW9uLmg6CisgICAgICAgICogZWRpdGluZy9FZGl0Q29tbWFuZC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjppbnB1dFR5cGVOYW1lRm9yRWRpdGluZ0FjdGlvbik6IERpdHRvLgorICAg ICAgICAqIGVkaXRpbmcvRWRpdG9yQ29tbWFuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpleGVj dXRlU3RyaWtldGhyb3VnaCk6IFVzZSBTdHJpa2VUaHJvdWdoIGFjdGlvbiBpbnN0ZWFkIG9mIFVu ZGVybGluZS4KKwogMjAxOS0xMS0wNiAgUGhpbGlwcGUgTm9ybWFuZCAgPHBoaWxuQGlnYWxpYS5j b20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMjQ5NDI4KTogW0dTdHJlYW1lcl0gVlA5IHZpZGVv IHJlbmRlcmVkIGdyZWVuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRB Y3Rpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0QWN0aW9uLmNwcAppbmRleCA3 ZDg1Y2VkNWIyMi4uZmJhZWY1ODdjOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRp bmcvRWRpdEFjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0QWN0aW9u LmNwcApAQCAtODQsNiArODQsOCBAQCBTdHJpbmcgdW5kb1JlZG9MYWJlbChFZGl0QWN0aW9uIGVk aXRBY3Rpb24pCiAgICAgICAgIHJldHVybiBXRUJfVUlfU1RSSU5HX0tFWSgiU3VwZXJzY3JpcHQi LCAiU3VwZXJzY3JpcHQgKFVuZG8gYWN0aW9uIG5hbWUpIiwgIlVuZG8gYWN0aW9uIG5hbWUiKTsK ICAgICBjYXNlIEVkaXRBY3Rpb246OlVuZGVybGluZToKICAgICAgICAgcmV0dXJuIFdFQl9VSV9T VFJJTkdfS0VZKCJVbmRlcmxpbmUiLCAiVW5kZXJsaW5lIChVbmRvIGFjdGlvbiBuYW1lKSIsICJV bmRvIGFjdGlvbiBuYW1lIik7CisgICAgY2FzZSBFZGl0QWN0aW9uOjpTdHJpa2VUaHJvdWdoOgor ICAgICAgICByZXR1cm4gV0VCX1VJX1NUUklOR19LRVkoIlN0cmlrZVRocm91Z2giLCAiU3RyaWtl VGhyb3VnaCAoVW5kbyBhY3Rpb24gbmFtZSkiLCAiVW5kbyBhY3Rpb24gbmFtZSIpOwogICAgIGNh c2UgRWRpdEFjdGlvbjo6T3V0bGluZToKICAgICAgICAgcmV0dXJuIFdFQl9VSV9TVFJJTkdfS0VZ KCJPdXRsaW5lIiwgIk91dGxpbmUgKFVuZG8gYWN0aW9uIG5hbWUpIiwgIlVuZG8gYWN0aW9uIG5h bWUiKTsKICAgICBjYXNlIEVkaXRBY3Rpb246OlVuc2NyaXB0OgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvZWRpdGluZy9FZGl0QWN0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0Vk aXRBY3Rpb24uaAppbmRleCAxMjJiYjRkOGNhOC4uMjE2OGViMDI4NjEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdEFjdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Vk aXRpbmcvRWRpdEFjdGlvbi5oCkBAIC01OSw2ICs1OSw3IEBAIGVudW0gY2xhc3MgRWRpdEFjdGlv biA6IHVpbnQ4X3QgewogICAgIFN1YnNjcmlwdCwKICAgICBTdXBlcnNjcmlwdCwKICAgICBVbmRl cmxpbmUsCisgICAgU3RyaWtlVGhyb3VnaCwKICAgICBPdXRsaW5lLAogICAgIFVuc2NyaXB0LAog ICAgIERlbGV0ZUJ5RHJhZywKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRp dENvbW1hbmQuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0Q29tbWFuZC5jcHAKaW5k ZXggMmJlZmUxZmRlNDkuLjZiM2Q4NWFiM2YwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9l ZGl0aW5nL0VkaXRDb21tYW5kLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRD b21tYW5kLmNwcApAQCAtNTYsNiArNTYsOCBAQCBTdHJpbmcgaW5wdXRUeXBlTmFtZUZvckVkaXRp bmdBY3Rpb24oRWRpdEFjdGlvbiBhY3Rpb24pCiAgICAgICAgIHJldHVybiAiZm9ybWF0U3VwZXJz Y3JpcHQiX3M7CiAgICAgY2FzZSBFZGl0QWN0aW9uOjpVbmRlcmxpbmU6CiAgICAgICAgIHJldHVy biAiZm9ybWF0VW5kZXJsaW5lIl9zOworICAgIGNhc2UgRWRpdEFjdGlvbjo6U3RyaWtlVGhyb3Vn aDoKKyAgICAgICAgcmV0dXJuICJmb3JtYXRTdHJpa2VUaHJvdWdoIl9zOwogICAgIGNhc2UgRWRp dEFjdGlvbjo6U2V0Q29sb3I6CiAgICAgICAgIHJldHVybiAiZm9ybWF0Rm9udENvbG9yIl9zOwog ICAgIGNhc2UgRWRpdEFjdGlvbjo6RGVsZXRlQnlEcmFnOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZWRpdGluZy9FZGl0b3JDb21tYW5kLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcv RWRpdG9yQ29tbWFuZC5jcHAKaW5kZXggMzBlODIyZTUxMDIuLjlkYmE3MDY5YWQxIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvckNvbW1hbmQuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yQ29tbWFuZC5jcHAKQEAgLTEwODIsOCArMTA4Miw3IEBA IHN0YXRpYyBib29sIGV4ZWN1dGVTdHJpa2V0aHJvdWdoKEZyYW1lJiBmcmFtZSwgRXZlbnQqLCBF ZGl0b3JDb21tYW5kU291cmNlIHNvdXJjCiB7CiAgICAgUmVmPEVkaXRpbmdTdHlsZT4gc3R5bGUg PSBFZGl0aW5nU3R5bGU6OmNyZWF0ZSgpOwogICAgIHN0eWxlLT5zZXRTdHJpa2VUaHJvdWdoQ2hh bmdlKHRleHREZWNvcmF0aW9uQ2hhbmdlRm9yVG9nZ2xpbmcoZnJhbWUuZWRpdG9yKCksIENTU1By b3BlcnR5V2Via2l0VGV4dERlY29yYXRpb25zSW5FZmZlY3QsICJsaW5lLXRocm91Z2giX3MpKTsK LSAgICAvLyBGSVhNRTogTmVlZHMgYSBuZXcgRWRpdEFjdGlvbiEKLSAgICByZXR1cm4gYXBwbHlD b21tYW5kVG9GcmFtZShmcmFtZSwgc291cmNlLCBFZGl0QWN0aW9uOjpVbmRlcmxpbmUsIFdURk1v dmUoc3R5bGUpKTsKKyAgICByZXR1cm4gYXBwbHlDb21tYW5kVG9GcmFtZShmcmFtZSwgc291cmNl LCBFZGl0QWN0aW9uOjpTdHJpa2VUaHJvdWdoLCBXVEZNb3ZlKHN0eWxlKSk7CiB9CiAKIHN0YXRp YyBib29sIGV4ZWN1dGVTdHlsZVdpdGhDU1MoRnJhbWUmIGZyYW1lLCBFdmVudCosIEVkaXRvckNv bW1hbmRTb3VyY2UsIGNvbnN0IFN0cmluZyYgdmFsdWUpCg==