203943 2019-11-06 21:59:38 -0800 Remove unimplemented property error log in when getting a property value from a computed style 2019-11-06 23:22:16 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 198680 1 hi hi commit-queue esprehn+autocc ews-watchlist glenn gyuyoung.kim hi macpherson menard rniwa simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1588112 0 hi 2019-11-06 21:59:38 -0800 In r251581, the list of computed CSS properties was changed to be autogenerated from 'CSSProperties.json'. One issue that arose from this was that `-webkit-text-decorations-in-effect` was no longer part of the `CSSComputedStyleDeclaration`, which caused a number of editing tests to fail, as that property is used for holding internal state related to various editing commands (e.g. `document.execCommand`). In order to get around this, `ComputedStyleExtractor::copyProperties()` was modified to instead copy _all_ CSS properties, regardless of whether they're part of the set of computed CSS properties. Unfortunately, this had a side effect of triggering a longstanding `LOG_ERROR` (added in r6178) when attempting to retrieve the value of certain CSS properties (e.g. `-internal-text-autosizing-status`). Since this path can be triggered by any arbitrary JavaScript (e.g. `window.getComputedStyle(document.body).getPropertyCSSValue("-internal-text-autosizing-status")`), it doesn't add much benefit to have this log, especially since the code itself is already annotated with comments/FIXMEs for CSS properties that don't have a computed value. 1588114 1 383023 hi 2019-11-06 22:04:24 -0800 Created attachment 383023 Patch 1588125 2 383023 commit-queue 2019-11-06 23:21:44 -0800 Comment on attachment 383023 Patch Clearing flags on attachment: 383023 Committed r252176: <https://trac.webkit.org/changeset/252176> 1588126 3 commit-queue 2019-11-06 23:21:46 -0800 All reviewed patches have been landed. Closing bug. 1588127 4 webkit-bug-importer 2019-11-06 23:22:16 -0800 <rdar://problem/56973391> 383023 2019-11-06 22:04:24 -0800 2019-11-06 23:21:44 -0800 Patch bug-203943-20191106220423.patch text/plain 3963 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0ZjUwNGYzNTIwZGE3MDg5YTVlY2E3ZDE5YWJjYmM0YWUxOTQ4NGQxLi5k ZTU0MjM3NThhMDFiZTZlMjRmMjA2ODRmZmFmZDlmNmEyOGJiNjZiIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjkgQEAKKzIwMTktMTEtMDYgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29t PgorCisgICAgICAgIFJlbW92ZSB1bmltcGxlbWVudGVkIHByb3BlcnR5IGVycm9yIGxvZyBpbiB3 aGVuIGdldHRpbmcgYSBwcm9wZXJ0eSB2YWx1ZSBmcm9tIGEgY29tcHV0ZWQgc3R5bGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzk0MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHIyNTE1ODEsIHRo ZSBsaXN0IG9mIGNvbXB1dGVkIENTUyBwcm9wZXJ0aWVzIHdhcyBjaGFuZ2VkIHRvIGJlIGF1dG9n ZW5lcmF0ZWQgZnJvbSAnQ1NTUHJvcGVydGllcy5qc29uJy4KKyAgICAgICAgT25lIGlzc3VlIHRo YXQgYXJvc2UgZnJvbSB0aGlzIHdhcyB0aGF0IGAtd2Via2l0LXRleHQtZGVjb3JhdGlvbnMtaW4t ZWZmZWN0YCB3YXMgbm8gbG9uZ2VyIHBhcnQgb2YgdGhlCisgICAgICAgIGBDU1NDb21wdXRlZFN0 eWxlRGVjbGFyYXRpb25gLCB3aGljaCBjYXVzZWQgYSBudW1iZXIgb2YgZWRpdGluZyB0ZXN0cyB0 byBmYWlsLCBhcyB0aGF0IHByb3BlcnR5IGlzIHVzZWQKKyAgICAgICAgZm9yIGhvbGRpbmcgaW50 ZXJuYWwgc3RhdGUgcmVsYXRlZCB0byB2YXJpb3VzIGVkaXRpbmcgY29tbWFuZHMgKGUuZy4gYGRv Y3VtZW50LmV4ZWNDb21tYW5kKC4uLilgKS4gSW4KKyAgICAgICAgb3JkZXIgdG8gZ2V0IGFyb3Vu ZCB0aGlzLCBgQ29tcHV0ZWRTdHlsZUV4dHJhY3Rvcjo6Y29weVByb3BlcnRpZXMoKWAgd2FzIG1v ZGlmaWVkIHRvIGluc3RlYWQgY29weSBhbGwgQ1NTCisgICAgICAgIHByb3BlcnRpZXMsIHJlZ2Fy ZGxlc3Mgb2Ygd2hldGhlciB0aGV5J3JlIHBhcnQgb2YgdGhlIHNldCBvZiBjb21wdXRlZCBDU1Mg cHJvcGVydGllcy4gVW5mb3J0dW5hdGVseSwgdGhpcworICAgICAgICBoYWQgYSBzaWRlIGVmZmVj dCBvZiB0cmlnZ2VyaW5nIGEgbG9uZ3N0YW5kaW5nIGBMT0dfRVJST1JgIChhZGRlZCBpbiByNjE3 OCkgd2hlbiBhdHRlbXB0aW5nIHRvIHJldHJpZXZlCisgICAgICAgIHRoZSB2YWx1ZSBvZiBjZXJ0 YWluIENTUyBwcm9wZXJ0aWVzIChlLmcuIGAtaW50ZXJuYWwtdGV4dC1hdXRvc2l6aW5nLXN0YXR1 c2ApLgorCisgICAgICAgIFNpbmNlIHRoaXMgY29kZSBwYXRoIGNhbiBiZSB0cmlnZ2VyZWQgYnkg SmF2YVNjcmlwdCAoZS5nLiBgZ2V0Q29tcHV0ZWRTdHlsZShub2RlKS5nZXRQcm9wZXJ0eUNTU1Zh bHVlKCIuLi4iKWApLAorICAgICAgICBpdCBkb2Vzbid0IGFkZCBtdWNoIGJlbmVmaXQgdG8gaGF2 ZSB0aGlzIGxvZywgZXNwZWNpYWxseSBzaW5jZSB0aGUgY29kZSBpdHNlbGYgaXMgYWxyZWFkeSBh bm5vdGF0ZWQgd2l0aAorICAgICAgICBjb21tZW50cy9GSVhNRXMgZm9yIENTUyBwcm9wZXJ0aWVz IHRoYXQgZG9uJ3QgaGF2ZSBhIGNvbXB1dGVkIHZhbHVlLgorCisgICAgICAgICogY3NzL0NTU0Nv bXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb21wdXRlZFN0 eWxlRXh0cmFjdG9yOjp2YWx1ZUZvclByb3BlcnR5SW5TdHlsZSk6CisgICAgICAgIChXZWJDb3Jl Ojpsb2dVbmltcGxlbWVudGVkUHJvcGVydHlJRCk6IERlbGV0ZWQuCisgICAgICAgICogY3NzL1NW R0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb21w dXRlZFN0eWxlRXh0cmFjdG9yOjpzdmdQcm9wZXJ0eVZhbHVlKToKKwogMjAxOS0xMS0wNCAgTXls ZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmFtZSB1 aS1tb25vc3BhY2VkIHRvIHVpLW1vbm9zcGFjZSB0byBtYXRjaCB0aGUgbW9ub3NwYWNlIGdlbmVy aWMgZm9udCBmYW1pbHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDb21wdXRl ZFN0eWxlRGVjbGFyYXRpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5 bGVEZWNsYXJhdGlvbi5jcHAKaW5kZXggNGJjMjFhZTBjNmQxMDMyNTNiOGI4Yzg3NGRiMDQ2MjI2 MTc4MGI2MS4uMWQyYWY3NjI4ZDUxYmViN2Y2NDY5MmQxNjVhYWJjNmMzNjljZjZiNiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAK QEAgLTE2NzksMTUgKzE2NzksNiBAQCBzdGF0aWMgUmVmPENTU1ZhbHVlPiBjb3VudGVyVG9DU1NW YWx1ZShjb25zdCBSZW5kZXJTdHlsZSYgc3R5bGUsIENTU1Byb3BlcnR5SUQgcAogICAgIHJldHVy biBsaXN0OwogfQogCi1zdGF0aWMgdm9pZCBsb2dVbmltcGxlbWVudGVkUHJvcGVydHlJRChDU1NQ cm9wZXJ0eUlEIHByb3BlcnR5SUQpCi17Ci0gICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPEhhc2hT ZXQ8Q1NTUHJvcGVydHlJRD4+IHByb3BlcnR5SURTZXQ7Ci0gICAgaWYgKCFwcm9wZXJ0eUlEU2V0 LmdldCgpLmFkZChwcm9wZXJ0eUlEKS5pc05ld0VudHJ5KQotICAgICAgICByZXR1cm47Ci0KLSAg ICBMT0dfRVJST1IoIldlYktpdCBkb2VzIG5vdCB5ZXQgaW1wbGVtZW50IGdldENvbXB1dGVkU3R5 bGUgZm9yICclcycuIiwgZ2V0UHJvcGVydHlOYW1lKHByb3BlcnR5SUQpKTsKLX0KLQogc3RhdGlj IFJlZjxDU1NWYWx1ZUxpc3Q+IGZvbnRGYW1pbHlMaXN0RnJvbVN0eWxlKGNvbnN0IFJlbmRlclN0 eWxlJiBzdHlsZSkKIHsKICAgICBhdXRvIGxpc3QgPSBDU1NWYWx1ZUxpc3Q6OmNyZWF0ZUNvbW1h U2VwYXJhdGVkKCk7CkBAIC0zODgxLDcgKzM4NzIsNiBAQCBSZWZQdHI8Q1NTVmFsdWU+IENvbXB1 dGVkU3R5bGVFeHRyYWN0b3I6OnZhbHVlRm9yUHJvcGVydHlJblN0eWxlKGNvbnN0IFJlbmRlclN0 eQogICAgICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgfQogCi0gICAgbG9nVW5pbXBsZW1l bnRlZFByb3BlcnR5SUQocHJvcGVydHlJRCk7CiAgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TVkdDU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRp b24uY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL1NWR0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlv bi5jcHAKaW5kZXggMTM1MTU0NDFlNWM0NGZmNzRiNTczOTUyZWRjODVlOTg2Y2Y5MWMwYi4uMjcx OGU0NTM4MjI2YjU5MDYwNDMzNWIzMmZhYTY3MzM3NTU5Y2MyZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvY3NzL1NWR0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvY3NzL1NWR0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAKQEAgLTE5 MSw3ICsxOTEsNiBAQCBSZWZQdHI8Q1NTVmFsdWU+IENvbXB1dGVkU3R5bGVFeHRyYWN0b3I6OnN2 Z1Byb3BlcnR5VmFsdWUoQ1NTUHJvcGVydHlJRCBwcm9wZXJ0eQogICAgICAgICAvLyBpbiBlaXRo ZXIgdGhpcyBzd2l0Y2ggc3RhdGVtZW50IG9yIHRoZSBvbmUgaW4gQ1NTQ29tcHV0ZWRTdHlsZURl bGNhcmF0aW9uOjpnZXRQcm9wZXJ0eUNTU1ZhbHVlCiAgICAgICAgIEFTU0VSVF9XSVRIX01FU1NB R0UoMCwgInVuaW1wbGVtZW50ZWQgcHJvcGVydHlJRDogJWQiLCBwcm9wZXJ0eUlEKTsKICAgICB9 Ci0gICAgTE9HX0VSUk9SKCJ1bmltcGxlbWVudGVkIHByb3BlcnR5SUQ6ICVkIiwgcHJvcGVydHlJ RCk7CiAgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAK