203933 2019-11-06 17:23:24 -0800 Picture-in-Picture events are not fired if we switch the Picture-in-Picture mode through modern media controls 2019-11-12 07:39:58 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 peng.liu6 peng.liu6 commit-queue eric.carlson ews-watchlist glenn jer.noble joepeck philipj sergio tsavell webkit-bug-importer oldest_to_newest 1588014 0 peng.liu6 2019-11-06 17:23:24 -0800 Picture-in-Picture events are not fired when enter/exit the Picture-in-Picture mode through modern media controls 1588015 1 webkit-bug-importer 2019-11-06 17:24:54 -0800 <rdar://problem/56966334> 1588021 2 382990 peng.liu6 2019-11-06 17:31:50 -0800 Created attachment 382990 Patch 1588062 3 382990 eric.carlson 2019-11-06 18:39:24 -0800 Comment on attachment 382990 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382990&action=review > Source/WebCore/Modules/modern-media-controls/media/pip-support.js:55 > - media.webkitSetPresentationMode(media.webkitPresentationMode === PiPMode ? InlineMode : PiPMode); > + if (!document.pictureInPictureElement) > + media.requestPictureInPicture(); > + else > + document.exitPictureInPicture(); Is this required, or is the change just modernize the controls code? If it is required, does that mean that existing code that uses video.webkitSetPresentationMode (e.g. all WebKit-specific PiP code) won't behave correctly? 1588103 4 382990 peng.liu6 2019-11-06 20:53:04 -0800 Comment on attachment 382990 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382990&action=review >> Source/WebCore/Modules/modern-media-controls/media/pip-support.js:55 >> + document.exitPictureInPicture(); > > Is this required, or is the change just modernize the controls code? > > If it is required, does that mean that existing code that uses video.webkitSetPresentationMode (e.g. all WebKit-specific PiP code) won't behave correctly? It is required. The video.webkitSetPresentationMode() will continue working, but if we use it, the video element won't fire the events defined in the picture-in-picture API spec (enterpictureinpicture, leavepictureinpicture) properly. 1588573 5 peng.liu6 2019-11-07 22:05:52 -0800 In Bug 203989, we will let video.webkitSetPresentationMode() fire the events like the interface defined in the picture-in-picture API spec. 1588696 6 382990 commit-queue 2019-11-08 10:06:51 -0800 Comment on attachment 382990 Patch Clearing flags on attachment: 382990 Committed r252240: <https://trac.webkit.org/changeset/252240> 1588697 7 commit-queue 2019-11-08 10:06:52 -0800 All reviewed patches have been landed. Closing bug. 1589251 8 tsavell 2019-11-11 10:17:59 -0800 It looks like the changes in: https://trac.webkit.org/changeset/252240/webkit caused two tests to timeout: media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html media/modern-media-controls/pip-support/pip-support-click.html history: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=media%2Fmodern-media-controls%2Fmedia-controller%2Fmedia-controller-inline-to-fullscreen-to-pip-to-inline.html&test=media%2Fmodern-media-controls%2Fpip-support%2Fpip-support-click.html Can this be looked at today? 1589252 9 peng.liu6 2019-11-11 10:21:00 -0800 Got it, will look into them now. Thanks! 1589332 10 peng.liu6 2019-11-11 14:42:41 -0800 Reopening to attach new patch. 1589333 11 383302 peng.liu6 2019-11-11 14:42:42 -0800 Created attachment 383302 Patch 1589334 12 383302 peng.liu6 2019-11-11 14:43:48 -0800 Comment on attachment 383302 Patch This patch can fix the timeout failure of media/modern-media-controls/pip-support/pip-support-click.html. 1589340 13 peng.liu6 2019-11-11 14:56:54 -0800 (In reply to Truitt Savell from comment #8) > It looks like the changes in: https://trac.webkit.org/changeset/252240/webkit > > caused two tests to timeout: > media/modern-media-controls/media-controller/media-controller-inline-to- > fullscreen-to-pip-to-inline.html For this layout test, can we disable it for mac-wk1 for now? It is related to the test runner updates that need to be done in bug 203723. Also, I need to look into bug 183490 to see the related media control bugs. 1589525 14 383302 commit-queue 2019-11-12 07:39:56 -0800 Comment on attachment 383302 Patch Clearing flags on attachment: 383302 Committed r252365: <https://trac.webkit.org/changeset/252365> 1589526 15 commit-queue 2019-11-12 07:39:58 -0800 All reviewed patches have been landed. Closing bug. 382990 2019-11-06 17:31:50 -0800 2019-11-08 10:06:51 -0800 Patch bug-203933-20191106173149.patch text/plain 4029 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyMTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzMzMWNjODA3ZTI0ZjVi MzNmOWRhZmIwYWZjYWEyMzdjYTJlY2JiZi4uZjA0NzkzMjFhNDUyNDBjMWRlODcyN2VhMGY3MTYy YjhjM2Q3YTU1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTExLTA2ICBQZW5n IExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAgICAgUGljdHVyZS1pbi1QaWN0dXJl IGV2ZW50cyBhcmUgbm90IGZpcmVkIHdoZW4gZW50ZXIvZXhpdCB0aGUgUGljdHVyZS1pbi1QaWN0 dXJlIG1vZGUgdGhyb3VnaCBtb2Rlcm4gbWVkaWEgY29udHJvbHMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzkzMworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgbGF5b3V0 IHRlc3QgY2FzZXMuIE5vIG5ldyB0ZXN0IGlzIHJlcXVpcmVkLgorCisgICAgICAgICogTW9kdWxl cy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWVkaWEvcGlwLXN1cHBvcnQuanM6CisgICAgICAgIChQ aVBTdXBwb3J0LnByb3RvdHlwZS5idXR0b25XYXNQcmVzc2VkKToKKyAgICAgICAgKiBNb2R1bGVz L3BpY3R1cmVpbnBpY3R1cmUvSFRNTFZpZGVvRWxlbWVudFBpY3R1cmVJblBpY3R1cmUuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6SFRNTFZpZGVvRWxlbWVudFBpY3R1cmVJblBpY3R1cmU6OmRpZEVu dGVyUGljdHVyZUluUGljdHVyZSk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVmlkZW9FbGVtZW50 UGljdHVyZUluUGljdHVyZTo6ZGlkRXhpdFBpY3R1cmVJblBpY3R1cmUpOgorCiAyMDE5LTExLTA2 ICBPcmlvbCBCcnVmYXUgIDxvYnJ1ZmF1QGlnYWxpYS5jb20+CiAKICAgICAgICAgS2VlcCBOb25l IHZhbHVlIGF0IHRoZSBlbmQgb2YgdGhlIExpc3RTdHlsZVR5cGUgZW51bQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWVkaWEvcGlwLXN1 cHBvcnQuanMgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9t ZWRpYS9waXAtc3VwcG9ydC5qcwppbmRleCBlMWJmYzdkMjBkMTI0Y2IyZTU0NDA4MWY1ODY5ODA1 MWNlNDQxNDhiLi4wNmI0ODM2YzZmYTM4MjFiZjc0MzQ0ODgxOTIyNjRjMThiNzQ4MjRiIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9tZWRp YS9waXAtc3VwcG9ydC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21vZGVybi1tZWRp YS1jb250cm9scy9tZWRpYS9waXAtc3VwcG9ydC5qcwpAQCAtNDksNyArNDksMTAgQEAgY2xhc3Mg UGlQU3VwcG9ydCBleHRlbmRzIE1lZGlhQ29udHJvbGxlclN1cHBvcnQKICAgICBidXR0b25XYXNQ cmVzc2VkKGNvbnRyb2wpCiAgICAgewogICAgICAgICBjb25zdCBtZWRpYSA9IHRoaXMubWVkaWFD b250cm9sbGVyLm1lZGlhOwotICAgICAgICBtZWRpYS53ZWJraXRTZXRQcmVzZW50YXRpb25Nb2Rl KG1lZGlhLndlYmtpdFByZXNlbnRhdGlvbk1vZGUgPT09IFBpUE1vZGUgPyBJbmxpbmVNb2RlIDog UGlQTW9kZSk7CisgICAgICAgIGlmICghZG9jdW1lbnQucGljdHVyZUluUGljdHVyZUVsZW1lbnQp CisgICAgICAgICAgICBtZWRpYS5yZXF1ZXN0UGljdHVyZUluUGljdHVyZSgpOworICAgICAgICBl bHNlCisgICAgICAgICAgICBkb2N1bWVudC5leGl0UGljdHVyZUluUGljdHVyZSgpOwogICAgIH0K IAogICAgIHN5bmNDb250cm9sKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv cGljdHVyZWlucGljdHVyZS9IVE1MVmlkZW9FbGVtZW50UGljdHVyZUluUGljdHVyZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3BpY3R1cmVpbnBpY3R1cmUvSFRNTFZpZGVvRWxlbWVudFBp Y3R1cmVJblBpY3R1cmUuY3BwCmluZGV4IDRmYzlhZmJkOGQ3NGQxYmJmYzc5YTkxYjcwMzEwZDE4 ODBkZTQwYjIuLjFiMzdkZjdhNTliOWRmNTZlZDljNGY1YjI4ZDIxMjZlNzA1YjM1MGEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvcGljdHVyZWlucGljdHVyZS9IVE1MVmlkZW9F bGVtZW50UGljdHVyZUluUGljdHVyZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9w aWN0dXJlaW5waWN0dXJlL0hUTUxWaWRlb0VsZW1lbnRQaWN0dXJlSW5QaWN0dXJlLmNwcApAQCAt MTUyLDExICsxNTIsMTIgQEAgdm9pZCBIVE1MVmlkZW9FbGVtZW50UGljdHVyZUluUGljdHVyZTo6 ZGlkRW50ZXJQaWN0dXJlSW5QaWN0dXJlKGNvbnN0IEludFNpemUmIHcKICAgICBtX3ZpZGVvRWxl bWVudC5kb2N1bWVudCgpLnNldFBpY3R1cmVJblBpY3R1cmVFbGVtZW50KCZtX3ZpZGVvRWxlbWVu dCk7CiAgICAgbV9waWN0dXJlSW5QaWN0dXJlV2luZG93LT5zZXRTaXplKHdpbmRvd1NpemUpOwog CisgICAgRW50ZXJQaWN0dXJlSW5QaWN0dXJlRXZlbnQ6OkluaXQgaW5pdGlhbGl6ZXI7CisgICAg aW5pdGlhbGl6ZXIuYnViYmxlcyA9IHRydWU7CisgICAgaW5pdGlhbGl6ZXIucGljdHVyZUluUGlj dHVyZVdpbmRvdyA9IG1fcGljdHVyZUluUGljdHVyZVdpbmRvdzsKKyAgICBtX3ZpZGVvRWxlbWVu dC5zY2hlZHVsZUV2ZW50KEVudGVyUGljdHVyZUluUGljdHVyZUV2ZW50OjpjcmVhdGUoZXZlbnRO YW1lcygpLmVudGVycGljdHVyZWlucGljdHVyZUV2ZW50LCBXVEZNb3ZlKGluaXRpYWxpemVyKSkp OworCiAgICAgaWYgKG1fZW50ZXJQaWN0dXJlSW5QaWN0dXJlUHJvbWlzZSkgewotICAgICAgICBF bnRlclBpY3R1cmVJblBpY3R1cmVFdmVudDo6SW5pdCBpbml0aWFsaXplcjsKLSAgICAgICAgaW5p dGlhbGl6ZXIuYnViYmxlcyA9IHRydWU7Ci0gICAgICAgIGluaXRpYWxpemVyLnBpY3R1cmVJblBp Y3R1cmVXaW5kb3cgPSBtX3BpY3R1cmVJblBpY3R1cmVXaW5kb3c7Ci0gICAgICAgIG1fdmlkZW9F bGVtZW50LnNjaGVkdWxlRXZlbnQoRW50ZXJQaWN0dXJlSW5QaWN0dXJlRXZlbnQ6OmNyZWF0ZShl dmVudE5hbWVzKCkuZW50ZXJwaWN0dXJlaW5waWN0dXJlRXZlbnQsIFdURk1vdmUoaW5pdGlhbGl6 ZXIpKSk7CiAgICAgICAgIG1fZW50ZXJQaWN0dXJlSW5QaWN0dXJlUHJvbWlzZS0+cmVzb2x2ZTxJ RExJbnRlcmZhY2U8UGljdHVyZUluUGljdHVyZVdpbmRvdz4+KCptX3BpY3R1cmVJblBpY3R1cmVX aW5kb3cpOwogICAgICAgICBtX2VudGVyUGljdHVyZUluUGljdHVyZVByb21pc2UgPSBudWxscHRy OwogICAgIH0KQEAgLTE2Nyw5ICsxNjgsOSBAQCB2b2lkIEhUTUxWaWRlb0VsZW1lbnRQaWN0dXJl SW5QaWN0dXJlOjpkaWRFeGl0UGljdHVyZUluUGljdHVyZSgpCiAgICAgSU5GT19MT0coTE9HSURF TlRJRklFUik7CiAgICAgbV9waWN0dXJlSW5QaWN0dXJlV2luZG93LT5jbG9zZSgpOwogICAgIG1f dmlkZW9FbGVtZW50LmRvY3VtZW50KCkuc2V0UGljdHVyZUluUGljdHVyZUVsZW1lbnQobnVsbHB0 cik7CisgICAgbV92aWRlb0VsZW1lbnQuc2NoZWR1bGVFdmVudChFdmVudDo6Y3JlYXRlKGV2ZW50 TmFtZXMoKS5sZWF2ZXBpY3R1cmVpbnBpY3R1cmVFdmVudCwgRXZlbnQ6OkNhbkJ1YmJsZTo6WWVz LCBFdmVudDo6SXNDYW5jZWxhYmxlOjpObykpOwogCiAgICAgaWYgKG1fZXhpdFBpY3R1cmVJblBp Y3R1cmVQcm9taXNlKSB7Ci0gICAgICAgIG1fdmlkZW9FbGVtZW50LnNjaGVkdWxlRXZlbnQoRXZl bnQ6OmNyZWF0ZShldmVudE5hbWVzKCkubGVhdmVwaWN0dXJlaW5waWN0dXJlRXZlbnQsIEV2ZW50 OjpDYW5CdWJibGU6OlllcywgRXZlbnQ6OklzQ2FuY2VsYWJsZTo6Tm8pKTsKICAgICAgICAgbV9l eGl0UGljdHVyZUluUGljdHVyZVByb21pc2UtPnJlc29sdmUoKTsKICAgICAgICAgbV9leGl0UGlj dHVyZUluUGljdHVyZVByb21pc2UgPSBudWxscHRyOwogICAgIH0K 383302 2019-11-11 14:42:42 -0800 2019-11-12 07:39:56 -0800 Patch bug-203933-20191111144241.patch text/plain 1878 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyMzMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTMxZGEyMTE5MDgyZTUy ZGIxYzA2ZDExYTA4MjU2YTU2ZDllYWEyYi4uM2ZkM2EyMzE4NGRmMmJjYjViMGVlNTg2ZmIwOGEy YzcwMTg3ZjJlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTExLTExICBQZW5n IExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAgICAgUGljdHVyZS1pbi1QaWN0dXJl IGV2ZW50cyBhcmUgbm90IGZpcmVkIGlmIHdlIHN3aXRjaCB0aGUgUGljdHVyZS1pbi1QaWN0dXJl IG1vZGUgdGhyb3VnaCBtb2Rlcm4gbWVkaWEgY29udHJvbHMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzkzMworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gdGhlIFBpY3R1cmUtaW4tUGljdHVyZSBB UEkgaXMgbm90IGF2YWlsYWJsZSwgd2UgbmVlZCB0byBjYWxsIHdlYmtpdFNldFByZXNlbnRhdGlv bk1vZGUoKQorICAgICAgICBvZiB0aGUgdmlkZW8gZWxlbWVudCB0byBpbXBsZW1lbnQgdGhlIHBp Y3R1cmUtaW4tcGljdHVyZSBmZWF0dXJlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgY292ZXJl ZCBieSB0ZXN0OiBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvcGlwLXN1cHBvcnQvcGlwLXN1 cHBvcnQtY2xpY2suaHRtbAorCisgICAgICAgICogTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJv bHMvbWVkaWEvcGlwLXN1cHBvcnQuanM6CisgICAgICAgIChQaVBTdXBwb3J0LnByb3RvdHlwZS5i dXR0b25XYXNQcmVzc2VkKToKKwogMjAxOS0xMS0xMSAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFw cGxlLmNvbT4KIAogICAgICAgICBFbnN1cmUgTWVkaWFSZW1vdGUgY2FsbGJhY2sgYWx3YXlzIGNh bGxlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJuLW1lZGlhLWNv bnRyb2xzL21lZGlhL3BpcC1zdXBwb3J0LmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rl cm4tbWVkaWEtY29udHJvbHMvbWVkaWEvcGlwLXN1cHBvcnQuanMKaW5kZXggMDZiNDgzNmM2ZmEz ODIxYmY3NDM0NDg4MTkyMjY0YzE4Yjc0ODI0Yi4uM2VmZmI1ODUyODdhZDU1OWQ4ZDI0NmRkMDVk MTU1ZDJkMWQ5MDM5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4t bWVkaWEtY29udHJvbHMvbWVkaWEvcGlwLXN1cHBvcnQuanMKKysrIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWVkaWEvcGlwLXN1cHBvcnQuanMKQEAgLTQ5 LDYgKzQ5LDExIEBAIGNsYXNzIFBpUFN1cHBvcnQgZXh0ZW5kcyBNZWRpYUNvbnRyb2xsZXJTdXBw b3J0CiAgICAgYnV0dG9uV2FzUHJlc3NlZChjb250cm9sKQogICAgIHsKICAgICAgICAgY29uc3Qg bWVkaWEgPSB0aGlzLm1lZGlhQ29udHJvbGxlci5tZWRpYTsKKyAgICAgICAgaWYgKCFkb2N1bWVu dC5waWN0dXJlSW5QaWN0dXJlRW5hYmxlZCkgeworICAgICAgICAgICAgbWVkaWEud2Via2l0U2V0 UHJlc2VudGF0aW9uTW9kZShtZWRpYS53ZWJraXRQcmVzZW50YXRpb25Nb2RlID09PSBQaVBNb2Rl ID8gSW5saW5lTW9kZSA6IFBpUE1vZGUpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9 CisKICAgICAgICAgaWYgKCFkb2N1bWVudC5waWN0dXJlSW5QaWN0dXJlRWxlbWVudCkKICAgICAg ICAgICAgIG1lZGlhLnJlcXVlc3RQaWN0dXJlSW5QaWN0dXJlKCk7CiAgICAgICAgIGVsc2UK