203884 2019-11-06 02:50:08 -0800 [Cairo] Cairo graphics backend uses ImageBuffer::copyImage just to access native image buffer handles 2019-11-06 05:14:18 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 182686 1 clord clord achristensen bfulgham cgarcia commit-queue don.olmstead fujii sabouhallawa simon.fraser webkit-bug-importer zalan oldest_to_newest 1587729 0 clord 2019-11-06 02:50:08 -0800 This pattern occurs a lot in the Cairo graphics backend: RefPtr<Image> image = layerImage.copyImage(DontCopyBackingStore); if (!image) return; if (auto surface = image->nativeImageForCurrentFrame()) { ... } Which is fine on a single thread, but ImageSource is not usable off-main-thread, so any drawing that calls functions that do this will cause an assert on a debug build. I think its use of ImageSource would be safe off-main-thread, but it's overkill just to get the native image handle. This is hampering OffscreenCanvas. 1587730 1 382908 clord 2019-11-06 03:01:43 -0800 Created attachment 382908 Patch 1587750 2 382908 commit-queue 2019-11-06 05:13:17 -0800 Comment on attachment 382908 Patch Clearing flags on attachment: 382908 Committed r252136: <https://trac.webkit.org/changeset/252136> 1587751 3 commit-queue 2019-11-06 05:13:19 -0800 All reviewed patches have been landed. Closing bug. 1587752 4 webkit-bug-importer 2019-11-06 05:14:18 -0800 <rdar://problem/56940631> 382908 2019-11-06 03:01:43 -0800 2019-11-06 05:13:17 -0800 Patch bug-203884-20191106110142.patch text/plain 7228 clord U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyMDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzgyMWYyMzEyYmM3ZWZh YTM0NzQyZDY3OWM2ZDIwYjUxYzY5ZGM1ZS4uMzdkM2FjMjBkNzNjZWE5ZTRlNDA4ODhlMDZhOTQ3 NjZmM2E1OTZmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE5LTExLTA2ICBDaHJp cyBMb3JkICA8Y2xvcmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbQ2Fpcm9dIENhaXJvIGdyYXBo aWNzIGJhY2tlbmQgdXNlcyBJbWFnZUJ1ZmZlcjo6Y29weUltYWdlIGp1c3QgdG8gYWNjZXNzIG5h dGl2ZSBpbWFnZSBidWZmZXIgaGFuZGxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjAzODg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlIENhaXJvIGdyYXBoaWNzIGJhY2tlbmQgdXNlcyBJbWFnZUJ1 ZmZlcjo6Y29weUltYWdlKERvbnRDb3B5QmFja2luZ1N0b3JlKSBmcmVxdWVudGx5IGp1c3QgdG8g YWNjZXNzCisgICAgICAgIHRoZSBuYXRpdmUgaW1hZ2UgcG9pbnRlci4gVGhpcyBtYWtlcyBzZXZl cmFsIGZ1bmN0aW9ucyB1bnVzYWJsZSBvZmYtbWFpbi10aHJlYWQsIHNvIGFkZCBhbiBhY2Nlc3Nv cgorICAgICAgICBmdW5jdGlvbiB0byBhdm9pZCBkb2luZyB0aGlzLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cyAtLSBubyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9JbWFnZUJ1ZmZlci5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJv L0NhaXJvT3BlcmF0aW9ucy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDYWlybzo6ZHJhd1NoYWRv d0xheWVyQnVmZmVyKToKKyAgICAgICAgKFdlYkNvcmU6OkNhaXJvOjpkcmF3U2hhZG93SW1hZ2Up OgorICAgICAgICAoV2ViQ29yZTo6Q2Fpcm86OmZpbGxTaGFkb3dCdWZmZXIpOgorICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6Y2xpcFRvSW1hZ2VCdWZmZXIpOgorICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dEltcGxDYWlyby5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHRJbXBsQ2Fpcm86OmNsaXBUb0ltYWdl QnVmZmVyKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9JbWFnZUJ1ZmZlckNh aXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlQnVmZmVyOjpuYXRpdmVJbWFnZSBjb25z dCk6CisKIDIwMTktMTEtMDUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtGcmVlVHlwZV0gVG9vIHNsb3cgcnVubmluZyBlbmNvZGluZy9sZWdh Y3ktbWIta29yZWFuL2V1Yy1rciBXUFQgdGVzdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5oCmluZGV4IDE2OTgwMjZlYzI0NDBmMjgxNTBiNGIyMDNl NDZlYzVjNjRlMmExYjkuLjJiYWE4ZTJiMjA5ZWNmZTI0N2FjOGQ4ZTNhMDY4YzBkMDZmOWY3NmIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVy LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VCdWZmZXIuaApA QCAtMTE2LDYgKzExNiwxMCBAQCBwdWJsaWM6CiAgICAgVmVjdG9yPHVpbnQ4X3Q+IHRvRGF0YShj b25zdCBTdHJpbmcmIG1pbWVUeXBlLCBPcHRpb25hbDxkb3VibGU+IHF1YWxpdHkgPSBXVEY6Om51 bGxvcHQpIGNvbnN0OwogICAgIFZlY3Rvcjx1aW50OF90PiB0b0JHUkFEYXRhKCkgY29uc3Q7CiAK KyNpZiBVU0UoQ0FJUk8pCisgICAgTmF0aXZlSW1hZ2VQdHIgbmF0aXZlSW1hZ2UoKSBjb25zdDsK KyNlbmRpZgorCiAjaWYgIVVTRShDRykKICAgICBBZmZpbmVUcmFuc2Zvcm0gYmFzZVRyYW5zZm9y bSgpIGNvbnN0IHsgcmV0dXJuIEFmZmluZVRyYW5zZm9ybSgpOyB9CiAgICAgdm9pZCB0cmFuc2Zv cm1Db2xvclNwYWNlKENvbG9yU3BhY2Ugc3JjQ29sb3JTcGFjZSwgQ29sb3JTcGFjZSBkc3RDb2xv clNwYWNlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nh aXJvL0NhaXJvT3BlcmF0aW9ucy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jYWlyby9DYWlyb09wZXJhdGlvbnMuY3BwCmluZGV4IDQ3NThhZTg1YzA1OWI5NjU2Yzk4YjM5 MzUzMjNmOTI2ZDY4NGU4NDguLmI2ZmE2OWM3OWZlYWY3MzAxYTA5YzdlYTRmMmQzYmVkNjAyMmNj NWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0Nh aXJvT3BlcmF0aW9ucy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2Fpcm8vQ2Fpcm9PcGVyYXRpb25zLmNwcApAQCAtMTc0LDExICsxNzQsNyBAQCBlbnVtIFBhdGhE cmF3aW5nU3R5bGUgewogCiBzdGF0aWMgdm9pZCBkcmF3U2hhZG93TGF5ZXJCdWZmZXIoUGxhdGZv cm1Db250ZXh0Q2Fpcm8mIHBsYXRmb3JtQ29udGV4dCwgSW1hZ2VCdWZmZXImIGxheWVySW1hZ2Us IGNvbnN0IEZsb2F0UG9pbnQmIGxheWVyT3JpZ2luLCBjb25zdCBGbG9hdFNpemUmIGxheWVyU2l6 ZSwgY29uc3QgU2hhZG93U3RhdGUmIHNoYWRvd1N0YXRlKQogewotICAgIFJlZlB0cjxJbWFnZT4g aW1hZ2UgPSBsYXllckltYWdlLmNvcHlJbWFnZShEb250Q29weUJhY2tpbmdTdG9yZSk7Ci0gICAg aWYgKCFpbWFnZSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgaWYgKGF1dG8gc3VyZmFjZSA9IGlt YWdlLT5uYXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpKSB7CisgICAgaWYgKGF1dG8gc3VyZmFj ZSA9IGxheWVySW1hZ2UubmF0aXZlSW1hZ2UoKSkgewogICAgICAgICBkcmF3TmF0aXZlSW1hZ2Uo cGxhdGZvcm1Db250ZXh0LCBzdXJmYWNlLmdldCgpLCBGbG9hdFJlY3Qocm91bmRlZEludFBvaW50 KGxheWVyT3JpZ2luKSwgbGF5ZXJTaXplKSwgRmxvYXRSZWN0KEZsb2F0UG9pbnQoKSwgbGF5ZXJT aXplKSwgeyBzaGFkb3dTdGF0ZS5nbG9iYWxDb21wb3NpdGVPcGVyYXRvciB9LCBzaGFkb3dTdGF0 ZS5nbG9iYWxBbHBoYSwgU2hhZG93U3RhdGUoKSk7CiAgICAgfQogfQpAQCAtMTg2LDExICsxODIs NyBAQCBzdGF0aWMgdm9pZCBkcmF3U2hhZG93TGF5ZXJCdWZmZXIoUGxhdGZvcm1Db250ZXh0Q2Fp cm8mIHBsYXRmb3JtQ29udGV4dCwgSW1hZ2VCdQogLy8gRklYTUU6IFRoaXMgaXMgbW9zdGx5IHNh bWUgYXMgZHJhd1NoYWRvd0xheWVyQnVmZmVyLCBzbyB3ZSBzaG91bGQgbWVyZ2UgdHdvLgogc3Rh dGljIHZvaWQgZHJhd1NoYWRvd0ltYWdlKFBsYXRmb3JtQ29udGV4dENhaXJvJiBwbGF0Zm9ybUNv bnRleHQsIEltYWdlQnVmZmVyJiBsYXllckltYWdlLCBjb25zdCBGbG9hdFJlY3QmIGRlc3RSZWN0 LCBjb25zdCBGbG9hdFJlY3QmIHNyY1JlY3QsIGNvbnN0IFNoYWRvd1N0YXRlJiBzaGFkb3dTdGF0 ZSkKIHsKLSAgICBSZWZQdHI8SW1hZ2U+IGltYWdlID0gbGF5ZXJJbWFnZS5jb3B5SW1hZ2UoRG9u dENvcHlCYWNraW5nU3RvcmUpOwotICAgIGlmICghaW1hZ2UpCi0gICAgICAgIHJldHVybjsKLQot ICAgIGlmIChhdXRvIHN1cmZhY2UgPSBpbWFnZS0+bmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUo KSkgeworICAgIGlmIChhdXRvIHN1cmZhY2UgPSBsYXllckltYWdlLm5hdGl2ZUltYWdlKCkpIHsK ICAgICAgICAgZHJhd05hdGl2ZUltYWdlKHBsYXRmb3JtQ29udGV4dCwgc3VyZmFjZS5nZXQoKSwg ZGVzdFJlY3QsIHNyY1JlY3QsIHsgc2hhZG93U3RhdGUuZ2xvYmFsQ29tcG9zaXRlT3BlcmF0b3Ig fSwgc2hhZG93U3RhdGUuZ2xvYmFsQWxwaGEsIFNoYWRvd1N0YXRlKCkpOwogICAgIH0KIH0KQEAg LTE5OSwxMSArMTkxLDggQEAgc3RhdGljIHZvaWQgZmlsbFNoYWRvd0J1ZmZlcihQbGF0Zm9ybUNv bnRleHRDYWlybyYgcGxhdGZvcm1Db250ZXh0LCBJbWFnZUJ1ZmZlciYKIHsKICAgICBzYXZlKHBs YXRmb3JtQ29udGV4dCk7CiAKLSAgICBSZWZQdHI8SW1hZ2U+IGltYWdlID0gbGF5ZXJJbWFnZS5j b3B5SW1hZ2UoRG9udENvcHlCYWNraW5nU3RvcmUpOwotICAgIGlmIChpbWFnZSkgewotICAgICAg ICBpZiAoYXV0byBzdXJmYWNlID0gaW1hZ2UtPm5hdGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCkp Ci0gICAgICAgICAgICBjbGlwVG9JbWFnZUJ1ZmZlcihwbGF0Zm9ybUNvbnRleHQsIHN1cmZhY2Uu Z2V0KCksIEZsb2F0UmVjdChsYXllck9yaWdpbiwgZXhwYW5kZWRJbnRTaXplKGxheWVyU2l6ZSkp KTsKLSAgICB9CisgICAgaWYgKGF1dG8gc3VyZmFjZSA9IGxheWVySW1hZ2UubmF0aXZlSW1hZ2Uo KSkKKyAgICAgICAgY2xpcFRvSW1hZ2VCdWZmZXIocGxhdGZvcm1Db250ZXh0LCBzdXJmYWNlLmdl dCgpLCBGbG9hdFJlY3QobGF5ZXJPcmlnaW4sIGV4cGFuZGVkSW50U2l6ZShsYXllclNpemUpKSk7 CiAKICAgICBGaWxsU291cmNlIGZpbGxTb3VyY2U7CiAgICAgZmlsbFNvdXJjZS5nbG9iYWxBbHBo YSA9IHNoYWRvd1N0YXRlLmdsb2JhbEFscGhhOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3Bw CmluZGV4IGQ1MDM5Yjk3MjExNjRkMjFkYmQyZDhhNWQ3OGQwMzNlZDFiNWRmYWQuLjliMDI1ZTE0 NzY3MzUyZTE0YWQ0OGY4NjdiMDQ1ODVlZTgwMzQxMzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRD YWlyby5jcHAKQEAgLTI2NywxMiArMjY3LDggQEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OmNsaXBU b0ltYWdlQnVmZmVyKEltYWdlQnVmZmVyJiBidWZmZXIsIGNvbnN0IEZsb2F0UmVjdCYgZGUKICAg ICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIFJlZlB0cjxJbWFnZT4gaW1hZ2UgPSBidWZmZXIu Y29weUltYWdlKERvbnRDb3B5QmFja2luZ1N0b3JlKTsKLSAgICBpZiAoIWltYWdlKQotICAgICAg ICByZXR1cm47Ci0KICAgICBBU1NFUlQoaGFzUGxhdGZvcm1Db250ZXh0KCkpOwotICAgIGlmIChh dXRvIHN1cmZhY2UgPSBpbWFnZS0+bmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUoKSkKKyAgICBp ZiAoYXV0byBzdXJmYWNlID0gYnVmZmVyLm5hdGl2ZUltYWdlKCkpCiAgICAgICAgIENhaXJvOjpj bGlwVG9JbWFnZUJ1ZmZlcigqcGxhdGZvcm1Db250ZXh0KCksIHN1cmZhY2UuZ2V0KCksIGRlc3RS ZWN0KTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2Fpcm8vR3JhcGhpY3NDb250ZXh0SW1wbENhaXJvLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dEltcGxDYWlyby5jcHAKaW5kZXggODUy YTI3NmY3ZmM2NjE2YTk5MDRhZmVlYjBlOTkwOTcwODA2MjMzYS4uNDNmYzQ5MjI2NjEwYTliNjYw ZDY5OTZmNGNmNTdhZGQ1ZjEyOWNiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0SW1wbENhaXJvLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRJbXBsQ2Fp cm8uY3BwCkBAIC00MTEsMTEgKzQxMSw3IEBAIEludFJlY3QgR3JhcGhpY3NDb250ZXh0SW1wbENh aXJvOjpjbGlwQm91bmRzKCkKIAogdm9pZCBHcmFwaGljc0NvbnRleHRJbXBsQ2Fpcm86OmNsaXBU b0ltYWdlQnVmZmVyKEltYWdlQnVmZmVyJiBidWZmZXIsIGNvbnN0IEZsb2F0UmVjdCYgZGVzdFJl Y3QpCiB7Ci0gICAgUmVmUHRyPEltYWdlPiBpbWFnZSA9IGJ1ZmZlci5jb3B5SW1hZ2UoRG9udENv cHlCYWNraW5nU3RvcmUpOwotICAgIGlmICghaW1hZ2UpCi0gICAgICAgIHJldHVybjsKLQotICAg IGlmIChhdXRvIHN1cmZhY2UgPSBpbWFnZS0+bmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUoKSkK KyAgICBpZiAoYXV0byBzdXJmYWNlID0gYnVmZmVyLm5hdGl2ZUltYWdlKCkpCiAgICAgICAgIENh aXJvOjpjbGlwVG9JbWFnZUJ1ZmZlcihtX3BsYXRmb3JtQ29udGV4dCwgc3VyZmFjZS5nZXQoKSwg ZGVzdFJlY3QpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jYWlyby9JbWFnZUJ1ZmZlckNhaXJvLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NhaXJvL0ltYWdlQnVmZmVyQ2Fpcm8uY3BwCmluZGV4IDBmNzI2NTcwMjRlYmFj NzQwYjBlNzhmNzMyYWM5M2ZiMGRkYjdkMWMuLjVlNTVmMzA4YmU5OWI3YTFmNjAzZGEyNWQ5NWQw NWNlZTI2Y2NhYTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NhaXJvL0ltYWdlQnVmZmVyQ2Fpcm8uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NhaXJvL0ltYWdlQnVmZmVyQ2Fpcm8uY3BwCkBAIC0yNTksNiArMjU5LDExIEBA IFZlY3Rvcjx1aW50OF90PiBJbWFnZUJ1ZmZlcjo6dG9CR1JBRGF0YSgpIGNvbnN0CiAgICAgcmV0 dXJuIGltYWdlRGF0YTsKIH0KIAorTmF0aXZlSW1hZ2VQdHIgSW1hZ2VCdWZmZXI6Om5hdGl2ZUlt YWdlKCkgY29uc3QKK3sKKyAgICByZXR1cm4gbV9kYXRhLm1fc3VyZmFjZS5nZXQoKTsKK30KKwog SW1hZ2VCdWZmZXI6OkltYWdlQnVmZmVyKGNvbnN0IEZsb2F0U2l6ZSYgc2l6ZSwgZmxvYXQgcmVz b2x1dGlvblNjYWxlLCBDb2xvclNwYWNlLCBSZW5kZXJpbmdNb2RlIHJlbmRlcmluZ01vZGUsIGNv bnN0IEhvc3RXaW5kb3cqLCBib29sJiBzdWNjZXNzKQogICAgIDogbV9kYXRhKEludFNpemUoc2l6 ZSksIHJlbmRlcmluZ01vZGUpCiAgICAgLCBtX2xvZ2ljYWxTaXplKHNpemUpCg==