203883 2019-11-06 01:34:12 -0800 Keep None value at the end of the ListStyleType enum 2019-11-13 02:32:36 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 167729 1 obrufau obrufau commit-queue esprehn+autocc ews-watchlist glenn jlewis3 kondapallykalyan pdr rego simon.fraser webkit-bug-importer oldest_to_newest 1587722 0 obrufau 2019-11-06 01:34:12 -0800 (In reply to Simon Fraser (smfr) from bug 167729 comment #18) > Comment on attachment 382768 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=382768&action=review > > > Source/WebCore/rendering/style/RenderStyleConstants.h:635 > > + None, > > + String > > Seems odd not to keep None at the end. 1587723 1 382906 obrufau 2019-11-06 01:36:05 -0800 Created attachment 382906 Patch 1587921 2 382906 commit-queue 2019-11-06 14:39:04 -0800 Comment on attachment 382906 Patch Clearing flags on attachment: 382906 Committed r252151: <https://trac.webkit.org/changeset/252151> 1587922 3 commit-queue 2019-11-06 14:39:05 -0800 All reviewed patches have been landed. Closing bug. 1587923 4 webkit-bug-importer 2019-11-06 14:40:17 -0800 <rdar://problem/56959364> 1589263 5 jlewis3 2019-11-11 11:01:58 -0800 Reverted r252151 for reason: This broke internal builds and tests along with https://bugs.webkit.org/show_bug.cgi?id=167729#c18. For more information discuss with your reviewers. Committed r252334: <https://trac.webkit.org/changeset/252334> 1589807 6 obrufau 2019-11-13 02:32:36 -0800 No longer relevant since bug 167729 was reverted. If I reland bug 167729, I will include the fix there. 382906 2019-11-06 01:36:05 -0800 2019-11-06 14:39:04 -0800 Patch bug-203883-20191106103604.patch text/plain 1359 obrufau U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyMTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTlkYTI3ZDAyZDc5OWI1 NmYxYTRmY2YwZTE0MDkzMDc4ZWU5N2M2Ny4uNzA0OWYxOGZmZDdjOTRlZjRiNDE4OTllMTUzOGFi NzQ5OTJhMTkxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTExLTA2ICBPcmlv bCBCcnVmYXUgIDxvYnJ1ZmF1QGlnYWxpYS5jb20+CisKKyAgICAgICAgS2VlcCBOb25lIHZhbHVl IGF0IHRoZSBlbmQgb2YgdGhlIExpc3RTdHlsZVR5cGUgZW51bQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzODgzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDIwMzgzNyBhZGRlZCBhIFN0cmluZyB2 YWx1ZSBhdCB0aGUgZW5kIG9mIHRoZSBMaXN0U3R5bGVUeXBlIGVudW0uCisgICAgICAgIFRoaXMg cGF0Y2ggbW92ZXMgaXQgYmVmb3JlIE5vbmUsIGluIG9yZGVyIHRvIGtlZXAgTm9uZSBhdCB0aGUg ZW5kLgorCisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlQ29uc3RhbnRzLmg6 CisKIDIwMTktMTEtMDYgIHlvdWVubiBmYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAg ICAgIFRoZXJlIGlzIG5vIG5lZWQgdG8gY2xlYW4gdGhlIGNvbnRlbnQgdHlwZSBoZWFkZXIgb2Yg YSByZXF1ZXN0IGlmIGl0IGlzIG51bGwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9zdHlsZS9SZW5kZXJTdHlsZUNvbnN0YW50cy5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL3N0eWxlL1JlbmRlclN0eWxlQ29uc3RhbnRzLmgKaW5kZXggODIxYzczZDg5ODhhZGRkZjhj ZTEwOTVlMDlkMTQyZTg3Mjc0OWJiMy4uOGRhZjYyZGFmOTVkYWM5ZWM3OTIwMDAzNGIzOGE3Zjcw ZTc5Njk5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRl clN0eWxlQ29uc3RhbnRzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1Jl bmRlclN0eWxlQ29uc3RhbnRzLmgKQEAgLTYzMSw4ICs2MzEsOCBAQCBlbnVtIGNsYXNzIExpc3RT dHlsZVR5cGUgOiB1aW50OF90IHsKICAgICBLYXRha2FuYSwKICAgICBIaXJhZ2FuYUlyb2hhLAog ICAgIEthdGFrYW5hSXJvaGEsCi0gICAgTm9uZSwKLSAgICBTdHJpbmcKKyAgICBTdHJpbmcsCisg ICAgTm9uZQogfTsKIAogZW51bSBjbGFzcyBRdW90ZVR5cGUgOiB1aW50OF90IHsK