20388 2008-08-14 17:44:49 -0700 <video> elements on Windows never becomes visible when a page is restored from the cache. 2008-08-14 17:53:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 eric.carlson webkit-unassigned oldest_to_newest 88518 0 eric.carlson 2008-08-14 17:44:49 -0700 <video> elements on Windows do not becomes visible when a page is restored from the cache, possibly as a is a side effect of the fix for rdar://6112219. This happens because the call sequence when restoring from the cache is such that m_qtMovie is NULL the first time the renderer calls MediaPlayer::setRect, but it caches the rect so MediaPlayerPrivate::setRect is never called when the renderer sets the size again after the movie is allocated. 88519 1 22804 eric.carlson 2008-08-14 17:47:27 -0700 Created attachment 22804 proposed patch 88520 2 adele 2008-08-14 17:53:49 -0700 Committed revision 35772. 22804 2008-08-14 17:47:27 -0700 2008-08-14 17:50:56 -0700 proposed patch patch.txt text/plain 1986 eric.carlson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNTc3MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDgtMDgtMTQgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWx3YXlzIHBhc3MgInNldCIgY2FsbHMgZG93biB0byBNZWRpYVBsYXllclByaXZhdGUgaW5z dGVhZCBvZiBvbmx5IHdoZW4gdGhlCisgICAgICAgIHZhbHVlIGlzIGRpZmZlcmVudCBmcm9tIHRo ZSBjYWNoZWQgdmFsdWUuIExldCB0aGUgaW1wbGVtZW50YXRpb24gZGVjaWRlIHdoZW4KKyAgICAg ICAgdG8gYXZvaWQgd29yayBiZWNhdXNlIG5vdGhpbmcgaGFzIGNoYW5nZWQuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpN ZWRpYVBsYXllcjo6c2V0Vm9sdW1lKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyOjpz ZXRSYXRlKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyOjpzZXRSZWN0KToKKyAgICAg ICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyOjpzZXRWaXNpYmxlKToKKwogMjAwOC0wOC0xNCAgS2Vp c2hpIEhhdHRvcmkgIDxjYXNleS5oYXR0b3JpQGdtYWlsLmNvbT4KIAogICAgICAgICBNYWtlIEZp cmVidWcgY29tbWFuZCBsaW5lIEFQSSByZXNwZWN0IHByZWRlZmluZWQgdmFyaWFibGVzLgpJbmRl eDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAJKHJldmlzaW9uIDM1 NzUxKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTE0MSwxMCArMTQxLDggQEAgZmxvYXQgTWVkaWFQbGF5ZXI6OnZvbHVtZSgp IGNvbnN0CiAKIHZvaWQgTWVkaWFQbGF5ZXI6OnNldFZvbHVtZShmbG9hdCB2b2x1bWUpCiB7Ci0g ICAgaWYgKHZvbHVtZSAhPSBtX3ZvbHVtZSkgewotICAgICAgICBtX3ZvbHVtZSA9IHZvbHVtZTsK LSAgICAgICAgbV9wcml2YXRlLT5zZXRWb2x1bWUodm9sdW1lKTsgICAKLSAgICB9CisgICAgbV92 b2x1bWUgPSB2b2x1bWU7CisgICAgbV9wcml2YXRlLT5zZXRWb2x1bWUodm9sdW1lKTsgICAKIH0K IAogZmxvYXQgTWVkaWFQbGF5ZXI6OnJhdGUoKSBjb25zdApAQCAtMTU0LDggKzE1Miw2IEBAIGZs b2F0IE1lZGlhUGxheWVyOjpyYXRlKCkgY29uc3QKIAogdm9pZCBNZWRpYVBsYXllcjo6c2V0UmF0 ZShmbG9hdCByYXRlKQogewotICAgIGlmIChyYXRlID09IG1fcmF0ZSkgCi0gICAgICAgIHJldHVy bjsKICAgICBtX3JhdGUgPSByYXRlOwogICAgIG1fcHJpdmF0ZS0+c2V0UmF0ZShyYXRlKTsgICAK IH0KQEAgLTE5Nyw4ICsxOTMsNiBAQCB1bnNpZ25lZCBNZWRpYVBsYXllcjo6dG90YWxCeXRlcygp CiAKIHZvaWQgTWVkaWFQbGF5ZXI6OnNldFJlY3QoY29uc3QgSW50UmVjdCYgcikgCiB7IAotICAg IGlmIChtX3JlY3QgPT0gcikKLSAgICAgICAgcmV0dXJuOwogICAgIG1fcmVjdCA9IHI7CiAgICAg bV9wcml2YXRlLT5zZXRSZWN0KHIpOwogfQpAQCAtMjEwLDggKzIwNCw2IEBAIGJvb2wgTWVkaWFQ bGF5ZXI6OnZpc2libGUoKSBjb25zdAogCiB2b2lkIE1lZGlhUGxheWVyOjpzZXRWaXNpYmxlKGJv b2wgYikKIHsKLSAgICBpZiAobV92aXNpYmxlID09IGIpCi0gICAgICAgIHJldHVybjsKICAgICBt X3Zpc2libGUgPSBiOwogICAgIG1fcHJpdmF0ZS0+c2V0VmlzaWJsZShiKTsKIH0K