203879 2019-11-05 21:53:35 -0800 [Win] DumpRenderTree.exe and WebKitTestRunner.exe shouldn't link with WebCoreTestSupport 2019-11-06 18:06:18 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii achristensen annulen bfulgham don.olmstead ews-watchlist gyuyoung.kim pvollan ross.kirsling ryuan.choi sergio webkit-bug-importer oldest_to_newest 1587685 0 fujii 2019-11-05 21:53:35 -0800 [Win] DumpRenderTree.exe and WebKitTestRunner.exe shouldn't link with WebCoreTestSupport After r252086, WinCairo DumpRenderTree.exe and WebKitTestRunner.exe can't start because they are linked with WinCairoRequirements libs. 1587687 1 382895 fujii 2019-11-05 22:01:52 -0800 Created attachment 382895 Patch 1587761 2 382923 fujii 2019-11-06 06:44:04 -0800 Created attachment 382923 Patch 1587863 3 382923 ross.kirsling 2019-11-06 12:12:44 -0800 Comment on attachment 382923 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382923&action=review > Tools/WebKitTestRunner/PlatformWin.cmake:-39 > - WebKit I take it that this one doesn't need to be preserved in WebKitTestRunnerLib? 1588020 4 382923 fujii 2019-11-06 17:31:34 -0800 Comment on attachment 382923 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382923&action=review >> Tools/WebKitTestRunner/PlatformWin.cmake:-39 >> - WebKit > > I take it that this one doesn't need to be preserved in WebKitTestRunnerLib? Nope. WebKitTestRunner.exe doesn't need to link with WebKit. It loads WebKitTestRunnerLib.dll by using LoadLibraryW. 1588025 5 382923 fujii 2019-11-06 17:39:45 -0800 Comment on attachment 382923 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382923&action=review >>> Tools/WebKitTestRunner/PlatformWin.cmake:-39 >>> - WebKit >> >> I take it that this one doesn't need to be preserved in WebKitTestRunnerLib? > > Nope. WebKitTestRunner.exe doesn't need to link with WebKit. It loads WebKitTestRunnerLib.dll by using LoadLibraryW. I misread your comment. WebKitTestRunnerLib_LIBRARIES includes WebKit. CMakeLists.txt: set(WebKitTestRunner_LIBRARIES WebKit::JavaScriptCore WebCoreTestSupport WebKit ) PlatformWin.cmake: set(WebKitTestRunnerLib_LIBRARIES ${WebKitTestRunner_LIBRARIES} Comsuppw Oleacc ) list(APPEND WebKitTestRunner_LIBRARIES shlwapi ) 1588040 6 fujii 2019-11-06 18:05:30 -0800 Committed r252165: <https://trac.webkit.org/changeset/252165> 1588041 7 webkit-bug-importer 2019-11-06 18:06:18 -0800 <rdar://problem/56967581> 382895 2019-11-05 22:01:52 -0800 2019-11-06 06:44:04 -0800 Patch bug-203879-20191106150151.patch text/plain 2402 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyMTIxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzcwYzBiYjI1ZGZiNDE0Y2FmZGM1NzZiMDQ0YTRkOGJh NmRlYTE3Zi4uOTUzZDdhODEyODQxZmZlZjkxNTliZDU4MTA5MjczNWVkOTk3MjlkZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDE5LTExLTA1ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5dIER1bXBSZW5kZXJUcmVlLmV4ZSBhbmQgV2ViS2l0VGVzdFJ1bm5l ci5leGUgc2hvdWxkbid0IGxpbmsgd2l0aCBXZWJDb3JlVGVzdFN1cHBvcnQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzg3OQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFmdGVyIHIyNTIwODYsIFdpbkNh aXJvIER1bXBSZW5kZXJUcmVlLmV4ZSBhbmQKKyAgICAgICAgV2ViS2l0VGVzdFJ1bm5lci5leGUg Y2FuJ3Qgc3RhcnQgYmVjYXVzZSB0aGV5IGFyZSBsaW5rZWQgd2l0aAorICAgICAgICBXaW5DYWly b1JlcXVpcmVtZW50cyBsaWJzLgorCisgICAgICAgIER1bXBSZW5kZXJUcmVlLmV4ZSBhbmQgV2Vi S2l0VGVzdFJ1bm5lci5leGUgYXJlIGp1c3Qgd3JhcHBlcgorICAgICAgICBwcm9ncmFtcyB0byBz ZXQgZW52IHZhcnMuIFRoZXkgc2hvdWxkbid0IGxpbmsgd2l0aAorICAgICAgICBXaW5DYWlyb1Jl cXVpcmVtZW50cyBsaWJzLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvUGxhdGZvcm1XaW4u Y21ha2U6IFNldCBEdW1wUmVuZGVyVHJlZV9MSUJSQVJJRVMgb25seSBzaGx3YXBpLgorICAgICAg ICAqIFdlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1XaW4uY21ha2U6IFNldCBXZWJLaXRUZXN0UnVu bmVyX0xJQlJBUklFUyBvbmx5IHNobHdhcGkuCisKIDIwMTktMTEtMDUgIEpvbmF0aGFuIEJlZGFy ZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjI1MjAzMSk6IGxh eW91dCB0ZXN0cyBmYWlsIHRvIHJ1biBpbiBub24gYXBwbGUgcG9ydHMgYWZ0ZXIgcjI1MjAzMSAo Rm9sbG93LXVwIGZpeCkKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1BsYXRmb3Jt V2luLmNtYWtlIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvUGxhdGZvcm1XaW4uY21ha2UKaW5kZXgg ZWU2NmU3Zjc5NDY1NmE4MGMxZTMzODkzNGY1NWQxYjZiNGZjYzZmZS4uMGM3NzMwYjA2MjU2NDlk OTk5YzFiNjM2YmYwZDQwOWYxYjRhNjRlNyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRy ZWUvUGxhdGZvcm1XaW4uY21ha2UKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvUGxhdGZvcm1X aW4uY21ha2UKQEAgLTY4LDE4ICs2OCwxOCBAQCBsaXN0KEFQUEVORCBEdW1wUmVuZGVyVHJlZV9J TkNMVURFX0RJUkVDVE9SSUVTCiAgICAgVGVzdE5ldHNjYXBlUGx1Z0luL1Rlc3RzL3dpbgogKQog Ci1saXN0KEFQUEVORCBEdW1wUmVuZGVyVHJlZV9MSUJSQVJJRVMKLSAgICBXZWJLaXRMZWdhY3kK LSAgICBzaGx3YXBpCi0pCi0KIHNldChEdW1wUmVuZGVyVHJlZUxpYl9MSUJSQVJJRVMKICAgICAk e0R1bXBSZW5kZXJUcmVlX0xJQlJBUklFU30KICAgICBDb21zdXBwdwogICAgIE9sZWFjYworICAg IFdlYktpdExlZ2FjeQogICAgIFdlYktpdExlZ2FjeUdVSUQKICkKIAorc2V0KER1bXBSZW5kZXJU cmVlX0xJQlJBUklFUworICAgIHNobHdhcGkKKykKKwogaWYgKCR7V1RGX1BMQVRGT1JNX1dJTl9D QUlST30pCiAgICAgbGlzdChBUFBFTkQgRHVtcFJlbmRlclRyZWVfSU5DTFVERV9ESVJFQ1RPUklF UwogICAgICAgICBjYWlybwpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9QbGF0 Zm9ybVdpbi5jbWFrZSBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1XaW4uY21ha2UK aW5kZXggZmU4MjcwMTc5OWQyNzhmZjdmMWQyMGFlYTQ0YjIxOTRiZDcwMmE3Zi4uMTRhODcyMWZi MDI0MGVlMDc5OWMzNzFlMzVlZGVjYzU5YjE5NDExYiAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci9QbGF0Zm9ybVdpbi5jbWFrZQorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVy L1BsYXRmb3JtV2luLmNtYWtlCkBAIC0zNSw4ICszNSw4IEBAIHNldChXZWJLaXRUZXN0UnVubmVy TGliX0xJQlJBUklFUwogICAgIE9sZWFjYwogKQogCi1saXN0KEFQUEVORCBXZWJLaXRUZXN0UnVu bmVyX0xJQlJBUklFUwotICAgIFdlYktpdAorc2V0KFdlYktpdFRlc3RSdW5uZXJfTElCUkFSSUVT CisgICAgc2hsd2FwaQogKQogCiBzZXQoV2ViS2l0VGVzdFJ1bm5lckluamVjdGVkQnVuZGxlX0xJ QlJBUklFUwo= 382923 2019-11-06 06:44:04 -0800 2019-11-06 12:12:44 -0800 Patch bug-203879-20191106150151.patch text/plain 2402 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyMTIxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzcwYzBiYjI1ZGZiNDE0Y2FmZGM1NzZiMDQ0YTRkOGJh NmRlYTE3Zi4uOTUzZDdhODEyODQxZmZlZjkxNTliZDU4MTA5MjczNWVkOTk3MjlkZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDE5LTExLTA1ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5dIER1bXBSZW5kZXJUcmVlLmV4ZSBhbmQgV2ViS2l0VGVzdFJ1bm5l ci5leGUgc2hvdWxkbid0IGxpbmsgd2l0aCBXZWJDb3JlVGVzdFN1cHBvcnQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzg3OQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFmdGVyIHIyNTIwODYsIFdpbkNh aXJvIER1bXBSZW5kZXJUcmVlLmV4ZSBhbmQKKyAgICAgICAgV2ViS2l0VGVzdFJ1bm5lci5leGUg Y2FuJ3Qgc3RhcnQgYmVjYXVzZSB0aGV5IGFyZSBsaW5rZWQgd2l0aAorICAgICAgICBXaW5DYWly b1JlcXVpcmVtZW50cyBsaWJzLgorCisgICAgICAgIER1bXBSZW5kZXJUcmVlLmV4ZSBhbmQgV2Vi S2l0VGVzdFJ1bm5lci5leGUgYXJlIGp1c3Qgd3JhcHBlcgorICAgICAgICBwcm9ncmFtcyB0byBz ZXQgZW52IHZhcnMuIFRoZXkgc2hvdWxkbid0IGxpbmsgd2l0aAorICAgICAgICBXaW5DYWlyb1Jl cXVpcmVtZW50cyBsaWJzLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvUGxhdGZvcm1XaW4u Y21ha2U6IFNldCBEdW1wUmVuZGVyVHJlZV9MSUJSQVJJRVMgb25seSBzaGx3YXBpLgorICAgICAg ICAqIFdlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1XaW4uY21ha2U6IFNldCBXZWJLaXRUZXN0UnVu bmVyX0xJQlJBUklFUyBvbmx5IHNobHdhcGkuCisKIDIwMTktMTEtMDUgIEpvbmF0aGFuIEJlZGFy ZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjI1MjAzMSk6IGxh eW91dCB0ZXN0cyBmYWlsIHRvIHJ1biBpbiBub24gYXBwbGUgcG9ydHMgYWZ0ZXIgcjI1MjAzMSAo Rm9sbG93LXVwIGZpeCkKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1BsYXRmb3Jt V2luLmNtYWtlIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvUGxhdGZvcm1XaW4uY21ha2UKaW5kZXgg ZWU2NmU3Zjc5NDY1NmE4MGMxZTMzODkzNGY1NWQxYjZiNGZjYzZmZS4uMGM3NzMwYjA2MjU2NDlk OTk5YzFiNjM2YmYwZDQwOWYxYjRhNjRlNyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRy ZWUvUGxhdGZvcm1XaW4uY21ha2UKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvUGxhdGZvcm1X aW4uY21ha2UKQEAgLTY4LDE4ICs2OCwxOCBAQCBsaXN0KEFQUEVORCBEdW1wUmVuZGVyVHJlZV9J TkNMVURFX0RJUkVDVE9SSUVTCiAgICAgVGVzdE5ldHNjYXBlUGx1Z0luL1Rlc3RzL3dpbgogKQog Ci1saXN0KEFQUEVORCBEdW1wUmVuZGVyVHJlZV9MSUJSQVJJRVMKLSAgICBXZWJLaXRMZWdhY3kK LSAgICBzaGx3YXBpCi0pCi0KIHNldChEdW1wUmVuZGVyVHJlZUxpYl9MSUJSQVJJRVMKICAgICAk e0R1bXBSZW5kZXJUcmVlX0xJQlJBUklFU30KICAgICBDb21zdXBwdwogICAgIE9sZWFjYworICAg IFdlYktpdExlZ2FjeQogICAgIFdlYktpdExlZ2FjeUdVSUQKICkKIAorc2V0KER1bXBSZW5kZXJU cmVlX0xJQlJBUklFUworICAgIHNobHdhcGkKKykKKwogaWYgKCR7V1RGX1BMQVRGT1JNX1dJTl9D QUlST30pCiAgICAgbGlzdChBUFBFTkQgRHVtcFJlbmRlclRyZWVfSU5DTFVERV9ESVJFQ1RPUklF UwogICAgICAgICBjYWlybwpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9QbGF0 Zm9ybVdpbi5jbWFrZSBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1XaW4uY21ha2UK aW5kZXggZmU4MjcwMTc5OWQyNzhmZjdmMWQyMGFlYTQ0YjIxOTRiZDcwMmE3Zi4uMTRhODcyMWZi MDI0MGVlMDc5OWMzNzFlMzVlZGVjYzU5YjE5NDExYiAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci9QbGF0Zm9ybVdpbi5jbWFrZQorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVy L1BsYXRmb3JtV2luLmNtYWtlCkBAIC0zNSw4ICszNSw4IEBAIHNldChXZWJLaXRUZXN0UnVubmVy TGliX0xJQlJBUklFUwogICAgIE9sZWFjYwogKQogCi1saXN0KEFQUEVORCBXZWJLaXRUZXN0UnVu bmVyX0xJQlJBUklFUwotICAgIFdlYktpdAorc2V0KFdlYktpdFRlc3RSdW5uZXJfTElCUkFSSUVT CisgICAgc2hsd2FwaQogKQogCiBzZXQoV2ViS2l0VGVzdFJ1bm5lckluamVjdGVkQnVuZGxlX0xJ QlJBUklFUwo=