20385 2008-08-14 13:10:02 -0700 REGRESSION (r35676): Firebug command line extensions interfere with existing objects 2008-08-14 17:00:34 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED InRadar, Regression P1 Normal --- 0 brian.mitchell webkit-unassigned aroben keishi timothy oldest_to_newest 88492 0 brian.mitchell 2008-08-14 13:10:02 -0700 The web inspector's console allows evaluation of code within the context of the inspected document. In many cases these pages have a number of javascript functions setup using common names like $. The firebug compatible functions override these calls causing many expressions to fail to evaluate in cases where different behavior was provided in those names under those calls. I would propose that the script check for predefined values before overriding with its own. I would also encourage having some of this functionality available via an isolated module (maybe $inspector would be an appropriate name) so those who want access to both behaviors can use the adjusted name. 88494 1 brian.mitchell 2008-08-14 13:34:14 -0700 I've checked firebug's behavior with this. Firebug does not override any of the pages functions if they exist with the same name. This allows the original functions to be used as expected. 88495 2 aroben 2008-08-14 13:41:58 -0700 <rdar://problem/6150581> 88507 3 22801 keishi 2008-08-14 16:07:49 -0700 Created attachment 22801 quick fix 88509 4 timothy 2008-08-14 16:13:18 -0700 A better fix might be a simple as: expression = "with (window._inspectorCommandLineAPI) { with (window) { " + expression + " } }"; The window object will be picked first, then _inspectorCommandLineAPI, then the global (window) object again. 88510 5 keishi 2008-08-14 16:22:41 -0700 (In reply to comment #4) > expression = "with (window._inspectorCommandLineAPI) { with (window) { > " + expression + " } }"; That's much better... 88511 6 timothy 2008-08-14 16:24:53 -0700 (In reply to comment #5) > (In reply to comment #4) > > expression = "with (window._inspectorCommandLineAPI) { with (window) { > > " + expression + " } }"; > > That's much better... > Did it work? I have not tested it. You should make a test case to land with your change. Put it in WebCore/manual-tests/inspector 88513 7 22802 keishi 2008-08-14 16:48:22 -0700 Created attachment 22802 the better one It worked. I'm not sure if this is what you meant for a test case. 88514 8 22802 timothy 2008-08-14 16:50:05 -0700 Comment on attachment 22802 the better one Yep, looks good! 88515 9 timothy 2008-08-14 16:57:37 -0700 Landed in r35769. 88516 10 timothy 2008-08-14 17:00:34 -0700 Thanks for the bug report Brian! 22801 2008-08-14 16:07:49 -0700 2008-08-14 16:48:22 -0700 quick fix patch10.txt text/plain 3245 keishi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNTc1OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTEgQEAKKzIwMDgtMDgtMTQgIEtlaXNoaSBIYXR0b3JpICA8Y2FzZXkuaGF0dG9y aUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRmlyZWJ1ZyBjb21tYW5kIGxpbmUgQVBJIHJlc3BlY3RzIHByZWRlZmluZWQgdmFyaWFi bGVzLgorCisgICAgICAgICogcGFnZS9pbnNwZWN0b3IvQ29uc29sZS5qczoKKwogMjAwOC0wOC0x NCAgS2V2aW4gT2xsaXZpZXIgIDxrZXZpbm9AdGhlb2xsaXZpZXJzLmNvbT4KIAogICAgICAgICB3 eCBidWlsZCBmaXhlcyBhZnRlciByZWNlbnQgY2hhbmdlcyB0byBDYW52YXMgYW5kIEltYWdlIGNs YXNzZXMuCkluZGV4OiBXZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL0NvbnNvbGUuanMKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9Db25zb2xlLmpzCShyZXZpc2lvbiAzNTc1MikK KysrIFdlYkNvcmUvcGFnZS9pbnNwZWN0b3IvQ29uc29sZS5qcwkod29ya2luZyBjb3B5KQpAQCAt MzM1LDkgKzMzNSwxMSBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZS5wcm90b3R5cGUgPSB7CiAgICAg ICAgIHZhciBpbnNwZWN0ZWRXaW5kb3cgPSBJbnNwZWN0b3JDb250cm9sbGVyLmluc3BlY3RlZFdp bmRvdygpOwogICAgICAgICBpZiAoIWluc3BlY3RlZFdpbmRvdy5faW5zcGVjdG9yQ29tbWFuZExp bmVBUEkpIHsKICAgICAgICAgICAgIGluc3BlY3RlZFdpbmRvdy5ldmFsKCJ3aW5kb3cuX2luc3Bl Y3RvckNvbW1hbmRMaW5lQVBJID0geyBcCi0gICAgICAgICAgICAgICAgJDogZnVuY3Rpb24oKSB7 IHJldHVybiBkb2N1bWVudC5nZXRFbGVtZW50QnlJZC5hcHBseShkb2N1bWVudCwgYXJndW1lbnRz KSB9LCBcCi0gICAgICAgICAgICAgICAgJCQ6IGZ1bmN0aW9uKCkgeyByZXR1cm4gZG9jdW1lbnQu cXVlcnlTZWxlY3RvckFsbC5hcHBseShkb2N1bWVudCwgYXJndW1lbnRzKSB9LCBcCi0gICAgICAg ICAgICAgICAgJHg6IGZ1bmN0aW9uKHhwYXRoLCBjb250ZXh0KSB7IFwKKyAgICAgICAgICAgICAg ICBnZXQgJCgpIHsgcmV0dXJuIHdpbmRvdy4kIHx8IGZ1bmN0aW9uKCkgeyByZXR1cm4gZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQuYXBwbHkoZG9jdW1lbnQsIGFyZ3VtZW50cykgfSB9LCBcCisgICAg ICAgICAgICAgICAgc2V0ICQoeCkgeyB3aW5kb3cuJCA9IHg7IH0sIFwKKyAgICAgICAgICAgICAg ICBnZXQgJCQoKSB7IHJldHVybiB3aW5kb3cuJCQgfHwgZnVuY3Rpb24oKSB7IHJldHVybiBkb2N1 bWVudC5xdWVyeVNlbGVjdG9yQWxsLmFwcGx5KGRvY3VtZW50LCBhcmd1bWVudHMpIH0gfSwgXAor ICAgICAgICAgICAgICAgIHNldCAkJCh4KSB7IHdpbmRvdy4kJCA9IHg7IH0sIFwKKyAgICAgICAg ICAgICAgICBnZXQgJHgoKSB7IHJldHVybiB3aW5kb3cuJHggfHwgZnVuY3Rpb24oeHBhdGgsIGNv bnRleHQpIHsgXAogICAgICAgICAgICAgICAgICAgICB2YXIgbm9kZXMgPSBbXTsgXAogICAgICAg ICAgICAgICAgICAgICB0cnkgeyBcCiAgICAgICAgICAgICAgICAgICAgICAgICB2YXIgZG9jID0g Y29udGV4dCB8fCBkb2N1bWVudDsgXApAQCAtMzQ2LDExICszNDgsMTYgQEAgV2ViSW5zcGVjdG9y LkNvbnNvbGUucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgICAgICAgICAgd2hpbGUgKG5v ZGUgPSByZXN1bHRzLml0ZXJhdGVOZXh0KCkpIG5vZGVzLnB1c2gobm9kZSk7IFwKICAgICAgICAg ICAgICAgICAgICAgfSBjYXRjaCAoZSkge30gXAogICAgICAgICAgICAgICAgICAgICByZXR1cm4g bm9kZXM7IFwKLSAgICAgICAgICAgICAgICB9LCBcCi0gICAgICAgICAgICAgICAga2V5czogZnVu Y3Rpb24obykgeyB2YXIgYSA9IFtdOyBmb3IgKGsgaW4gbykgYS5wdXNoKGspOyByZXR1cm4gYTsg fSwgXAotICAgICAgICAgICAgICAgIHZhbHVlczogZnVuY3Rpb24obykgeyB2YXIgYSA9IFtdOyBm b3IgKGsgaW4gbykgYS5wdXNoKG9ba10pOyByZXR1cm4gYTsgfSwgXAotICAgICAgICAgICAgICAg IHByb2ZpbGU6IGZ1bmN0aW9uKCkgeyByZXR1cm4gY29uc29sZS5wcm9maWxlLmFwcGx5KGNvbnNv bGUsIGFyZ3VtZW50cykgfSwgXAotICAgICAgICAgICAgICAgIHByb2ZpbGVFbmQ6IGZ1bmN0aW9u KCkgeyByZXR1cm4gY29uc29sZS5wcm9maWxlRW5kLmFwcGx5KGNvbnNvbGUsIGFyZ3VtZW50cykg fSBcCisgICAgICAgICAgICAgICAgfSB9LCBcCisgICAgICAgICAgICAgICAgc2V0ICR4KHgpIHsg d2luZG93LiR4ID0geDsgfSwgXAorICAgICAgICAgICAgICAgIGdldCBrZXlzKCkgeyByZXR1cm4g d2luZG93LmtleXMgfHwgZnVuY3Rpb24obykgeyB2YXIgYSA9IFtdOyBmb3IgKGsgaW4gbykgYS5w dXNoKGspOyByZXR1cm4gYTsgfSB9LCBcCisgICAgICAgICAgICAgICAgc2V0IGtleXMoeCkgeyB3 aW5kb3cua2V5cyA9IHg7IH0sIFwKKyAgICAgICAgICAgICAgICBnZXQgdmFsdWVzKCkgeyByZXR1 cm4gd2luZG93LnZhbHVlcyB8fCBmdW5jdGlvbihvKSB7IHZhciBhID0gW107IGZvciAoayBpbiBv KSBhLnB1c2gob1trXSk7IHJldHVybiBhOyB9IH0sIFwKKyAgICAgICAgICAgICAgICBzZXQgdmFs dWVzKHgpIHsgd2luZG93LnZhbHVlcyA9IHg7IH0sIFwKKyAgICAgICAgICAgICAgICBnZXQgcHJv ZmlsZSgpIHsgcmV0dXJuIHdpbmRvdy5wcm9maWxlIHx8IGZ1bmN0aW9uKCkgeyByZXR1cm4gY29u c29sZS5wcm9maWxlLmFwcGx5KGNvbnNvbGUsIGFyZ3VtZW50cykgfSB9LCBcCisgICAgICAgICAg ICAgICAgc2V0IHByb2ZpbGUoeCkgeyB3aW5kb3cucHJvZmlsZSA9IHg7IH0sIFwKKyAgICAgICAg ICAgICAgICBnZXQgcHJvZmlsZUVuZCgpIHsgcmV0dXJuIHdpbmRvdy5wcm9maWxlRW5kIHx8IGZ1 bmN0aW9uKCkgeyByZXR1cm4gY29uc29sZS5wcm9maWxlRW5kLmFwcGx5KGNvbnNvbGUsIGFyZ3Vt ZW50cykgfSB9LCBcCisgICAgICAgICAgICAgICAgc2V0IHByb2ZpbGVFbmQoeCkgeyB3aW5kb3cu cHJvZmlsZUVuZCA9IHg7IH0sIFwKICAgICAgICAgICAgIH07Iik7CiAgICAgICAgIH0KIAo= 22802 2008-08-14 16:48:22 -0700 2008-08-14 16:50:05 -0700 the better one patch10.txt text/plain 1732 keishi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNTc1OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTEgQEAKKzIwMDgtMDgtMTQgIEtlaXNoaSBIYXR0b3JpICA8Y2FzZXkuaGF0dG9y aUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRmlyZWJ1ZyBjb21tYW5kIGxpbmUgQVBJIHJlc3BlY3RzIHByZWRlZmluZWQgdmFyaWFi bGVzLgorCisgICAgICAgICogcGFnZS9pbnNwZWN0b3IvQ29uc29sZS5qczoKKwogMjAwOC0wOC0x NCAgS2V2aW4gT2xsaXZpZXIgIDxrZXZpbm9AdGhlb2xsaXZpZXJzLmNvbT4KIAogICAgICAgICB3 eCBidWlsZCBmaXhlcyBhZnRlciByZWNlbnQgY2hhbmdlcyB0byBDYW52YXMgYW5kIEltYWdlIGNs YXNzZXMuCkluZGV4OiBXZWJDb3JlL21hbnVhbC10ZXN0cy9pbnNwZWN0b3IvY29tbWFuZC1saW5l LWFwaS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbWFudWFsLXRlc3RzL2luc3BlY3Rvci9j b21tYW5kLWxpbmUtYXBpLmh0bWwJKHJldmlzaW9uIDApCisrKyBXZWJDb3JlL21hbnVhbC10ZXN0 cy9pbnNwZWN0b3IvY29tbWFuZC1saW5lLWFwaS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsx LDYgQEAKKzxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0IiBjaGFyc2V0PSJ1dGYtOCI+Cisg ICAgdmFyICQgPSBmdW5jdGlvbigpIHsgY29uc29sZS5sb2coIk9LIikgfTsKKzwvc2NyaXB0Pgor Cis8cD5UZXN0IGZvciA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjAzODUiPkJ1ZyAyMDM4NTogRmlyZWJ1ZyBjb21tYW5kIGxpbmUgZXh0ZW5zaW9ucyBp bnRlcmZlcmUgd2l0aCBleGlzdGluZyBvYmplY3RzPC9hPi48L3A+Cis8cD5UbyB0ZXN0LCBleGVj dXRlICIkKCkiIGluIHRoZSBJbnNwZWN0b3IncyBDb25zb2xlLiBBbHNvIHRyeWluZyBzZXR0aW5n ICQuPC9wPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKSW5kZXg6IFdlYkNvcmUvcGFnZS9p bnNwZWN0b3IvQ29uc29sZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvaW5zcGVjdG9y L0NvbnNvbGUuanMJKHJldmlzaW9uIDM1NzUyKQorKysgV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9D b25zb2xlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0zNTQsNyArMzU0LDcgQEAgV2ViSW5zcGVjdG9y LkNvbnNvbGUucHJvdG90eXBlID0gewogICAgICAgICAgICAgfTsiKTsKICAgICAgICAgfQogCi0g ICAgICAgIGV4cHJlc3Npb24gPSAid2l0aCAod2luZG93Ll9pbnNwZWN0b3JDb21tYW5kTGluZUFQ SSkgeyAiICsgZXhwcmVzc2lvbiArICIgfSI7CisgICAgICAgIGV4cHJlc3Npb24gPSAid2l0aCAo d2luZG93Ll9pbnNwZWN0b3JDb21tYW5kTGluZUFQSSkgeyB3aXRoICh3aW5kb3cpIHsgIiArIGV4 cHJlc3Npb24gKyAiIH0gfSI7CiAgICAgICAgIHJldHVybiBpbnNwZWN0ZWRXaW5kb3cuZXZhbChl eHByZXNzaW9uKTsKICAgICB9LAogCg==