203831 2019-11-04 16:39:13 -0800 [iOS] Add logging and telemetry to mach services believed to be unused 2019-11-05 14:37:16 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue ggaren webkit-bug-importer oldest_to_newest 1587229 0 pvollan 2019-11-04 16:39:13 -0800 The sandbox rules for mach services believed to be unused should have logging and telemetry added to confirm whether the assumption is correct. 1587230 1 382789 pvollan 2019-11-04 16:44:58 -0800 Created attachment 382789 Patch 1587500 2 382789 ggaren 2019-11-05 11:59:51 -0800 Comment on attachment 382789 Patch r=me 1587515 3 pvollan 2019-11-05 13:11:41 -0800 (In reply to Geoffrey Garen from comment #2) > Comment on attachment 382789 [details] > Patch > > r=me Thanks for reviewing! 1587534 4 382789 commit-queue 2019-11-05 14:05:55 -0800 Comment on attachment 382789 Patch Clearing flags on attachment: 382789 Committed r252081: <https://trac.webkit.org/changeset/252081> 1587535 5 commit-queue 2019-11-05 14:05:57 -0800 All reviewed patches have been landed. Closing bug. 1587537 6 webkit-bug-importer 2019-11-05 14:06:16 -0800 <rdar://problem/56918131> 1587547 7 382789 bfulgham 2019-11-05 14:20:08 -0800 Comment on attachment 382789 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382789&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-166 > - (global-name "com.apple.coremedia.routingsessionmanager.xpc") Make sure you test Airplay before deciding this can be removed. 1587551 8 pvollan 2019-11-05 14:37:16 -0800 (In reply to Brent Fulgham from comment #7) > Comment on attachment 382789 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=382789&action=review > > > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-166 > > - (global-name "com.apple.coremedia.routingsessionmanager.xpc") > > Make sure you test Airplay before deciding this can be removed. Ah, that's a good point, will do :) Thanks for reviewing! 382789 2019-11-04 16:44:58 -0800 2019-11-05 14:05:55 -0800 Patch bug-203831-20191104164457.patch text/plain 5566 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTIwMjkpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTExLTA0ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBBZGQgbG9nZ2luZyBh bmQgdGVsZW1ldHJ5IHRvIG1hY2ggc2VydmljZXMgYmVsaWV2ZWQgdG8gYmUgdW51c2VkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDM4MzEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgc2FuZGJveCBy dWxlcyBmb3IgbWFjaCBzZXJ2aWNlcyBiZWxpZXZlZCB0byBiZSB1bnVzZWQgc2hvdWxkIGhhdmUg bG9nZ2luZyBhbmQgdGVsZW1ldHJ5IGFkZGVkIHRvIGNvbmZpcm0KKyAgICAgICAgd2hldGhlciB0 aGUgYXNzdW1wdGlvbiBpcyBjb3JyZWN0LgorCisgICAgICAgICogUmVzb3VyY2VzL1NhbmRib3hQ cm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiOgorCiAyMDE5LTExLTA0 ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggY3Jh c2ggY2F1c2VkIGJ5IHN5c2NhbGwgc2FuZGJveCB2aW9sYXRpb24KSW5kZXg6IFNvdXJjZS9XZWJL aXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250 ZW50LnNiCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9m aWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiCShyZXZpc2lvbiAyNTIwMDIp CisrKyBTb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBs ZS5XZWJLaXQuV2ViQ29udGVudC5zYgkod29ya2luZyBjb3B5KQpAQCAtMTAzLDcgKzEwMyw3IEBA CiAgICAgICAgIChhbGxvdyBmaWxlLXJlYWQqIGFzc2V0LWFjY2Vzcy1maWx0ZXIpCiAgICAgICAg IChpZiAobWVtcSAnd2l0aC1tZWRpYS1wbGF5YmFjayBvcHRpb25zKQogICAgICAgICAgICAgKHBs YXktbWVkaWEgYXNzZXQtYWNjZXNzLWZpbHRlcikpCi0gICAgICAgIChhbGxvdyBtYWNoLWxvb2t1 cAorICAgICAgICAoYWxsb3cgbWFjaC1sb29rdXAgKHdpdGggcmVwb3J0KSAod2l0aCB0ZWxlbWV0 cnkpCiAgICAgICAgICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5tb2JpbGVhc3NldGQi ICJjb20uYXBwbGUubW9iaWxlYXNzZXRkLnYyIikpCiAgICAgICAgIChtb2JpbGUtcHJlZmVyZW5j ZXMtcmVhZCAiY29tLmFwcGxlLk1vYmlsZUFzc2V0IikpKQogCkBAIC0xNTIsMjUgKzE1MiwyNyBA QAogICAgICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5jb3JlbWVkaWEuYXVkaW9wcm9j ZXNzaW5ndGFwLnhwYyIpCiAgICAgICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmNvcmVt ZWRpYS5jYXB0dXJlc2Vzc2lvbiIpICAgICAgOyBBY3R1YWxseSBmb3IgdmlkZW8gY2FwdHVyZQog ICAgICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5jb3JlbWVkaWEuY2FwdHVyZXNvdXJj ZSIpICAgICAgIDsgQWxzbyBmb3IgdmlkZW8gY2FwdHVyZSAoPHJkYXI6Ly9wcm9ibGVtLzE1Nzk0 MjkxPikuCi0gICAgICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmNvcmVtZWRpYS5jcGVw cm90ZWN0b3IueHBjIikKICAgICAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuY29yZW1l ZGlhLmN1c3RvbXVybGxvYWRlci54cGMiKSA7IE5lZWRlZCBmb3IgY3VzdG9tIG1lZGlhIGxvYWRp bmcKLSAgICAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuY29yZW1lZGlhLmVuZHBvaW50 LnhwYyIpCi0gICAgICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmNvcmVtZWRpYS5maWdj cGVjcnlwdG9yIikKLSAgICAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuY29yZW1lZGlh LmZpZ2NvbnRlbnRrZXlzZXNzaW9uLnhwYyIpCiAgICAgICAgICAgIChnbG9iYWwtbmFtZSAiY29t LmFwcGxlLmNvcmVtZWRpYS5mb3JtYXRyZWFkZXIueHBjIikKICAgICAgICAgICAgKGdsb2JhbC1u YW1lICJjb20uYXBwbGUuY29yZW1lZGlhLnBsYXllci54cGMiKQogICAgICAgICAgICAoZ2xvYmFs LW5hbWUgImNvbS5hcHBsZS5jb3JlbWVkaWEucmVtYWtlciIpCiAgICAgICAgICAgIChnbG9iYWwt bmFtZSAiY29tLmFwcGxlLmNvcmVtZWRpYS5yZW1vdGVxdWV1ZSIpCiAgICAgICAgICAgIChnbG9i YWwtbmFtZSAiY29tLmFwcGxlLmNvcmVtZWRpYS5yb3V0ZWRpc2NvdmVyZXIueHBjIikKICAgICAg ICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuY29yZW1lZGlhLnJvdXRpbmdjb250ZXh0Lnhw YyIpCi0gICAgICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmNvcmVtZWRpYS5yb3V0aW5n c2Vzc2lvbm1hbmFnZXIueHBjIikKICAgICAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUu Y29yZW1lZGlhLnNhbXBsZWJ1ZmZlcmF1ZGlvcmVuZGVyZXIueHBjIikKICAgICAgICAgICAgKGds b2JhbC1uYW1lICJjb20uYXBwbGUuY29yZW1lZGlhLnNhbXBsZWJ1ZmZlcnJlbmRlcnN5bmNocm9u aXplci54cGMiKQogICAgICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5jb3JlbWVkaWEu c2FuZGJveHNlcnZlci54cGMiKQogICAgICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5j b3JlbWVkaWEuc3lzdGVtY29udHJvbGxlci54cGMiKQotICAgICAgICAgICAoZ2xvYmFsLW5hbWUg ImNvbS5hcHBsZS5jb3JlbWVkaWEuc3RzIikKICAgICAgICAgICAgKGdsb2JhbC1uYW1lICJjb20u YXBwbGUuY29yZW1lZGlhLnZvbHVtZWNvbnRyb2xsZXIueHBjIikpCiAKKyAgICAoYWxsb3cgbWFj aC1sb29rdXAgKHdpdGggcmVwb3J0KSAod2l0aCB0ZWxlbWV0cnkpCisgICAgICAgIChnbG9iYWwt bmFtZSAiY29tLmFwcGxlLmNvcmVtZWRpYS5jcGVwcm90ZWN0b3IueHBjIikKKyAgICAgICAgKGds b2JhbC1uYW1lICJjb20uYXBwbGUuY29yZW1lZGlhLmVuZHBvaW50LnhwYyIpCisgICAgICAgIChn bG9iYWwtbmFtZSAiY29tLmFwcGxlLmNvcmVtZWRpYS5maWdjb250ZW50a2V5c2Vzc2lvbi54cGMi KQorICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5jb3JlbWVkaWEuZmlnY3BlY3J5cHRv ciIpCisgICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmNvcmVtZWRpYS5yb3V0aW5nc2Vz c2lvbm1hbmFnZXIueHBjIikKKyAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuY29yZW1l ZGlhLnN0cyIpKQorCiAgICAgKG1vYmlsZS1wcmVmZXJlbmNlcy1yZWFkCiAgICAgICAgICJjb20u YXBwbGUuYXZmb3VuZGF0aW9uIgogICAgICAgICAiY29tLmFwcGxlLmNvcmVhdWRpbyIKQEAgLTE4 Miw5ICsxODQsMTEgQEAKIAogICAgIDs7IFJlcXVpcmVkIGJ5IHRoZSBNZWRpYVBsYXllciBmcmFt ZXdvcmsuCiAgICAgKGFsbG93IG1hY2gtbG9va3VwCi0gICAgICAgIChnbG9iYWwtbmFtZSAiY29t LmFwcGxlLmFpcnBsYXkuYXBzeW5jY29udHJvbGxlci54cGMiKQogICAgICAgICAoZ2xvYmFsLW5h bWUgImNvbS5hcHBsZS5hdWRpby5BdWRpb1Nlc3Npb24iKSkKIAorICAgIChhbGxvdyBtYWNoLWxv b2t1cCAod2l0aCByZXBvcnQpICh3aXRoIHRlbGVtZXRyeSkKKyAgICAgICAgKGdsb2JhbC1uYW1l ICJjb20uYXBwbGUuYWlycGxheS5hcHN5bmNjb250cm9sbGVyLnhwYyIpKQorCiAgICAgOzsgQWxs b3cgbWVkaWFzZXJ2ZXJkIHRvIGlzc3VlIGZpbGUgZXh0ZW5zaW9ucyBmb3IgdGhlIHB1cnBvc2Vz IG9mIHJlYWRpbmcgbWVkaWEKICAgICAoYWxsb3cgZmlsZS1pc3N1ZS1leHRlbnNpb24gKHJlcXVp cmUtYWxsCiAgICAgICAgIChleHRlbnNpb24gImNvbS5hcHBsZS5hcHAtc2FuZGJveC5yZWFkIikK QEAgLTM0Niw3ICszNTAsNyBAQAogICAgICAgICAoYWxsb3ctY3JlYXRlLWRpcmVjdG9yeSAobGl0 ZXJhbCBiYXNlLWRpcmVjdG9yeSkpCiAgICAgICAgIChhbGxvdyBmaWxlLXJlYWQqIGZpbGUtd3Jp dGUqCiAgICAgICAgICAgICAocHJlZml4IChzdHJpbmctYXBwZW5kIGJhc2UtZGlyZWN0b3J5ICIv YXdkLSIgZGFlbW9uLW5hbWUgIi5sb2ciKSkpCi0gICAgICAgIChhbGxvdyBtYWNoLWxvb2t1cAor ICAgICAgICAoYWxsb3cgbWFjaC1sb29rdXAgKHdpdGggcmVwb3J0KSAod2l0aCB0ZWxlbWV0cnkp CiAgICAgICAgICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5hd2RkIikpKSkKIAogKGRl ZmluZS1vbmNlIChsb2dkLWRpYWdub3N0aWMtcGF0aHMpCkBAIC00MjMsMTMgKzQyNywxNSBAQAog ICAgICAgICAiY29tLmFwcGxlLm10IgogICAgICAgICAiY29tLmFwcGxlLnByZWZlcmVuY2VzLnNv dW5kcyIpCiAKLSAgICAoYWxsb3cgbWFjaC1sb29rdXAKKyAgICAoYWxsb3cgbWFjaC1sb29rdXAg KHdpdGggcmVwb3J0KSAod2l0aCB0ZWxlbWV0cnkpCiAgICAgICAgIChnbG9iYWwtbmFtZSAiY29t LmFwcGxlLmZyb250Ym9hcmQuc3lzdGVtYXBwc2VydmljZXMiKSAgICAgICAgICAgICAgICAgOyAt W1VJVmlld1NlcnZpY2VJbnRlcmZhY2UgX2NyZWF0ZVByb2Nlc3NBc3NlcnRpb25dIC0+IFNCU1By b2Nlc3NJREZvckRpc3BsYXlJZGVudGlmaWVyKCkKLSAgICAgICAgKGdsb2JhbC1uYW1lICJjb20u YXBwbGUuQ0FSZW5kZXJTZXJ2ZXIiKQogICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5p b2hpZGV2ZW50c3lzdGVtIikKICAgICApCiAKLSAgICAoYWxsb3cgbWFjaC1sb29rdXAgKHdpdGgg dGVsZW1ldHJ5KQorICAgIChhbGxvdyBtYWNoLWxvb2t1cAorICAgICAgICAoZ2xvYmFsLW5hbWUg ImNvbS5hcHBsZS5DQVJlbmRlclNlcnZlciIpKQorCisgICAgKGFsbG93IG1hY2gtbG9va3VwICh3 aXRoIHJlcG9ydCkgKHdpdGggdGVsZW1ldHJ5KQogICAgICAgICAoZ2xvYmFsLW5hbWUtcmVnZXgg IyJeY29tXC5hcHBsZVwudWlraXRcLnZpZXdzZXJ2aWNlXC4uKyIpCiAgICAgICAgICh4cGMtc2Vy dmljZS1uYW1lLXJlZ2V4ICMiXC5hcHBsZS1leHRlbnNpb24tc2VydmljZSQiKSA7OyA8cmRhcjov L3Byb2JsZW0vMTk1MjU4ODc+CiAgICAgICAgICh4cGMtc2VydmljZS1uYW1lLXJlZ2V4ICMiXC52 aWV3c2VydmljZSQiKSA7OyA8cmRhcjovL3Byb2JsZW0vMzEyNTIzNzE+CkBAIC03MDQsNyArNzEw LDcgQEAKICh1cmwtdHJhbnNsYXRpb24pCiAKIDs7IFRleHRJbnB1dCBmcmFtZXdvcmsKLShhbGxv dyBtYWNoLWxvb2t1cAorKGFsbG93IG1hY2gtbG9va3VwICh3aXRoIHJlcG9ydCkgKHdpdGggdGVs ZW1ldHJ5KQogICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLlRleHRJbnB1dCIpKQogCiAobW9i aWxlLXByZWZlcmVuY2VzLXJlYWQgImNvbS5hcHBsZS5kYSIpCg==