203802 2019-11-04 01:18:47 -0800 RealtimeOutgoingAudioSource/RealtimeOutgoingVideoSource should unobserve before destruction time 2019-11-04 07:47:08 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson ews-watchlist glenn hta jer.noble philipj sergio tommyw webkit-bug-importer youennf oldest_to_newest 1586907 0 youennf 2019-11-04 01:18:47 -0800 RealtimeOutgoingAudioSource/RealtimeOutgoingVideoSource should unobserve before destruction time. They might ref themselves in observer callbacks 1586908 1 webkit-bug-importer 2019-11-04 01:19:30 -0800 <rdar://problem/56858330> 1586912 2 382723 youennf 2019-11-04 01:43:04 -0800 Created attachment 382723 Patch 1586982 3 382723 commit-queue 2019-11-04 07:47:06 -0800 Comment on attachment 382723 Patch Clearing flags on attachment: 382723 Committed r251989: <https://trac.webkit.org/changeset/251989> 1586983 4 commit-queue 2019-11-04 07:47:08 -0800 All reviewed patches have been landed. Closing bug. 382723 2019-11-04 01:43:04 -0800 2019-11-04 07:47:06 -0800 Patch bug-203802-20191104104302.patch text/plain 5711 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxOTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjFiMDk5NDllYmQzOWMx M2Q0YWNkYzMwYzliZmFhMzU2Y2U4NjdiNy4uM2M3ZWRhY2QzZjNiOGQ0YTNlNTgxYTgyMjg1NTZk ZjVkOTVjNGU0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE5LTExLTA0ICB5b3Vl bm4gZmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSZWFsdGltZU91dGdvaW5n QXVkaW9Tb3VyY2UvUmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291cmNlIHNob3VsZCB1bm9ic2VydmUg YmVmb3JlIGRlc3RydWN0aW9uIHRpbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwMzgwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoZXNlIGNsYXNzZXMgYXJlIHVzZWQgYnkgTGliV2ViUlRDUnRwU2Vu ZGVyQmFja2VuZC4KKyAgICAgICAgV2hlbiB0aGUgYmFja2VuZCBpcyBkZXN0cm95ZWQsIG5vdGlm eSB0aGUgc291cmNlcyB0byB1bm9ic2VydmUgYmVmb3JlIHVucmVmaW5nIHRoZW0uCisgICAgICAg IEFkZCBkZWJ1ZyBhc3NlcnRpb25zIHRvIGVuc3VyZSB0aGlzIGlzIGRvbmUgY29ycmVjdGx5Lgor ICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogTW9kdWxlcy9t ZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDUnRwU2VuZGVyQmFja2VuZC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpMaWJXZWJSVENSdHBTZW5kZXJCYWNrZW5kOjp+TGliV2ViUlRDUnRwU2Vu ZGVyQmFja2VuZCk6CisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGli V2ViUlRDUnRwU2VuZGVyQmFja2VuZC5oOgorICAgICAgICBGaXhlZCBWYXJpYW50IE1vdmUgaXNz dWUuCisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1UcmFja1ByaXZh dGUuaDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU3RyZWFtVHJhY2tQcml2YXRlOjpoYXNPYnNl cnZlciBjb25zdCk6CisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vUmVhbHRpbWVPdXRn b2luZ0F1ZGlvU291cmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlYWx0aW1lT3V0Z29pbmdB dWRpb1NvdXJjZTo6flJlYWx0aW1lT3V0Z29pbmdBdWRpb1NvdXJjZSk6CisgICAgICAgICogcGxh dGZvcm0vbWVkaWFzdHJlYW0vUmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291cmNlLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlYWx0aW1lT3V0Z29pbmdWaWRlb1NvdXJjZTo6flJlYWx0aW1lT3V0Z29p bmdWaWRlb1NvdXJjZSk6CisKIDIwMTktMTEtMDQgIHlvdWVubiBmYWJsZXQgIDx5b3Vlbm5AYXBw bGUuY29tPgogCiAgICAgICAgIEVuZm9yY2UgdXNlciBnZXN0dXJlIGZvciBnZXRVc2VyTWVkaWEg aW4gY2FzZSBhIHByZXZpb3VzIGdldFVzZXJNZWRpYSBjYWxsIHdhcyBkZW5pZWQKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJU Q1J0cFNlbmRlckJhY2tlbmQuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVh bS9saWJ3ZWJydGMvTGliV2ViUlRDUnRwU2VuZGVyQmFja2VuZC5jcHAKaW5kZXggNTMzMzNjYjg1 YTIwYzQ0NmIzODdiNzEyNmNiYjU5ODIzMmM3OWI1ZS4uNmM5NjFlNWZhMzJiNzY5OWYxYmE2ODdi NDdmZGQyZjIyNTI5MDAxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDUnRwU2VuZGVyQmFja2VuZC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDUnRwU2Vu ZGVyQmFja2VuZC5jcHAKQEAgLTM3LDYgKzM3LDE2IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsK IAorTGliV2ViUlRDUnRwU2VuZGVyQmFja2VuZDo6fkxpYldlYlJUQ1J0cFNlbmRlckJhY2tlbmQo KQoreworICAgIFdURjo6c3dpdGNoT24obV9zb3VyY2UsIFtdIChSZWY8UmVhbHRpbWVPdXRnb2lu Z0F1ZGlvU291cmNlPiYgc291cmNlKSB7CisgICAgICAgIHNvdXJjZS0+c3RvcCgpOworICAgIH0s IFtdIChSZWY8UmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291cmNlPiYgc291cmNlKSB7CisgICAgICAg IHNvdXJjZS0+c3RvcCgpOworICAgIH0sIFtdIChzdGQ6Om51bGxwdHJfdCYpIHsKKyAgICB9KTsK K30KKwogdGVtcGxhdGU8dHlwZW5hbWUgU291cmNlPgogc3RhdGljIGlubGluZSBib29sIHVwZGF0 ZVRyYWNrU291cmNlKFNvdXJjZSYgc291cmNlLCBNZWRpYVN0cmVhbVRyYWNrKiB0cmFjaykKIHsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vbGlid2VicnRj L0xpYldlYlJUQ1J0cFNlbmRlckJhY2tlbmQuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk aWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1J0cFNlbmRlckJhY2tlbmQuaAppbmRleCBiZWZl Y2JmOWIyZmM5MGNiMzMwYmI0NzQxY2RhNDFkMmExYzJmMWU0Li4yOGIyMDdjMDNkYzM0ZDBmZmVi MzkxMTk1Nzk5Zjk4NjdhMzMzYzBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENSdHBTZW5kZXJCYWNrZW5kLmgKKysrIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDUnRw U2VuZGVyQmFja2VuZC5oCkBAIC02MCw2ICs2MCw3IEBAIHB1YmxpYzoKICAgICAgICAgLCBtX3Nv dXJjZShXVEZNb3ZlKHNvdXJjZSkpCiAgICAgewogICAgIH0KKyAgICB+TGliV2ViUlRDUnRwU2Vu ZGVyQmFja2VuZCgpOwogCiAgICAgdm9pZCBzZXRSVENTZW5kZXIocnRjOjpzY29wZWRfcmVmcHRy PHdlYnJ0Yzo6UnRwU2VuZGVySW50ZXJmYWNlPiYmIHJ0Y1NlbmRlcikgeyBtX3J0Y1NlbmRlciA9 IFdURk1vdmUocnRjU2VuZGVyKTsgfQogICAgIHdlYnJ0Yzo6UnRwU2VuZGVySW50ZXJmYWNlKiBy dGNTZW5kZXIoKSB7IHJldHVybiBtX3J0Y1NlbmRlci5nZXQoKTsgfQpAQCAtMTA1LDYgKzEwNiw3 IEBAIHB1YmxpYzoKICAgICB7CiAgICAgICAgIEFTU0VSVChiYWNrZW5kLmhhc1NvdXJjZSgpKTsK ICAgICAgICAgc2V0U291cmNlKFdURk1vdmUoYmFja2VuZC5tX3NvdXJjZSkpOworICAgICAgICBi YWNrZW5kLm1fc291cmNlID0gbnVsbHB0cjsKICAgICB9CiAKIHByaXZhdGU6CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbVRyYWNrUHJp dmF0ZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1U cmFja1ByaXZhdGUuaAppbmRleCA4Nzc5YjIyZWQwYTZjZjM0NDE2NWJmZGM2M2I1ZjJiMTBiMzlk OTMzLi5hNGVjNDM4YTk4NDRmYzgyNTE2MTllZDMzOThmZmY3YWViYjE5MjI2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbVRyYWNrUHJp dmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3Ry ZWFtVHJhY2tQcml2YXRlLmgKQEAgLTEwNiw2ICsxMDYsOSBAQCBwdWJsaWM6CiAKICAgICB2b2lk IGFkZE9ic2VydmVyKE9ic2VydmVyJik7CiAgICAgdm9pZCByZW1vdmVPYnNlcnZlcihPYnNlcnZl ciYpOworI2lmICFBU1NFUlRfRElTQUJMRUQKKyAgICBib29sIGhhc09ic2VydmVyKE9ic2VydmVy JikgY29uc3Q7CisjZW5kaWYKIAogICAgIGNvbnN0IFJlYWx0aW1lTWVkaWFTb3VyY2VTZXR0aW5n cyYgc2V0dGluZ3MoKSBjb25zdDsKICAgICBjb25zdCBSZWFsdGltZU1lZGlhU291cmNlQ2FwYWJp bGl0aWVzJiBjYXBhYmlsaXRpZXMoKSBjb25zdDsKQEAgLTE2Nyw2ICsxNzAsMTQgQEAgcHJpdmF0 ZToKIAogdHlwZWRlZiBWZWN0b3I8UmVmUHRyPE1lZGlhU3RyZWFtVHJhY2tQcml2YXRlPj4gTWVk aWFTdHJlYW1UcmFja1ByaXZhdGVWZWN0b3I7CiAKKyNpZiAhQVNTRVJUX0RJU0FCTEVECitpbmxp bmUgYm9vbCBNZWRpYVN0cmVhbVRyYWNrUHJpdmF0ZTo6aGFzT2JzZXJ2ZXIoT2JzZXJ2ZXImIG9i c2VydmVyKSBjb25zdAoreworICAgIGF1dG8gbG9ja2VyID0gaG9sZExvY2sobV9vYnNlcnZlcnNM b2NrKTsKKyAgICByZXR1cm4gbV9vYnNlcnZlcnMuY29udGFpbnMoJm9ic2VydmVyKTsKK30KKyNl bmRpZgorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBFTkFCTEUoTUVESUFf U1RSRUFNKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0v UmVhbHRpbWVPdXRnb2luZ0F1ZGlvU291cmNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L21lZGlhc3RyZWFtL1JlYWx0aW1lT3V0Z29pbmdBdWRpb1NvdXJjZS5jcHAKaW5kZXggNDcxOTZj NDFmY2U4ZWZjYmFkZGRjZjJjOTgzMmViNWM1OWYzMGEyMS4uNjhiNzUwZTdhZTJkNjViZjUzMDJh NWJkNThkMjc2MTA5Y2RkNGU5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bWVkaWFzdHJlYW0vUmVhbHRpbWVPdXRnb2luZ0F1ZGlvU291cmNlLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGltZU91dGdvaW5nQXVkaW9Tb3VyY2Uu Y3BwCkBAIC00NSw2ICs0NSw3IEBAIFJlYWx0aW1lT3V0Z29pbmdBdWRpb1NvdXJjZTo6UmVhbHRp bWVPdXRnb2luZ0F1ZGlvU291cmNlKFJlZjxNZWRpYVN0cmVhbVRyYWNrUHJpCiAKIFJlYWx0aW1l T3V0Z29pbmdBdWRpb1NvdXJjZTo6flJlYWx0aW1lT3V0Z29pbmdBdWRpb1NvdXJjZSgpCiB7Cisg ICAgQVNTRVJUKCFtX2F1ZGlvU291cmNlLT5oYXNPYnNlcnZlcigqdGhpcykpOwogICAgIEFTU0VS VChtX3NpbmtzLmlzRW1wdHkoKSk7CiAgICAgc3RvcCgpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vUmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291cmNl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL1JlYWx0aW1lT3V0Z29p bmdWaWRlb1NvdXJjZS5jcHAKaW5kZXggZWY5M2U2N2RmMjM4NzkwYTVlZDM3NDNlMzQzOThkNmU4 MzVkMzMwOC4uYTJiZDUwMDE2ZjRjNDk4MTQ3NDgwYTVlOGEyM2VmOWFmYTc1OGU4OSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vUmVhbHRpbWVPdXRnb2lu Z1ZpZGVvU291cmNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVh bS9SZWFsdGltZU91dGdvaW5nVmlkZW9Tb3VyY2UuY3BwCkBAIC01Niw2ICs1Niw3IEBAIFJlYWx0 aW1lT3V0Z29pbmdWaWRlb1NvdXJjZTo6UmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291cmNlKFJlZjxN ZWRpYVN0cmVhbVRyYWNrUHJpCiAKIFJlYWx0aW1lT3V0Z29pbmdWaWRlb1NvdXJjZTo6flJlYWx0 aW1lT3V0Z29pbmdWaWRlb1NvdXJjZSgpCiB7CisgICAgQVNTRVJUKCFtX3ZpZGVvU291cmNlLT5o YXNPYnNlcnZlcigqdGhpcykpOwogICAgIEFTU0VSVChtX3NpbmtzLmlzRW1wdHkoKSk7CiAgICAg c3RvcCgpOwogfQo=