203788 2019-11-02 12:25:46 -0700 Don't show the broken image icon for missing CSS images 2023-05-22 09:07:27 -0700 1 1 1 Unclassified WebKit Images WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 229909 1 simon.fraser webkit-unassigned gsnedders rreno sabouhallawa simon.fraser webkit-bug-importer oldest_to_newest 1586761 0 simon.fraser 2019-11-02 12:25:46 -0700 We currently render the broken image icon for missing CSS images (backgrounds, border-image etc) but I don't think we should. I think we should only show it for content images. 1587037 1 sabouhallawa 2019-11-04 10:10:39 -0800 (In reply to Simon Fraser (smfr) from comment #0) > We currently render the broken image icon for missing CSS images > (backgrounds, border-image etc) but I don't think we should. I think we > should only show it for content images. How can this happen? Can you include a test case? In RenderBoxModelObject::paintFillLayerExtended() we check: bool shouldPaintBackgroundImage = bgImage && bgImage->canRender(this, style().effectiveZoom()); If the image is missing, bgImage will be null. And if an error happens while loading or decoding the image, bgImage->canRender() will return false. In both cases drawing the background image step will be skipped. 1587048 2 simon.fraser 2019-11-04 10:27:38 -0800 I think I was seeing this for border-image. 1803045 3 gsnedders 2021-10-12 02:42:31 -0700 *** Bug 231078 has been marked as a duplicate of this bug. *** 1803050 4 gsnedders 2021-10-12 02:48:13 -0700 (In reply to Simon Fraser (smfr) from comment #2) > I think I was seeing this for border-image. Bug 206909 was caused by us rendering `content: -webkit-image-set(url(...))` given an invalid image. 1803134 5 gsnedders 2021-10-12 08:44:10 -0700 <rdar://problem/82999675> 1805876 6 simon.fraser 2021-10-18 21:16:30 -0700 I can't figure out how to reproduce this now. 1805882 7 simon.fraser 2021-10-18 21:40:31 -0700 This is one way: background-image: -webkit-cross-fade(url('http://www.example.com/broken.png'), url('http://www.example.com/broken.png'), 50%); I think it's bad that CachedImage::image() and CachedImage::imageForRenderer() can return the broken image icon. That causes hilarity like consulting this image for it's opaqueness, or EXIF orientation, even if it's never used in this context (e.g. CSS backgrounds). 1805884 8 441689 simon.fraser 2021-10-18 22:00:42 -0700 Created attachment 441689 Some examples 1805952 9 gsnedders 2021-10-19 05:30:03 -0700 (In reply to Simon Fraser (smfr) from comment #6) > I can't figure out how to reproduce this now. content: -webkit-image-set(url('http://www.example.com/broken.png') 1x); still suffices too should really go through and add a whole bunch of WPT tests for this, in the various places where <image> is used as the value 1909279 10 gsnedders 2022-10-31 03:46:41 -0700 <rdar://problem/84026868> 1956966 11 rreno 2023-05-22 09:07:27 -0700 The images level 4 spec introduced the concept of an invalid image: http://w3c.github.io/csswg-drafts/css-images-4/#invalid-image I implemented this as a StyleInvalidImage for use in image-set in 261015@main Maybe this is useful in the contexts described in this bug too? 441689 2021-10-18 22:00:42 -0700 2021-10-18 22:00:42 -0700 Some examples broken-css-images.html text/html 983 simon.fraser PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KICAgIDxtZXRhIG5hbWU9InZpZXdwb3J0IiBj b250ZW50PSJ3aWR0aD1kZXZpY2Utd2lkdGgsIGluaXRpYWwtc2NhbGU9MSwgc2hyaW5rLXRvLWZp dD1ubyI+CiAgICA8c3R5bGU+CiAgICAgICAgLmJveCB7CiAgICAgICAgICAgIHdpZHRoOiAyMDBw eDsKICAgICAgICAgICAgaGVpZ2h0OiAyMDBweDsKICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xv cjogc2lsdmVyOwogICAgICAgICAgICBmb250LXNpemU6IDEwMHB4OwogICAgICAgICAgICBtYXJn aW46IDIwcHg7CiAgICAgICAgfQogICAgICAgIAogICAgICAgIGltZyB7CiAgICAgICAgICAgIHdp ZHRoOiAxMDBweDsKICAgICAgICAgICAgaGVpZ2h0OiAxMDBweDsKICAgICAgICB9CiAgICAgICAg CiAgICAgICAgLmNyb3NzZmFkZSB7CiAgICAgICAgICAgIGJhY2tncm91bmQtaW1hZ2U6IC13ZWJr aXQtY3Jvc3MtZmFkZSh1cmwoJ2h0dHA6Ly93d3cuZXhhbXBsZS5jb20vYnJva2VuLnBuZycpLCB1 cmwoJ2h0dHA6Ly93d3cuZXhhbXBsZS5jb20vYnJva2VuLnBuZycpLCA1MCUpOwogICAgICAgIH0K CiAgICAgICAgLmZpbHRlciB7CiAgICAgICAgICAgIGJhY2tncm91bmQtaW1hZ2U6IGZpbHRlcih1 cmwoJ2h0dHA6Ly93d3cuZXhhbXBsZS5jb20vYnJva2VuLnBuZycpLCBzYXR1cmF0ZSgwLjUpKTsK ICAgICAgICB9CiAgICA8L3N0eWxlPgo8L2hlYWQ+Cjxib2R5PgogICAgCiAgICA8aDE+aW1hZ2Ug ZWxlbWVudDwvaDE+CiAgICA8aW1nIGlkPSJicm9rZW4taW1hZ2UiIHNyYz0iaHR0cDovL3d3dy5l eGFtcGxlLmNvbS9icm9rZW4ucG5nIj4KICAgIAogICAgPGgxPmNyb3NzIGZhZGUgaW1hZ2U8L2gx PgogICAgPGRpdiBjbGFzcz0iY3Jvc3NmYWRlIGJveCI+PC9kaXY+CgogICAgPGgxPmZpbHRlciBp bWFnZTwvaDE+CiAgICA8ZGl2IGNsYXNzPSJmaWx0ZXIgYm94Ij48L2Rpdj4KICAgIAogICAgCjwv Ym9keT4KPC9odG1sPgo=