203779 2019-11-02 06:08:45 -0700 [LFC][Verification] Forced line break display runs don't have TextContext 2019-11-03 15:39:10 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1586724 0 zalan 2019-11-02 06:08:45 -0700 Since they are not text runs. 1586725 1 webkit-bug-importer 2019-11-02 06:09:03 -0700 <rdar://problem/56839710> 1586726 2 382675 zalan 2019-11-02 06:16:54 -0700 Created attachment 382675 Patch 1586727 3 382676 zalan 2019-11-02 06:18:14 -0700 Created attachment 382676 Patch 1586818 4 382676 koivisto 2019-11-03 01:10:59 -0800 Comment on attachment 382676 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382676&action=review > Source/WebCore/layout/Verification.cpp:127 > && areEssentiallyEqual(inlineTextBox.logicalRight(), inlineRun.logicalRight()) > && areEssentiallyEqual(inlineTextBox.logicalTop(), inlineRun.logicalTop()) > && areEssentiallyEqual(inlineTextBox.logicalBottom(), inlineRun.logicalBottom()) There is areEssentiallyEqual for LayoutRects that could be used here. 1586869 5 zalan 2019-11-03 14:56:10 -0800 (In reply to Antti Koivisto from comment #4) > Comment on attachment 382676 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=382676&action=review > > > Source/WebCore/layout/Verification.cpp:127 > > && areEssentiallyEqual(inlineTextBox.logicalRight(), inlineRun.logicalRight()) > > && areEssentiallyEqual(inlineTextBox.logicalTop(), inlineRun.logicalTop()) > > && areEssentiallyEqual(inlineTextBox.logicalBottom(), inlineRun.logicalBottom()) > > There is areEssentiallyEqual for LayoutRects that could be used here. This local version of areEssentiallyEqual is a bit more relaxed than a generic areEssentiallyEqual function (the epsilon covers cases when a final geometry value goes through a handful of arithmetic conversions) 1586872 6 382676 commit-queue 2019-11-03 15:39:08 -0800 Comment on attachment 382676 Patch Clearing flags on attachment: 382676 Committed r251977: <https://trac.webkit.org/changeset/251977> 1586873 7 commit-queue 2019-11-03 15:39:10 -0800 All reviewed patches have been landed. Closing bug. 382675 2019-11-02 06:16:54 -0700 2019-11-02 06:18:13 -0700 Patch bug-203779-20191102061650.patch text/plain 1935 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxOTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjM3NjIwYWQ0NjU0MWRl NGI3ZTY5OTdhYmFkMDA5MTRlMDBhNDExOC4uMGI0OTMyMzU0YTkxN2UxMDc4NzQ4MTdkZTRlNzlh YWRjMDNiMDA3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTExLTAyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bVmVyaWZpY2F0aW9u XSBGb3JjZWQgbGluZSBicmVhayBkaXNwbGF5IHJ1bnMgZG9uJ3QgaGF2ZSBUZXh0Q29udGV4dAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzNzc5Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NjgzOTcxMD4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEaXNwbGF5IHJ1bnMncyBvcHRpb25hbCBUZXh0Q29u dGVudCBpcyBubyBhdmFpbGFibGUgZm9yIGZvcmNlZCBsaW5lIGJyZWFrcyAoc2luY2UgdGhleSBh cmUgbm90IHRleHQgcnVucykuCisKKyAgICAgICAgKiBsYXlvdXQvVmVyaWZpY2F0aW9uLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6Y2hlY2tGb3JNYXRjaGluZ1RleHRSdW5zKToKKwog MjAxOS0xMS0wMiAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtM RkNdW0lGQ10gUnVucyBjb2xsYXBzZWQgdG8gemVybyBhZHZhbmNlZCB3aWR0aCBhcmUgbm90IGFs d2F5cyB3aGl0ZXNwYWNlIGNvbGxhcHNlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5 b3V0L1ZlcmlmaWNhdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvVmVyaWZpY2F0aW9u LmNwcAppbmRleCAzZWZjMjNiNjhhMTQzYzU4NWUyNzZlODNjYzIzZGU0YzA4NjlhM2IxLi5jY2Nj NDc0ZGYzMmVhYTIxNDQzMGZjZTBmNjRkNjQ1MTM5Mjg5ZmFjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvVmVyaWZpY2F0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlv dXQvVmVyaWZpY2F0aW9uLmNwcApAQCAtMTI1LDggKzEyNSw3IEBAIHN0YXRpYyBib29sIGNoZWNr Rm9yTWF0Y2hpbmdUZXh0UnVucyhjb25zdCBEaXNwbGF5OjpSdW4mIGlubGluZVJ1biwgY29uc3Qg SW5saW5lCiAgICAgICAgICYmIGFyZUVzc2VudGlhbGx5RXF1YWwoaW5saW5lVGV4dEJveC5sb2dp Y2FsUmlnaHQoKSwgaW5saW5lUnVuLmxvZ2ljYWxSaWdodCgpKQogICAgICAgICAmJiBhcmVFc3Nl bnRpYWxseUVxdWFsKGlubGluZVRleHRCb3gubG9naWNhbFRvcCgpLCBpbmxpbmVSdW4ubG9naWNh bFRvcCgpKQogICAgICAgICAmJiBhcmVFc3NlbnRpYWxseUVxdWFsKGlubGluZVRleHRCb3gubG9n aWNhbEJvdHRvbSgpLCBpbmxpbmVSdW4ubG9naWNhbEJvdHRvbSgpKQotICAgICAgICAmJiBpbmxp bmVUZXh0Qm94LnN0YXJ0KCkgPT0gaW5saW5lUnVuLnRleHRDb250ZXh0KCktPnN0YXJ0KCkKLSAg ICAgICAgJiYgaW5saW5lVGV4dEJveC5lbmQoKSA9PSBpbmxpbmVSdW4udGV4dENvbnRleHQoKS0+ ZW5kKCk7CisgICAgICAgICYmIChpbmxpbmVUZXh0Qm94LmlzTGluZUJyZWFrKCkgfHwgKGlubGlu ZVRleHRCb3guc3RhcnQoKSA9PSBpbmxpbmVSdW4udGV4dENvbnRleHQoKS0+c3RhcnQoKSAmJiBp bmxpbmVUZXh0Qm94LmVuZCgpID09IGlubGluZVJ1bi50ZXh0Q29udGV4dCgpLT5lbmQoKSkpOwog fQogCiBzdGF0aWMgdm9pZCBjb2xsZWN0Rmxvd0JveFN1YnRyZWUoY29uc3QgSW5saW5lRmxvd0Jv eCYgZmxvd2JveCwgVmVjdG9yPFdlYkNvcmU6OklubGluZUJveCo+JiBpbmxpbmVCb3hlcykK 382676 2019-11-02 06:18:14 -0700 2019-11-03 15:39:08 -0800 Patch bug-203779-20191102061810.patch text/plain 1936 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxOTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjM3NjIwYWQ0NjU0MWRl NGI3ZTY5OTdhYmFkMDA5MTRlMDBhNDExOC4uNGZkN2UyMTUwOGU5YzkyNmE1ZDFlNTk1OTM0MmQ3 Nzc2ZTIyNzQwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTExLTAyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bVmVyaWZpY2F0aW9u XSBGb3JjZWQgbGluZSBicmVhayBkaXNwbGF5IHJ1bnMgZG9uJ3QgaGF2ZSBUZXh0Q29udGV4dAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzNzc5Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NjgzOTcxMD4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEaXNwbGF5OjpSdW4ncyBvcHRpb25hbCBUZXh0Q29u dGV4dCBpcyBub3QgYXZhaWxhYmxlIGZvciBmb3JjZWQgbGluZSBicmVha3MgKHNpbmNlIHRoZXkg YXJlIG5vdCB0ZXh0IHJ1bnMpLgorCisgICAgICAgICogbGF5b3V0L1ZlcmlmaWNhdGlvbi5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OmNoZWNrRm9yTWF0Y2hpbmdUZXh0UnVucyk6CisK IDIwMTktMTEtMDIgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBb TEZDXVtJRkNdIFJ1bnMgY29sbGFwc2VkIHRvIHplcm8gYWR2YW5jZWQgd2lkdGggYXJlIG5vdCBh bHdheXMgd2hpdGVzcGFjZSBjb2xsYXBzZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9WZXJpZmljYXRpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L1ZlcmlmaWNhdGlv bi5jcHAKaW5kZXggM2VmYzIzYjY4YTE0M2M1ODVlMjc2ZTgzY2MyM2RlNGMwODY5YTNiMS4uY2Nj YzQ3NGRmMzJlYWEyMTQ0MzBmY2UwZjY0ZDY0NTEzOTI4OWZhYyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvbGF5b3V0L1ZlcmlmaWNhdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5 b3V0L1ZlcmlmaWNhdGlvbi5jcHAKQEAgLTEyNSw4ICsxMjUsNyBAQCBzdGF0aWMgYm9vbCBjaGVj a0Zvck1hdGNoaW5nVGV4dFJ1bnMoY29uc3QgRGlzcGxheTo6UnVuJiBpbmxpbmVSdW4sIGNvbnN0 IElubGluZQogICAgICAgICAmJiBhcmVFc3NlbnRpYWxseUVxdWFsKGlubGluZVRleHRCb3gubG9n aWNhbFJpZ2h0KCksIGlubGluZVJ1bi5sb2dpY2FsUmlnaHQoKSkKICAgICAgICAgJiYgYXJlRXNz ZW50aWFsbHlFcXVhbChpbmxpbmVUZXh0Qm94LmxvZ2ljYWxUb3AoKSwgaW5saW5lUnVuLmxvZ2lj YWxUb3AoKSkKICAgICAgICAgJiYgYXJlRXNzZW50aWFsbHlFcXVhbChpbmxpbmVUZXh0Qm94Lmxv Z2ljYWxCb3R0b20oKSwgaW5saW5lUnVuLmxvZ2ljYWxCb3R0b20oKSkKLSAgICAgICAgJiYgaW5s aW5lVGV4dEJveC5zdGFydCgpID09IGlubGluZVJ1bi50ZXh0Q29udGV4dCgpLT5zdGFydCgpCi0g ICAgICAgICYmIGlubGluZVRleHRCb3guZW5kKCkgPT0gaW5saW5lUnVuLnRleHRDb250ZXh0KCkt PmVuZCgpOworICAgICAgICAmJiAoaW5saW5lVGV4dEJveC5pc0xpbmVCcmVhaygpIHx8IChpbmxp bmVUZXh0Qm94LnN0YXJ0KCkgPT0gaW5saW5lUnVuLnRleHRDb250ZXh0KCktPnN0YXJ0KCkgJiYg aW5saW5lVGV4dEJveC5lbmQoKSA9PSBpbmxpbmVSdW4udGV4dENvbnRleHQoKS0+ZW5kKCkpKTsK IH0KIAogc3RhdGljIHZvaWQgY29sbGVjdEZsb3dCb3hTdWJ0cmVlKGNvbnN0IElubGluZUZsb3dC b3gmIGZsb3dib3gsIFZlY3RvcjxXZWJDb3JlOjpJbmxpbmVCb3gqPiYgaW5saW5lQm94ZXMpCg==