203778 2019-11-02 05:51:57 -0700 [LFC][IFC] Runs collapsed to zero advanced width are not always whitespace collapsed 2019-11-03 07:10:36 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1586721 0 zalan 2019-11-02 05:51:57 -0700 Should find a better name for Run::isCollapsedToZeroAdvanceWidth() since it can easily be confused with whitespace collapsing 1586722 1 webkit-bug-importer 2019-11-02 05:52:09 -0700 <rdar://problem/56839642> 1586723 2 382674 zalan 2019-11-02 06:02:15 -0700 Created attachment 382674 Patch 1586830 3 382674 commit-queue 2019-11-03 07:10:35 -0800 Comment on attachment 382674 Patch Clearing flags on attachment: 382674 Committed r251973: <https://trac.webkit.org/changeset/251973> 1586831 4 commit-queue 2019-11-03 07:10:36 -0800 All reviewed patches have been landed. Closing bug. 382674 2019-11-02 06:02:15 -0700 2019-11-03 07:10:35 -0800 Patch bug-203778-20191102060210.patch text/plain 3077 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxOTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjc2ZTRhNGUyYzNmZThh YTE2NDFlNWU5OWEyZGNkZDkyMzFiMTQ5Yy4uZjM3NjIwYWQ0NjU0MWRlNGI3ZTY5OTdhYmFkMDA5 MTRlMDBhNDExOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTExLTAyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBSdW5zIGNv bGxhcHNlZCB0byB6ZXJvIGFkdmFuY2VkIHdpZHRoIGFyZSBub3QgYWx3YXlzIHdoaXRlc3BhY2Ug Y29sbGFwc2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDM3NzgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU2ODM5NjQyPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEp1c3QgYmVjYXVzZSBhIHJ1biBj b2xsYXBzZXMgdG8gemVybyBhZHZhbmNlZCB3aWR0aCwgaXQgZG9lcyBub3QgbmVjZXNzYXJpbHkg bWVhbiBpdCBpcyBhIGNvbGxhcHNlZCBydW4gKGluIHdoaXRlc3BhY2UgY29sbGFwc2luZyBzZW5z ZSkKKyAgICAgICAgZS5nLiB0cmltbWVkIHRyYWlsaW5nIHdoaXRlc3BhY2UgKG1fY29sbGFwc2Vk VG9aZXJvQWR2YW5jZVdpZHRoIHNob3VsZCBwcm9iYWJseSBiZSByZW5hbWVkIHRvIHNvbWV0aGlu ZyBvdGhlciB0aGFuICJjb2xsYXBzZWQiIHRvIGF2b2lkIGNvbmZ1c2lvbikuCisKKyAgICAgICAg KiBsYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkxheW91dDo6TGluZTo6Y2xvc2UpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5l OjphcHBlbmRUZXh0Q29udGVudCk6CisgICAgICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcv SW5saW5lTGluZS5oOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5lOjpSdW46OnNldENv bGxhcHNlc1RvWmVyb0FkdmFuY2VXaWR0aCk6CisKIDIwMTktMTEtMDEgIENocmlzIER1bWV6ICA8 Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBQb3J0IFNlcnZpY2VXb3JrZXJDb250YWluZXIg dG8gdGhlIEhUTUw1IGV2ZW50IGxvb3AKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91 dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmUuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAKaW5kZXggZGQzYjhhZTE2YjNlZjVjYjRl NzYwZjg2OTYxZGJiYWI0ZGY5MjRiZC4uOTFjYTZmM2I2ZTUzNTk2MDZkNjIxYTBhMjI3ODdkZmZj YjcxZTRkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRp bmcvSW5saW5lTGluZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1h dHRpbmcvSW5saW5lTGluZS5jcHAKQEAgLTE1OCw3ICsxNTgsNyBAQCBMaW5lOjpSdW5MaXN0IExp bmU6OmNsb3NlKElzTGFzdExpbmVXaXRoSW5saW5lQ29udGVudCBpc0xhc3RMaW5lV2l0aElubGlu ZUNvbnRlbgogICAgICAgICAgICAgaWYgKHByZXZpb3VzUnVuLT5oYXNUcmFpbGluZ0NvbGxhcHNl ZENvbnRlbnQoKSkKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgICAgICAv LyBWaXN1YWxseSBlbXB0eSBydW5zIGFyZSBpZ25vcmVkLgotICAgICAgICAgICAgaWYgKGN1cnJl bnRSdW4tPmlzQ29sbGFwc2VkVG9aZXJvQWR2YW5jZVdpZHRoKCkpCisgICAgICAgICAgICBpZiAo Y3VycmVudFJ1bi0+aXNDb2xsYXBzZWRUb1plcm9BZHZhbmNlV2lkdGgoKSB8fCBwcmV2aW91c1J1 bi0+aXNDb2xsYXBzZWRUb1plcm9BZHZhbmNlV2lkdGgoKSkKICAgICAgICAgICAgICAgICByZXR1 cm4gZmFsc2U7CiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgfTsKQEAgLTQ2Myw3 ICs0NjMsNyBAQCB2b2lkIExpbmU6OmFwcGVuZFRleHRDb250ZW50KGNvbnN0IElubGluZVRleHRJ dGVtJiBpbmxpbmVJdGVtLCBMYXlvdXRVbml0IGxvZ2ljYQogICAgIGF1dG8gY29sbGFwc2VzVG9a ZXJvQWR2YW5jZVdpZHRoID0gd2lsbENvbGxhcHNlQ29tcGxldGVseSgpOwogICAgIGlmIChjb2xs YXBzZXNUb1plcm9BZHZhbmNlV2lkdGgpCiAgICAgICAgIGxpbmVSdW4tPnNldENvbGxhcHNlc1Rv WmVyb0FkdmFuY2VXaWR0aCgpOwotICAgIGVsc2UgaWYgKGNvbGxhcHNlZFJ1bikKKyAgICBpZiAo Y29sbGFwc2VkUnVuKQogICAgICAgICBsaW5lUnVuLT5zZXRJc0NvbGxhcHNlZCgpOwogICAgIGlm IChpc1RyaW1tYWJsZSkKICAgICAgICAgbV90cmltbWFibGVDb250ZW50LmFkZChsaW5lUnVuLmdl dCgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5n L0lubGluZUxpbmUuaCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lu bGluZUxpbmUuaAppbmRleCAxZTllYjg2MjUzNzg5ODQ3MDIzNDMyNWQwNDk2MzJlOWY4ZTMwM2Fh Li4xZGVmMDcyZDdjY2JlMGFjYTU2YjUwNDhmNDU1NzNlYTUyN2YyOTE0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmgKKysrIGIv U291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5oCkBAIC0x ODIsNyArMTgyLDYgQEAgaW5saW5lIGJvb2wgTGluZTo6UnVuOjppc0NvbGxhcHNlZFRvWmVyb0Fk dmFuY2VXaWR0aCgpIGNvbnN0CiAKIGlubGluZSB2b2lkIExpbmU6OlJ1bjo6c2V0Q29sbGFwc2Vz VG9aZXJvQWR2YW5jZVdpZHRoKCkKIHsKLSAgICBzZXRJc0NvbGxhcHNlZCgpOwogICAgIG1fY29s bGFwc2VkVG9aZXJvQWR2YW5jZVdpZHRoID0gdHJ1ZTsKICAgICBtX2Rpc3BsYXlSdW4uc2V0TG9n aWNhbFdpZHRoKHsgfSk7CiAgICAgbV9leHBhbnNpb25PcHBvcnR1bml0eUNvdW50ID0geyB9Owo=