203765 2019-11-01 14:55:08 -0700 REGRESSION(r248696): Element Click on Mac is adding an extra page topContentInsets to y-coordinate 2019-11-01 15:20:42 -0700 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg hi webkit-bug-importer oldest_to_newest 1586580 0 bburg 2019-11-01 14:55:08 -0700 . 1586582 1 bburg 2019-11-01 14:55:22 -0700 <rdar://problem/56014369> 1586589 2 382635 bburg 2019-11-01 15:03:10 -0700 Created attachment 382635 Patch 1586590 3 382635 hi 2019-11-01 15:05:37 -0700 Comment on attachment 382635 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382635&action=review r=me, an all negative diff I love it =D > Source/WebKit/ChangeLog:11 > + The topContentInsets is now accounted for by rootViewToWindow(), so don't add it in manually. Shouldn't this just be "The topContentInset is"? Also, was this something that changed recently (the "now" makes it seem like this wasn't the case before)? If so, do you know what revision? If not, please remove the "now". 1586597 4 bburg 2019-11-01 15:09:15 -0700 (In reply to Devin Rousso from comment #3) > Comment on attachment 382635 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=382635&action=review > > r=me, an all negative diff I love it =D > > > Source/WebKit/ChangeLog:11 > > + The topContentInsets is now accounted for by rootViewToWindow(), so don't add it in manually. > > Shouldn't this just be "The topContentInset is"? Yes. > > Also, was this something that changed recently (the "now" makes it seem like > this wasn't the case before)? If so, do you know what revision? If not, > please remove the "now". This method was reworked this spring to work in terms of viewport coordinates. I'll just drop 'now' since there were many relevant commits in this chain of regressions. 1586600 5 bburg 2019-11-01 15:16:36 -0700 Committed r251948: <https://trac.webkit.org/changeset/251948> 382635 2019-11-01 15:03:10 -0700 2019-11-01 15:20:42 -0700 Patch bug-203765-20191101150310.patch text/plain 1853 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxOTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGIwN2Y4MGZhMmQ2NTIyZmI2 YjE5ZjVmYTY1YmNlMzU0NGVjZWIxMDEuLmM1MzYyZTgzYWM1ZTQ4N2ZkYTM1NzRmMjAyNzlhYjFi ODY4YmM1ZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMTEtMDEgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjQ4Njk2KTogRWxl bWVudCBDbGljayBvbiBNYWMgaXMgYWRkaW5nIGFuIGV4dHJhIHBhZ2UgdG9wQ29udGVudEluc2V0 cyB0byB5LWNvb3JkaW5hdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwMzc2NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTYwMTQzNjk+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QXV0b21hdGlvbi9tYWMvV2ViQXV0b21hdGlvblNlc3Npb25NYWMubW06CisgICAgICAgIChXZWJL aXQ6OldlYkF1dG9tYXRpb25TZXNzaW9uOjpwbGF0Zm9ybVNpbXVsYXRlTW91c2VJbnRlcmFjdGlv bik6CisgICAgICAgIFRoZSB0b3BDb250ZW50SW5zZXRzIGlzIG5vdyBhY2NvdW50ZWQgZm9yIGJ5 IHJvb3RWaWV3VG9XaW5kb3coKSwgc28gZG9uJ3QgYWRkIGl0IGluIG1hbnVhbGx5LgorCiAyMDE5 LTExLTAxICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBJ bnZlc3RpZ2F0ZSBpZiBtYWNoIGxvb2t1cCBhY2Nlc3MgdG8gKi5hcHBsZS1leHRlbnNpb24tc2Vy dmljZSwgKi52aWV3c2VydmljZSwgYW5kIGNvbS5hcHBsZS51aWtpdC52aWV3c2VydmljZS4qIGNh biBiZSBkZW5pZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0F1dG9tYXRp b24vbWFjL1dlYkF1dG9tYXRpb25TZXNzaW9uTWFjLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQXV0b21hdGlvbi9tYWMvV2ViQXV0b21hdGlvblNlc3Npb25NYWMubW0KaW5kZXggNTBmNDI3 ZWUwNzFjYjE1ZjE2ZTA4NTI4YjhhYjI0ZTUwODc2ZWFjYi4uMTE3ZGZkNGFmZTE4MWQyZjk0NjM0 YmExMGJlNzhiYzY5NzA4Mzk3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QXV0b21hdGlvbi9tYWMvV2ViQXV0b21hdGlvblNlc3Npb25NYWMubW0KKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQXV0b21hdGlvbi9tYWMvV2ViQXV0b21hdGlvblNlc3Npb25NYWMubW0K QEAgLTEzNyw3ICsxMzcsNyBAQCB2b2lkIFdlYkF1dG9tYXRpb25TZXNzaW9uOjpwbGF0Zm9ybVNp bXVsYXRlTW91c2VJbnRlcmFjdGlvbihXZWJQYWdlUHJveHkmIHBhZ2UsCiB7CiAgICAgSW50UmVj dCB3aW5kb3dSZWN0OwogCi0gICAgSW50UG9pbnQgbG9jYXRpb25JblZpZXcgPSBXZWJDb3JlOjpJ bnRQb2ludChsb2NhdGlvbkluVmlld3BvcnQueCgpLCBsb2NhdGlvbkluVmlld3BvcnQueSgpICsg cGFnZS50b3BDb250ZW50SW5zZXQoKSk7CisgICAgSW50UG9pbnQgbG9jYXRpb25JblZpZXcgPSBX ZWJDb3JlOjpJbnRQb2ludChsb2NhdGlvbkluVmlld3BvcnQueCgpLCBsb2NhdGlvbkluVmlld3Bv cnQueSgpKTsKICAgICBwYWdlLnJvb3RWaWV3VG9XaW5kb3coSW50UmVjdChsb2NhdGlvbkluVmll dywgSW50U2l6ZSgpKSwgd2luZG93UmVjdCk7CiAgICAgSW50UG9pbnQgbG9jYXRpb25JbldpbmRv dyA9IHdpbmRvd1JlY3QubG9jYXRpb24oKTsKIAo=