203722 2019-10-31 21:26:12 -0700 Web Inspector: REGRESSION(r249831): content view is empty if a breakpoint is hit in the main resource 2019-11-01 12:17:19 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=203748 InRadar P2 Normal --- 201535 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck simon.fraser webkit-bug-importer oldest_to_newest 1586265 0 hi 2019-10-31 21:26:12 -0700 # STEPS TO REPRODUCE: 1. inspect any page with an inline <script> 2. set a breakpoint in that <script> 3. reload => pause information is shown, but the content view is empty => continuing doesn't update the content view 1586266 1 hi 2019-10-31 21:26:24 -0700 <rdar://problem/56802409> 1586267 2 382549 hi 2019-10-31 21:30:36 -0700 Created attachment 382549 Patch 1586307 3 382565 hi 2019-11-01 00:29:11 -0700 Created attachment 382565 Patch This gets part of the way there, in that the content is now visible. But there appears to be another issue, which is that the initial content is now just the inline script content, rather than the entire HTML document. This seems to have been caused by r249831. My guess as to why that's happening is that the timing of showing the pause location within the inline script is now not working correctly since we have to wait for the formatted HTML content, which is asynchronous. I think we should either not auto-format HTML resources if we're showing a pause location the first time the resource is shown or try to delay the highlighting code until after the format is complete. 1586431 4 382565 joepeck 2019-11-01 10:38:05 -0700 Comment on attachment 382565 Patch rs=me 1586434 5 joepeck 2019-11-01 10:40:22 -0700 (In reply to Devin Rousso from comment #3) > Created attachment 382565 [details] > Patch > > This gets part of the way there, in that the content is now visible. > > But there appears to be another issue, which is that the initial content is > now just the inline script content, I think that might have been expected behavior. If I recall correctly, the frontend would have paused in a Script but not necessarily the main resource content... as backwards as that sounds. We've had situations in the past where we would show blank content and just a <script>...</script> if you pause in script during page load. That said, if we have the full content, we should address it! 1586439 6 hi 2019-11-01 10:48:25 -0700 (In reply to Joseph Pecoraro from comment #5) > (In reply to Devin Rousso from comment #3) > > Created attachment 382565 [details] > > Patch > > > > This gets part of the way there, in that the content is now visible. > > > > But there appears to be another issue, which is that the initial content is now just the inline script content, > > I think that might have been expected behavior. > > If I recall correctly, the frontend would have paused in a Script but not necessarily the main resource content... as backwards as that sounds. We've had situations in the past where we would show blank content and just a <script>...</script> if you pause in script during page load. > > That said, if we have the full content, we should address it! Before r249831 though, we did show the *full* content. This is 100% a regression. I'm pretty sure we also have the full content by this point, so we should definitely show it. 1586445 7 382565 hi 2019-11-01 11:01:10 -0700 Comment on attachment 382565 Patch I'm going to land this as is since it's already a positive change. I've created a followup for the "missing the rest of the content" issue: - <https://webkit.org/b/203748> Web Inspector: REGRESSION(r249831): hitting a breakpoint in an inline <script> doesn't show the surrounding HTML content 1586492 8 382565 commit-queue 2019-11-01 12:17:18 -0700 Comment on attachment 382565 Patch Clearing flags on attachment: 382565 Committed r251932: <https://trac.webkit.org/changeset/251932> 1586493 9 commit-queue 2019-11-01 12:17:19 -0700 All reviewed patches have been landed. Closing bug. 382549 2019-10-31 21:30:36 -0700 2019-11-01 00:29:11 -0700 Patch bug-203722-20191031213035.patch text/plain 3137 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQ1YzhiYjE5YWY2MDA3NzEwZTg4ZGUzNTQ5Njhi MGUxNzgzMDk4YzkuLjg0YzY0MzU3ZTQ3NzQzYTg1NGQwMzc3NzQzYTBkNzE5ZjdkOWMwNDggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTEwLTMxICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKD8pOiBjb250ZW50IHZpZXcgaXMgZW1wdHkgaWYgYSBicmVha3BvaW50IGlzIGhp dCBpbiB0aGUgbWFpbiByZXNvdXJjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjAzNzIyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NjgwMjQwOT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvTW9kZWxzL1NvdXJjZUNvZGUuanM6CisgICAgICAgIChXSS5Tb3VyY2VDb2RlLnBy b3RvdHlwZS5nZXQgY3VycmVudFJldmlzaW9uKToKKyAgICAgICAgKFdJLlNvdXJjZUNvZGUucHJv dG90eXBlLnJldmlzaW9uQ29udGVudERpZENoYW5nZSk6CisgICAgICAgIChXSS5Tb3VyY2VDb2Rl LnByb3RvdHlwZS5fcHJvY2Vzc0NvbnRlbnQpOgorICAgICAgICAoV0kuU291cmNlQ29kZS5wcm90 b3R5cGUuX2luaXRpYWxpemVDdXJyZW50UmV2aXNpb25JZk5lZWRlZCk6IERlbGV0ZWQuCisgICAg ICAgIERvbid0IHdhaXQgdG8gbGF6aWx5IGNsb25lIHRoZSBgb3JpZ2luYWxSZXZpc2lvbmAgYW5k IHVzZSBpdCBhcyB0aGUgYGN1cnJlbnRSZXZpc2lvbmAuIFNvbWUKKyAgICAgICAgbGlzdGVuZXJz IGV4cGVjdCB0aGUgYGN1cnJlbnRSZXZpc2lvbmAgdG8gYWxyZWFkeSBiZSBzZXQgYnkgdGhlIHRp bWUgdGhpcyBoYXBwZW5zLCBzbyBhcworICAgICAgICBzb29uIGFzIHRoZSBvcmlnaW5hbCByZXZp c2lvbidzIGNvbnRlbnQgaXMgY2hhbmdlZCwgY2xvbmUgaXQgaW50byB0aGUgYGN1cnJlbnRSZXZp c2lvbmAuCisKIDIwMTktMTAtMzEgIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5j b20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQ29sb3IgcGlja2VyOiBpbmNvcnJlY3Qgc2F0 dXJhdGlvbiB3aGVuIHNlbGVjdGluZyBjb2xvciBvbiBjb2xvciBzcXVhcmUKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9Tb3VyY2VDb2RlLmpz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1NvdXJjZUNvZGUu anMKaW5kZXggYWY3ODY1MDcwNGU1MDdiYTE4YzUwMTI3MTg3YzcxNWU4ZTA1MDdlOS4uMzM2OTM2 OWYwNjZjNjVmYmI0NWY1OWIwY2Q4YzUyMzI4MGYyYTM0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1NvdXJjZUNvZGUuanMKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1NvdXJjZUNvZGUuanMKQEAg LTY2LDcgKzY2LDYgQEAgV0kuU291cmNlQ29kZSA9IGNsYXNzIFNvdXJjZUNvZGUgZXh0ZW5kcyBX SS5PYmplY3QKIAogICAgIGdldCBjdXJyZW50UmV2aXNpb24oKQogICAgIHsKLSAgICAgICAgdGhp cy5faW5pdGlhbGl6ZUN1cnJlbnRSZXZpc2lvbklmTmVlZGVkKCk7CiAgICAgICAgIHJldHVybiB0 aGlzLl9jdXJyZW50UmV2aXNpb247CiAgICAgfQogCkBAIC0xNzgsNiArMTc3LDkgQEAgV0kuU291 cmNlQ29kZSA9IGNsYXNzIFNvdXJjZUNvZGUgZXh0ZW5kcyBXSS5PYmplY3QKIAogICAgIHJldmlz aW9uQ29udGVudERpZENoYW5nZShyZXZpc2lvbikKICAgICB7CisgICAgICAgIGlmIChyZXZpc2lv biA9PT0gdGhpcy5fb3JpZ2luYWxSZXZpc2lvbiAmJiB0aGlzLl9jdXJyZW50UmV2aXNpb24gPT09 IHRoaXMuX29yaWdpbmFsUmV2aXNpb24pCisgICAgICAgICAgICB0aGlzLl9jdXJyZW50UmV2aXNp b24gPSB0aGlzLl9vcmlnaW5hbFJldmlzaW9uLmNvcHkoKTsKKwogICAgICAgICBpZiAodGhpcy5f aWdub3JlUmV2aXNpb25Db250ZW50RGlkQ2hhbmdlRXZlbnQpCiAgICAgICAgICAgICByZXR1cm47 CiAKQEAgLTIyMSwxMiArMjIzLDYgQEAgV0kuU291cmNlQ29kZSA9IGNsYXNzIFNvdXJjZUNvZGUg ZXh0ZW5kcyBXSS5PYmplY3QKIAogICAgIC8vIFByaXZhdGUKIAotICAgIF9pbml0aWFsaXplQ3Vy cmVudFJldmlzaW9uSWZOZWVkZWQoKQotICAgIHsKLSAgICAgICAgaWYgKHRoaXMuX2N1cnJlbnRS ZXZpc2lvbiA9PT0gdGhpcy5fb3JpZ2luYWxSZXZpc2lvbikKLSAgICAgICAgICAgIHRoaXMuY3Vy cmVudFJldmlzaW9uID0gdGhpcy5fb3JpZ2luYWxSZXZpc2lvbi5jb3B5KCk7Ci0gICAgfQotCiAg ICAgX3Byb2Nlc3NDb250ZW50KHBhcmFtZXRlcnMpCiAgICAgewogICAgICAgICAvLyBEaWZmZXJl bnQgYmFja2VuZCBBUElzIHJldHVybiBvbmUgb2YgYGNvbnRlbnQsIGBib2R5YCwgYHRleHRgLCBv ciBgc2NyaXB0U291cmNlYC4KQEAgLTI0OSw4ICsyNDUsNiBAQCBXSS5Tb3VyY2VDb2RlID0gY2xh c3MgU291cmNlQ29kZSBleHRlbmRzIFdJLk9iamVjdAogICAgICAgICB9KTsKICAgICAgICAgdGhp cy5faWdub3JlUmV2aXNpb25Db250ZW50RGlkQ2hhbmdlRXZlbnQgPSBmYWxzZTsKIAotICAgICAg ICB0aGlzLl9pbml0aWFsaXplQ3VycmVudFJldmlzaW9uSWZOZWVkZWQoKTsKLQogICAgICAgICAv LyBGSVhNRTogUmV0dXJuaW5nIHRoZSBjb250ZW50IGluIHRoaXMgcHJvbWlzZSBpcyBtaXNsZWFk aW5nLiBJdCBtYXkgbm90IGJlIGN1cnJlbnQgY29udGVudAogICAgICAgICAvLyBub3csIGFuZCBp dCBtYXkgYmVjb21lIG91dC1kYXRlZCBsYXRlciBvbi4gV2Ugc2hvdWxkIGRyb3AgY29udGVudCBm cm9tIHRoaXMgcHJvbWlzZQogICAgICAgICAvLyBhbmQgcmVxdWlyZSBjbGllbnRzIHRvIGFzayBm b3IgdGhlIGN1cnJlbnQgY29udGVudHMgZnJvbSB0aGUgc291cmNlQ29kZSBpbiB0aGUgcmVzdWx0 Lgo= 382565 2019-11-01 00:29:11 -0700 2019-11-01 12:17:18 -0700 Patch 203722.diff text/plain 2711 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDhhOWE1NDI5OTA0Li40ZmMxNDBjMWUwYiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMTEtMDEgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJF R1JFU1NJT04ocjI0OTgzMSk6IGNvbnRlbnQgdmlldyBpcyBlbXB0eSBpZiBhIGJyZWFrcG9pbnQg aXMgaGl0IGluIHRoZSBtYWluIHJlc291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDM3MjIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU2ODAy NDA5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VXNlckludGVyZmFjZS9Nb2RlbHMvU291cmNlQ29kZS5qczoKKyAgICAgICAgKFdJLlNvdXJjZUNv ZGUucHJvdG90eXBlLmdldCBjdXJyZW50UmV2aXNpb24pOgorICAgICAgICAoV0kuU291cmNlQ29k ZS5wcm90b3R5cGUucmV2aXNpb25Db250ZW50RGlkQ2hhbmdlKToKKyAgICAgICAgKFdJLlNvdXJj ZUNvZGUucHJvdG90eXBlLl9pbml0aWFsaXplQ3VycmVudFJldmlzaW9uSWZOZWVkZWQpOgorICAg ICAgICAoV0kuU291cmNlQ29kZS5wcm90b3R5cGUuX3Byb2Nlc3NDb250ZW50KToKKyAgICAgICAg RG9uJ3Qgd2FpdCB0byBsYXppbHkgY2xvbmUgdGhlIGBvcmlnaW5hbFJldmlzaW9uYCBhbmQgdXNl IGl0IGFzIHRoZSBgY3VycmVudFJldmlzaW9uYC4gU29tZQorICAgICAgICBsaXN0ZW5lcnMgZXhw ZWN0IHRoZSBgY3VycmVudFJldmlzaW9uYCB0byBhbHJlYWR5IGJlIHNldCBieSB0aGUgdGltZSB0 aGlzIGhhcHBlbnMsIHNvIGFzCisgICAgICAgIHNvb24gYXMgdGhlIG9yaWdpbmFsIHJldmlzaW9u J3MgY29udGVudCBpcyBjaGFuZ2VkLCBjbG9uZSBpdCBpbnRvIHRoZSBgY3VycmVudFJldmlzaW9u YC4KKwogMjAxOS0xMC0zMSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAg ICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxpbmVzOiBhZGQgYSB0aW1lbGluZSB0aGF0IHNob3dz IGluZm9ybWF0aW9uIGFib3V0IGFueSByZWNvcmRlZCBDU1MgYW5pbWF0aW9uL3RyYW5zaXRpb24K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9T b3VyY2VDb2RlLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxz L1NvdXJjZUNvZGUuanMKaW5kZXggYWY3ODY1MDcwNGUuLjNlMjZmZmMyNzU5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvU291cmNlQ29kZS5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvU291cmNl Q29kZS5qcwpAQCAtMTc4LDYgKzE3OCw5IEBAIFdJLlNvdXJjZUNvZGUgPSBjbGFzcyBTb3VyY2VD b2RlIGV4dGVuZHMgV0kuT2JqZWN0CiAKICAgICByZXZpc2lvbkNvbnRlbnREaWRDaGFuZ2UocmV2 aXNpb24pCiAgICAgeworICAgICAgICBpZiAocmV2aXNpb24gPT09IHRoaXMuX29yaWdpbmFsUmV2 aXNpb24pCisgICAgICAgICAgICB0aGlzLl9pbml0aWFsaXplQ3VycmVudFJldmlzaW9uSWZOZWVk ZWQoKTsKKwogICAgICAgICBpZiAodGhpcy5faWdub3JlUmV2aXNpb25Db250ZW50RGlkQ2hhbmdl RXZlbnQpCiAgICAgICAgICAgICByZXR1cm47CiAKQEAgLTIyNCw3ICsyMjcsNyBAQCBXSS5Tb3Vy Y2VDb2RlID0gY2xhc3MgU291cmNlQ29kZSBleHRlbmRzIFdJLk9iamVjdAogICAgIF9pbml0aWFs aXplQ3VycmVudFJldmlzaW9uSWZOZWVkZWQoKQogICAgIHsKICAgICAgICAgaWYgKHRoaXMuX2N1 cnJlbnRSZXZpc2lvbiA9PT0gdGhpcy5fb3JpZ2luYWxSZXZpc2lvbikKLSAgICAgICAgICAgIHRo aXMuY3VycmVudFJldmlzaW9uID0gdGhpcy5fb3JpZ2luYWxSZXZpc2lvbi5jb3B5KCk7CisgICAg ICAgICAgICB0aGlzLl9jdXJyZW50UmV2aXNpb24gPSB0aGlzLl9vcmlnaW5hbFJldmlzaW9uLmNv cHkoKTsKICAgICB9CiAKICAgICBfcHJvY2Vzc0NvbnRlbnQocGFyYW1ldGVycykKQEAgLTI0OSw4 ICsyNTIsNiBAQCBXSS5Tb3VyY2VDb2RlID0gY2xhc3MgU291cmNlQ29kZSBleHRlbmRzIFdJLk9i amVjdAogICAgICAgICB9KTsKICAgICAgICAgdGhpcy5faWdub3JlUmV2aXNpb25Db250ZW50RGlk Q2hhbmdlRXZlbnQgPSBmYWxzZTsKIAotICAgICAgICB0aGlzLl9pbml0aWFsaXplQ3VycmVudFJl dmlzaW9uSWZOZWVkZWQoKTsKLQogICAgICAgICAvLyBGSVhNRTogUmV0dXJuaW5nIHRoZSBjb250 ZW50IGluIHRoaXMgcHJvbWlzZSBpcyBtaXNsZWFkaW5nLiBJdCBtYXkgbm90IGJlIGN1cnJlbnQg Y29udGVudAogICAgICAgICAvLyBub3csIGFuZCBpdCBtYXkgYmVjb21lIG91dC1kYXRlZCBsYXRl ciBvbi4gV2Ugc2hvdWxkIGRyb3AgY29udGVudCBmcm9tIHRoaXMgcHJvbWlzZQogICAgICAgICAv LyBhbmQgcmVxdWlyZSBjbGllbnRzIHRvIGFzayBmb3IgdGhlIGN1cnJlbnQgY29udGVudHMgZnJv bSB0aGUgc291cmNlQ29kZSBpbiB0aGUgcmVzdWx0Lgo=