<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>203720</bug_id>
          
          <creation_ts>2019-10-31 20:52:00 -0700</creation_ts>
          <short_desc>offlineasm should emit the suffixes for floating point instructions on Windows x86</short_desc>
          <delta_ts>2019-10-31 22:31:13 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=194257</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tadeu Zagallo">tzagallo</reporter>
          <assigned_to name="Tadeu Zagallo">tzagallo</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>fujii</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>ross.kirsling</cc>
    
    <cc>saam</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1586246</commentid>
    <comment_count>0</comment_count>
    <who name="Tadeu Zagallo">tzagallo</who>
    <bug_when>2019-10-31 20:52:00 -0700</bug_when>
    <thetext>...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1586248</commentid>
    <comment_count>1</comment_count>
      <attachid>382546</attachid>
    <who name="Tadeu Zagallo">tzagallo</who>
    <bug_when>2019-10-31 20:53:25 -0700</bug_when>
    <thetext>Created attachment 382546
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1586249</commentid>
    <comment_count>2</comment_count>
      <attachid>382546</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-10-31 20:55:36 -0700</bug_when>
    <thetext>Comment on attachment 382546
Patch

r=me, I think we can try this</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1586250</commentid>
    <comment_count>3</comment_count>
    <who name="Tadeu Zagallo">tzagallo</who>
    <bug_when>2019-10-31 20:58:53 -0700</bug_when>
    <thetext>Committed r251905: &lt;https://trac.webkit.org/changeset/251905&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1586251</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-10-31 20:59:14 -0700</bug_when>
    <thetext>&lt;rdar://problem/56805958&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>382546</attachid>
            <date>2019-10-31 20:53:25 -0700</date>
            <delta_ts>2019-10-31 20:55:36 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-203720-20191031205322.patch</filename>
            <type>text/plain</type>
            <size>1174</size>
            <attacher name="Tadeu Zagallo">tzagallo</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxODk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4
Y2Q1MWZhNmY5M2M0NmY0NTVkYTJlODc4MDQwOTg1MDUwZWNiZDY0Li5lNWI4YTQzMDcwOTNiYjhl
NGUxYjIyOGJhOTgwNzY1ZmZiOWU4OWU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxMiBAQAorMjAxOS0xMC0zMSAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv
bT4KKworICAgICAgICBvZmZsaW5lYXNtIHNob3VsZCBlbWl0IHRoZSBzdWZmaXhlcyBmb3IgZmxv
YXRpbmcgcG9pbnQgaW5zdHJ1Y3Rpb25zIG9uIFdpbmRvd3MgeDg2CisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDM3MjAKKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIG9mZmxpbmVhc20veDg2LnJiOgorCiAy
MDE5LTEwLTMxICBUYWRldSBaYWdhbGxvICA8dHphZ2FsbG9AYXBwbGUuY29tPgogCiAgICAgICAg
IFVucmV2aWV3ZWQsIGZpeCBMb3dMZXZlbEludGVycHJldGVyMzJfNjQuYXNtIGFmdGVyIHIyNTE4
ODYKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3g4Ni5yYiBi
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3g4Ni5yYgppbmRleCA4ZmQyYmRlYTE3
NzViY2E0N2NkNWFhZWJiODdlYzdiNGYwNDQ0MzhmLi4xMTJlZWQ3YjVjMTA4ODI1YjQzOWQxMDk2
MTQ2Zjg1Y2RiMDI5MTM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGlu
ZWFzbS94ODYucmIKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20veDg2LnJi
CkBAIC01MjIsNyArNTIyLDcgQEAgY2xhc3MgSW5zdHJ1Y3Rpb24KICAgICBlbmQKIAogICAgIGRl
ZiB4ODZTdWZmaXgoa2luZCkKLSAgICAgICAgaWYgaXNJbnRlbFN5bnRheAorICAgICAgICBpZiBp
c0ludGVsU3ludGF4IGFuZCBub3QgWzpmbG9hdCwgOmRvdWJsZV0uaW5jbHVkZT8ga2luZAogICAg
ICAgICAgICAgcmV0dXJuICIiCiAgICAgICAgIGVuZAogCg==
</data>
<flag name="review"
          id="398291"
          type_id="1"
          status="+"
          setter="ysuzuki"
    />
          </attachment>
      

    </bug>

</bugzilla>