203719 2019-10-31 20:51:00 -0700 Web Inspector: Sources: tab isn't visible after removal of Debugger Tab and Resources Tab 2020-01-06 12:55:21 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=205826 InRadar P2 Normal --- 202341 1 hi hi bburg commit-queue hi inspector-bugzilla-changes simon.fraser timothy webkit-bug-importer oldest_to_newest 1586244 0 hi 2019-10-31 20:51:00 -0700 If you'd never previously opened the Sources Tab, but had already used Web Inspector, it won't appear after the Resources/Debugger Tabs were removed. 1586245 1 hi 2019-10-31 20:51:19 -0700 <rdar://problem/56802389> 1586247 2 382545 hi 2019-10-31 20:52:48 -0700 Created attachment 382545 Patch 1586388 3 382545 commit-queue 2019-11-01 09:19:21 -0700 Comment on attachment 382545 Patch Clearing flags on attachment: 382545 Committed r251922: <https://trac.webkit.org/changeset/251922> 1586389 4 commit-queue 2019-11-01 09:19:23 -0700 All reviewed patches have been landed. Closing bug. 1586467 5 382545 bburg 2019-11-01 11:41:57 -0700 Comment on attachment 382545 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382545&action=review r=me > Source/WebInspectorUI/UserInterface/Base/Main.js:154 > + // Replace the Debugger/Resources Tab with the Sources Tab. Please extract this into a separate function. Maybe even a separate file like MigrationUtilities.js. When we decide this code is no longer worth the trouble (say, Catalina + 1, or based on telemetry showing its use has diminished) then we can easily remove it. > Source/WebInspectorUI/UserInterface/Base/Main.js:155 > + let debuggerIndex = WI._openTabsSetting.value.indexOf("debugger"); It seems weird we have a symbolic name for "debugger" or "resources" tab? 1586532 6 382545 hi 2019-11-01 13:54:25 -0700 Comment on attachment 382545 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382545&action=review >> Source/WebInspectorUI/UserInterface/Base/Main.js:154 >> + // Replace the Debugger/Resources Tab with the Sources Tab. > > Please extract this into a separate function. Maybe even a separate file like MigrationUtilities.js. When we decide this code is no longer worth the trouble (say, Catalina + 1, or based on telemetry showing its use has diminished) then we can easily remove it. This already landed in r251922 😅 >> Source/WebInspectorUI/UserInterface/Base/Main.js:155 >> + let debuggerIndex = WI._openTabsSetting.value.indexOf("debugger"); > > It seems weird we have a symbolic name for "debugger" or "resources" tab? This was the value of `WI.DebuggerTabContentView.Type` and `WI.ResourcesTabContentView.Type`. It's the identifier we used for saving/restoring. 382545 2019-10-31 20:52:48 -0700 2019-11-01 13:54:25 -0700 Patch bug-203719-20191031205245.patch text/plain 2425 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQ1YzhiYjE5YWY2MDA3NzEwZTg4ZGUzNTQ5Njhi MGUxNzgzMDk4YzkuLmIzNGRlYTRlOWZjNWFhYjk3Njg3OWVmNjIyYTU5YzY1NDQxNGQzODUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTEwLTMxICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBT b3VyY2VzOiB0YWIgaXNuJ3QgdmlzaWJsZSBhZnRlciByZW1vdmFsIG9mIERlYnVnZ2VyIFRhYiBh bmQgUmVzb3VyY2VzIFRhYgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjAzNzE5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NjgwMjM4OT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvQmFzZS9NYWluLmpzOgorICAgICAgICAoV0kubG9hZGVkKToKKyAgICAgICAgSWYgdGhlIERl YnVnZ2VyIFRhYiBpZGVudGlmaWVyIG9yIFJlc291cmNlcyBUYWIgaWRlbnRpZmllciBzdGlsbCBl eGlzdHMgaW4gdGhlIGxpc3Qgb2Ygb3BlbgorICAgICAgICB0YWJzLCByZW1vdmUgYm90aCBhbmQg cmVwbGFjZSB0aGUgZmlyc3Qgb25lIHdpdGggdGhlIFNvdXJjZXMgVGFiIGlkZW50aWZpZXIuCisK IDIwMTktMTAtMzEgIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAg ICAgICAgV2ViIEluc3BlY3RvcjogQ29sb3IgcGlja2VyOiBpbmNvcnJlY3Qgc2F0dXJhdGlvbiB3 aGVuIHNlbGVjdGluZyBjb2xvciBvbiBjb2xvciBzcXVhcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwppbmRleCA2ZmI0OWM0N2EyYjdjYzVh NzhlMmNkNjdlYTFiZDcxYzllM2Q2NWNhLi42NjMzNWI3NDgyYTU5ZDcyYThhNmE5Yzk2OTU3NTVh Y2MwOWVkMTlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9CYXNlL01haW4uanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv QmFzZS9NYWluLmpzCkBAIC0xNTEsNiArMTUxLDI2IEBAIFdJLmxvYWRlZCA9IGZ1bmN0aW9uKCkK ICAgICBdKTsKICAgICBXSS5fc2VsZWN0ZWRUYWJJbmRleFNldHRpbmcgPSBuZXcgV0kuU2V0dGlu Zygic2VsZWN0ZWQtdGFiLWluZGV4IiwgMCk7CiAKKyAgICAvLyBSZXBsYWNlIHRoZSBEZWJ1Z2dl ci9SZXNvdXJjZXMgVGFiIHdpdGggdGhlIFNvdXJjZXMgVGFiLgorICAgIGxldCBkZWJ1Z2dlcklu ZGV4ID0gV0kuX29wZW5UYWJzU2V0dGluZy52YWx1ZS5pbmRleE9mKCJkZWJ1Z2dlciIpOworICAg IGxldCByZXNvdXJjZXNJbmRleCA9IFdJLl9vcGVuVGFic1NldHRpbmcudmFsdWUuaW5kZXhPZigi cmVzb3VyY2VzIik7CisgICAgaWYgKGRlYnVnZ2VySW5kZXggPj0gMCB8fCByZXNvdXJjZXNJbmRl eCA+PSAwKSB7CisgICAgICAgIFdJLl9vcGVuVGFic1NldHRpbmcudmFsdWUucmVtb3ZlKCJkZWJ1 Z2dlciIpOworICAgICAgICBXSS5fb3BlblRhYnNTZXR0aW5nLnZhbHVlLnJlbW92ZSgicmVzb3Vy Y2VzIik7CisKKyAgICAgICAgaWYgKGRlYnVnZ2VySW5kZXggPT09IC0xKQorICAgICAgICAgICAg ZGVidWdnZXJJbmRleCA9IEluZmluaXR5OworICAgICAgICBpZiAocmVzb3VyY2VzSW5kZXggPT09 IC0xKQorICAgICAgICAgICAgcmVzb3VyY2VzSW5kZXggPSBJbmZpbml0eTsKKworICAgICAgICBs ZXQgc291cmNlc0luZGV4ID0gTWF0aC5taW4oZGVidWdnZXJJbmRleCwgcmVzb3VyY2VzSW5kZXgp OworICAgICAgICBXSS5fb3BlblRhYnNTZXR0aW5nLnZhbHVlLnNwbGljZShzb3VyY2VzSW5kZXgs IDEsIFdJLlNvdXJjZXNUYWJDb250ZW50Vmlldy5UeXBlKTsKKyAgICAgICAgV0kuX29wZW5UYWJz U2V0dGluZy5zYXZlKCk7CisKKyAgICAgICAgaWYgKFdJLl9zZWxlY3RlZFRhYkluZGV4U2V0dGlu Zy52YWx1ZSA9PT0gZGVidWdnZXJJbmRleCB8fCBXSS5fc2VsZWN0ZWRUYWJJbmRleFNldHRpbmcu dmFsdWUgPT09IHJlc291cmNlc0luZGV4KQorICAgICAgICAgICAgV0kuX3NlbGVjdGVkVGFiSW5k ZXhTZXR0aW5nLnZhbHVlID0gc291cmNlc0luZGV4OworICAgIH0KKwogICAgIC8vIFN0YXRlLgog ICAgIFdJLnByaW50U3R5bGVzRW5hYmxlZCA9IGZhbHNlOwogICAgIFdJLnNldFpvb21GYWN0b3Io V0kuc2V0dGluZ3Muem9vbUZhY3Rvci52YWx1ZSk7Cg==