203712 2019-10-31 18:21:36 -0700 [JSC] Remove metadata(CallFrame*) accessor 2019-10-31 20:23:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1586188 0 ysuzuki 2019-10-31 18:21:36 -0700 [JSC] Remove metadata(CallFrame*) accessor 1586189 1 382532 ysuzuki 2019-10-31 18:21:56 -0700 Created attachment 382532 Patch 1586227 2 382532 tzagallo 2019-10-31 20:17:35 -0700 Comment on attachment 382532 Patch r=me. Might be worth mentioning the motivation in the ChangeLog. 1586230 3 ysuzuki 2019-10-31 20:22:23 -0700 Committed r251903: <https://trac.webkit.org/changeset/251903> 1586231 4 webkit-bug-importer 2019-10-31 20:23:19 -0700 <rdar://problem/56805476> 382532 2019-10-31 18:21:56 -0700 2019-10-31 20:17:35 -0700 Patch bug-203712-20191031182156.patch text/plain 6898 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxOTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 Y2Q1MWZhNmY5M2M0NmY0NTVkYTJlODc4MDQwOTg1MDUwZWNiZDY0Li4yYmRlYWE1YjMxMzAyNTg2 Yzc2ZDZjNWEyYzZiZTI0OTdiZTA1Nzg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOS0xMC0zMSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFJlbW92ZSBtZXRhZGF0YShDYWxsRnJhbWUqKSBhY2Nlc3Nvcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzNzEyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugc2hvdWxk IHBhc3MgQ29kZUJsb2NrKiBleHBsaWNpdGx5LgorCisgICAgICAgICogZGZnL0RGR09TUkVudHJ5 LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpwcmVwYXJlQ2F0Y2hPU1JFbnRyeSk6CisgICAgICAg ICogZGZnL0RGR09TUkVudHJ5Lmg6CisgICAgICAgICogZ2VuZXJhdG9yL01ldGFkYXRhLnJiOgor ICAgICAgICAqIGppdC9KSVRPcGVyYXRpb25zLmNwcDoKKwogMjAxOS0xMC0zMSAgVGFkZXUgWmFn YWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBmaXggTG93 TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbSBhZnRlciByMjUxODg2CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkVudHJ5LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHT1NSRW50cnkuY3BwCmluZGV4IDQ2MmQ2ODJkMjdhODA2OGVhYTE1ZWRhMjBk ZTI3MDU5ODk4ZDk3MTEuLjQ0OTczMDgzOWM5NDQ1MDcyNTcxYTViMGM3Yzk0Yjg0M2U4OTBkYzcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRW50cnkuY3BwCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRW50cnkuY3BwCkBAIC0zMjksMTcg KzMyOSwxNyBAQCB2b2lkKiBwcmVwYXJlT1NSRW50cnkoVk0mIHZtLCBDYWxsRnJhbWUqIGNhbGxG cmFtZSwgQ29kZUJsb2NrKiBjb2RlQmxvY2ssIEJ5dGVjbwogICAgIHJldHVybiBzY3JhdGNoOwog fQogCi1NYWNyb0Fzc2VtYmxlckNvZGVQdHI8RXhjZXB0aW9uSGFuZGxlclB0clRhZz4gcHJlcGFy ZUNhdGNoT1NSRW50cnkoVk0mIHZtLCBDYWxsRnJhbWUqIGNhbGxGcmFtZSwgQ29kZUJsb2NrKiBj b2RlQmxvY2ssIEJ5dGVjb2RlSW5kZXggYnl0ZWNvZGVJbmRleCkKK01hY3JvQXNzZW1ibGVyQ29k ZVB0cjxFeGNlcHRpb25IYW5kbGVyUHRyVGFnPiBwcmVwYXJlQ2F0Y2hPU1JFbnRyeShWTSYgdm0s IENhbGxGcmFtZSogY2FsbEZyYW1lLCBDb2RlQmxvY2sqIGJhc2VsaW5lQ29kZUJsb2NrLCBDb2Rl QmxvY2sqIG9wdGltaXplZENvZGVCbG9jaywgQnl0ZWNvZGVJbmRleCBieXRlY29kZUluZGV4KQog ewotICAgIEFTU0VSVChjb2RlQmxvY2stPmppdFR5cGUoKSA9PSBKSVRUeXBlOjpERkdKSVQgfHwg Y29kZUJsb2NrLT5qaXRUeXBlKCkgPT0gSklUVHlwZTo6RlRMSklUKTsKLSAgICBBU1NFUlQoY29k ZUJsb2NrLT5qaXRDb2RlKCktPmRmZ0NvbW1vbigpLT5pc1N0aWxsVmFsaWQpOworICAgIEFTU0VS VChvcHRpbWl6ZWRDb2RlQmxvY2stPmppdFR5cGUoKSA9PSBKSVRUeXBlOjpERkdKSVQgfHwgb3B0 aW1pemVkQ29kZUJsb2NrLT5qaXRUeXBlKCkgPT0gSklUVHlwZTo6RlRMSklUKTsKKyAgICBBU1NF UlQob3B0aW1pemVkQ29kZUJsb2NrLT5qaXRDb2RlKCktPmRmZ0NvbW1vbigpLT5pc1N0aWxsVmFs aWQpOwogCi0gICAgaWYgKCFPcHRpb25zOjp1c2VPU1JFbnRyeVRvREZHKCkgJiYgY29kZUJsb2Nr LT5qaXRDb2RlKCktPmppdFR5cGUoKSA9PSBKSVRUeXBlOjpERkdKSVQpCisgICAgaWYgKCFPcHRp b25zOjp1c2VPU1JFbnRyeVRvREZHKCkgJiYgb3B0aW1pemVkQ29kZUJsb2NrLT5qaXRDb2RlKCkt PmppdFR5cGUoKSA9PSBKSVRUeXBlOjpERkdKSVQpCiAgICAgICAgIHJldHVybiBudWxscHRyOwot ICAgIGlmICghT3B0aW9uczo6dXNlT1NSRW50cnlUb0ZUTCgpICYmIGNvZGVCbG9jay0+aml0Q29k ZSgpLT5qaXRUeXBlKCkgPT0gSklUVHlwZTo6RlRMSklUKQorICAgIGlmICghT3B0aW9uczo6dXNl T1NSRW50cnlUb0ZUTCgpICYmIG9wdGltaXplZENvZGVCbG9jay0+aml0Q29kZSgpLT5qaXRUeXBl KCkgPT0gSklUVHlwZTo6RlRMSklUKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAotICAgIENv bW1vbkRhdGEqIGRmZ0NvbW1vbiA9IGNvZGVCbG9jay0+aml0Q29kZSgpLT5kZmdDb21tb24oKTsK KyAgICBDb21tb25EYXRhKiBkZmdDb21tb24gPSBvcHRpbWl6ZWRDb2RlQmxvY2stPmppdENvZGUo KS0+ZGZnQ29tbW9uKCk7CiAgICAgUkVMRUFTRV9BU1NFUlQoZGZnQ29tbW9uKTsKICAgICBERkc6 OkNhdGNoRW50cnlwb2ludERhdGEqIGNhdGNoRW50cnlwb2ludCA9IGRmZ0NvbW1vbi0+Y2F0Y2hP U1JFbnRyeURhdGFGb3JCeXRlY29kZUluZGV4KGJ5dGVjb2RlSW5kZXgpOwogICAgIGlmICghY2F0 Y2hFbnRyeXBvaW50KSB7CkBAIC0zODAsOSArMzgwLDkgQEAgTWFjcm9Bc3NlbWJsZXJDb2RlUHRy PEV4Y2VwdGlvbkhhbmRsZXJQdHJUYWc+IHByZXBhcmVDYXRjaE9TUkVudHJ5KFZNJiB2bSwgQ2Fs bEYKICAgICBpZiAoVU5MSUtFTFkoIXZtLmVuc3VyZVN0YWNrQ2FwYWNpdHlGb3IoJmNhbGxGcmFt ZS0+cmVnaXN0ZXJzKClbdmlydHVhbFJlZ2lzdGVyRm9yTG9jYWwoZnJhbWVTaXplRm9yQ2hlY2sp Lm9mZnNldCgpXSkpKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAotICAgIGF1dG8gaW5zdHJ1 Y3Rpb24gPSBjYWxsRnJhbWUtPmNvZGVCbG9jaygpLT5pbnN0cnVjdGlvbnMoKS5hdChjYWxsRnJh bWUtPmJ5dGVjb2RlSW5kZXgoKSk7CisgICAgYXV0byBpbnN0cnVjdGlvbiA9IGJhc2VsaW5lQ29k ZUJsb2NrLT5pbnN0cnVjdGlvbnMoKS5hdChjYWxsRnJhbWUtPmJ5dGVjb2RlSW5kZXgoKSk7CiAg ICAgQVNTRVJUKGluc3RydWN0aW9uLT5pczxPcENhdGNoPigpKTsKLSAgICBWYWx1ZVByb2ZpbGVB bmRPcGVyYW5kQnVmZmVyKiBidWZmZXIgPSBpbnN0cnVjdGlvbi0+YXM8T3BDYXRjaD4oKS5tZXRh ZGF0YShjYWxsRnJhbWUpLm1fYnVmZmVyOworICAgIFZhbHVlUHJvZmlsZUFuZE9wZXJhbmRCdWZm ZXIqIGJ1ZmZlciA9IGluc3RydWN0aW9uLT5hczxPcENhdGNoPigpLm1ldGFkYXRhKGJhc2VsaW5l Q29kZUJsb2NrKS5tX2J1ZmZlcjsKICAgICBKU1ZhbHVlKiBkYXRhQnVmZmVyID0gcmVpbnRlcnBy ZXRfY2FzdDxKU1ZhbHVlKj4oZGZnQ29tbW9uLT5jYXRjaE9TUkVudHJ5QnVmZmVyLT5kYXRhQnVm ZmVyKCkpOwogICAgIHVuc2lnbmVkIGluZGV4ID0gMDsKICAgICBidWZmZXItPmZvckVhY2goWyZd IChWYWx1ZVByb2ZpbGVBbmRPcGVyYW5kJiBwcm9maWxlKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkVudHJ5LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR09TUkVudHJ5LmgKaW5kZXggY2Y5NmQ3MThhZDdiNGVhZjIzNDFhM2RkNWEwZTMzZTU1 MTU2ZjcxMS4uNDY3OWQzZGJjOTc0MzJlNWU0NmMzYzczYjJmNTVjNTk0NmYzZWExMiAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPU1JFbnRyeS5oCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRW50cnkuaApAQCAtODQsNyArODQsNyBAQCBzdHJ1 Y3QgQ2F0Y2hFbnRyeXBvaW50RGF0YSB7CiB2b2lkKiBwcmVwYXJlT1NSRW50cnkoVk0mLCBDYWxs RnJhbWUqLCBDb2RlQmxvY2sqLCBCeXRlY29kZUluZGV4KTsKIAogLy8gSWYgbnVsbCBpcyByZXR1 cm5lZCwgd2UgY2FuJ3QgT1NSIGVudGVyLiBJZiBpdCdzIG5vdCBudWxsLCBpdCdzIHRoZSBQQyB0 byBqdW1wIHRvLgotTWFjcm9Bc3NlbWJsZXJDb2RlUHRyPEV4Y2VwdGlvbkhhbmRsZXJQdHJUYWc+ IHByZXBhcmVDYXRjaE9TUkVudHJ5KFZNJiwgQ2FsbEZyYW1lKiwgQ29kZUJsb2NrKiwgQnl0ZWNv ZGVJbmRleCk7CitNYWNyb0Fzc2VtYmxlckNvZGVQdHI8RXhjZXB0aW9uSGFuZGxlclB0clRhZz4g cHJlcGFyZUNhdGNoT1NSRW50cnkoVk0mLCBDYWxsRnJhbWUqLCBDb2RlQmxvY2sqIGJhc2VsaW5l Q29kZUJsb2NrLCBDb2RlQmxvY2sqIG9wdGltaXplZENvZGVCbG9jaywgQnl0ZWNvZGVJbmRleCk7 CiAjZWxzZQogaW5saW5lIE1hY3JvQXNzZW1ibGVyQ29kZVB0cjxFeGNlcHRpb25IYW5kbGVyUHRy VGFnPiBwcmVwYXJlT1NSRW50cnkoVk0mLCBDYWxsRnJhbWUqLCBDb2RlQmxvY2sqLCBCeXRlY29k ZUluZGV4KSB7IHJldHVybiBudWxscHRyOyB9CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9nZW5lcmF0b3IvTWV0YWRhdGEucmIgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvZ2VuZXJhdG9yL01ldGFkYXRhLnJiCmluZGV4IDhkN2I0ZDEwNmVlOTk0Mjc1YmI5Y2E3Yjcz YmQ4YzJmM2U2NzVhODcuLjdjZDE1ZDMxNWQ2MzkwYWJhMjYzNWU5NjM1OWY4OTBlMmViNzFhOTUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9nZW5lcmF0b3IvTWV0YWRhdGEucmIK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2dlbmVyYXRvci9NZXRhZGF0YS5yYgpAQCAtODMs MTEgKzgzLDYgQEAgZGVmIGFjY2Vzc29yCiAgICAgewogICAgICAgICByZXR1cm4gY29kZUJsb2Nr LT5tZXRhZGF0YTxNZXRhZGF0YT4ob3Bjb2RlSUQsICN7TWV0YWRhdGEuZmllbGRfbmFtZX0pOwog ICAgIH0KLQotICAgIE1ldGFkYXRhJiBtZXRhZGF0YShDYWxsRnJhbWUqIGNhbGxGcmFtZSkgY29u c3QKLSAgICB7Ci0gICAgICAgIHJldHVybiBtZXRhZGF0YShjYWxsRnJhbWUtPmNvZGVCbG9jaygp KTsKLSAgICB9CiBFT0YKICAgICBlbmQKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2ppdC9KSVRPcGVyYXRpb25zLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU T3BlcmF0aW9ucy5jcHAKaW5kZXggOWM2NzZmMTUwNDY1OWJmNDAxOGRhMzgyNGYyNmM5ZTI5MGM1 ODJjNC4uZjlhNjM5Nzg3YjNlODAwYjFlYmVlMTA5ZDA3NTI4ZDc2ODM5N2ZlNSAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zLmNwcAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwCkBAIC0xNzMyLDE0ICsxNzMy LDE1IEBAIGNoYXIqIEpJVF9PUEVSQVRJT04gb3BlcmF0aW9uVHJ5T1NSRW50ZXJBdENhdGNoKFZN KiB2bVBvaW50ZXIsIHVpbnQzMl90IGJ5dGVjb2RlCiAgICAgSklUT3BlcmF0aW9uUHJvbG9ndWVD YWxsRnJhbWVUcmFjZXIgdHJhY2VyKHZtLCBjYWxsRnJhbWUpOwogICAgIEJ5dGVjb2RlSW5kZXgg Ynl0ZWNvZGVJbmRleCA9IEJ5dGVjb2RlSW5kZXg6OmZyb21CaXRzKGJ5dGVjb2RlSW5kZXhCaXRz KTsKIAotICAgIENvZGVCbG9jayogb3B0aW1pemVkUmVwbGFjZW1lbnQgPSBjYWxsRnJhbWUtPmNv ZGVCbG9jaygpLT5yZXBsYWNlbWVudCgpOworICAgIENvZGVCbG9jayogY29kZUJsb2NrID0gY2Fs bEZyYW1lLT5jb2RlQmxvY2soKTsKKyAgICBDb2RlQmxvY2sqIG9wdGltaXplZFJlcGxhY2VtZW50 ID0gY29kZUJsb2NrLT5yZXBsYWNlbWVudCgpOwogICAgIGlmIChVTkxJS0VMWSghb3B0aW1pemVk UmVwbGFjZW1lbnQpKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAogICAgIHN3aXRjaCAob3B0 aW1pemVkUmVwbGFjZW1lbnQtPmppdFR5cGUoKSkgewogICAgIGNhc2UgSklUVHlwZTo6REZHSklU OgogICAgIGNhc2UgSklUVHlwZTo6RlRMSklUOiB7Ci0gICAgICAgIE1hY3JvQXNzZW1ibGVyQ29k ZVB0cjxFeGNlcHRpb25IYW5kbGVyUHRyVGFnPiBlbnRyeSA9IERGRzo6cHJlcGFyZUNhdGNoT1NS RW50cnkodm0sIGNhbGxGcmFtZSwgb3B0aW1pemVkUmVwbGFjZW1lbnQsIGJ5dGVjb2RlSW5kZXgp OworICAgICAgICBNYWNyb0Fzc2VtYmxlckNvZGVQdHI8RXhjZXB0aW9uSGFuZGxlclB0clRhZz4g ZW50cnkgPSBERkc6OnByZXBhcmVDYXRjaE9TUkVudHJ5KHZtLCBjYWxsRnJhbWUsIGNvZGVCbG9j aywgb3B0aW1pemVkUmVwbGFjZW1lbnQsIGJ5dGVjb2RlSW5kZXgpOwogICAgICAgICByZXR1cm4g ZW50cnkuZXhlY3V0YWJsZUFkZHJlc3M8Y2hhcio+KCk7CiAgICAgfQogICAgIGRlZmF1bHQ6CkBA IC0xNzYzLDcgKzE3NjQsNyBAQCBjaGFyKiBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvblRyeU9TUkVu dGVyQXRDYXRjaEFuZFZhbHVlUHJvZmlsZShWTSogdm1Qb2ludGVyLCB1aQogICAgIHN3aXRjaCAo b3B0aW1pemVkUmVwbGFjZW1lbnQtPmppdFR5cGUoKSkgewogICAgIGNhc2UgSklUVHlwZTo6REZH SklUOgogICAgIGNhc2UgSklUVHlwZTo6RlRMSklUOiB7Ci0gICAgICAgIE1hY3JvQXNzZW1ibGVy Q29kZVB0cjxFeGNlcHRpb25IYW5kbGVyUHRyVGFnPiBlbnRyeSA9IERGRzo6cHJlcGFyZUNhdGNo T1NSRW50cnkodm0sIGNhbGxGcmFtZSwgb3B0aW1pemVkUmVwbGFjZW1lbnQsIGJ5dGVjb2RlSW5k ZXgpOworICAgICAgICBNYWNyb0Fzc2VtYmxlckNvZGVQdHI8RXhjZXB0aW9uSGFuZGxlclB0clRh Zz4gZW50cnkgPSBERkc6OnByZXBhcmVDYXRjaE9TUkVudHJ5KHZtLCBjYWxsRnJhbWUsIGNvZGVC bG9jaywgb3B0aW1pemVkUmVwbGFjZW1lbnQsIGJ5dGVjb2RlSW5kZXgpOwogICAgICAgICByZXR1 cm4gZW50cnkuZXhlY3V0YWJsZUFkZHJlc3M8Y2hhcio+KCk7CiAgICAgfQogICAgIGRlZmF1bHQ6 Cg==