203705 2019-10-31 17:13:32 -0700 Disable Wasm interpreter on WinCairo 2023-11-09 18:52:21 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=194257 InRadar P2 Normal --- 203716 1 tzagallo tzagallo bfulgham commit-queue don.olmstead ews-watchlist fujii ian.grunert keith_miller mark.lam msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1586160 0 tzagallo 2019-10-31 17:13:32 -0700 ... 1586164 1 382524 tzagallo 2019-10-31 17:16:50 -0700 Created attachment 382524 Patch 1586167 2 ysuzuki 2019-10-31 17:22:22 -0700 Do you know why ENABLE(WEBASSEMBLY) is ON in Windows? 1586169 3 tzagallo 2019-10-31 17:26:26 -0700 (In reply to Yusuke Suzuki from comment #2) > Do you know why ENABLE(WEBASSEMBLY) is ON in Windows? No idea, I asked in the original bug, and that's the only reason I didn't disable it in the original commit, since I didn't know whether it'd be of interest to actually make it work or whether I should just disable it. I figured I should just have the patch ready so we can get it back building just in case. 1586217 4 382524 ysuzuki 2019-10-31 19:33:07 -0700 Comment on attachment 382524 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382524&action=review r=me with FIXME request. > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:2018 > +if WEBASSEMBLY and not X86_64_WIN Can you add a FIXME and URL to fix this issue? I think this is essentially unnecessary, and it should be fixed. I don’t consider that WEBASSEMBLY is true on Windows, so it would eventually can cause the problem again: like putting a code that is guarded by WEBASSEMBLY, but we don’t consider Windows at all. So I think this should be fixed soon, but I don’t want to Wasm interpreter patch roll-out. So, I’m OK for this for very short-term workaround. 1586218 5 382524 tzagallo 2019-10-31 19:34:41 -0700 Comment on attachment 382524 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382524&action=review Thanks for the review! >> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:2018 >> +if WEBASSEMBLY and not X86_64_WIN > > Can you add a FIXME and URL to fix this issue? I think this is essentially unnecessary, and it should be fixed. > I don’t consider that WEBASSEMBLY is true on Windows, so it would eventually can cause the problem again: like putting a code that is guarded by WEBASSEMBLY, but we don’t consider Windows at all. > So I think this should be fixed soon, but I don’t want to Wasm interpreter patch roll-out. So, I’m OK for this for very short-term workaround. Thanks, that makes sense. I'll add it. 1586220 6 382540 tzagallo 2019-10-31 19:39:33 -0700 Created attachment 382540 Patch for landing 1586222 7 bfulgham 2019-10-31 19:57:17 -0700 Note: This breaks 64-bit Windows in general, not just WinCairo. 1586228 8 382540 bfulgham 2019-10-31 20:19:28 -0700 Comment on attachment 382540 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=382540&action=review > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:2019 > +// https://bugs.webkit.org/show_bug.cgi?id=203716 Shouldn't these be '#' comments? 1586229 9 382540 tzagallo 2019-10-31 20:20:49 -0700 Comment on attachment 382540 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=382540&action=review >> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:2019 >> +// https://bugs.webkit.org/show_bug.cgi?id=203716 > > Shouldn't these be '#' comments? We usually use `#`, so that was unintentional, but both work. 1586232 10 382540 commit-queue 2019-10-31 20:23:20 -0700 Comment on attachment 382540 Patch for landing Clearing flags on attachment: 382540 Committed r251904: <https://trac.webkit.org/changeset/251904> 1586233 11 commit-queue 2019-10-31 20:23:22 -0700 All reviewed patches have been landed. Closing bug. 1586234 12 webkit-bug-importer 2019-10-31 20:24:16 -0700 <rdar://problem/56805484> 1586235 13 bfulgham 2019-10-31 20:25:05 -0700 Sadly, I don't believe this fixes the 64-bit Window build. I still see errors: :/Projects/WebKit/OpenSource/WebKitBuild/Release/JavaScriptCore/DerivedSources/LowLevelInterpreterWin.asm(26614): error A2008: syntax error : xmm1 [C:\Projects\WebKit\OpenSource\WebKitBuild\Release\ ource\JavaScriptCore\JavaScriptCore.vcxproj] :/Projects/WebKit/OpenSource/WebKitBuild/Release/JavaScriptCore/DerivedSources/LowLevelInterpreterWin.asm(26721): error A2008: syntax error : xmm1 [C:\Projects\WebKit\OpenSource\WebKitBuild\Release\ ource\JavaScriptCore\JavaScriptCore.vcxproj] .... and many more. 26614 in LowLevelIntepreterWin.asm is the 'ucomi' command below: _offlineasm_compareJumpOp__llintOpWithJump__llintOpWithM_____makeReturn__fn__fn__fn__429_impl__op2NotInt: cvtsi2sd xmm0, eax ; C:/Projects/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1861 test rdx, r14 ; C:/Projects/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1862 jz _offlineasm_compareJumpOp__llintOpWithJump__llintOpWithM___n__fn__makeReturn__fn__fn__fn__429_impl__slow add rdx, r14 ; C:/Projects/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1863 movd xmm1, rdx ; C:/Projects/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1864 ucomi xmm1, xmm0 ; C:/Projects/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:1712 jbe _offlineasm_compareJumpOp__llintOpWithJump__llintOpWithM____makeReturn__fn__fn__fn__429_impl__jumpTarget add r10, 4 ; C:/Projects/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:308 movzx eax, byte ptr [0 + r13 + r10 * 1] ; C:/Projects/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:28 lea rdx, g_opcodeMap ; C:/Projects/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:29 jmp qword ptr [0 + rdx + rax * 8] ; C:/Projects/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:30 1586236 14 bfulgham 2019-10-31 20:25:21 -0700 Reopening: This does not fix the build issue (as shown above). 1586238 15 bfulgham 2019-10-31 20:27:48 -0700 More errors: C:/Projects/WebKit/OpenSource/WebKitBuild/Release/JavaScriptCore/DerivedSources/LowLevelInterpreterWin.asm(5973): error A2008: syntax error : , [C:\Projects\WebKit\OpenSource\WebKitBuild\Release\Source\JavaScriptCore\JavaScriptCore.vcxproj] C:/Projects/WebKit/OpenSource/WebKitBuild/Release/JavaScriptCore/DerivedSources/LowLevelInterpreterWin.asm(5990): error A2008: syntax error : , [C:\Projects\WebKit\OpenSource\WebKitBuild\Release\Source\JavaScriptCore\JavaScriptCore.vcxproj] C:/Projects/WebKit/OpenSource/WebKitBuild/Release/JavaScriptCore/DerivedSources/LowLevelInterpreterWin.asm(6098): error A2008: syntax error : , [C:\Projects\WebKit\OpenSource\WebKitBuild\Release\Source\JavaScriptCore\JavaScriptCore.vcxproj] C:/Projects/WebKit/OpenSource/WebKitBuild/Release/JavaScriptCore/DerivedSources/LowLevelInterpreterWin.asm(6115): error A2008: syntax error : , [C:\Projects\WebKit\OpenSource\WebKitBuild\Release\Source\JavaScriptCore\JavaScriptCore.vcxproj] C:/Projects/WebKit/OpenSource/WebKitBuild/Release/JavaScriptCore/DerivedSources/LowLevelInterpreterWin.asm(6225): error A2008: syntax error : , [C:\Projects\WebKit\OpenSource\WebKitBuild\Release\Source\JavaScriptCore\JavaScriptCore.vcxproj] C:/Projects/WebKit/OpenSource/WebKitBuild/Release/JavaScriptCore/DerivedSources/LowLevelInterpreterWin.asm(6242): error A2008: syntax error : , [C:\Projects\WebKit\OpenSource\WebKitBuild\Release\Source\JavaScriptCore\JavaScriptCore.vcxproj] C:/Projects/WebKit/OpenSource/WebKitBuild/Release/JavaScriptCore/DerivedSources/LowLevelInterpreterWin.asm(6341): error A2152: coprocessor register cannot be first operand [C:\Projects\WebKit\OpenSource\WebKitBuild\Release\Source\JavaScriptCore\JavaScriptCore.vcxproj] C:/Projects/WebKit/OpenSource/WebKitBuild/Release/JavaScriptCore/DerivedSources/LowLevelInterpreterWin.asm(6358): error A2152: coprocessor register cannot be first operand [C:\Projects\WebKit\OpenSou Line 5973 is the 'mul' command: _offlineasm_binaryOpCustomStore__llintOpWithMetadata__ll___n__fn__makeReturn__fn__fn__fn__op1NotIntReady: movsx r8, byte ptr [1 + r13 + r10 * 1] ; C:/Projects/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:50 add rax, r14 ; C:/Projects/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1025 movd xmm0, rax ; C:/Projects/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1026 mul xmm0, xmm1 ; C:/Projects/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1090 movd rax, xmm0 ; C:/Projects/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1028 sub rax, r14 ; C:/Projects/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1029 mov qword ptr [0 + rbp + r8 * 8], rax ; C:/Projects/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1030 add r10, 6 ; C:/Projects/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:308 movzx eax, byte ptr [0 + r13 + r10 * 1] ; C:/Projects/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:28 lea rdx, g_opcodeMap ; C:/Projects/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:29 jmp qword ptr [0 + rdx + rax * 8] ; C:/Projects/WebKit/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:30 1586239 16 bfulgham 2019-10-31 20:28:03 -0700 I really don't think things are in a good state right now. Can't we roll this out somehow? 1991377 17 ian.grunert 2023-11-09 17:23:02 -0800 I think this can be closed, wasm interpreter has been enabled on Windows by https://bugs.webkit.org/show_bug.cgi?id=222315 382524 2019-10-31 17:16:50 -0700 2019-10-31 19:39:30 -0700 Patch bug-203705-20191031171647.patch text/plain 1878 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxODk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 Y2Q1MWZhNmY5M2M0NmY0NTVkYTJlODc4MDQwOTg1MDUwZWNiZDY0Li4zNWM3NDQxMTYwOGE3YjBk YWYxODdjNTg1NmMzMjJjY2M3OTAyZGRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0xMC0zMSAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBEaXNhYmxlIFdhc20gaW50ZXJwcmV0ZXIgb24gV2luQ2Fpcm8KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzcwNQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBpbnRlcnByZXRl ciBkb2VzIG5vdCBidWlsZCBvbiBXaW5DYWlyby4KKworICAgICAgICAqIGxsaW50L0xvd0xldmVs SW50ZXJwcmV0ZXIuYXNtOgorICAgICAgICAqIHJ1bnRpbWUvT3B0aW9ucy5jcHA6CisgICAgICAg IChKU0M6Om92ZXJyaWRlRGVmYXVsdHMpOgorCiAyMDE5LTEwLTMxICBUYWRldSBaYWdhbGxvICA8 dHphZ2FsbG9AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGZpeCBMb3dMZXZlbElu dGVycHJldGVyMzJfNjQuYXNtIGFmdGVyIHIyNTE4ODYKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbSBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQppbmRleCBiMzUwYTA2OTU1OWNh YmRlZDIyNTYxZDNkYTkzYjBjZjY2ZGE4NjU1Li5iZTVmYjkzZTc1ODAyM2E3MmFmNzlkZjVhZGI1 ZmVhMTkyYTU4NjEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93 TGV2ZWxJbnRlcnByZXRlci5hc20KKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xv d0xldmVsSW50ZXJwcmV0ZXIuYXNtCkBAIC0yMDE1LDcgKzIwMTUsNyBAQCBtYWNybyBub3RTdXBw b3J0ZWQoKQogICAgIGVuZAogZW5kCiAKLWlmIFdFQkFTU0VNQkxZCitpZiBXRUJBU1NFTUJMWSBh bmQgbm90IFg4Nl82NF9XSU4KIAogZW50cnkod2FzbSwgbWFjcm8oKQogICAgIGluY2x1ZGUgSW5p dFdhc20KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMu Y3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5jcHAKaW5kZXggNDBh ZDIxODFiNThmNjk5NjU0YjJiMzBkNGUwOGNlNjM0OTg2ZjIyZi4uOGIzNGFkZmFjMTU1Mjk0OTIy NzM2MmE1ODU3MDQ5NDEwMWIwMzQ3ZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvT3B0aW9ucy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv T3B0aW9ucy5jcHAKQEAgLTM2MCw2ICszNjAsMTAgQEAgc3RhdGljIHZvaWQgb3ZlcnJpZGVEZWZh dWx0cygpCiAgICAgT3B0aW9uczo6dXNlTWFjaEZvckV4Y2VwdGlvbnMoKSA9IGZhbHNlOwogI2Vu ZGlmCiAKKyNpZiBPUyhXSU5ET1dTKQorICAgIE9wdGlvbnM6OnVzZVdhc21MTEludCgpID0gZmFs c2U7CisjZW5kaWYKKwogICAgIGlmIChPcHRpb25zOjp1c2VXYXNtTExJbnQoKSkgewogICAgICAg ICBPcHRpb25zOjp0aHJlc2hvbGRGb3JPTUdPcHRpbWl6ZUFmdGVyV2FybVVwKCkgPSAxNTAwOwog ICAgICAgICBPcHRpb25zOjp0aHJlc2hvbGRGb3JPTUdPcHRpbWl6ZVNvb24oKSA9IDEwMDsK 382540 2019-10-31 19:39:33 -0700 2019-10-31 20:23:20 -0700 Patch for landing bug-203705-20191031193929.patch text/plain 1358 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxODk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 Y2Q1MWZhNmY5M2M0NmY0NTVkYTJlODc4MDQwOTg1MDUwZWNiZDY0Li5kOGI3ZWUwNjg4OTYzMzEw OThkYmU4NWFkODBiYTk2YzI1NThmNTdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOS0xMC0zMSAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBEaXNhYmxlIFdhc20gaW50ZXJwcmV0ZXIgb24gV2luQ2Fpcm8KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzcwNQorCisgICAg ICAgIFJldmlld2VkIGJ5IFl1c3VrZSBTdXp1a2kuCisKKyAgICAgICAgVGhlIGludGVycHJldGVy IGRvZXMgbm90IGJ1aWxkIG9uIFdpbkNhaXJvLgorCisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJ bnRlcnByZXRlci5hc206CisKIDIwMTktMTAtMzEgIFRhZGV1IFphZ2FsbG8gIDx0emFnYWxsb0Bh cHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZml4IExvd0xldmVsSW50ZXJwcmV0ZXIz Ml82NC5hc20gYWZ0ZXIgcjI1MTg4NgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xs aW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCmluZGV4IGIzNTBhMDY5NTU5Y2FiZGVkMjI1NjFk M2RhOTNiMGNmNjZkYTg2NTUuLjljZTM0Yzg1Njc3OGY3Mjg2MTM0MDhhYmRlNzcyMjY4MzkyZWNk NjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVy cHJldGVyLmFzbQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRl cnByZXRlci5hc20KQEAgLTIwMTUsNyArMjAxNSw5IEBAIG1hY3JvIG5vdFN1cHBvcnRlZCgpCiAg ICAgZW5kCiBlbmQKIAotaWYgV0VCQVNTRU1CTFkKKy8vIEZJWE1FOiBXZSBzaG91bGQgbm90IG5l ZWQgdGhlIFg4Nl82NF9XSU4gY29uZGl0aW9uIGhlcmUsIHNpbmNlIFdFQkFTU0VNQkxZIHNob3Vs ZCBhbHJlYWR5IGJlIGZhbHNlIG9uIFdpbmRvd3MKKy8vIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMDM3MTYKK2lmIFdFQkFTU0VNQkxZIGFuZCBub3QgWDg2XzY0X1dJ TgogCiBlbnRyeSh3YXNtLCBtYWNybygpCiAgICAgaW5jbHVkZSBJbml0V2FzbQo=