203703 2019-10-31 16:46:55 -0700 Fix GTK build after r251886 2019-10-31 23:34:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=194257 InRadar P2 Normal --- 1 tzagallo tzagallo commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1586141 0 tzagallo 2019-10-31 16:46:55 -0700 ... 1586143 1 382520 tzagallo 2019-10-31 16:48:52 -0700 Created attachment 382520 Patch 1586144 2 tzagallo 2019-10-31 16:49:29 -0700 Let's see if EWS is green, or if there are more things to fix. 1586148 3 382520 mark.lam 2019-10-31 17:01:30 -0700 Comment on attachment 382520 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382520&action=review > Source/JavaScriptCore/wasm/WasmSlowPaths.cpp:400 > +extern "C" SlowPathReturnType slow_path_wasm_throw_exception(CallFrame* callFrame, const Instruction* pc, Wasm::Instance* instance, Wasm::ExceptionType exceptionType) Don't you also have to do this for slow_path_wasm_popcount and slow_path_wasm_popcount11? 1586286 4 tzagallo 2019-10-31 22:04:15 -0700 (In reply to Mark Lam from comment #3) > Comment on attachment 382520 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=382520&action=review > > > Source/JavaScriptCore/wasm/WasmSlowPaths.cpp:400 > > +extern "C" SlowPathReturnType slow_path_wasm_throw_exception(CallFrame* callFrame, const Instruction* pc, Wasm::Instance* instance, Wasm::ExceptionType exceptionType) > > Don't you also have to do this for slow_path_wasm_popcount and > slow_path_wasm_popcount11? Those are already annotated 1586287 5 382520 ysuzuki 2019-10-31 22:06:40 -0700 Comment on attachment 382520 Patch r=me 1586289 6 382520 tzagallo 2019-10-31 22:09:01 -0700 Comment on attachment 382520 Patch Thanks for the review! 1586297 7 382520 commit-queue 2019-10-31 22:53:52 -0700 Comment on attachment 382520 Patch Clearing flags on attachment: 382520 Committed r251911: <https://trac.webkit.org/changeset/251911> 1586298 8 commit-queue 2019-10-31 22:53:55 -0700 All reviewed patches have been landed. Closing bug. 1586299 9 webkit-bug-importer 2019-10-31 22:54:14 -0700 <rdar://problem/56807680> 1586301 10 ysuzuki 2019-10-31 23:34:27 -0700 Committed r251912: <https://trac.webkit.org/changeset/251912> 382520 2019-10-31 16:48:52 -0700 2019-10-31 22:53:52 -0700 Patch bug-203703-20191031164850.patch text/plain 1633 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxODk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 Y2Q1MWZhNmY5M2M0NmY0NTVkYTJlODc4MDQwOTg1MDUwZWNiZDY0Li40YmU5N2EwYzk0MWU0ZDI3 YmEwMTAzNzFmYWE0Yjk2OTk2MmY0ZTBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOS0xMC0zMSAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBGaXggR1RLIGJ1aWxkIGFmdGVyIHIyNTE4ODYKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzcwMworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHNsb3dfcGF0aF93YXNtX3Rocm93X2V4 Y2VwdGlvbiB3YXMgbWlzc2luZyBgZXh0ZXJuICJDImAgaW4gdGhlIGltcGxlbWVudGF0aW9uIGZp bGUuCisKKyAgICAgICAgKiB3YXNtL1dhc21TbG93UGF0aHMuY3BwOgorICAgICAgICAoSlNDOjpM TEludDo6c2xvd19wYXRoX3dhc21fdGhyb3dfZXhjZXB0aW9uKToKKwogMjAxOS0xMC0zMSAgVGFk ZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBm aXggTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbSBhZnRlciByMjUxODg2CmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtU2xvd1BhdGhzLmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS93YXNtL1dhc21TbG93UGF0aHMuY3BwCmluZGV4IGZjYzkyM2U1YTIzZGQ1 M2UxOTgyM2U1M2E3YjI1N2ZkZjdkOGQ4YzMuLjAzYWZmYjQ2NmRlZTMxM2QzYWJkMDJlZjdhZTRi ODIwNTFlNGQ0MTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21T bG93UGF0aHMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21TbG93UGF0 aHMuY3BwCkBAIC0zOTcsNyArMzk3LDcgQEAgV0FTTV9TTE9XX1BBVEhfREVDTChzZXRfZ2xvYmFs X3JlZikKICAgICBXQVNNX0VORF9JTVBMKCk7CiB9CiAKLVNsb3dQYXRoUmV0dXJuVHlwZSBzbG93 X3BhdGhfd2FzbV90aHJvd19leGNlcHRpb24oQ2FsbEZyYW1lKiBjYWxsRnJhbWUsIGNvbnN0IElu c3RydWN0aW9uKiBwYywgV2FzbTo6SW5zdGFuY2UqIGluc3RhbmNlLCBXYXNtOjpFeGNlcHRpb25U eXBlIGV4Y2VwdGlvblR5cGUpCitleHRlcm4gIkMiIFNsb3dQYXRoUmV0dXJuVHlwZSBzbG93X3Bh dGhfd2FzbV90aHJvd19leGNlcHRpb24oQ2FsbEZyYW1lKiBjYWxsRnJhbWUsIGNvbnN0IEluc3Ry dWN0aW9uKiBwYywgV2FzbTo6SW5zdGFuY2UqIGluc3RhbmNlLCBXYXNtOjpFeGNlcHRpb25UeXBl IGV4Y2VwdGlvblR5cGUpCiB7CiAgICAgVU5VU0VEX1BBUkFNKHBjKTsKICAgICBXQVNNX1JFVFVS Tl9UV08oV2FzbTo6VGh1bmtzOjpzaW5nbGV0b24oKS50aHJvd1dhc21FeGNlcHRpb24oKShjYWxs RnJhbWUsIGV4Y2VwdGlvblR5cGUsIGluc3RhbmNlKSwgMCk7Cg==