203701 2019-10-31 16:16:26 -0700 Python 3: Add support in webkitpy.layout_tests 2021-06-28 04:37:06 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=203702 https://bugs.webkit.org/show_bug.cgi?id=184986 https://bugs.webkit.org/show_bug.cgi?id=204180 https://bugs.webkit.org/show_bug.cgi?id=204209 https://bugs.webkit.org/show_bug.cgi?id=204212 https://bugs.webkit.org/show_bug.cgi?id=204227 https://bugs.webkit.org/show_bug.cgi?id=222188 InRadar P2 Normal --- 221043 1 jbedard jbedard emilio ews-watchlist glenn gsnedders mcatanzaro pnormand psaavedra webkit-bug-importer oldest_to_newest 1586124 0 jbedard 2019-10-31 16:16:26 -0700 Work towards allowing run-webkit-tests to be run with Python3. 1722973 1 mcatanzaro 2021-01-27 07:30:23 -0800 *** Bug 210699 has been marked as a duplicate of this bug. *** 1722977 2 mcatanzaro 2021-01-27 07:34:39 -0800 From bug #210699: $ ./Tools/Scripts/run-webkit-tests --verbose --debug LayoutTests/fast/css/getComputedStyle/computed-style.html Using port 'gtk-wk2' Test configuration: <, x86, debug> Placing test results in /home/emilio/src/WebKit/WebKitBuild/Debug/layout-test-results Using Debug build Pixel tests disabled Regular timeout: 30000, slow test timeout: 150000 Command line: /home/emilio/src/WebKit/WebKitBuild/Debug/bin/WebKitTestRunner - Found 1 test; running 1, skipping 0. Verbose baseline search path: platform/gtk -> platform/wk2 -> generic Baseline search path: platform/gtk -> platform/wk2 -> generic Running 1 test Checking system dependencies ... TypeError raised: argument should be integer or bytes-like object, not 'str' Traceback (most recent call last): File "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 91, in main run_details = run(port, options, args, stderr) File "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 487, in run run_details = manager.run(args) File "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 270, in run if not self._set_up_run(tests_to_run_by_device[device_type], device_type=device_type): File "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 176, in _set_up_run self._port.setup_test_run(device_type) File "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/port/gtk.py", line 108, in setup_test_run self._pulseaudio_sanitizer.unload_pulseaudio_module() File "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/port/pulseaudio_sanitizer.py", line 58, in unload_pulseaudio_module if module.find("module-stream-restore") >= 0: TypeError: argument should be integer or bytes-like object, not 'str' 1722986 3 jbedard 2021-01-27 07:53:45 -0800 Not a code-path (In reply to Michael Catanzaro from comment #2) > From bug #210699: > > $ ./Tools/Scripts/run-webkit-tests --verbose --debug > LayoutTests/fast/css/getComputedStyle/computed-style.html > > Using port 'gtk-wk2' > Test configuration: <, x86, debug> > Placing test results in > /home/emilio/src/WebKit/WebKitBuild/Debug/layout-test-results > Using Debug build > Pixel tests disabled > Regular timeout: 30000, slow test timeout: 150000 > Command line: /home/emilio/src/WebKit/WebKitBuild/Debug/bin/WebKitTestRunner > - > > Found 1 test; running 1, skipping 0. > > Verbose baseline search path: platform/gtk -> platform/wk2 -> generic > > Baseline search path: platform/gtk -> platform/wk2 -> generic > > Running 1 test > > Checking system dependencies ... > TypeError raised: argument should be integer or bytes-like object, not 'str' > Traceback (most recent call last): > File > "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/layout_tests/ > run_webkit_tests.py", line 91, in main > run_details = run(port, options, args, stderr) > File > "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/layout_tests/ > run_webkit_tests.py", line 487, in run > run_details = manager.run(args) > File > "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/ > manager.py", line 270, in run > if not self._set_up_run(tests_to_run_by_device[device_type], > device_type=device_type): > File > "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/ > manager.py", line 176, in _set_up_run > self._port.setup_test_run(device_type) > File "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/port/gtk.py", line > 108, in setup_test_run > self._pulseaudio_sanitizer.unload_pulseaudio_module() > File > "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/port/pulseaudio_sanitizer. > py", line 58, in unload_pulseaudio_module > if module.find("module-stream-restore") >= 0: > TypeError: argument should be integer or bytes-like object, not 'str' I don't have a machine which exercises this code path, the fix is not likely to be difficult, but it's also likely there are multiple encoding problems in that class. 1722987 4 pnormand 2021-01-27 07:54:16 -0800 If that's the only issue, the fix is easy. I'll check it. 1722997 5 418548 jbedard 2021-01-27 08:39:05 -0800 Created attachment 418548 Patch 1723001 6 jbedard 2021-01-27 08:42:24 -0800 (In reply to Jonathan Bedard from comment #5) > Created attachment 418548 [details] > Patch That's a blind fix for the raised exception 1746459 7 pnormand 2021-04-02 05:11:35 -0700 bug 223888 removes that pulseaudio thing BTW :) 1755040 8 pnormand 2021-04-28 09:07:36 -0700 What's the status here? Just trying now to run the WPE layout tests in Python3, the test harness no longer spits a traceback and tests actually seem to run. 1755046 9 jbedard 2021-04-28 09:37:05 -0700 (In reply to Philippe Normand from comment #8) > What's the status here? > > Just trying now to run the WPE layout tests in Python3, the test harness no > longer spits a traceback and tests actually seem to run. The test runner works in 3.7, still has some issues in 3.8 which I will be working on this week and next (issues are about forking) 1755048 10 pnormand 2021-04-28 09:48:13 -0700 Here in linux with python 3.8.7 the only issue I noticed so far was that tests expected to time out were detected as unexpected timeouts. 1755382 11 webkit-bug-importer 2021-04-29 08:04:32 -0700 <rdar://problem/77321491> 1755387 12 gsnedders 2021-04-29 08:09:53 -0700 (In reply to Jonathan Bedard from comment #9) > (In reply to Philippe Normand from comment #8) > > What's the status here? > > > > Just trying now to run the WPE layout tests in Python3, the test harness no > > longer spits a traceback and tests actually seem to run. > > The test runner works in 3.7, still has some issues in 3.8 which I will be > working on this week and next (issues are about forking) Note that the change of the multiprocessing default start method in 3.8 was only on macOS; non-macOS Unix systems still use the fork start method, and Windows has for a long time used the spawn start method. As such, as Philippe says, I would be surprised by changes in behaviour between 3.7 and 3.8 on Linux. Also, given the WinCairo test bot isn't totally broken, presumably whatever is causing issues with the spawn start method is something related to the Darwin ports? 1773023 13 pnormand 2021-06-28 04:37:06 -0700 Python2 is still used for the WebSocket server. WIP patch in bug 222188. 418548 2021-01-27 08:39:05 -0800 2021-01-27 08:39:05 -0800 Patch bug-203701-20210127083904.patch text/plain 1361 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MTk1NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIxLTAxLTI3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBQeXRob24gMzogQWRkIHN1cHBvcnQgaW4gd2Via2l0cHkubGF5b3V0X3Rl c3RzIChndGspCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDM3MDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9wdWxzZWF1ZGlvX3Nhbml0aXplci5weToKKyAgICAg ICAgKFB1bHNlQXVkaW9TYW5pdGl6ZXIudW5sb2FkX3B1bHNlYXVkaW9fbW9kdWxlKToKKwogMjAy MS0wMS0yNyAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgRW5h YmxlIEdQVSBXZWJSVEMgY29kZWNzIGluIFdlYktpdFRlc3RSdW5uZXIKSW5kZXg6IFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvcG9ydC9wdWxzZWF1ZGlvX3Nhbml0aXplci5weQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvcHVsc2VhdWRpb19zYW5pdGl6ZXIucHkJKHJl dmlzaW9uIDI3MTk1NCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9wdWxzZWF1ZGlv X3Nhbml0aXplci5weQkod29ya2luZyBjb3B5KQpAQCAtNTUsNyArNTUsNyBAQCBjbGFzcyBQdWxz ZUF1ZGlvU2FuaXRpemVyOgogICAgICAgICAgICAgICAgIHJldHVybgogICAgICAgICBtb2R1bGVz X2xpc3QgPSBwYWN0bF9wcm9jZXNzLmNvbW11bmljYXRlKClbMF0KICAgICAgICAgZm9yIG1vZHVs ZSBpbiBtb2R1bGVzX2xpc3Quc3BsaXRsaW5lcygpOgotICAgICAgICAgICAgaWYgbW9kdWxlLmZp bmQoIm1vZHVsZS1zdHJlYW0tcmVzdG9yZSIpID49IDA6CisgICAgICAgICAgICBpZiBtb2R1bGUu ZmluZChiJ21vZHVsZS1zdHJlYW0tcmVzdG9yZScpID49IDA6CiAgICAgICAgICAgICAgICAgIyBT b21lIHB1bHNlYXVkaW8tdXRpbHMgdmVyc2lvbnMgZG9uJ3QgcHJvdmlkZQogICAgICAgICAgICAg ICAgICMgdGhlIGluZGV4LCBqdXN0IGFuIGVtcHR5IHN0cmluZwogICAgICAgICAgICAgICAgIHNl bGYuX3BhX21vZHVsZV9pbmRleCA9IG1vZHVsZS5zcGxpdCgnXHQnKVswXSBvciAtMQo=