203697 2019-10-31 13:59:08 -0700 [iOS] Fix mach lookup sandbox violations in the Mail app 2019-10-31 22:53:06 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan ap bfulgham commit-queue webkit-bug-importer oldest_to_newest 1586063 0 pvollan 2019-10-31 13:59:08 -0700 The following services are being used by the Mail app, and needs to be allowed. 1) com.apple.logd.events 2) com.apple.distributed_notifications@1v3 1586064 1 pvollan 2019-10-31 13:59:30 -0700 rdar://problem/56765698 1586067 2 382499 pvollan 2019-10-31 14:03:38 -0700 Created attachment 382499 Patch 1586078 3 382501 pvollan 2019-10-31 14:32:09 -0700 Created attachment 382501 Patch 1586127 4 382501 ap 2019-10-31 16:19:08 -0700 Comment on attachment 382501 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382501&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:624 > +(allow mach-lookup > (global-name "com.apple.logd.events")) > > (allow mach-lookup > + (global-name "com.apple.distributed_notifications@1v3")) > + > +(allow mach-lookup > + (global-name "com.apple.aggregated")) > + > +(allow mach-lookup > (global-name "com.apple.cfprefsd.daemon")) Should these all be combined into one "allow mach-lookup" expression? 1586135 5 382518 pvollan 2019-10-31 16:30:50 -0700 Created attachment 382518 Patch 1586137 6 pvollan 2019-10-31 16:33:17 -0700 (In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 382501 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=382501&action=review > > > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:624 > > +(allow mach-lookup > > (global-name "com.apple.logd.events")) > > > > (allow mach-lookup > > + (global-name "com.apple.distributed_notifications@1v3")) > > + > > +(allow mach-lookup > > + (global-name "com.apple.aggregated")) > > + > > +(allow mach-lookup > > (global-name "com.apple.cfprefsd.daemon")) > > Should these all be combined into one "allow mach-lookup" expression? Done. Thanks for reviewing! 1586172 7 382518 commit-queue 2019-10-31 17:32:04 -0700 Comment on attachment 382518 Patch Clearing flags on attachment: 382518 Committed r251897: <https://trac.webkit.org/changeset/251897> 382499 2019-10-31 14:03:38 -0700 2019-10-31 14:32:08 -0700 Patch bug-203697-20191031140338.patch text/plain 1478 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTE4NzUpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTEwLTMxICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBGaXggbWFjaCBsb29r dXAgc2FuZGJveCB2aW9sYXRpb25zIGluIHRoZSBNYWlsIGFwcAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzNjk3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxsb3cgbWFjaCBsb29rdXAgdG8gdGhlIHNl cnZpY2VzICJjb20uYXBwbGUubG9nZC5ldmVudHMiIGFuZCAiY29tLmFwcGxlLmRpc3RyaWJ1dGVk X25vdGlmaWNhdGlvbnNAMXYzIiwKKyAgICAgICAgd2hpY2ggYXJlIHNlZW4gd2hlbiBydW5uaW5n IHRoZSBNYWlsIGFwcGxpY2F0aW9uLgorCisgICAgICAgICogUmVzb3VyY2VzL1NhbmRib3hQcm9m aWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiOgorCiAyMDE5LTEwLTMxICBU cnVpdHQgU2F2ZWxsICA8dHNhdmVsbEBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg cm9sbGluZyBvdXQgcjI1MTg1NC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRi b3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxl LldlYktpdC5XZWJDb250ZW50LnNiCShyZXZpc2lvbiAyNTE4NjMpCisrKyBTb3VyY2UvV2ViS2l0 L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVu dC5zYgkod29ya2luZyBjb3B5KQpAQCAtNjExLDEwICs2MTEsMTMgQEAKIChhbGxvdyBtYWNoLWxv b2t1cAogICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmxvZ2QiKSkKIAotKGRlbnkgbWFjaC1s b29rdXAgKHdpdGggc2VuZC1zaWduYWwgU0lHS0lMTCkKKyhhbGxvdyBtYWNoLWxvb2t1cAogICAg IChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmxvZ2QuZXZlbnRzIikpCiAKIChhbGxvdyBtYWNoLWxv b2t1cAorICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmRpc3RyaWJ1dGVkX25vdGlmaWNhdGlv bnNAMXYzIikpCisKKyhhbGxvdyBtYWNoLWxvb2t1cAogICAgIChnbG9iYWwtbmFtZSAiY29tLmFw cGxlLmNmcHJlZnNkLmRhZW1vbiIpKQogCiAoYWxsb3cgaXBjLXBvc2l4LXNobS1yZWFkKgo= 382501 2019-10-31 14:32:09 -0700 2019-10-31 16:19:08 -0700 Patch bug-203697-20191031143208.patch text/plain 1647 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTE4NzUpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTEwLTMxICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBGaXggbWFjaCBsb29r dXAgc2FuZGJveCB2aW9sYXRpb25zIGluIHRoZSBNYWlsIGFwcAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzNjk3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxsb3cgbWFjaCBsb29rdXAgdG8gdGhlIHNl cnZpY2VzICJjb20uYXBwbGUubG9nZC5ldmVudHMiIGFuZCAiY29tLmFwcGxlLmRpc3RyaWJ1dGVk X25vdGlmaWNhdGlvbnNAMXYzIiwKKyAgICAgICAgd2hpY2ggYXJlIHNlZW4gd2hlbiBydW5uaW5n IHRoZSBNYWlsIGFwcGxpY2F0aW9uLiBBbHNvIGFsbG93ICJjb20uYXBwbGUuYWdncmVnYXRlZCIs IHdoaWNoIHdhcyBwcmV2aW91c2x5CisgICAgICAgIGFsbG93ZWQsIGFuZCBpcyBzaG93aW5nIHVw IGluIHJlcG9ydHMuCisKKyAgICAgICAgKiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9j b20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2I6CisKIDIwMTktMTAtMzEgIFRydWl0dCBTYXZl bGwgIDx0c2F2ZWxsQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91 dCByMjUxODU0LgpJbmRleDogU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVz L2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0Lldl YkNvbnRlbnQuc2IJKHJldmlzaW9uIDI1MTg2MykKKysrIFNvdXJjZS9XZWJLaXQvUmVzb3VyY2Vz L1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiCSh3b3Jr aW5nIGNvcHkpCkBAIC02MTEsMTAgKzYxMSwxNiBAQAogKGFsbG93IG1hY2gtbG9va3VwCiAgICAg KGdsb2JhbC1uYW1lICJjb20uYXBwbGUubG9nZCIpKQogCi0oZGVueSBtYWNoLWxvb2t1cCAod2l0 aCBzZW5kLXNpZ25hbCBTSUdLSUxMKQorKGFsbG93IG1hY2gtbG9va3VwCiAgICAgKGdsb2JhbC1u YW1lICJjb20uYXBwbGUubG9nZC5ldmVudHMiKSkKIAogKGFsbG93IG1hY2gtbG9va3VwCisgICAg KGdsb2JhbC1uYW1lICJjb20uYXBwbGUuZGlzdHJpYnV0ZWRfbm90aWZpY2F0aW9uc0AxdjMiKSkK KworKGFsbG93IG1hY2gtbG9va3VwCisgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuYWdncmVn YXRlZCIpKQorCisoYWxsb3cgbWFjaC1sb29rdXAKICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBs ZS5jZnByZWZzZC5kYWVtb24iKSkKIAogKGFsbG93IGlwYy1wb3NpeC1zaG0tcmVhZCoK 382518 2019-10-31 16:30:50 -0700 2019-10-31 17:32:04 -0700 Patch bug-203697-20191031163049.patch text/plain 1726 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTE4NzUpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTEwLTMxICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBGaXggbWFjaCBsb29r dXAgc2FuZGJveCB2aW9sYXRpb25zIGluIHRoZSBNYWlsIGFwcAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzNjk3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KKworICAgICAgICBBbGxvdyBtYWNoIGxvb2t1cCB0byB0 aGUgc2VydmljZXMgImNvbS5hcHBsZS5sb2dkLmV2ZW50cyIgYW5kICJjb20uYXBwbGUuZGlzdHJp YnV0ZWRfbm90aWZpY2F0aW9uc0AxdjMiLAorICAgICAgICB3aGljaCBhcmUgc2VlbiB3aGVuIHJ1 bm5pbmcgdGhlIE1haWwgYXBwbGljYXRpb24uIEFsc28gYWxsb3cgImNvbS5hcHBsZS5hZ2dyZWdh dGVkIiwgd2hpY2ggd2FzIHByZXZpb3VzbHkKKyAgICAgICAgYWxsb3dlZCwgYW5kIGlzIHNob3dp bmcgdXAgaW4gcmVwb3J0cy4KKworICAgICAgICAqIFJlc291cmNlcy9TYW5kYm94UHJvZmlsZXMv aW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYjoKKwogMjAxOS0xMC0zMSAgVHJ1aXR0 IFNhdmVsbCAgPHRzYXZlbGxAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxp bmcgb3V0IHIyNTE4NTQuCkluZGV4OiBTb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJv ZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJL aXQuV2ViQ29udGVudC5zYgkocmV2aXNpb24gMjUxODYzKQorKysgU291cmNlL1dlYktpdC9SZXNv dXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IJ KHdvcmtpbmcgY29weSkKQEAgLTYwOSwxMiArNjA5LDEwIEBACiAgICAgICAgIChleHRlbnNpb24g ImNvbS5hcHBsZS5maWxlcHJvdmlkZXIucmVhZC13cml0ZSIpKSkKIAogKGFsbG93IG1hY2gtbG9v a3VwCi0gICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUubG9nZCIpKQotCi0oZGVueSBtYWNoLWxv b2t1cCAod2l0aCBzZW5kLXNpZ25hbCBTSUdLSUxMKQotICAgIChnbG9iYWwtbmFtZSAiY29tLmFw cGxlLmxvZ2QuZXZlbnRzIikpCi0KLShhbGxvdyBtYWNoLWxvb2t1cAorICAgIChnbG9iYWwtbmFt ZSAiY29tLmFwcGxlLmxvZ2QiKQorICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmxvZ2QuZXZl bnRzIikKKyAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5kaXN0cmlidXRlZF9ub3RpZmljYXRp b25zQDF2MyIpCisgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuYWdncmVnYXRlZCIpCiAgICAg KGdsb2JhbC1uYW1lICJjb20uYXBwbGUuY2ZwcmVmc2QuZGFlbW9uIikpCiAKIChhbGxvdyBpcGMt cG9zaXgtc2htLXJlYWQqCg==